Skip to contentSkip to conversation

phy: keep the BCMR_LOOPBACK bit while setup forced mode

PATCH Superseded Weidong Wang 1 participant 1 message Mar 25, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: keep the BCMR_LOOPBACK bit while setup forced mode

When tested the PHY SGMII Loopback,:
1.set the LOOPBACK bit,
2.set the autoneg to AUTONEG_DISABLE, it calls the genphy_setup_forced which will clear the bit.

So just keep the LOOPBACK bit while setup forced mode.

---
 drivers/net/phy/phy_device.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/phy_device.c +2 -0
index e551f3a..8da4b80 100644
@@ -1124,7 +1124,9 @@ static int genphy_config_advert(struct phy_device *phydev)
 int genphy_setup_forced(struct phy_device *phydev)
 {
 	int ctl = 0;
+	int val = phy_read(phydev, MII_BMCR);
 
+	ctl |= val & BMCR_LOOPBACK;
 	phydev->pause = 0;
 	phydev->asym_pause = 0;
 
Signature · 1 line
2.7.0