ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies

PATCH In review Markus Reichl 2 participants 3 messages Apr 4, 2016 – Apr 5, 2016

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Markus Reichl

author

2016-04-04 09:55 UTC #0 lore raw

PATCH v2 1/1 ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies

Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output and remove their always_on properties.

Signed-off-by Markus Reichl <[email protected]>

---
Changes in V2:
Sqashed two patches in one.

Tested with eMMC only on XU4.
SD still needs testing.

---
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +12 -5

index 1bd507b..0e71d42 100644
@@ -121,10 +121,9 @@
 			};
 
 			ldo3_reg: LDO3 {
-				regulator-name = "vdd_ldo3";
+				regulator-name = "vddq_mmc0";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
-				regulator-always-on;
 			};
 
 			ldo5_reg: LDO5 {

@@ -184,10 +183,9 @@
 			};
 
 			ldo13_reg: LDO13 {
-				regulator-name = "vdd_ldo13";
+				regulator-name = "vddq_mmc2";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
-				regulator-always-on;
 			};
 
 			ldo15_reg: LDO15 {

@@ -211,11 +209,16 @@
 				regulator-always-on;
 			};
 
+			ldo18_reg: LDO18 {
+				regulator-name = "vdd_emmc_1V8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+
 			ldo19_reg: LDO19 {
 				regulator-name = "vdd_sd";
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
-				regulator-always-on;
 			};
 
 			ldo24_reg: LDO24 {

@@ -347,6 +350,8 @@
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;
 	mmc-hs400-1_8v;
+	vmmc-supply = <&ldo18_reg>;
+	vqmmc-supply = <&ldo3_reg>;
 };
 
 &mmc_2 {

@@ -359,6 +364,8 @@
 	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
 	bus-width = <4>;
 	cap-sd-highspeed;
+	vmmc-supply = <&ldo19_reg>;
+	vqmmc-supply = <&ldo13_reg>;
 };
 
 &pinctrl_0 {

Signature · 1 line

2.1.4

Krzysztof Kozlowski

2016-04-05 03:56 UTC #1 lore raw

Quoted 11 lines · Markus Reichl

Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output and remove their always_on properties.
Signed-off-by Markus Reichl <[email protected]>
---
Changes in V2:
Sqashed two patches in one.
Tested with eMMC only on XU4.
SD still needs testing.

I tested the SD card, everything looks fine. Applied with adjusted commit message (the warnings I asked for should be mentioned). Thanks.

Best regards,
Krzysztof

Markus Reichl

author

2016-04-05 07:28 UTC #2 lore raw

Hi Krzysztof,

Am 05.04.2016 um 05:56 schrieb Krzysztof Kozlowski:

Quoted 10 lines · Markus Reichl

Quoted 9 lines
Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output and remove their always_on properties.
Signed-off-by Markus Reichl <[email protected]>
---
Changes in V2:
Sqashed two patches in one.

Quoted 6 lines

Quoted 2 lines
Tested with eMMC only on XU4.
SD still needs testing.
I tested the SD card, everything looks fine. Applied with adjusted commit message (the warnings I asked for should be mentioned). Thanks.

Thanks,
--
Markus Reichl

Quoted 8 lines

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html