Add support for generate bitbake error reports

RFC Aníbal Limón 3 participants 10 messages Jun 9, 2016 – Jun 15, 2016 1 message not in the archive

Share & tools

Aníbal Limón

author

2016-06-09 21:22 UTC #0 lore raw

Hi folks,

Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.

A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of some process monitoring the bitbake output in this case the Yocto Autobuilder.

This email is for review my current implementation for generate bitbake error reports in the Autobuilder [2] next i'll try to explain how it works.

I aadded a BitbakeShellCommand [3] class for use in the buildsteps that executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if fails.

For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.

In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on the worker side so it's easy to transfer the reports from master to worker instead of send it by master.

Finally to complete with the job of have the bitbake errors reports the Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.

Please review it and provide me feedback.

Cheers,
alimon

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=contrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h=contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1

Beth 'pidge' Flanagan

2016-06-13 09:25 UTC #1 lore raw

Quoted 37 lines · Aníbal Limón

Hi folks,
Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps that
executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if
fails.
For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on
the worker side so it's easy to transfer the reports from master to worker instead of send it by master.

Quoted 7 lines

Finally to complete with the job of have the bitbake errors reports the
Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.
Please review it and provide me feedback.

1. fix the commit message to ea1d5b35bc77bad5d2
2. in same, why are you removing buildset-config.controller/poky- tiny.conf? I believe this is still supported (and even if it isn't in master, we maintain backwards compatibility)

As a whole, I like what is being done here. I would like this put on the devel cluster before bringing it into production, just to smoke test this, both with nightly builds and single builds. I can't see anything that would obviously blow up though.

cheers,

-b

Signature · 2 lines

Beth 'pidge' Flanagan <[email protected]>
toganlabs.com

Quoted 19 lines

Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h
=contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1

Aníbal Limón

author

2016-06-13 15:08 UTC #2 lore raw

Quoted 43 lines · Beth 'pidge' Flanagan

Quoted 42 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps that
executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if
fails.
For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on
the worker side so it's easy to transfer the reports from master to worker instead of send it by master.
Finally to complete with the job of have the bitbake errors reports the
Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.

Quoted 8 lines

Quoted 2 lines
Please review it and provide me feedback.
1. fix the commit message to ea1d5b35bc77bad5d2
2. in same, why are you removing buildset-config.controller/poky- tiny.conf? I believe this is still supported (and even if it isn't in master, we maintain backwards compatibility)

Thanks for notice the removal of poky-tiny it wasn't my intention, i did an script to update the buildsets and seems that don't work well. I'll fix the last commit message ea1d5b35bc77bad5d2 and also include the poky-tiny buildset.

Quoted 12 lines

As a whole, I like what is being done here. I would like this put on the devel cluster before bringing it into production, just to smoke test this, both with nightly builds and single builds. I can't see anything that would obviously blow up though.
cheers,
-b

Beth 'pidge' Flanagan

2016-06-13 15:53 UTC #3 lore raw

Quoted 69 lines · Aníbal Limón

Quoted 59 lines · Beth 'pidge' Flanagan
Quoted 57 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org
about failing tasks on bitbake using SendErrorReport buildstep but we
have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm
working on it but for generate bitbake error reports there's a need
of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it
works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps
that
executes bitbake the main objective of this class is to have common
operations to be made in bitbake commands like create error reports
if
fails.
For create error reports this class add an stdio observer to look at
bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller
transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works
on
the worker side so it's easy to transfer the reports from master to
worker instead of send it by master.
Finally to complete with the job of have the bitbake errors reports
the
Error report web changes need (i'm working on it) to be integrated
first in order to don't break anything.
Quoted 8 lines
Quoted 2 lines
Please review it and provide me feedback.
1. fix the commit message to ea1d5b35bc77bad5d2
2. in same, why are you removing buildset-config.controller/poky- tiny.conf? I believe this is still supported (and even if it isn't in
master, we maintain backwards compatibility)

Quoted 7 lines

Thanks for notice the removal of poky-tiny it wasn't my intention, i did
an script to update the buildsets and seems that don't work well. I'll
fix the last commit message ea1d5b35bc77bad5d2 and also include the poky-tiny buildset.

Great, if you can get this onto a dev cluster (halstead should have info here on connection), I'd be interested in seeing what a nightly and a nightly-arm do.

-b

Quoted 14 lines

Quoted 14 lines
As a whole, I like what is being done here. I would like this put on
the devel cluster before bringing it into production, just to smoke test this, both with nightly builds and single builds. I can't see anything that would obviously blow up though.
cheers,
-b

Joshua G Lock

2016-06-14 15:16 UTC #4 lore raw

In reply to Aníbal Limón

(Resent including the list, apologies for those receiving it again)

Quoted 37 lines · Aníbal Limón

Hi folks,
Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps that
executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if
fails.
For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on
the worker side so it's easy to transfer the reports from master to worker instead of send it by master.

Quoted 6 lines

Finally to complete with the job of have the bitbake errors reports the
Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.
Please review it and provide me feedback.

This would've been much easier to review as a series of patches.

After a quick read via the gitweb the series as a whole looks good.

A couple of review comments:

In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py: Add BitbakeLogLineObserver for BitbakeShellCommands." you have a comment

"discard line that are not errors and line that is recipe task errors"

but the lines are not actually discarded, afaict from a cursory read through they aren't used in the rest of the series
unless errors['bitbake'] == True?

Could we move the error['log'].append() to after the if statement which checks whether this is a bitbake error?

Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports"
in get_error_report_bitbake_dir() you use both " and ' for strings.

Same in 40279597615c49bc4f4f067cbab937584b626671

Regards,

Joshua

Quoted 20 lines

Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h
=contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1

Aníbal Limón

author

2016-06-14 15:56 UTC #6 lore raw

In reply to a message not in the archive

Quoted 54 lines · Joshua G

Quoted 37 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps that
executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if
fails.
For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on
the worker side so it's easy to transfer the reports from master to worker instead of send it by master.
Quoted 6 lines
Finally to complete with the job of have the bitbake errors reports the
Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.
Please review it and provide me feedback.
This would've been much easier to review as a series of patches.
After a quick read via the gitweb the series as a whole looks good.
A couple of review comments:
In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py: Add BitbakeLogLineObserver for BitbakeShellCommands." you have a comment

Quoted 8 lines

"discard line that are not errors and line that is recipe task errors"
but the lines are not actually discarded, afaict from a cursory read through they aren't used in the rest of the series
unless errors['bitbake'] == True?
Could we move the error['log'].append() to after the if statement which checks whether this is a bitbake error?

Yes and i'll update the commit message to be more consistent.

Quoted 6 lines

Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports"
in get_error_report_bitbake_dir() you use both " and ' for strings.
Same in 40279597615c49bc4f4f067cbab937584b626671

I'll fix the typos for only use "".

alimon

Quoted 24 lines

Regards,
Joshua
Quoted 19 lines
Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h
=contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1

Aníbal Limón

author

2016-06-14 17:02 UTC #7 lore raw

Quoted 73 lines · Aníbal Limón

Quoted 54 lines · Joshua G
Quoted 37 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org about failing tasks on bitbake using SendErrorReport buildstep but we have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm working on it but for generate bitbake error reports there's a need of
some process monitoring the bitbake output in this case the Yocto Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps that
executes bitbake the main objective of this class is to have common operations to be made in bitbake commands like create error reports if
fails.
For create error reports this class add an stdio observer to look at bitbake output and if bitbake fails review the bitbake output for identify if the failure is an non-related task error [4]. If the observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works on
the worker side so it's easy to transfer the reports from master to worker instead of send it by master.
Quoted 6 lines
Finally to complete with the job of have the bitbake errors reports the
Error report web changes need (i'm working on it) to be integrated first in order to don't break anything.
Please review it and provide me feedback.
This would've been much easier to review as a series of patches.
After a quick read via the gitweb the series as a whole looks good.
A couple of review comments:
In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py: Add BitbakeLogLineObserver for BitbakeShellCommands." you have a comment
Quoted 8 lines
"discard line that are not errors and line that is recipe task errors"
but the lines are not actually discarded, afaict from a cursory read through they aren't used in the rest of the series
unless errors['bitbake'] == True?
Could we move the error['log'].append() to after the if statement which checks whether this is a bitbake error?
Yes and i'll update the commit message to be more consistent.
Quoted 5 lines
Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports"
in get_error_report_bitbake_dir() you use both " and ' for strings.

Quoted 6 lines

Quoted 1 line
Same in 40279597615c49bc4f4f067cbab937584b626671
I'll fix the typos for only use "".
alimon

I updated the branch with the changes suggested now at,

http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=contrib/alimon/devel

alimon

Quoted 27 lines

Quoted 24 lines
Regards,
Joshua
Quoted 19 lines
Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tree/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h
=contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cdf1

Joshua G Lock

2016-06-15 13:19 UTC #8 lore raw

Quoted 102 lines · Aníbal Limón

Quoted 100 lines · Aníbal Limón
Quoted 77 lines · Joshua G
Quoted 52 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org
about failing tasks on bitbake using SendErrorReport buildstep but we
have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm
working on it but for generate bitbake error reports there's a need
of
some process monitoring the bitbake output in this case the Yocto
Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it
works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps
that
executes bitbake the main objective of this class is to have common
operations to be made in bitbake commands like create error reports
if
fails.
For create error reports this class add an stdio observer to look at
bitbake output and if bitbake fails review the bitbake output for
identify if the failure is an non-related task error [4]. If the
observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller
transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works
on
the worker side so it's easy to transfer the reports from master to
worker instead of send it by master.
Quoted 8 lines
Finally to complete with the job of have the bitbake errors reports
the
Error report web changes need (i'm working on it) to be integrated
first in order to don't break anything.
Please review it and provide me feedback.
This would've been much easier to review as a series of patches.
After a quick read via the gitweb the series as a whole looks good.
A couple of review comments:
In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py:
Add
BitbakeLogLineObserver for BitbakeShellCommands." you have a comment
"discard line that are not errors and line that is recipe task errors"
Quoted 8 lines
but the lines are not actually discarded, afaict from a cursory read
through they aren't used in the rest of the series unless errors['bitbake'] == True?
Could we move the error['log'].append() to after the if statement which
checks whether this is a bitbake error?
Yes and i'll update the commit message to be more consistent.
Quoted 8 lines
Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports" in get_error_report_bitbake_dir() you use both " and ' for strings.
Same in 40279597615c49bc4f4f067cbab937584b626671

Quoted 8 lines

Quoted 4 lines
I'll fix the typos for only use "".
alimon
I updated the branch with the changes suggested now at,
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel

Is that the right location? For example I still see log lines being appended to error['log'] *before* the check to discard lines in:

http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h=c
ontrib/alimon/devel&id=742e5bf33934c4ec9de9136a854e190aaf8ba0b3

+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
+
+        # save all the log for be able to get report variables like +        # machine, target, distro, etc
+        self.step.errors['log'].append(line)
+
+        # discard line that are not errors and line that +        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # if not match recipe task type is a bitbake exception/error +        self.step.errors['bitbake'] = True

whereas I think we only need to save log lines when it's a bitbake error, i.e:

+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
+
+        # discard line that are not errors and line that +        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # save all the log for be able to get report variables like +
      # machine, target, distro, etc
+        self.step.errors['log'].ap
pend(line)
+
+        # if not match recipe task type is a bitbake exception/error +        self.step.errors['bitbake'] = True

Further
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h=c
ontrib/alimon/devel&id=2523c869855d8e2393b9dd7142c0992908444584

still has typo's in the commit title and message.

Finally, please don't end the subject line of commit messages with a period.

Regards,

Joshua

Quoted 37 lines

alimon
Quoted 34 lines
Quoted 31 lines
Regards,
Joshua
Quoted 26 lines
Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log
/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n 92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n 53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/com
mit/?h =contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cd f1

Aníbal Limón

author

2016-06-15 14:07 UTC #9 lore raw

Quoted 162 lines · Joshua G Lock

Quoted 102 lines · Aníbal Limón
Quoted 100 lines · Aníbal Limón
Quoted 77 lines · Joshua G
Quoted 52 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org
about failing tasks on bitbake using SendErrorReport buildstep but we
have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm
working on it but for generate bitbake error reports there's a need
of
some process monitoring the bitbake output in this case the Yocto
Autobuilder.
This email is for review my current implementation for generate bitbake
error reports in the Autobuilder [2] next i'll try to explain how it
works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps
that
executes bitbake the main objective of this class is to have common
operations to be made in bitbake commands like create error reports
if
fails.
For create error reports this class add an stdio observer to look at
bitbake output and if bitbake fails review the bitbake output for
identify if the failure is an non-related task error [4]. If the
observer found bitbake error creates an Error report with the information in the master controller.
In order to send the bitbake error to Error report web the controller
transfer the report to the worker using a new DownloadDirectory implementation that i made [5], the SendErrorReport buildstep works
on
the worker side so it's easy to transfer the reports from master to
worker instead of send it by master.
Quoted 8 lines
Finally to complete with the job of have the bitbake errors reports
the
Error report web changes need (i'm working on it) to be integrated
first in order to don't break anything.
Please review it and provide me feedback.
This would've been much easier to review as a series of patches.
After a quick read via the gitweb the series as a whole looks good.
A couple of review comments:
In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py:
Add
BitbakeLogLineObserver for BitbakeShellCommands." you have a comment
"discard line that are not errors and line that is recipe task errors"
Quoted 8 lines
but the lines are not actually discarded, afaict from a cursory read
through they aren't used in the rest of the series unless errors['bitbake'] == True?
Could we move the error['log'].append() to after the if statement which
checks whether this is a bitbake error?
Yes and i'll update the commit message to be more consistent.
Quoted 8 lines
Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports" in get_error_report_bitbake_dir() you use both " and ' for strings.
Same in 40279597615c49bc4f4f067cbab937584b626671
Quoted 8 lines
Quoted 4 lines
I'll fix the typos for only use "".
alimon
I updated the branch with the changes suggested now at,
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?h=co
ntrib/alimon/devel
Is that the right location? For example I still see log lines being appended to error['log'] *before* the check to discard lines in:
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h=c
ontrib/alimon/devel&id=742e5bf33934c4ec9de9136a854e190aaf8ba0b3
(quoted diff) +20 -0
+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
+
+        # save all the log for be able to get report variables like
+        # machine, target, distro, etc
+        self.step.errors['log'].append(line)
+
+        # discard line that are not errors and line that
+        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # if not match recipe task type is a bitbake exception/error
+        self.step.errors['bitbake'] = True
whereas I think we only need to save log lines when it's a bitbake error, i.e:
(quoted diff) +17 -0
+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
+
+        # discard line that are not errors and line that
+        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # save all the log for be able to get report variables like
+  
      # machine, target, distro, etc
+        self.step.errors['log'].ap
pend(line)

Review

Quoted 3 lines

(quoted diff) +3 -0

+
+        # if not match recipe task type is a bitbake exception/error
+        self.step.errors['bitbake'] = True

I tried to explain this in the comment above append log, we need the full log for get information about machine. distro, etc also if a line don't match but then is discover that is a bitbake error we want to have the full log not discarding recipe/task errors because some times the context about bitbake error/exception matters.

Quoted 9 lines

Further
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?h=c
ontrib/alimon/devel&id=2523c869855d8e2393b9dd7142c0992908444584
still has typo's in the commit title and message.
Finally, please don't end the subject line of commit messages with a period.

I'll fix the commit msg.

alimon

Quoted 41 lines

Regards,
Joshua
Quoted 37 lines
alimon
Quoted 34 lines
Quoted 31 lines
Regards,
Joshua
Quoted 26 lines
Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log
/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n 92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/devel#n 53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/com
mit/?h =contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f801cd f1

Joshua G Lock

2016-06-15 14:14 UTC #10 lore raw

Quoted 190 lines · Aníbal Limón

Quoted 178 lines · Joshua G Lock
Quoted 120 lines · Aníbal Limón
Quoted 118 lines · Aníbal Limón
Quoted 97 lines · Joshua G
Quoted 63 lines · Aníbal Limón
Hi folks,
Currently we support to send error reports to errors.yoctoproject.org
about failing tasks on bitbake using SendErrorReport buildstep
but we
have a lack of bitbake related errors like exceptions.
A bug exist to implement this support into Error report web [1], i'm
working on it but for generate bitbake error reports there's a
need
of
some process monitoring the bitbake output in this case the Yocto
Autobuilder.
This email is for review my current implementation for generate
bitbake
error reports in the Autobuilder [2] next i'll try to explain
how it
works.
I aadded a BitbakeShellCommand [3] class for use in the buildsteps
that
executes bitbake the main objective of this class is to have
common
operations to be made in bitbake commands like create error reports
if
fails.
For create error reports this class add an stdio observer to
look at
bitbake output and if bitbake fails review the bitbake output
for
identify if the failure is an non-related task error [4]. If
the
observer found bitbake error creates an Error report with the
information in the master controller.
In order to send the bitbake error to Error report web the controller
transfer the report to the worker using a new DownloadDirectory
implementation that i made [5], the SendErrorReport buildstep
works
on
the worker side so it's easy to transfer the reports from master to
worker instead of send it by master.
Quoted 8 lines
Finally to complete with the job of have the bitbake errors reports
the
Error report web changes need  (i'm working on it) to be integrated
first in order to don't break anything.
Please review it and provide me feedback.
This would've been much easier to review as a series of patches.
After a quick read via the gitweb the series as a whole looks good.
A couple of review comments:
In a04b41d37c29191318386455d8d958ff815a3a10 "lib/buildsteps.py:
Add
BitbakeLogLineObserver for BitbakeShellCommands." you have a comment
"discard line that are not errors and line that is recipe task
errors"
but the lines are not actually discarded, afaict  from a cursory
read
through they aren't used in the rest of the series unless errors['bitbake'] == True?
Quoted 4 lines
Could we move the error['log'].append() to after the if statement
which
checks whether this is a bitbake error?
Yes and i'll update the commit message to be more consistent.
Quoted 8 lines
Minor nit, in caf472bc696053227825c5a102feef3e17574ba2 "lib/buildsteps:
BitbakeShellCommand add support for create error reports" in get_error_report_bitbake_dir() you use both " and ' for strings.
Same in 40279597615c49bc4f4f067cbab937584b626671
I'll fix the typos for only use "".
Quoted 7 lines
Quoted 2 lines
alimon
I updated the branch with the changes suggested now at,
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/?
h=co
ntrib/alimon/devel
Is that the right location? For example I still see log lines being appended to error['log'] *before* the check to discard lines in:
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/
?h=c ontrib/alimon/devel&id=742e5bf33934c4ec9de9136a854e190aaf8ba0b3
+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
+
+        # save all the log for be able to get report variables like
+        # machine, target, distro, etc
+        self.step.errors['log'].append(line)
(quoted diff) +10 -0
+
+        # discard line that are not errors and line that
+        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # if not match recipe task type is a bitbake
exception/error
+        self.step.errors['bitbake'] = True
whereas I think we only need to save log lines when it's a bitbake error, i.e:
+    def _handleError(self, line):
+        if not hasattr(self.step, 'errors'):
+            self.step.errors = {}
+            self.step.errors['bitbake'] = False
+            self.step.errors['log'] = []
(quoted diff) +10 -0
+
+        # discard line that are not errors and line that
+        # is recipe task errors
+        if (not self.rexp_error.match(line)) or \
+                self.rexp_pnpv_error.match(line) or \
+                self.rexp_task_error.match(line) or \
+                self.rexp_log_error.match(line):
+            return
+
+        # save all the log for be able to get report variables
like
Quoted 9 lines
+
      # machine, target, distro, etc
+        self.step.errors['log'].ap pend(line)
+
+        # if not match recipe task type is a bitbake exception/error
+        self.step.errors['bitbake'] = True

Quoted 7 lines

I tried to explain this in the comment above append log, we need the full log for get information about machine. distro, etc also if a line
don't match but then is discover that is a bitbake error we want to have the full log not discarding recipe/task errors because some times
the context about bitbake error/exception matters.

Ahah, I hadn't seen that comment. I think I got hung up on the comment "discard line that are not errors and line that is recipe task errors" when we don't really discard the line, we just don't mark it as a bitbake error.

Quoted 5 lines

Quoted 5 lines
Further
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/
?h=c ontrib/alimon/devel&id=2523c869855d8e2393b9dd7142c0992908444584

Quoted 8 lines

Quoted 6 lines
still has typo's in the commit title and message.
Finally, please don't end the subject line of commit messages with a
period.
I'll fix the commit msg.

Thanks!

Regards,

Joshua

Quoted 51 lines

alimon
Quoted 48 lines
Regards,
Joshua
Quoted 44 lines
alimon
Quoted 41 lines
Quoted 38 lines
Regards,
Joshua
Quoted 33 lines
Cheers,
alimon
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=7583
[2]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder
/log
/?h=co
ntrib/alimon/devel
[3]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder
/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/dev el#n
92
[4]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder
/tre
e/lib/
python2.7/site- packages/autobuilder/lib/buildsteps.py?h=contrib/alimon/dev el#n
53
[5]
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder
/com
mit/?h =contrib/alimon/devel&id=4022920bb0e56d1eef3dfe7c5e9b4699f8 01cd
f1