Skip to contentSkip to conversation

Initial environment variables

U-Boot ron_madrid at sbcglobal.net 2 participants 2 messages Jul 16, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 36 lines · Ben Warren

From: Ben Warren <[email protected]>
Subject: Re: [U-Boot] Initial environment variables
To: "Ron Madrid" <[email protected]>
Cc: u-boot at lists.denx.de, "Mike Frysinger" <[email protected]>
Date: Thursday, July 16, 2009, 2:08 PM

Quoted 1 line · Ron Madrid

--- On Thu, 7/16/09, Mike Frysinger <[email protected]>

Quoted 3 lines · wrote:
Quoted 3 lines

the board maintainer decides the default env

values, not

Quoted 1 line
Quoted 1 line

board users. Ben's comment was probably on

the assumption that you are in the

Quoted 4 lines
Quoted 2 lines

latter category.

Ah, that could be why. Thankfully I am the

maintainer for the board. So I

Quoted 1 line

am going to assume then that it would be OK for me to

add these variable

Quoted 1 line

settings to my board's include/configs file and submit

a patch for it,

Quoted 4 lines

unless I here other objections.

Ron

No, there should be no default net parameters, because you're making likely-bogus assumptions about the network that your board's going to go into. Just because your LAN uses '192.168.0.x' doesn't mean anybody else's does. It's even worse for MAC addresses - what if I buy two of your boards and plug them into the same switch? If the addresses are identical all sorts of bad things can happen. Not to mention that public MAC addresses are assigned (and paid for) and should be

Quoted 8 lines

guaranteed to be unique. And private (bit 41 set) addresses are used in many different ways. One systems company that I worked at would program these dynamically based on which shelf/slot the board was plugged into. It's best to fail loudly (a printf stating that MAC addresses haven't been programmed) than to silently cause network issues. I could go on and on, but hopefully you get the point.

I do understand your points. I am confused then as to why there are around 100 different board configurations that include these variables.

Ron

#1 lore raw
Quoted 63 lines · ron_madrid at sbcglobal.net
Quoted 50 lines · Ben Warren

From: Ben Warren <[email protected]>
Subject: Re: [U-Boot] Initial environment variables
To: "Ron Madrid" <[email protected]>
Cc: u-boot at lists.denx.de, "Mike Frysinger" <[email protected]>
Date: Thursday, July 16, 2009, 2:08 PM

Quoted 2 lines · Ron Madrid

--- On Thu, 7/16/09, Mike Frysinger <[email protected]>

Quoted 4 lines · wrote:
Quoted 4 lines

the board maintainer decides the default env

values, not

Quoted 2 lines
Quoted 2 lines

board users. Ben's comment was probably on

the assumption that you are in the

Quoted 5 lines
Quoted 3 lines

latter category.

Ah, that could be why. Thankfully I am the

maintainer for the board. So I

Quoted 2 lines

am going to assume then that it would be OK for me to

add these variable

Quoted 2 lines

settings to my board's include/configs file and submit

a patch for it,

Quoted 5 lines

unless I here other objections.

Ron

No, there should be no default net parameters, because you're making likely-bogus assumptions about the network that your board's going to go into. Just because your LAN uses '192.168.0.x' doesn't mean anybody else's does. It's even worse for MAC addresses - what if I buy two of your boards and plug them into the same switch? If the addresses are identical all sorts of bad things can happen. Not to mention that public MAC addresses are assigned (and paid for) and should be

Quoted 9 lines

guaranteed to be unique. And private (bit 41 set) addresses are used in many different ways. One systems company that I worked at would program these dynamically based on which shelf/slot the board was plugged into. It's best to fail loudly (a printf stating that MAC addresses haven't been programmed) than to silently cause network issues. I could go on and on, but hopefully you get the point.

Quoted 6 lines

I do understand your points. I am confused then as to why there are around 100 different board configurations that include these variables.

Ron

Sorry, before my time :) They should be cleaned up.

regards,
Ben