discuss the code in /pid/buildjson.cpp
Hi all,
Sorry for insufficient info about my question.
I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.
Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.
Sincerely,
Hank Liou
Quanta Computer Inc.
Quoted 9 lines · Hank Liou (劉晉翰)
Hi all,
Sorry for insufficient info about my question.
I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.
Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.
Looks like it. I'll submit a patchset.
Quoted 5 lines
Sincerely,
Hank Liou
Quanta Computer Inc.
Quoted 5 lines · Patrick Venture
Quoted 3 lines · Hank Liou (劉晉翰)
Hi all,
Quoted 8 lines
Quoted 6 lines
Sorry for insufficient info about my question.
I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.
Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.
Looks like it. I'll submit a patchset.
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/19647
Quoted 6 lines
Quoted 6 lines
Sincerely,
Hank Liou
Quanta Computer Inc.