Skip to contentSkip to conversation

discuss the code in /pid/buildjson.cpp

phosphor-pid-control Hank Liou (劉晉翰) 2 participants 3 messages Mar 26, 2019

lore
Share & tools
lore
#0 lore raw

Hi all,

Sorry for insufficient info about my question.

I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.

Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.

Sincerely,

Hank Liou
Quanta Computer Inc.

#1 lore raw
Quoted 9 lines · Hank Liou (劉晉翰)

Hi all,

Sorry for insufficient info about my question.

I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.

Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.

Looks like it. I'll submit a patchset.

Quoted 5 lines

Sincerely,

Hank Liou
Quanta Computer Inc.

#2 lore raw
Quoted 5 lines · Patrick Venture
Quoted 3 lines · Hank Liou (劉晉翰)

Hi all,

Quoted 8 lines
Quoted 6 lines

Sorry for insufficient info about my question.

I am reading the source code of /pid/buildjson.cpp in phosphor-pid-control.

Is there an error in line 59 and 69? To be precise, I think j should be p since only p has elements positiveHysteresis and negativeHysteresis.

Looks like it. I'll submit a patchset.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/19647

Quoted 6 lines
Quoted 6 lines

Sincerely,

Hank Liou
Quanta Computer Inc.