Skip to contentSkip to conversation

media: sun8i: Fix an error handling path in deinterlace_runtime_resume()

PATCH Markus Elfring 1 participant 1 message May 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

It is spurious to call 'clk_disable_unprepare()' when 'clk_prepare_enable()' has not been called yet.

Can it be that the usage of the word “suspicious” would be more appropriate for such a change description?

Quoted 1 line

Re-order the error handling path to avoid it.

Would it be also helpful to explicitly mention in the commit message that you would like to move a call of the function “clk_rate_exclusive_put” to the end of this function implementation for the correction of the desired exception handling?

Regards,
Markus