gfs2: Fix regression in freeze_go_sync
PATCH 1/1 gfs2: Fix regression in freeze_go_sync
In reply to a message not in the archiveHi,
Patch 541656d3a51 ("gfs2: freeze should work on read-only mounts") changed the check for glock state in function freeze_go_sync() from "gl->gl_state == LM_ST_SHARED" to "gl->gl_req == LM_ST_EXCLUSIVE". That's wrong and it regressed gfs2's freeze/thaw mechanism.
We need to check gl_state == LM_ST_SHARED and not gl_req == LM_ST_EXCLUSIVE because when any node does a freeze, all the nodes should have the freeze glock in SH mode and they all call do_xmote: One node for EX and the others for UN. They ALL must freeze locally, and they ALL must queue freeze work. The freeze_work calls freeze_func, which reacquires the freeze glock in SH, effectively waiting for the thaw on the node who holds the freeze glock in EX. Once thawed, the freeze_func acquires the freeze glock in SH and everybody goes back to thawed.
--- fs/gfs2/glops.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
fs/gfs2/glops.c +12 -1
@@ -571,7 +571,18 @@ static int freeze_go_sync(struct gfs2_glock *gl)int error =0 ;struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; -if (gl->gl_req ==LM_ST_EXCLUSIVE && !gfs2_withdrawn (sdp)) { +/* +* We need to check gl_state == LM_ST_SHARED here and not gl_req == +* LM_ST_EXCLUSIVE. That's because when any node does a freeze, +* all the nodes should have the freeze glock in SH mode and they all +* call do_xmote: One for EX and the others for UN. They ALL must +* freeze locally, and they ALL must queue freeze work. The freeze_work +* calls freeze_func, which tries to reacquire the freeze glock in SH, +* effectively waiting for the thaw on the node who holds it in EX. +* Once thawed, the work func acquires the freeze glock in +* SH and everybody goes back to thawed. +*/ +if (gl->gl_state ==LM_ST_SHARED && !gfs2_withdrawn (sdp)) {atomic_set (&sdp->sd_freeze_state,SFS_STARTING_FREEZE ); error =freeze_super (sdp->sd_vfs);if (error) {