Skip to contentSkip to conversation

Allow incomplete mirror repairs in lvconvert --repair.

PATCH New Petr Rockai 1 participant 2 messages Feb 15, 2010 – Mar 23, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow incomplete mirror repairs in lvconvert --repair.

Hi,

the attached patch should address RHBZ 560105 and 560111. This changes lvconvert --repair as follows:

- downconvert (like before)
- try to replace everything (like before)
- if the second step fails, try to reduce number of mirror images (one at a time) until only 2 remain
- if this still fails and we used to have a disk log, try 2-way + corelog

This should basically give you an LV that is closest to the original mirror, in the space constraints of free PV areas.

Please note that this patch also changes the failure/success returns of (manual) lvconvert --repair. As far as the initial downconversion succeeds -- i.e. the resulting LV is not partial, we report success.

Failures to replace (part of) the failed devices are now reported as warnings.

Yours,
Petr.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-repair-partial.diff
Type: text/x-diff
Size: 5553 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100215/23e6c89a/attachment.bin>

#1 lore raw

PATCH 1/1 Allow incomplete mirror repairs in lvconvert --repair.

Hi,

re-sending the patch against current CVS, and with a minor bug fixed.

Quoted 12 lines · Petr Rockai

the attached patch should address RHBZ 560105 and 560111. This changes lvconvert --repair as follows:

- downconvert (like before)
- try to replace everything (like before)
- if the second step fails, try to reduce number of mirror images (one at a time) until only 2 remain
- if this still fails and we used to have a disk log, try 2-way + corelog

This should basically give you an LV that is closest to the original mirror, in the space constraints of free PV areas.

Quoted 6 lines

Please note that this patch also changes the failure/success returns of (manual) lvconvert --repair. As far as the initial downconversion succeeds -- i.e. the resulting LV is not partial, we report success.

Failures to replace (part of) the failed devices are now reported as warnings.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-repair-partial2.diff
Type: text/x-diff
Size: 5688 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100323/ab994915/attachment.bin>