Skip to contentSkip to conversation

small smbfs bugfix

PATCH NAK Pavel Fedin 2 participants 2 messages Jan 26, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 small smbfs bugfix

Hello!

This small patch fixes a problem with smbfs in 2.6.19.2 kernel.
Should also apply to other kernels.
The problem is that smbfs doesn't understand "user" and "noexec"
options. This makes it impossible to include into /etc/fstab lines like:

/pc2/myshare /mnt/smb/pc2/myshare smbfs user,noauto 0 0

Smbmount expands "user,noauto" to "user,noauto,noexec" plus something
else, don't remember exactly what. In the result such an entry simply can't be mounted because smbfs fails due to unknown options.
This patch makes smbfs silently ignoring all unknown options instead of
producing an error.

Also i would suggest to introduce this behavor to all other
filesystems. This would greatly improve autofs usability. Imagine a
situation: i have a ZIP drive and i'd like to be able to use ext2, ext3 and vfat-formatted cartridges. Also i'm russian user so i use NLS feature for names translation. In the fstab i would write:

/dev/hdd /mnt/zip ext2,ext3,vfat user,noauto,iocharset=koi8-r,codepage=866 0 0

But in this case ext2 and ext3 wouldn't work at all since they would
fail due to unknown "iocharset" and "codepage" options.

Signature · 2 lines
Best regards,
 Pavel                          mailto:[email protected]
fs/smbfs/inode.c renamed from fs/smbfs/inode.c.orig +0 -4
@@ -405,10 +405,6 @@
 		case 't':
 			mnt->ttl = value;
 			break;
-		default:
-			printk ("smbfs: Unrecognized mount option %s\n",
-				optopt);
-			return -1;
 		}
 	}
 	mnt->flags = flags;
#1 lore raw
Quoted 4 lines · Pavel Fedin

Hello!

This small patch fixes a problem with smbfs in 2.6.19.2 kernel.
Should also apply to other kernels.

NACK

Quoted 11 lines

The problem is that smbfs doesn't understand "user" and "noexec"
options. This makes it impossible to include into /etc/fstab lines like:

/pc2/myshare /mnt/smb/pc2/myshare smbfs user,noauto 0 0

Smbmount expands "user,noauto" to "user,noauto,noexec" plus something
else, don't remember exactly what. In the result such an entry simply can't be mounted because smbfs fails due to unknown options.
This patch makes smbfs silently ignoring all unknown options instead of
producing an error.

I believe the problem is in smbmount. At the system call level, "user" and "noauto" are not valid options. These are usually parsed by the mount command, but not sent to the mount syscall. "noexec" also shouldn't be passed as a string in the syscall, but the MS_NOEXEC flag should be set in the mountflags argument.

Quoted 10 lines

Also i would suggest to introduce this behavor to all other
filesystems. This would greatly improve autofs usability. Imagine a
situation: i have a ZIP drive and i'd like to be able to use ext2, ext3 and vfat-formatted cartridges. Also i'm russian user so i use NLS feature for names translation. In the fstab i would write:

/dev/hdd /mnt/zip ext2,ext3,vfat user,noauto,iocharset=koi8-r,codepage=866 0 0

But in this case ext2 and ext3 wouldn't work at all since they would
fail due to unknown "iocharset" and "codepage" options.

If the file system doesn't honor the option, it shouldn't accept it. In the first example, if you really want to mount with noexec, and smbfs simply ignores it, you've undermined the security of the system. Not recognizing the iocharset and codepage probably isn't as big a problem, but ext2/3 would not be behaving the same was as if it truly respected those options.

Quoted 4 lines
Signature · 3 lines
-- 
Best regards,
 Pavel                          mailto:[email protected]

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center