BUG in u-boot for ODROID-XU3/XU4/HC1/HC2
hi,
i've recently tried u-boot 2022.04 (u-boot-v2022.04.tar.bz2) and my odroid-hc2 didn't boot with uefi (default since Fedora 35) but worked when i used exlinux.conf
trying to track down the problem, i've found that in the default u-boot environment the "board" and "boardname" variables were "smdk5420" and not "odroid" (like before) ... and thus the "fdtfile" variable was "exynos5422-smdk5420hc1.dtb" and not "exynos5422-odroidhc1.dtb".
continuing i've made a diff between the u-boot-v2021.10.tar.bz2 and u-boot-v2022.04.tar.bz2 ... and long story short, i've found the culprit in commit f76750d1 "Convert CONFIG_CONS_INDEX et al to Kconfig" :
-------------------------------------------------------------------------------------------------
include/configs/odroid_xu3.h 2022-04-04 17:31:32.000000000 +0300 renamed from include/configs/odroid_xu3.h 2021-10-04 18:09:26.000000000 +0300 +0 -1
@@ -75,14 +75,11 @@ /* Set soc_rev, soc_id, board_rev, board_name, fdtfile */ #define CONFIG_ODROID_REV_AIN 9 -#define CONFIG_REVISION_TAG /* * Need to override existing one (smdk5420) with odroid so
set_board_info will
* use proper prefix when creating full board_name (SYS_BOARD + type) */
-#undef CONFIG_SYS_BOARD
-#define CONFIG_SYS_BOARD "odroid"
/* Define new extra env settings, including DFU settings */ #undef CONFIG_EXTRA_ENV_SETTINGS
-------------------------------------------------------------------------------------------------
and following part needs a revert
-------------------------------------------------------------------------------------------------
-#undef CONFIG_SYS_BOARD
-#define CONFIG_SYS_BOARD "odroid"
-------------------------------------------------------------------------------------------------
or, as an (untested) alternative, define CONFIG_SYS_BOARD correctly in board/samsung/smdk5420/Kconfig as follows:
-------------------------------------------------------------------------------------------------
Kconfig.new 2022-05-28 02:57:19.867518057 +0300 renamed from Kconfig 2022-04-04 17:31:32.000000000 +0300 +1 -1
@@ -1,7 +1,7 @@ if TARGET_ODROID_XU3 config SYS_BOARD - default "smdk5420" + default "odroid" config SYS_VENDOR default "samsung"
-------------------------------------------------------------------------------------------------
Gabriel
Quoted 6 lines · Gabriel Hojda
hi,
i've recently tried u-boot 2022.04 (u-boot-v2022.04.tar.bz2) and my odroid-hc2 didn't boot with uefi (default since Fedora 35) but worked when i used exlinux.conf
Quoted 8 lines
trying to track down the problem, i've found that in the default u-boot environment the "board" and "boardname" variables were "smdk5420" and not "odroid" (like before) ... and thus the "fdtfile" variable was "exynos5422-smdk5420hc1.dtb" and not "exynos5422-odroidhc1.dtb".
continuing i've made a diff between the u-boot-v2021.10.tar.bz2 and u-boot-v2022.04.tar.bz2 ... and long story short, i've found the culprit in commit
f76750d1"ConvertCONFIG_CONS_INDEXet al toKconfig" :
Thanks for the report. Can you please try updating include/configs/odroid_xu3.h to override "board" in CONFIG_EXTRA_ENV_SETTINGS and see if the auto-detection works as expected? We can't change CONFIG_SYS_BOARD as that would then change wht we look for in board/samsung/ to build.
Signature · 1 line
Tom
hi,
finally got around to do it: added "board=ordoid" to CONFIG_EXTRA_ENV_SETTINGS in include/configs/odroid_xu3.h using following patch, rebuild the rpm locally, updated u-boot on the sdcard for my local odroid-hc2 and booted with the new u-boot ... so adding board to CONFIG_EXTRA_ENV_SETTINGS fixes the problem.
Gabriel
-----------------------------------------------------------------------------
include/configs/odroid_xu3.h 2022-06-08 10:53:10.834233375 +0300 renamed from include/configs/odroid_xu3.h 2022-06-08 10:56:19.361113780 +0300 +1 -0
@@ -94,6 +94,7 @@ "rootfstype=ext4\0" \ "console=console=ttySAC2,115200n8\0" \ "fdtfile=exynos5422-odroidxu3.dtb\0" \ + "board=odroid\0" \ "board_name=odroidxu3\0" \ "mmcbootdev=0\0" \ "mmcrootdev=0\0" \
-----------------------------------------------------------------------------
Quoted 22 lines · Tom Rini
Quoted 6 lines · Gabriel Hojda
hi,
i've recently tried u-boot 2022.04 (u-boot-v2022.04.tar.bz2) and my odroid-hc2 didn't boot with uefi (default since Fedora 35) but worked when i used exlinux.conf
Quoted 8 lines
trying to track down the problem, i've found that in the default u-boot environment the "board" and "boardname" variables were "smdk5420" and not "odroid" (like before) ... and thus the "fdtfile" variable was "exynos5422-smdk5420hc1.dtb" and not "exynos5422-odroidhc1.dtb".
continuing i've made a diff between the u-boot-v2021.10.tar.bz2 and u-boot-v2022.04.tar.bz2 ... and long story short, i've found the culprit in commit
f76750d1"ConvertCONFIG_CONS_INDEXet al toKconfig" :Thanks for the report. Can you please try updating
include/configs/odroid_xu3.hto override "board" inCONFIG_EXTRA_ENV_SETTINGSand see if the auto-detection works as expected? We can't changeCONFIG_SYS_BOARDas that would then change wht we look for in board/samsung/ to build.