net: mvpp2: add xlg pcs inband capabilities
Subsystems (3)
PATCH 1/1 net: mvpp2: add xlg pcs inband capabilities
Add PCS inband capabilities for XLG in the Marvell PP2 driver, so phylink knows that 5G and 10G speeds have no inband capabilities.
---
The lack of this patch meant that I didn't see the problems with 10G SFP modules, as phylink becomes permissive without these capabilities, thereby causing a weakness in my run-time testing.
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +7 -0
@@ -6222,6 +6222,12 @@ static struct mvpp2_port *mvpp2_pcs_gmac_to_port(struct phylink_pcs *pcs) return container_of(pcs, struct mvpp2_port, pcs_gmac); } +static unsigned int mvpp2_xjg_pcs_inband_caps (struct phylink_pcs *pcs, +phy_interface_t interface) +{ +return LINK_INBAND_DISABLE ; +} +static void mvpp2_xlg_pcs_get_state (struct phylink_pcs *pcs,unsigned int neg_mode,struct phylink_link_state *state)
@@ -6256,6 +6262,7 @@ static int mvpp2_xlg_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode, }static const struct phylink_pcs_ops mvpp2_phylink_xlg_pcs_ops = { + .pcs_inband_caps = mvpp2_xjg_pcs_inband_caps, .pcs_get_state = mvpp2_xlg_pcs_get_state, .pcs_config = mvpp2_xlg_pcs_config, };
Signature · 1 line
2.47.2
Quoted 4 lines · Russell King (Oracle)
Add PCS inband capabilities for XLG in the Marvell PP2 driver, so phylink knows that 5G and 10G speeds have no inband capabilities.
Signed-off-by Russell King (Oracle) <[email protected]>
Quoted 37 lines
---
The lack of this patch meant that I didn't see the problems with 10G SFP modules, as phylink becomes permissive without these capabilities, thereby causing a weakness in my run-time testing.drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +7
-0@@ -6222,6 +6222,12 @@ static struct mvpp2_port *mvpp2_pcs_gmac_to_port(struct phylink_pcs *pcs) return container_of(pcs, struct mvpp2_port, pcs_gmac); } +static unsigned int mvpp2_xjg_pcs_inband_caps (struct phylink_pcs *pcs, +phy_interface_t interface) +{ +return LINK_INBAND_DISABLE ; +} +static void mvpp2_xlg_pcs_get_state (struct phylink_pcs *pcs,unsigned int neg_mode,struct phylink_link_state *state)@@ -6256,6 +6262,7 @@ static int mvpp2_xlg_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode, }static const struct phylink_pcs_ops mvpp2_phylink_xlg_pcs_ops = { + .pcs_inband_caps = mvpp2_xjg_pcs_inband_caps, .pcs_get_state = mvpp2_xlg_pcs_get_state, .pcs_config = mvpp2_xlg_pcs_config, };Signature · 1 line
2.47.2
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Sun, 31 Aug 2025 18:01:51 +0100 you wrote:
Add PCS inband capabilities for XLG in the Marvell PP2 driver, so phylink knows that 5G and 10G speeds have no inband capabilities.
Signed-off-by Russell King (Oracle) <[email protected]>---
The lack of this patch meant that I didn't see the problems with 10G SFP modules, as phylink becomes permissive without these capabilities, thereby causing a weakness in my run-time testing.[...]
Here is the summary with links:
- [net-next] net: mvpp2: add xlg pcs inband capabilities
https://git.kernel.org/netdev/net-next/c/99502c61e80c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html