Skip to contentSkip to conversation

staging: most: fix line ending with '(' in video

PATCH RESEND Superseded Khadija Kamran 3 participants 3 messages Mar 23, 2023 – Mar 24, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: most: fix line ending with '(' in video

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line.

---
 drivers/staging/most/video/video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/most/video/video.c +1 -2
index ffa97ef21ea5..6254a5df2502 100644
@@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
 
 /**************************************************************************/
 
-static struct most_video_dev *get_comp_dev(
-	struct most_interface *iface, int channel_idx)
+static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
 {
 	struct most_video_dev *mdev;
 	unsigned long flags;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line.

---
 drivers/staging/most/video/video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Why is this a RESEND?

#2 lore raw
In reply to Khadija Kamran
Quoted 17 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line.

---
 drivers/staging/most/video/video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/most/video/video.c +0 -0
index ffa97ef21ea5..6254a5df2502 100644

drivers/staging/most/video/video.c static const struct video_device comp_videodev_template = { · line 368

Quoted 6 lines
drivers/staging/most/video/video.c +1 -2
@@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
 
 /**************************************************************************/
 
-static struct most_video_dev *get_comp_dev(
-	struct most_interface *iface, int channel_idx)
+static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)

I know the 80 char limit is not strictly enforced anymore but I, and some other maintainers, like to see it adhered to unless there is a really good reason to violate it. How about?

static struct most_video_dev *get_comp_dev(struct most_interface *iface,
int channel_idx)

Ira

Quoted 7 lines
drivers/staging/most/video/video.c +0 -0
 {
 	struct most_video_dev *mdev;
 	unsigned long flags;
Signature · 1 line
2.34.1