Skip to contentSkip to conversation

staging: most: fix line ending with '(' in dim2

PATCH RESEND Superseded Khadija Kamran 3 participants 3 messages Mar 23, 2023 – Mar 24, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: most: fix line ending with '(' in dim2

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/most/dim2/hal.c +2 -3
index a5d40b5b138a..6abe3ab2b2cf 100644
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
 		dim2_clear_ctr(ctr_addr);
 }
 
-static void dim2_configure_channel(
-	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
-	u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+				   u16 hw_buffer_size, u16 packet_length)
 {
 	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
 	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Why is this a RESEND?

#2 lore raw
In reply to Khadija Kamran
Quoted 17 lines · Khadija Kamran

Splitting function header to multiple lines because of 80 characters per line limit, results in ending the function call line with '('. This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call line. Align the rest of the parameters to the opening parenthesis.

---
 drivers/staging/most/dim2/hal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/most/dim2/hal.c +0 -0
index a5d40b5b138a..6abe3ab2b2cf 100644

drivers/staging/most/dim2/hal.c static void dim2_clear_ctram(void) · line 349

Quoted 7 lines
drivers/staging/most/dim2/hal.c +1 -3
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
 		dim2_clear_ctr(ctr_addr);
 }
 
-static void dim2_configure_channel(
-	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
-	u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,

NIT: This introduces a long (> 80 char) line for not a great reason. Since you are changing it anyway how about?

static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx,
u16 dbr_address, u16 hw_buffer_size, u16 packet_length)

Ira

Quoted 9 lines
drivers/staging/most/dim2/hal.c +1 -0
+				   u16 hw_buffer_size, u16 packet_length)
 
 {
 	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);

dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);

Signature · 1 line
2.34.1