Fix "alc262_sony_unsol[]" hda_verb array
PATCH 1/1 Fix "alc262_sony_unsol[]" hda_verb array
I think that hda_verb array must have "terminator (empty array)". But alc262_sony_unsol[] does not have it.
And it causes gcc-4.3's buggy behavior
with snd_hda_sequence_write().
Signed-off-by Akio Idehara <[email protected]>
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
@@ -8839,6 +8839,7 @@ static struct hda_verb alc262_sony_unsol {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN | ALC880_HP_EVENT}, {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, + {} };/* mute/unmute internal speaker according to the hp jack and mute state */
At Mon, 9 Jun 2008 22:46:07 +0900,
Quoted 7 lines · idak
I think that
hda_verbarray must have "terminator (empty array)". But alc262_sony_unsol[] does not have it.
And it causes gcc-4.3's buggy behavior
withsnd_hda_sequence_write().Signed-off-by Akio Idehara <[email protected]>
Ouch, it was obviously overlooked...
I took both patches, and try to push this one to the upstream.
thanks,
Takashi
Quoted 18 lines
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +1
-0@@ -8839,6 +8839,7 @@ static struct hda_verb alc262_sony_unsol {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN | ALC880_HP_EVENT}, {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP}, + {} };/* mute/unmute internal speaker according to the hp jack and mute state */ _______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel