cpufreq: spear: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate()
Subsystems (2)
PATCH v2 1/1 cpufreq: spear: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate()
The clk_get_parent() function doesn't return error pointers, it returns NULL on error. Update the error checking to match.
Fixes 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver")
Signed-off-by Dan Carpenter <[email protected]>
---
v2: fix subsystem prefix in subject
drivers/cpufreq/spear-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/spear-cpufreq.c +2 -2
@@ -79,9 +79,9 @@ static int spear1340_set_cpu_rate(struct clk *sys_pclk, unsigned long newfreq)int ret =0 ; sys_clk =clk_get_parent (spear_cpufreq.clk); -if (IS_ERR (sys_clk)) { +if (!sys_clk) {pr_err ("failed to get cpu's parent (sys) clock\n" ); -return PTR_ERR (sys_clk); +return -EINVAL ; }/* Set the rate of the source clock before changing the parent */
Signature · 1 line
2.53.0
Quoted 7 lines · Dan Carpenter
The
clk_get_parent()function doesn't return error pointers, it returns NULL on error. Update the error checking to match.Fixes 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver")Signed-off-by Dan Carpenter <[email protected]>---
v2: fix subsystem prefix in subject
Reviewed-by Zhongqiu Han <[email protected]>
Quoted 20 lines
drivers/cpufreq/spear-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/cpufreq/spear-cpufreq.c +2
-2@@ -79,9 +79,9 @@ static int spear1340_set_cpu_rate(struct clk *sys_pclk, unsigned long newfreq)int ret =0 ; sys_clk =clk_get_parent (spear_cpufreq.clk); -if (IS_ERR (sys_clk)) { +if (!sys_clk) {pr_err ("failed to get cpu's parent (sys) clock\n" ); -return PTR_ERR (sys_clk); +return -EINVAL ; }/* Set the rate of the source clock before changing the parent */
Signature · 2 lines
Thx and BRs, Zhongqiu Han
Quoted 10 lines · Zhongqiu Han
Quoted 7 lines · Dan Carpenter
The
clk_get_parent()function doesn't return error pointers, it returns NULL on error. Update the error checking to match.Fixes 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver")Signed-off-by Dan Carpenter <[email protected]>---
v2: fix subsystem prefix in subjectReviewed-by Zhongqiu Han <[email protected]>
Applied. Thanks.
Signature · 1 line
viresh