Skip to contentSkip to conversation

drm/panel: ilitek-ili9805: Use _multi variants

PATCH Superseded Michail Tatas 2 participants 4 messages Jul 16 – Jul 17

Subsystems (4)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: ilitek-ili9805: Use _multi variants

Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file.
The multi variant of these functions include improved error handling.

---
 drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++---------------
 1 file changed, 13 insertions(+), 38 deletions(-)
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +13 -38
index e6c483851f1f..7e9587afebbe 100644
@@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx)
 
 static int ili9805_activate(struct ili9805 *ctx)
 {
-	struct mipi_dsi_device *dsi = ctx->dsi;
-	struct device *dev = &dsi->dev;
-	int i, ret;
+	struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
+	int i;
 
 	for (i = 0; i < ctx->desc->init_length; i++) {
 		const struct ili9805_instr *instr = &ctx->desc->init[i];
 
-		ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len);
-		if (ret < 0)
-			return ret;
+		mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len);
 
 		if (instr->delay > 0)
-			msleep(instr->delay);
-	}
-
-	ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
-	if (ret) {
-		dev_err(dev, "Failed to exit sleep mode (%d)\n", ret);
-		return ret;
+			mipi_dsi_msleep(&dsi_ctx, instr->delay);
 	}
 
-	usleep_range(5000, 6000);
+	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
+	mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000);
+	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
 
-	ret = mipi_dsi_dcs_set_display_on(ctx->dsi);
-	if (ret) {
-		dev_err(dev, "Failed to set display ON (%d)\n", ret);
-		return ret;
-	}
-
-	return 0;
+	return dsi_ctx.accum_err;
 }
 
 static int ili9805_prepare(struct drm_panel *panel)
@@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel)
 
 static int ili9805_deactivate(struct ili9805 *ctx)
 {
-	struct mipi_dsi_device *dsi = ctx->dsi;
-	struct device *dev = &dsi->dev;
-	int ret;
-
-	ret = mipi_dsi_dcs_set_display_off(ctx->dsi);
-	if (ret < 0) {
-		dev_err(dev, "Failed to set display OFF (%d)\n", ret);
-		return ret;
-	}
+	struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
 
-	usleep_range(5000, 10000);
-
-	ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);
-	if (ret < 0) {
-		dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
-		return ret;
-	}
+	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+	mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000);
+	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
-	return 0;
+	return dsi_ctx.accum_err;
 }
 
 static int ili9805_unprepare(struct drm_panel *panel)
Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 12 lines · Michail Tatas
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +2 -3
@@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx)
 
 static int ili9805_activate(struct ili9805 *ctx)
 {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int i, ret;
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
+       int i;
 
        for (i = 0; i < ctx->desc->init_length; i++) {

drivers/gpu/drm/panel/panel-ilitek-ili9805.c static int ili9805_power_off(struct ili9805 *ctx) · line 175

Quoted 10 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +1 -5
                const struct ili9805_instr *instr = &ctx->desc->init[i];
 
-               ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len);
-               if (ret < 0)
-                       return ret;
+               mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len);
 
                if (instr->delay > 0)
-                       msleep(instr->delay);
-       }

What you've done is an improvement, but it's not all the way there. Specifically, we'd really want to get rid of the whole "struct ili9805_instr" type and instead each panel should have an init function. The "struct ili9805_desc" should have a pointer to the init function instead of a pointer to the init data.

For details, you can see a preivous email about this [1], which then has further links if you want to dig into details. You can see that Chintan eventually implemented this in commit a89d9a327d06 ("drm/panel: novatek-nt36672a: Inline panel init sequences").

If landing this patch without cleaning up the init sequences is really important to you, I could be convinced. However, the init sequences aren't all that big and it would be nice if you could clean it up all at once. It could be one patch or two.

[1] http://lore.kernel.org/r/CAD=FV=UCyfjiqcpYCM5ePz-auX4g=i_+i78ivvvyA8R1XtAKzg@mail.gmail.com

Quoted 18 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +1 -12
@@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel)
 
 static int ili9805_deactivate(struct ili9805 *ctx)
 {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int ret;
-
-       ret = mipi_dsi_dcs_set_display_off(ctx->dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to set display OFF (%d)\n", ret);
-               return ret;
-       }
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
 
-       usleep_range(5000, 10000);
-
-       ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);

drivers/gpu/drm/panel/panel-ilitek-ili9805.c static int ili9805_prepare(struct drm_panel *panel) · line 207

Quoted 10 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +4 -5
-       if (ret < 0) {
-               dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
-               return ret;
-       }
+       mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+       mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000);
+       mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
-       return 0;
+       return dsi_ctx.accum_err;

Nobody looks at the return code of this function. Since you're touching it anyway, can you change ili9805_deactivate() to return "void"? I wouldn't object if you made ili9805_power_off() return "void" in the same patch too, even though it's a bit unrelated to the rest of the patch.

-Doug

#2 lore raw

On Thu, Jul 16, 2026 at 04:31:53PM -0700, Doug Anderson wrote:

Hello Doug, thanks a lot for the review!

Quoted 22 lines

Hi,

Quoted 19 lines · Michail Tatas
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +3 -6
@@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx)
 
 static int ili9805_activate(struct ili9805 *ctx)
 {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int i, ret;
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
+       int i;
 
        for (i = 0; i < ctx->desc->init_length; i++) {
                const struct ili9805_instr *instr = &ctx->desc->init[i];
 
-               ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len);
-               if (ret < 0)
-                       return ret;
+               mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len);
 
Quoted 9 lines

drivers/gpu/drm/panel/panel-ilitek-ili9805.c static int ili9805_power_off(struct ili9805 *ctx) · line 175

Quoted 3 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +0 -2
                if (instr->delay > 0)
-                       msleep(instr->delay);
-       }

What you've done is an improvement, but it's not all the way there. Specifically, we'd really want to get rid of the whole "struct ili9805_instr" type and instead each panel should have an init function. The "struct ili9805_desc" should have a pointer to the init function instead of a pointer to the init data.

I am more than happy to do these changes as well. My only concern is that I do not have hardware to test the panel. Are compiling and static analysis sufficient tests for these changes ?

Quoted 10 lines

For details, you can see a preivous email about this [1], which then has further links if you want to dig into details. You can see that Chintan eventually implemented this in commit a89d9a327d06 ("drm/panel: novatek-nt36672a: Inline panel init sequences").

If landing this patch without cleaning up the init sequences is really important to you, I could be convinced. However, the init sequences aren't all that big and it would be nice if you could clean it up all at once. It could be one patch or two.

It is not all that important, I can clean up the init sequences and send it as part of the v2

Quoted 29 lines

[1] http://lore.kernel.org/r/CAD=FV=UCyfjiqcpYCM5ePz-auX4g=i_+i78ivvvyA8R1XtAKzg@mail.gmail.com

Quoted 26 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +4 -16
@@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel)
 
 static int ili9805_deactivate(struct ili9805 *ctx)
 {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int ret;
-
-       ret = mipi_dsi_dcs_set_display_off(ctx->dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to set display OFF (%d)\n", ret);
-               return ret;
-       }
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
 
-       usleep_range(5000, 10000);
-
-       ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
-               return ret;
-       }
+       mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+       mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000);
+       mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
Quoted 9 lines

Review static int ili9805_prepare(struct drm_panel *panel) · line 207

Quoted 2 lines
(quoted diff) +1 -1
-       return 0;
+       return dsi_ctx.accum_err;

Nobody looks at the return code of this function. Since you're touching it anyway, can you change ili9805_deactivate() to return "void"? I wouldn't object if you made ili9805_power_off() return "void" in the same patch too, even though it's a bit unrelated to the rest of the patch.

Good point regarding the return types, I will change them to return void.

I will send a v2 with the requested changes.

Regards,
Michail

#3 lore raw

Hi,

Quoted 37 lines · Michail Tatas

On Thu, Jul 16, 2026 at 04:31:53PM -0700, Doug Anderson wrote:

Hello Doug, thanks a lot for the review!

Quoted 22 lines

Hi,

Quoted 19 lines · Michail Tatas
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +3 -6
@@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx)
 
 static int ili9805_activate(struct ili9805 *ctx)
 {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int i, ret;
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
+       int i;
 
        for (i = 0; i < ctx->desc->init_length; i++) {
                const struct ili9805_instr *instr = &ctx->desc->init[i];
 
-               ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len);
-               if (ret < 0)
-                       return ret;
+               mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len);
 
Quoted 9 lines

drivers/gpu/drm/panel/panel-ilitek-ili9805.c static int ili9805_power_off(struct ili9805 *ctx) · line 175

Quoted 3 lines
drivers/gpu/drm/panel/panel-ilitek-ili9805.c +0 -2
                if (instr->delay > 0)
-                       msleep(instr->delay);
-       }

What you've done is an improvement, but it's not all the way there. Specifically, we'd really want to get rid of the whole "struct ili9805_instr" type and instead each panel should have an init function. The "struct ili9805_desc" should have a pointer to the init function instead of a pointer to the init data.

Quoted 3 lines

I am more than happy to do these changes as well. My only concern is that I do not have hardware to test the panel. Are compiling and static analysis sufficient tests for these changes ?

That is inevitable with these cleanups. We're doing our best with static analysis and code review. If someone comes along later and finds that something broke, we'll fix it.

-Doug