Skip to contentSkip to conversation

iio: light: ltr390: Remove stale TODOs

PATCH Superseded Chang Yu 2 participants 2 messages Aug 28

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Chang Yu

author
#0 lore raw

PATCH v2 1/1 iio: light: ltr390: Remove stale TODOs

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

Configurable gain and resoluion: commit 13fad2607dad ("iio: light:
ltr390: Add configurable gain and resolution")

Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
Suspend and Resume support")

Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
Add ALS channel and support for gain and resolution")

Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts and threshold event support")

---

Changes since v2:
* Added commit hashes for each implemented feature.

 drivers/iio/light/ltr390.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/iio/light/ltr390.c +0 -6
index bc031f2c3141..f1bb066248e6 100644
@@ -10,12 +10,6 @@
  *
  * Datasheet:
  *   https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
- *
- * TODO:
- *   - Support for configurable gain and resolution
- *   - Sensor suspend/resume support
- *   - Add support for reading the ALS
- *   - Interrupt support
  */
 
 #include <linux/bitfield.h>
Signature · 1 line
2.55.0
#1 lore raw
Quoted 4 lines · Chang Yu

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

Configurable gain and resoluion: commit 13fad2607dad ("iio: light:

Misspelled 'resolution'.

Quoted 1 line

ltr390: Add configurable gain and resolution")

Here is trailing white space. Also you can do it in a way

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

Quoted 8 lines

Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
Suspend and Resume support")

Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
Add ALS channel and support for gain and resolution")

Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts and threshold event support")

Signature · 2 lines
With Best Regards,
Andy Shevchenko