Skip to contentSkip to conversation

iio: light: ltr390: Remove stale TODOs

PATCH In review Chang Yu 4 participants 4 messages Aug 28 – Aug 30

Subsystems (2)
lore
Share & tools
lore

Chang Yu

author
#0 lore raw

PATCH v3 1/1 iio: light: ltr390: Remove stale TODOs

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

---

Changes since v3:
* Reformatted commit links.

 drivers/iio/light/ltr390.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/iio/light/ltr390.c +0 -6
index bc031f2c3141..f1bb066248e6 100644
@@ -10,12 +10,6 @@
  *
  * Datasheet:
  *   https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
- *
- * TODO:
- *   - Support for configurable gain and resolution
- *   - Sensor suspend/resume support
- *   - Add support for reading the ALS
- *   - Interrupt support
  */
 
 #include <linux/bitfield.h>
Signature · 1 line
2.55.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 9 lines · Chang Yu

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

Quoted 5 lines

Link is the official tag, no blank line is supposed to be here. But no need to resend anymore, for this patch I hope Jonathan will make a necessary tweak whilst applying.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 16 lines · On Fri, 28 Aug 2026 11:19:46 +0300 Andy Shevchenko <[email protected]>…
Quoted 9 lines · Chang Yu

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

Quoted 5 lines
Quoted 5 lines

Link is the official tag, no blank line is supposed to be here. But no need to resend anymore, for this patch I hope Jonathan will make a necessary tweak whilst applying.

It was a touch messy as b4 picked up the fact there were tags in the earlier version for Link and (I think) because of this blank line it didn't match them with these ones so we had two sets of the same thing. Anyhow fixed up and applied

Jonathan

Quoted 1 line
#3 lore raw
In reply to Chang Yu
Quoted 8 lines · On Fri, 28 Aug 2026 01:13:54 -0700 Chang Yu <[email protected]> wrote:

Remove stale TODOs from ltr390.c. All features have already been implemented by Abhash Jha<[email protected]>'s patches:

[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support

Quoted 7 lines

---

Next time, please wait at least 24 hours before sending a new version.

Signature · 2 lines
Kind regards,
Joshua Crofts