Skip to contentSkip to conversation

Initial support for the XPedite5170

PATCH New Peter Tyser 4 participants 19 messages May 22, 2009 – Jul 10, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Initial support for the XPedite5170

Initial support for Extreme Engineering Solutions XPedite5170 - a MPC8640-based 3U VPX single board computer with a PMC/XMC site.

http://www.xes-inc.com/Products/XPedite5170/XPedite5170.html

Peter Tyser (6):
85xx: Add PORBMSR and PORDEVSR shift defines
86xx: Unlock l1 cache unconditionally
xes: Update Freescale PCI code to work with 86xx processors
xes: Update Freescale DDR code to work with 86xx processors
xes: Update Freescale clock code to work with 86xx processors XPedite5170 board support

Zach LeRoy (1):
tsec: Add support for BCM5482S PHY

 MAINTAINERS                                        |    1 +
 MAKEALL                                            |    1 +
 Makefile                                           |    3 +
 board/xes/common/Makefile                          |    7 +-
 .../xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c}  |    8 +
 .../xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c}  |    8 +-
 .../xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c}  |   81 ++-
 board/xes/xpedite5170/Makefile                     |   52 ++
 board/xes/xpedite5170/config.mk                    |   32 +
 board/xes/xpedite5170/ddr.c                        |  168 +++++
 board/xes/xpedite5170/law.c                        |   52 ++
 board/xes/xpedite5170/u-boot.lds                   |  132 ++++
 board/xes/xpedite5170/xpedite5170.c                |  111 +++
 drivers/net/tsec.c                                 |   41 ++
 include/asm-ppc/immap_85xx.h                       |    2 +
 include/configs/XPEDITE5170.h                      |  758 ++++++++++++++++++++
 include/tsec.h                                     |    2 +
 lib_ppc/board.c                                    |    8 +-
 lib_ppc/bootm.c                                    |    3 +-
 19 files changed, 1453 insertions(+), 17 deletions(-)
 rename board/xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c} (86%)
 rename board/xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c} (92%)
 rename board/xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c} (79%)
 create mode 100644 board/xes/xpedite5170/Makefile
 create mode 100644 board/xes/xpedite5170/config.mk
 create mode 100644 board/xes/xpedite5170/ddr.c
 create mode 100644 board/xes/xpedite5170/law.c
 create mode 100644 board/xes/xpedite5170/u-boot.lds
 create mode 100644 board/xes/xpedite5170/xpedite5170.c
 create mode 100644 include/configs/XPEDITE5170.h
#1 lore raw

PATCH 1/7 85xx: Add PORBMSR and PORDEVSR shift defines

Add defines similar to those already used for the the 86xx architecture. This will ease sharing of PCI code between the 85xx and 86xx architectures.

---
 include/asm-ppc/immap_85xx.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/asm-ppc/immap_85xx.h +2 -0
index 2231177..bc0cbdd 100644
@@ -1528,6 +1528,7 @@ typedef struct ccsr_gur {
 #endif
 	uint	porbmsr;	/* 0xe0004 - POR boot mode status register */
 #define MPC85xx_PORBMSR_HA		0x00070000
+#define MPC85xx_PORBMSR_HA_SHIFT	16
 	uint	porimpscr;	/* 0xe0008 - POR I/O impedance status and control register */
 	uint	pordevsr;	/* 0xe000c - POR I/O device status regsiter */
 #define MPC85xx_PORDEVSR_SGMII1_DIS	0x20000000
@@ -1537,6 +1538,7 @@ typedef struct ccsr_gur {
 #define MPC85xx_PORDEVSR_SRDS2_IO_SEL   0x38000000
 #define MPC85xx_PORDEVSR_PCI1		0x00800000
 #define MPC85xx_PORDEVSR_IO_SEL		0x00780000
+#define MPC85xx_PORDEVSR_IO_SEL_SHIFT	19
 #define MPC85xx_PORDEVSR_PCI2_ARB	0x00040000
 #define MPC85xx_PORDEVSR_PCI1_ARB	0x00020000
 #define MPC85xx_PORDEVSR_PCI1_PCI32	0x00010000
Signature · 1 line
1.6.2.1
#3 lore raw

PATCH 2/7 tsec: Add support for BCM5482S PHY

In reply to Peter Tyser

From: Zach LeRoy <[email protected]>

---
 drivers/net/tsec.c |   41 +++++++++++++++++++++++++++++++++++++++++
 include/tsec.h     |    2 ++
 2 files changed, 43 insertions(+), 0 deletions(-)
drivers/net/tsec.c +41 -0
index 399116f..63fc02e 100644
@@ -468,6 +468,18 @@ uint mii_parse_link(uint mii_reg, struct tsec_private *priv)
 }
 
 /*
+ * "Ethernet at Wirespeed" needs to be enabled to achieve link in certain
+ * circumstances.  eg a gigabit TSEC connected to a gigabit switch with
+ * a 4-wire ethernet cable.  Both ends advertise gigabit, but can't
+ * link.  "Ethernet at Wirespeed" reduces advertised speed until link
+ * can be achieved.
+ */
+uint mii_BCM54xx_wirespeed(uint mii_reg, struct tsec_private *priv)
+{
+	return (read_phy_reg(priv, mii_reg) & 0x8FFF) | 0x8010;
+}
+
+/*
  * Parse the BCM54xx status register for speed and duplex information.
  * The linux sungem_phy has this information, but in a table format.
  */
@@ -1070,6 +1082,34 @@ struct phy_info phy_info_BCM5464S = {
 	},
 };
 
+struct phy_info phy_info_BCM5482S =  {
+	0x0143bcb,
+	"Broadcom BCM5482S",
+	4,
+	(struct phy_cmd[]) { /* config */
+		/* Reset and configure the PHY */
+		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+		/* Setup read from auxilary control shadow register 7 */
+		{MIIM_BCM54xx_AUXCNTL, MIIM_BCM54xx_AUXCNTL_ENCODE(7), NULL},
+		/* Read Misc Control register and or in Ethernet at Wirespeed */
+		{MIIM_BCM54xx_AUXCNTL, 0, &mii_BCM54xx_wirespeed},
+		{MIIM_CONTROL, MIIM_CONTROL_INIT, &mii_cr_init},
+		{miim_end,}
+	},
+	(struct phy_cmd[]) { /* startup */
+		/* Status is read once to clear old link state */
+		{MIIM_STATUS, miim_read, NULL},
+		/* Auto-negotiate */
+		{MIIM_STATUS, miim_read, &mii_parse_sr},
+		/* Read the status */
+		{MIIM_BCM54xx_AUXSTATUS, miim_read, &mii_parse_BCM54xx_sr},
+		{miim_end,}
+	},
+	(struct phy_cmd[]) { /* shutdown */
+		{miim_end,}
+	},
+};
+
 struct phy_info phy_info_M88E1011S = {
 	0x01410c6,
 	"Marvell 88E1011S",
@@ -1611,6 +1651,7 @@ struct phy_info *phy_info[] = {
 	&phy_info_cis8201,
 	&phy_info_BCM5461S,
 	&phy_info_BCM5464S,
+	&phy_info_BCM5482S,
 	&phy_info_M88E1011S,
 	&phy_info_M88E1111S,
 	&phy_info_M88E1118,
include/tsec.h +2 -0
index 7b52e06..71903ba 100644
@@ -152,6 +152,8 @@
 #define MIIM_EXT_PAGE_ACCESS	0x1f
 
 /* Broadcom BCM54xx -- taken from linux sungem_phy */
+#define MIIM_BCM54xx_AUXCNTL			0x18
+#define MIIM_BCM54xx_AUXCNTL_ENCODE(val)	((val & 0x7) << 12)|(val & 0x7)
 #define MIIM_BCM54xx_AUXSTATUS			0x19
 #define MIIM_BCM54xx_AUXSTATUS_LINKMODE_MASK	0x0700
 #define MIIM_BCM54xx_AUXSTATUS_LINKMODE_SHIFT	8
Signature · 1 line
1.6.2.1
#6 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

In reply to Peter Tyser

Previously, it was only unlocked when Linux was executed using the "bootm" command. Unlocking it unconditionally improves U-Boot performance and provides a common cache state when booting OSes.

---
 lib_ppc/board.c |    8 +++++---
 lib_ppc/bootm.c |    3 ++-
 2 files changed, 7 insertions(+), 4 deletions(-)
lib_ppc/board.c +5 -3
index a0e6b20..7c02540 100644
@@ -68,7 +68,8 @@
 #if defined(CONFIG_LOGBUFFER)
 #include <logbuff.h>
 #endif
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && defined(CONFIG_E500)
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	(defined(CONFIG_E500) || defined(CONFIG_MPC86xx))
 #include <asm/cache.h>
 #endif
 #ifdef CONFIG_PS2KBD
@@ -754,8 +755,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	icache_enable ();	/* it's time to enable the instruction cache */
 #endif
 
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && defined(CONFIG_E500)
-	unlock_ram_in_cache();	/* it's time to unlock D-cache in e500 */
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	(defined(CONFIG_E500) || defined(CONFIG_MPC86xx))
+	unlock_ram_in_cache();	/* it's time to unlock D-cache */
 #endif
 
 #if defined(CONFIG_BAB7xx) || defined(CONFIG_CPC45)
lib_ppc/bootm.c +2 -1
index 0d702bf..d1cf94e 100644
@@ -71,7 +71,8 @@ static void boot_jump_linux(bootm_headers_t *images)
 
 	show_boot_progress (15);
 
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && !defined(CONFIG_E500)
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	!defined(CONFIG_E500) && !defined(CONFIG_MPC86xx)
 	unlock_ram_in_cache();
 #endif
 
Signature · 1 line
1.6.2.1
#12 lore raw

PATCH 4/7 xes: Update Freescale PCI code to work with 86xx processors

In reply to Peter Tyser
---
 board/xes/common/Makefile                          |    2 +-
 .../xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c}  |   81 +++++++++++++++++--
 2 files changed, 73 insertions(+), 10 deletions(-)
 rename board/xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c} (79%)
board/xes/common/Makefile +1 -1
index e7620f4..87b8a02 100644
@@ -29,7 +29,7 @@ endif
 
 LIB	= $(obj)lib$(VENDOR).a
 
-COBJS-$(CONFIG_FSL_PCI_INIT)	+= fsl_85xx_pci.o
+COBJS-$(CONFIG_FSL_PCI_INIT)	+= fsl_8xxx_pci.o
 COBJS-$(CONFIG_MPC8572)		+= fsl_8572_clk.o
 COBJS-$(CONFIG_MPC85xx)		+= fsl_85xx_ddr.o
 COBJS-$(CONFIG_NAND_ACTL)	+= actl_nand.o
board/xes/common/fsl_8xxx_pci.c renamed from board/xes/common/fsl_85xx_pci.c +72 -9

137 lines not on this page · raw message

Signature · 1 line
1.6.2.1
#14 lore raw

PATCH 5/7 xes: Update Freescale DDR code to work with 86xx processors

In reply to Peter Tyser
---
 board/xes/common/Makefile                          |    2 +-
 .../xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c}  |    8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
 rename board/xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c} (92%)
board/xes/common/Makefile +1 -1
index 87b8a02..6aef6f4 100644
@@ -31,7 +31,7 @@ LIB	= $(obj)lib$(VENDOR).a
 
 COBJS-$(CONFIG_FSL_PCI_INIT)	+= fsl_8xxx_pci.o
 COBJS-$(CONFIG_MPC8572)		+= fsl_8572_clk.o
-COBJS-$(CONFIG_MPC85xx)		+= fsl_85xx_ddr.o
+COBJS-$(CONFIG_FSL_DDR2)	+= fsl_8xxx_ddr.o
 COBJS-$(CONFIG_NAND_ACTL)	+= actl_nand.o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
board/xes/common/fsl_8xxx_ddr.c renamed from board/xes/common/fsl_85xx_ddr.c +7 -1
similarity index 92%
rename from board/xes/common/fsl_85xx_ddr.c
rename to board/xes/common/fsl_8xxx_ddr.c
index 30b4767..ec64efa 100644
@@ -32,9 +32,10 @@ phys_size_t initdram(int board_type)
 {
 	phys_size_t dram_size = fsl_ddr_sdram();
 
+#ifdef CONFIG_MPC85xx
 	dram_size = setup_ddr_tlbs(dram_size / 0x100000);
-
 	dram_size *= 0x100000;
+#endif
 
 #if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)
 	/* Initialize and enable DDR ECC */
@@ -48,7 +49,12 @@ phys_size_t initdram(int board_type)
 void board_add_ram_info(int use_default)
 {
 #if (CONFIG_NUM_DDR_CONTROLLERS > 1)
+#if defined(CONFIG_MPC85xx)
 	volatile ccsr_ddr_t *ddr1 = (void *)(CONFIG_SYS_MPC85xx_DDR_ADDR);
+#elif defined(CONFIG_MPC86xx)
+	volatile immap_t *immap = (immap_t *)CONFIG_SYS_IMMR;
+	volatile ccsr_ddr_t *ddr1 = &immap->im_ddr1;
+#endif
 #endif
 
 	puts(" (");
Signature · 1 line
1.6.2.1
#16 lore raw

PATCH 6/7 xes: Update Freescale clock code to work with 86xx processors

In reply to Peter Tyser
---
 board/xes/common/Makefile                          |    3 ++-
 .../xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c}  |    8 ++++++++
 2 files changed, 10 insertions(+), 1 deletions(-)
 rename board/xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c} (86%)
board/xes/common/Makefile +2 -1
index 6aef6f4..d022831 100644
@@ -30,7 +30,8 @@ endif
 LIB	= $(obj)lib$(VENDOR).a
 
 COBJS-$(CONFIG_FSL_PCI_INIT)	+= fsl_8xxx_pci.o
-COBJS-$(CONFIG_MPC8572)		+= fsl_8572_clk.o
+COBJS-$(CONFIG_MPC8572)		+= fsl_8xxx_clk.o
+COBJS-$(CONFIG_MPC86xx)		+= fsl_8xxx_clk.o
 COBJS-$(CONFIG_FSL_DDR2)	+= fsl_8xxx_ddr.o
 COBJS-$(CONFIG_NAND_ACTL)	+= actl_nand.o
 
board/xes/common/fsl_8xxx_clk.c renamed from board/xes/common/fsl_8572_clk.c +8 -0
similarity index 86%
rename from board/xes/common/fsl_8572_clk.c
rename to board/xes/common/fsl_8xxx_clk.c
index f5df2da..0155670 100644
@@ -27,7 +27,12 @@
  */
 unsigned long get_board_sys_clk(ulong dummy)
 {
+#if defined(CONFIG_MPC85xx)
 	volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
+#elif defined(CONFIG_MPC86xx)
+	immap_t *immap = (immap_t *)CONFIG_SYS_IMMR;
+	volatile ccsr_gur_t *gur = &immap->im_gur;
+#endif
 	u32 gpporcr = gur->gpporcr;
 
 	if (gpporcr & 0x10000)
@@ -36,8 +41,10 @@ unsigned long get_board_sys_clk(ulong dummy)
 		return 50000000;
 }
 
+#ifdef CONFIG_MPC85xx
 /*
  * Return DDR input clock - synchronous with SYSCLK or 66 MHz
+ * Note: 86xx doesn't support asynchronous DDR clk
  */
 unsigned long get_board_ddr_clk(ulong dummy)
 {
@@ -49,3 +56,4 @@ unsigned long get_board_ddr_clk(ulong dummy)
 
 	return 66666666;
 }
+#endif
Signature · 1 line
1.6.2.1
#18 lore raw

PATCH 7/7 XPedite5170 board support

In reply to Peter Tyser

Initial support for Extreme Engineering Solutions XPedite5170 - a MPC8640-based 3U VPX single board computer with a PMC/XMC site.

---
 MAINTAINERS                         |    1 +
 MAKEALL                             |    1 +
 Makefile                            |    3 +
 board/xes/xpedite5170/Makefile      |   52 +++
 board/xes/xpedite5170/config.mk     |   32 ++
 board/xes/xpedite5170/ddr.c         |  168 ++++++++
 board/xes/xpedite5170/law.c         |   52 +++
 board/xes/xpedite5170/u-boot.lds    |  132 ++++++
 board/xes/xpedite5170/xpedite5170.c |  111 +++++
 include/configs/XPEDITE5170.h       |  758 +++++++++++++++++++++++++++++++++++
 10 files changed, 1310 insertions(+), 0 deletions(-)
 create mode 100644 board/xes/xpedite5170/Makefile
 create mode 100644 board/xes/xpedite5170/config.mk
 create mode 100644 board/xes/xpedite5170/ddr.c
 create mode 100644 board/xes/xpedite5170/law.c
 create mode 100644 board/xes/xpedite5170/u-boot.lds
 create mode 100644 board/xes/xpedite5170/xpedite5170.c
 create mode 100644 include/configs/XPEDITE5170.h
MAINTAINERS +1 -0
index bf076b9..5331e92 100644
@@ -428,6 +428,7 @@ Rune Torgersen <[email protected]>
 
 Peter Tyser <[email protected]>
 
+	XPEDITE5170	MPC8640
 	XPEDITE5200	MPC8548
 	XPEDITE5370	MPC8572
 
MAKEALL +1 -0
index c98d03a..47b6bf4 100755
@@ -407,6 +407,7 @@ LIST_86xx="		\
 	MPC8610HPCD	\
 	MPC8641HPCN	\
 	sbc8641d	\
+	XPEDITE5170	\
 "
 
 #########################################################################
Makefile +3 -0
index 81a5cd0..a64d0e4 100644
@@ -2558,6 +2558,9 @@ MPC8641HPCN_config:    unconfig
 sbc8641d_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc86xx sbc8641d
 
+XPEDITE5170_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) ppc mpc86xx xpedite5170 xes
+
 #########################################################################
 ## 74xx/7xx Systems
 #########################################################################
board/xes/xpedite5170/Makefile new file +52 -0

52 lines not on this page · raw message

board/xes/xpedite5170/config.mk new file +32 -0
new file mode 100644
index 0000000..c3df6d5
@@ -0,0 +1,32 @@
+#
+# Copyright 2009 Extreme Engineering Solutions, Inc.
+# Copyright 2007-2008 Freescale Semiconductor, Inc.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+#
+# XPedite5170
+#
+TEXT_BASE = 0xfff00000
+
+PLATFORM_RELFLAGS += -mrelocatable
+
+PLATFORM_CPPFLAGS += -DCONFIG_MPC86xx=1
+PLATFORM_CPPFLAGS += -DCONFIG_MPC8641=1 -maltivec -mabi=altivec -msoft-float
board/xes/xpedite5170/ddr.c new file +168 -0

168 lines not on this page · raw message

board/xes/xpedite5170/law.c new file +52 -0

52 lines not on this page · raw message

board/xes/xpedite5170/u-boot.lds new file +132 -0

132 lines not on this page · raw message

board/xes/xpedite5170/xpedite5170.c new file +111 -0

111 lines not on this page · raw message

include/configs/XPEDITE5170.h new file +758 -0

758 lines not on this page · raw message

Signature · 1 line
1.6.2.1
#7 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

In reply to Peter Tyser
Quoted 9 lines · Peter Tyser

Previously, it was only unlocked when Linux was executed using the "bootm" command. Unlocking it unconditionally improves U-Boot performance and provides a common cache state when booting OSes.

---

lib_ppc/board.c |    8 +++++---
lib_ppc/bootm.c |    3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)

Wolfgang, do you know any reason we can't do the unlock for ALL ppc's in board_init_r()?

- k

Quoted 49 lines
lib_ppc/board.c +5 -3
index a0e6b20..7c02540 100644
@@ -68,7 +68,8 @@
 #if defined(CONFIG_LOGBUFFER)
 #include <logbuff.h>
 #endif
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && defined(CONFIG_E500)
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	(defined(CONFIG_E500) || defined(CONFIG_MPC86xx))
 #include <asm/cache.h>
 #endif
 #ifdef CONFIG_PS2KBD
@@ -754,8 +755,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	icache_enable ();	/* it's time to enable the instruction cache */
 #endif
 
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && defined(CONFIG_E500)
-	unlock_ram_in_cache();	/* it's time to unlock D-cache in e500 */
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	(defined(CONFIG_E500) || defined(CONFIG_MPC86xx))
+	unlock_ram_in_cache();	/* it's time to unlock D-cache */
 #endif
 
 #if defined(CONFIG_BAB7xx) || defined(CONFIG_CPC45)
lib_ppc/bootm.c +2 -1
index 0d702bf..d1cf94e 100644
@@ -71,7 +71,8 @@ static void boot_jump_linux(bootm_headers_t *images)
 
 	show_boot_progress (15);
 
-#if defined(CONFIG_SYS_INIT_RAM_LOCK) && !defined(CONFIG_E500)
+#if defined(CONFIG_SYS_INIT_RAM_LOCK) && \
+	!defined(CONFIG_E500) && !defined(CONFIG_MPC86xx)
 	unlock_ram_in_cache();
 #endif
 
Signature · 6 lines
1.6.2.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#5 lore raw

PATCH 2/7 tsec: Add support for BCM5482S PHY

In reply to Kumar Gala
Quoted 11 lines · Kumar Gala
Quoted 7 lines · Peter Tyser

From: Zach LeRoy <[email protected]>

---
drivers/net/tsec.c | 41 +++++++++++++++++++++++++++++++++++++++++
include/tsec.h | 2 ++

2 files changed, 43 insertions(+), 0 deletions(-)
Quoted 9 lines

Ben,

This seems fine to me.. can you pick it up via the u-boot-net tree for next.

- k

Sure

-- Ben

Applied
#2 lore raw

PATCH 1/7 85xx: Add PORBMSR and PORDEVSR shift defines

In reply to Peter Tyser
Quoted 9 lines · Peter Tyser

Add defines similar to those already used for the the 86xx architecture.
This will ease sharing of PCI code between the 85xx and 86xx architectures.

---
include/asm-ppc/immap_85xx.h | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

applied to next

- k

Applied
#13 lore raw

PATCH 4/7 xes: Update Freescale PCI code to work with 86xx processors

In reply to Peter Tyser
Quoted 7 lines · Peter Tyser

---
board/xes/common/Makefile | 2 +-
.../xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c} | 81 +++++++++++
++++++--

2 files changed, 73 insertions(+), 10 deletions(-)

rename board/xes/common/{fsl_85xx_pci.c => fsl_8xxx_pci.c} (79%)

applied to next

- k

Applied
#15 lore raw

PATCH 5/7 xes: Update Freescale DDR code to work with 86xx processors

In reply to Peter Tyser
Quoted 6 lines · Peter Tyser

---

board/xes/common/Makefile                          |    2 +-
.../xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c}  |    8 +++++++-
2 files changed, 8 insertions(+), 2 deletions(-)

rename board/xes/common/{fsl_85xx_ddr.c => fsl_8xxx_ddr.c} (92%)

applied to next

- k

Applied
#17 lore raw

PATCH 6/7 xes: Update Freescale clock code to work with 86xx processors

In reply to Peter Tyser
Quoted 6 lines · Peter Tyser

---

board/xes/common/Makefile                          |    3 ++-
.../xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c}  |    8 ++++++++
2 files changed, 10 insertions(+), 1 deletions(-)

rename board/xes/common/{fsl_8572_clk.c => fsl_8xxx_clk.c} (86%)

applied to next

- k

#8 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

In reply to Kumar Gala

Dear Kumar Gala,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 4 lines · Peter Tyser

Previously, it was only unlocked when Linux was executed using the "bootm" command. Unlocking it unconditionally improves U-Boot performance and provides a common cache state when booting OSes.

Quoted 8 lines
Quoted 5 lines

---

lib_ppc/board.c |    8 +++++---
lib_ppc/bootm.c |    3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)

Wolfgang, do you know any reason we can't do the unlock for ALL ppc's in board_init_r()?

Sorry, I don't remember if there was any speciofic reason, or what that might have been. Maybe the CHANGELOGs contain some hints?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes a feeling is all we humans have to go on.
	-- Kirk, "A Taste of Armageddon", stardate 3193.9
#9 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

Quoted 16 lines · Wolfgang Denk

Dear Kumar Gala,

Quoted 13 lines · In message <[email protected]> you wrote:
Quoted 9 lines · Peter Tyser

Previously, it was only unlocked when Linux was executed using the "bootm" command. Unlocking it unconditionally improves U-Boot performance and provides a common cache state when booting OSes.

---

lib_ppc/board.c |    8 +++++---
lib_ppc/bootm.c |    3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)
Quoted 5 lines
Quoted 2 lines

Wolfgang, do you know any reason we can't do the unlock for ALL ppc's in board_init_r()?

Sorry, I don't remember if there was any speciofic reason, or what that might have been. Maybe the CHANGELOGs contain some hints?

The only platforms the define unlock_ram_in_cache() are 83xx, 85xx, 86xx, and 74xx_7xx.

It looks like the most of them had "issues" in their implementation that could explain why there weren't enabled:
83xx - ade50c7fa1b16ef98be17e9c3ae286aecf4f5605, 6eb2a44e27919fdc601e0c05404b298a7602c0e3

86xx - 392438406041415fe64ab8748ec5ab5ad01d1cf7

74xx - d685b74c64a38849f1a129b3ab846fbf67dd937e

85xx - this one works

My best guess was all the non-85xx implementations had bugs or other issues that caused U-Boot to become unstable after unlocking the cache. Perhaps those bugs are fixed now, but I only have 86xx hardware to test on. I've been running a few 86xx boards with the cache unlocked with no noticeable problems.

Peter

#10 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

Dear Peter Tyser,

Quoted 13 lines · In message <[email protected]> you wrote:

The only platforms the define unlock_ram_in_cache() are 83xx, 85xx, 86xx, and 74xx_7xx.

It looks like the most of them had "issues" in their implementation that could explain why there weren't enabled:
83xx - ade50c7fa1b16ef98be17e9c3ae286aecf4f5605, 6eb2a44e27919fdc601e0c05404b298a7602c0e3

86xx - 392438406041415fe64ab8748ec5ab5ad01d1cf7

74xx - d685b74c64a38849f1a129b3ab846fbf67dd937e

Quoted 7 lines

85xx - this one works

My best guess was all the non-85xx implementations had bugs or other issues that caused U-Boot to become unstable after unlocking the cache. Perhaps those bugs are fixed now, but I only have 86xx hardware to test on. I've been running a few 86xx boards with the cache unlocked with no noticeable problems.

Thanks for the analysis. So let's go ahead and do this globally.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Karl's version of Parkinson's Law: Work expands to  exceed  the  time
alloted it.
#11 lore raw

PATCH 3/7 86xx: Unlock l1 cache unconditionally

Quoted 18 lines · Wolfgang Denk

Dear Peter Tyser,

Quoted 15 lines · In message <[email protected]> you wrote:

The only platforms the define unlock_ram_in_cache() are 83xx, 85xx, 86xx, and 74xx_7xx.

It looks like the most of them had "issues" in their implementation that could explain why there weren't enabled:
83xx - ade50c7fa1b16ef98be17e9c3ae286aecf4f5605, 6eb2a44e27919fdc601e0c05404b298a7602c0e3

86xx - 392438406041415fe64ab8748ec5ab5ad01d1cf7

74xx - d685b74c64a38849f1a129b3ab846fbf67dd937e

85xx - this one works

Quoted 7 lines
Quoted 5 lines

My best guess was all the non-85xx implementations had bugs or other issues that caused U-Boot to become unstable after unlocking the cache. Perhaps those bugs are fixed now, but I only have 86xx hardware to test on. I've been running a few 86xx boards with the cache unlocked with no noticeable problems.

Thanks for the analysis. So let's go ahead and do this globally.

I'll submit a patch. Hopefully someone with an 83xx and 74xx/7xx board can give it a shot before you apply it.

Best,
Peter