NET: NETROM: Don't use static buffer.
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 65cb898f276a2dc3c56e6a78b5bc422303e6856f.1248620197.git.ralf@linux-mips.org
David Miller
maintainerFrom: Ralf Baechle <[email protected]>
Date: Sat, 25 Jul 2009 11:38:17 +0100
Quoted 5 lines
The use of a static buffer in
nr_call_to_digi()to return its result is not threadproof and can result in corruption if multiple threads are trying to perform SIOCADDRT ioctls.Signed-off-by Ralf Baechle <[email protected]>
So what frees up these now-dynamically-allocated digi objects?
David Miller
maintainerFrom: David Miller <[email protected]>
Date: Sun, 26 Jul 2009 19:09:27 -0700 (PDT)
Quoted 10 lines
From: Ralf Baechle <[email protected]>
Date: Sat, 25 Jul 2009 11:38:17 +0100Quoted 5 lines
The use of a static buffer in
nr_call_to_digi()to return its result is not threadproof and can result in corruption if multiple threads are trying to perform SIOCADDRT ioctls.Signed-off-by Ralf Baechle <[email protected]>So what frees up these now-dynamically-allocated digi objects?
Ralf, ping?
A message that is not in the archive (sent off-list or not yet received): eb5a7590d64932b2239e358b54391c25007472ee.1248620197.git.ralf@linux-mips.org
David Miller
maintainerRe: [PATCH 2/2] NET: ROSE: Don't use static buffer.
From: Ralf Baechle <[email protected]>
Date: Sat, 25 Jul 2009 11:38:18 +0100
Quoted 5 lines
The use of a static buffer in
rose2asc()to return its result is not threadproof and can result in corruption if multiple threads are trying to use one of the procfs files based onrose2asc().Signed-off-by Ralf Baechle <[email protected]>
Looks good, applied, thanks!