Skip to contentSkip to conversation

NET: NETROM: Don't use static buffer.

PATCH David Miller 1 participant 3 messages Jul 27, 2009 – Aug 4, 2009 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
author maintainer
#5 lore raw

Re: [PATCH 2/2] NET: ROSE: Don't use static buffer.

In reply to a message not in the archive

From: Ralf Baechle <[email protected]>
Date: Sat, 25 Jul 2009 11:38:18 +0100

Quoted 5 lines

The use of a static buffer in rose2asc() to return its result is not threadproof and can result in corruption if multiple threads are trying to use one of the procfs files based on rose2asc().

Looks good, applied, thanks!

author maintainer
#3 lore raw
In reply to David Miller

From: David Miller <[email protected]>
Date: Sun, 26 Jul 2009 19:09:27 -0700 (PDT)

Quoted 10 lines

From: Ralf Baechle <[email protected]>
Date: Sat, 25 Jul 2009 11:38:17 +0100

Quoted 5 lines

The use of a static buffer in nr_call_to_digi() to return its result is not threadproof and can result in corruption if multiple threads are trying to perform SIOCADDRT ioctls.

So what frees up these now-dynamically-allocated digi objects?

Ralf, ping?