Skip to contentSkip to conversation

YB2370: Build Appliance integrates a filemanager

PATCH In review Cristian Iorga 2 participants 8 messages Aug 23, 2013

lore
Share & tools
lore
#0 lore raw

v3 cover YB2370: Build Appliance integrates a filemanager

A filemanager has been integrated into BA in order to manage file and folders resulted from distro building.

V3 patch set corrects the following mistakes:
* add the correct component names in commit messages;
* add sato theme, but also keep hicolor-icon-theme;
hicolor-icon-theme provides the skeleton structure for icons;
* fix the wrong user in recipes-graphics/builder shell script,
(regression introduced in a previous commit: 851163a7c672b5fb051fc0e7938ebd585bb33bf0);

The following changes since commit 199b1a8c7d7109d9b59d67bf4dcfeb03be07587a:

mkfontscale: This no longer needs a full libx11, xproto suffices (2013-08-22 18:30:06 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ciorga/YB2370
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ciorga/YB2370

Cristian Iorga (4):
xdg-utils: add runtime dependency on xprop
packagegroup-self-hosted: pcmanfm and xdg-utils integration
packagegroup-self-hosted: changing the icon theme to sato recipes-graphics/builder: fix wrong user name

 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 4 ++++
 meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb      | 1 +
 meta/recipes-graphics/builder/files/builder_hob_start.sh    | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v3 1/4 xdg-utils: add runtime dependency on xprop

xprop is called by xdg-utils scripts.

---
 meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb +1 -0
index d5c7aa3..22247f7 100644
@@ -23,3 +23,4 @@ SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209
 
 inherit autotools
 
+RDEPENDS_${PN} = "xprop"
Signature · 1 line
1.8.1.2
#4 lore raw

PATCH v3 2/4 packagegroup-self-hosted: pcmanfm and xdg-utils integration

In reply to Cristian Iorga

PCManFm file manager is integrated in Build Appliance; xdg-utils is also integrated for file association support.

---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +2 -0
index 6a0722a..2d35c16 100644
@@ -38,11 +38,13 @@ RDEPENDS_packagegroup-self-hosted-host-tools = "\
     hdparm \
     iptables \
     lsb \
+    xdg-utils \
     mc \
     mc-fish \
     mc-helpers \
     mc-helpers-perl \
     mc-helpers-python \
+    pcmanfm \
     parted \
     pseudo \
     screen \
Signature · 1 line
1.8.1.2
#6 lore raw

PATCH v3 3/4 packagegroup-self-hosted: changing the icon theme to sato

In reply to Cristian Iorga

Hicolor icon theme does not properly displays icons for folders in Build Appliance.
Sato icon theme is working correctly.
Also, settings-daemon needs to be added to image in order to properly display folder icons.

---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +2 -0
index 2d35c16..429ade9 100644
@@ -123,7 +123,9 @@ RDEPENDS_packagegroup-self-hosted-extended = "\
     grep \
     groff \
     gzip \
+    settings-daemon \
     hicolor-icon-theme \
+    sato-icon-theme \
     libaio \
     libusb1 \
     libxml2 \
Signature · 1 line
1.8.1.2
#7 lore raw

PATCH v3 4/4 recipes-graphics/builder: fix wrong user name

In reply to Cristian Iorga

Fix wrong inclusion of local username.
The right "builder" user is now used in
builder_hob_start shell script.

---
 meta/recipes-graphics/builder/files/builder_hob_start.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/builder/files/builder_hob_start.sh +1 -1
index b3a0540..bef6878 100644
@@ -13,7 +13,7 @@ export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 pcmanfm -d&
 
 #register folders to open with PCManFM filemanager
-if [ ! -d /home/ubik/tmp/.local/share/applications ]; then
+if [ ! -d /home/builder/.local/share/applications ]; then
     mkdir -p /home/builder/.local/share/applications/
     xdg-mime default pcmanfm.desktop inode/directory
 fi
Signature · 1 line
1.8.1.2
#5 lore raw

Re: [PATCH v3 2/4] packagegroup-self-hosted: pcmanfm and xdg-utils integration - no comment on the patch itself!!

In reply to Cristian Iorga

There seems to be an issue with the create-pull-request script.. It will break the subject in two lines...
As such, at least under Outlook, the mail titles look strange. Is this happening to other people also?
Regards,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Cristian Iorga
Sent: Friday, August 23, 2013 4:42 PM
To: [email protected]
Subject: [OE-core] [PATCH v3 2/4] packagegroup-self-hosted: pcmanfm and xdg-utils integration

PCManFm file manager is integrated in Build Appliance; xdg-utils is also integrated for file association support.

---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +2 -0
index 6a0722a..2d35c16 100644
@@ -38,11 +38,13 @@ RDEPENDS_packagegroup-self-hosted-host-tools = "\
     hdparm \
     iptables \
     lsb \
+    xdg-utils \
     mc \
     mc-fish \
     mc-helpers \
     mc-helpers-perl \
     mc-helpers-python \
+    pcmanfm \
     parted \
     pseudo \
     screen \

--
1.8.1.2

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

Re: [PATCH v3 1/4] xdg-utils: add runtime dependency on xprop

In reply to Cristian Iorga
Quoted 12 lines · Cristian Iorga

xprop is called by xdg-utils scripts.

---
 meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb +0 -0
index d5c7aa3..22247f7 100644

meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209 · line 26

Quoted 4 lines
meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb +1 -0
@@ -23,3 +23,4 @@ SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209
 
 inherit autotools
 
+RDEPENDS_${PN} = "xprop"

Usually best to do += with these. I've tweaked it when applying.

Cheers,

Richard

#3 lore raw

Re: [PATCH v3 1/4] xdg-utils: add runtime dependency on xprop

OK, thanks.
I thought that would be safer this way.

-----Original Message-----
From: Richard Purdie [mailto:[email protected]]
Sent: Friday, August 23, 2013 6:09 PM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH v3 1/4] xdg-utils: add runtime dependency on xprop

Quoted 12 lines · Cristian Iorga

xprop is called by xdg-utils scripts.

---
 meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb +0 -0
index d5c7aa3..22247f7 100644

meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209 · line 26

Quoted 4 lines
meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb +1 -0
@@ -23,3 +23,4 @@ SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209
 
 inherit autotools
 
+RDEPENDS_${PN} = "xprop"

Usually best to do += with these. I've tweaked it when applying.

Cheers,

Richard