Skip to contentSkip to conversation

Fix multiple checkpatch issues

PATCH Superseded Amitoj Kaur Chawla 2 participants 6 messages Oct 8, 2015

Subsystems (2)
Staging Staging - silicon motion SM750 frame buffer driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Amitoj Kaur Chawla

author
#0 lore raw

cover Fix multiple checkpatch issues

This patchset fixes multiple issues found using checkpatch.pl

Amitoj Kaur Chawla (3):
staging: sm750fb: Remove space after cast
staging: sm750fb: Remove space before closing brace
staging: sm750fb: Remove space after opening brace

 drivers/staging/sm750fb/ddk750_chip.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/3 staging: sm750fb: Remove space after cast

Remove unnecessary space after cast. Problem found using checkpatch.pl
CHECK: No space is necessary after a cast

Signed-off-by Amitoj Kaur Chawla <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +2 -2
index 270d10b..e797b5b 100644
@@ -133,7 +133,7 @@ static void setMemoryClock(unsigned int frequency)
 			frequency = MHz(336);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);

@@ -180,7 +180,7 @@ static void setMasterClock(unsigned int frequency)
 			frequency = MHz(190);
 
 		/* Calculate the divisor */
-		divisor = (unsigned int) roundedDiv(getChipClock(), frequency);
+		divisor = (unsigned int)roundedDiv(getChipClock(), frequency);
 
 		/* Set the corresponding divisor in the register. */
 		ulReg = PEEK32(CURRENT_GATE);
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 2/3 staging: sm750fb: Remove space before closing brace

In reply to Amitoj Kaur Chawla

Remove space before closing brace '}'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by Amitoj Kaur Chawla <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -1
index e797b5b..ebc3242 100644
@@ -234,7 +234,6 @@ unsigned int ddk750_getVMSize(void)
 		break;
 	}
 	return data;
-
 }
 
 int ddk750_initHw(initchip_param_t *pInitParam)
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH 3/3 staging: sm750fb: Remove space after opening brace

In reply to Amitoj Kaur Chawla

Remove space after opening brace '{'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by Amitoj Kaur Chawla <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -1
index ebc3242..6f05f78 100644
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
 
 int ddk750_initHw(initchip_param_t *pInitParam)
 {
-
 	unsigned int ulReg;
 
 <<<<<<< HEAD
Signature · 1 line
1.9.1
#4 lore raw

Re: [Outreachy kernel] [PATCH 3/3] staging: sm750fb: Remove space after opening brace

Quoted 14 lines · Amitoj Kaur Chawla

Remove space after opening brace '{'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by Amitoj Kaur Chawla <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -0
index ebc3242..6f05f78 100644

drivers/staging/sm750fb/ddk750_chip.c unsigned int ddk750_getVMSize(void) · line 243

Quoted 7 lines
drivers/staging/sm750fb/ddk750_chip.c +0 -1
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
 
 int ddk750_initHw(initchip_param_t *pInitParam)
 {
-
 	unsigned int ulReg;
 
 <<<<<<< HEAD

Something went wrong here.

julia

Quoted 10 lines
Signature · 8 lines
1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/65d703974d96550d8802203b4243da28797ae8bf.1444332001.git.amitoj1606%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
author
#5 lore raw

Re: [Outreachy kernel] [PATCH 3/3] staging: sm750fb: Remove space after opening brace

Quoted 17 lines · Julia Lawall
Quoted 15 lines · Amitoj Kaur Chawla

Remove space after opening brace '{'. Problem found using checkpatch.pl
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by Amitoj Kaur Chawla <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -0
index ebc3242..6f05f78 100644
@@ -238,7 +238,6 @@ unsigned int ddk750_getVMSize(void)
Quoted 9 lines

drivers/staging/sm750fb/ddk750_chip.c unsigned int ddk750_getVMSize(void) · line 243

Quoted 6 lines
drivers/staging/sm750fb/ddk750_chip.c +0 -1
 int ddk750_initHw(initchip_param_t *pInitParam)
 {
-
      unsigned int ulReg;
 
 <<<<<<< HEAD

Something went wrong here.

I just saw. This last line. HEAD. I'll look into this!

Thanks,

Amitoj