Skip to contentSkip to conversation

ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

PATCH Superseded Alexandrov Stansilav 4 participants 9 messages Jan 4, 2017 – Jan 31, 2017

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

v2: Splited patch to codec and sst parts

 sound/soc/codecs/rt5640.c           | 1 +
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 2 files changed, 3 insertions(+)
Signature · 1 line
2.10.2
#1 lore raw

PATCH v2 1/2 ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5640.c +1 -0
index e29a6de..b857a71 100644
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
Signature · 1 line
2.10.2
#5 lore raw

PATCH v2 2/2 ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

In reply to Alexandrov Stansilav
---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/intel/atom/sst/sst_acpi.c +2 -0
index f4d92bb..896ced2 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
Signature · 1 line
2.10.2
Acked-by on the v2 series
#8 lore raw
In reply to Alexandrov Stansilav
Quoted 11 lines · Alexandrov Stansilav

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
Quoted 7 lines

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

v2: Splited patch to codec and sst parts

 sound/soc/codecs/rt5640.c           | 1 +
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 2 files changed, 3 insertions(+)

The commit message is a tad long but the patch is legit

#2 lore raw

Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

In reply to Alexandrov Stansilav

On Wed, Jan 04, 2017 at 03:22:12PM +0300, Alexandrov Stansilav wrote:

This looks okay, but title is same for both of the patches. It would be better to describe the change you are doing and not the outcome.

so a better title could be:

ASoC: rt5640: Add "10EC3276" ACPI ID

and in log say:

HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add that.

Quoted 20 lines
---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5640.c +1 -0
index e29a6de..b857a71 100644
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
Signature · 1 line
2.10.2
Signature · 1 line
~Vinod
#6 lore raw

Re: [PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

In reply to Alexandrov Stansilav
Quoted 1 line · Alexandrov Stansilav

Same comments here too, the title and log doesn't tell me the changes in the patch.

So a better title could be:

ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

And log may contain:

HP Pavilion x2 10-p000 sports a rt5640 codec, bit with ACPI ID 10EC5640, so add a new entry in machine table for this configuration.

Quoted 20 lines
---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/intel/atom/sst/sst_acpi.c +2 -0
index f4d92bb..896ced2 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
Signature · 1 line
2.10.2
Signature · 1 line
~Vinod
#3 lore raw

Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

In reply to Vinod Koul
Quoted 5 lines

Vinod Koul писал 2017-01-05 06:49:

This looks okay, but title is same for both of the patches. It would be better to describe the change you are doing and not the outcome.

Quoted 8 lines

so a better title could be:

ASoC: rt5640: Add "10EC3276" ACPI ID

and in log say:

HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add that.

Thanks for comments. And i'm sorry for this inconvenience -_- I will send new patchset with corrections.

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

maintainer
#7 lore raw

Applied "ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry" to the asoc tree

In reply to Alexandrov Stansilav

The patch

ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From e7974816a8fce6cd11dc4dfa9f1c1844a9b5d8df Mon Sep 17 00:00:00 2001

From: Alexandrov Stansilav <[email protected]>
Date: Thu, 26 Jan 2017 14:09:32 -0600
Subject: [PATCH] ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

Add machine entry for HP X2 Pavilion 10-p100.
This notebook contains rt5640 codec, but with ACPI ID "10EC3276".

---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/intel/atom/sst/sst_acpi.c +2 -0
index f4d92bbc5373..896ced2dd73c 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
Signature · 1 line
2.11.0
maintainer
#4 lore raw

Applied "ASoC: rt5640: Add "10EC3276" ACPI ID" to the asoc tree

In reply to Alexandrov Stansilav

The patch

ASoC: rt5640: Add "10EC3276" ACPI ID

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 03200140ee83b3655152bc0c144378732fec8af1 Mon Sep 17 00:00:00 2001

From: Alexandrov Stansilav <[email protected]>
Date: Thu, 26 Jan 2017 14:09:31 -0600
Subject: [PATCH] ASoC: rt5640: Add "10EC3276" ACPI ID

Add ACPI ID "10EC3276" for sound card found on notebook HP Pavilion X2 10-p000. ACPI DSDT Table on this device describes this card as ALC3276, but it is in fact rt5640.

---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5640.c +1 -0
index e29a6defefa0..b857a715ef64 100644
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
Signature · 1 line
2.11.0