Skip to contentSkip to conversation

add tools for terminal and devshell

PATCH In review Robert Yang 4 participants 7 messages Mar 13, 2017

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover add tools for terminal and devshell

The following changes since commit a47e64d985a610535449730806651f5bfd75d9ec:

libcomps: add a recipe (2017-03-11 16:08:50 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/tools
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/tools

Robert Yang (2):
terminal.bbclass: add tools for terminal
devshell.bbclass: add editors for devshell

 meta/classes/devshell.bbclass | 6 ++++++
 meta/classes/terminal.bbclass | 5 +++++
 2 files changed, 11 insertions(+)
Signature · 1 line
2.11.0.rc2.dirty
author
#1 lore raw

PATCH 1/2 terminal.bbclass: add tools for terminal

Otherwise the -cdevshell doesn't work.

Signed-off-by Robert Yang <[email protected]>
---
 meta/classes/terminal.bbclass | 5 +++++
 1 file changed, 5 insertions(+)
meta/classes/terminal.bbclass +5 -0
index 62409c0815..b68e5733c7 100644
@@ -9,6 +9,11 @@ OE_TERMINAL_EXPORTS[type] = 'list'
 XAUTHORITY ?= "${HOME}/.Xauthority"
 SHELL ?= "bash"
 
+# Tools needed by terminal
+HOSTTOOLS_NONFATAL += "tmux tmux xfce4-terminal konsole gnome-terminal \
+    terminology mate-terminal rxvt xterm tmux screen \
+"
+
 def oe_terminal_prioritized():
     import oe.terminal
     return " ".join(o.name for o in oe.terminal.prioritized())
Signature · 1 line
2.11.0.rc2.dirty
#2 lore raw

Re: [PATCH 1/2] terminal.bbclass: add tools for terminal

meta/classes/terminal.bbclass OE_TERMINAL_EXPORTS[type] = 'list' · line 15

Quoted 4 lines · Robert Yang
meta/classes/terminal.bbclass +4 -0
+# Tools needed by terminal
+HOSTTOOLS_NONFATAL += "tmux tmux xfce4-terminal konsole gnome-terminal \
+    terminology mate-terminal rxvt xterm tmux screen \
+"

Why are you adding tmxu 3 times?

Cheers,
Anders

Signature · 2 lines
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB
author
#3 lore raw

PATCH 2/2 devshell.bbclass: add editors for devshell

In reply to Robert Yang

* The vi, vim, emacs and nano can be used in devshell.

* The groups, lesspipe and dircolors are required by /etc/skel/.bashrc on Ubuntu 14.04, otherwise, there would be warnings when start devshell:
bash: groups: command not found
bash: lesspipe: command not found
bash: dircolors: command not found

Signed-off-by Robert Yang <[email protected]>
---
 meta/classes/devshell.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)
meta/classes/devshell.bbclass +6 -0
index 4de7ea6fce..055d21ba50 100644
@@ -2,6 +2,12 @@ inherit terminal
 
 DEVSHELL = "${SHELL}"
 
+# Tools used in devshell
+HOSTTOOLS_NONFATAL += "vi vim emacs nano"
+
+# Tools needed by bash
+HOSTTOOLS_NONFATAL += "groups lesspipe dircolors"
+
 python do_devshell () {
     if d.getVarFlag("do_devshell", "manualfakeroot"):
        d.prependVar("DEVSHELL", "pseudo ")
Signature · 1 line
2.11.0.rc2.dirty
#4 lore raw

Re: [PATCH 2/2] devshell.bbclass: add editors for devshell

Quoted 1 line · Robert Yang

* The vi, vim, emacs and nano can be used in devshell.

thanks
- armin

Quoted 28 lines

* The groups, lesspipe and dircolors are required by /etc/skel/.bashrc on Ubuntu 14.04, otherwise, there would be warnings when start devshell:
bash: groups: command not found
bash: lesspipe: command not found
bash: dircolors: command not found

Signed-off-by Robert Yang <[email protected]>
---
  meta/classes/devshell.bbclass | 6 ++++++
  1 file changed, 6 insertions(+)
meta/classes/devshell.bbclass +6 -0
index 4de7ea6fce..055d21ba50 100644
@@ -2,6 +2,12 @@ inherit terminal
 
  DEVSHELL = "${SHELL}"
 
+# Tools used in devshell
+HOSTTOOLS_NONFATAL += "vi vim emacs nano"
+
+# Tools needed by bash
+HOSTTOOLS_NONFATAL += "groups lesspipe dircolors"
+
  python do_devshell () {
      if d.getVarFlag("do_devshell", "manualfakeroot"):
         d.prependVar("DEVSHELL", "pseudo ")
#5 lore raw

Re: [PATCH 2/2] devshell.bbclass: add editors for devshell

In reply to Robert Yang
Quoted 24 lines · Robert Yang

* The vi, vim, emacs and nano can be used in devshell.

* The groups, lesspipe and dircolors are required by /etc/skel/.bashrc on
  Ubuntu 14.04, otherwise, there would be warnings when start devshell:
    bash: groups: command not found
    bash: lesspipe: command not found
    bash: dircolors: command not found

Signed-off-by Robert Yang <[email protected]>

---
 meta/classes/devshell.bbclass | 6 ++++++

 1 file changed, 6 insertions(+)
meta/classes/devshell.bbclass +0 -0
index 4de7ea6fce..055d21ba50 100644
@@ -2,6 +2,12 @@ inherit terminal


 DEVSHELL = "${SHELL}"

meta/classes/devshell.bbclass inherit terminal · line 6

Quoted 2 lines
meta/classes/devshell.bbclass +2 -0
+# Tools used in devshell
+HOSTTOOLS_NONFATAL += "vi vim emacs nano"

Thinking about this further, I think we need to restore PATH for the devshell. We can't really go down the road of trying to add in links for any tool the developer may want to use...

Cheers,

Richard

author
#6 lore raw

Re: [PATCH 2/2] devshell.bbclass: add editors for devshell

Quoted 23 lines · Richard Purdie
Quoted 22 lines · Robert Yang

* The vi, vim, emacs and nano can be used in devshell.

* The groups, lesspipe and dircolors are required by /etc/skel/.bashrc on
Ubuntu 14.04, otherwise, there would be warnings when start
devshell:
bash: groups: command not found
bash: lesspipe: command not found
bash: dircolors: command not found

Signed-off-by Robert Yang <[email protected]>
---
 meta/classes/devshell.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)
meta/classes/devshell.bbclass +0 -0
index 4de7ea6fce..055d21ba50 100644
@@ -2,6 +2,12 @@ inherit terminal
Quoted 8 lines

meta/classes/devshell.bbclass inherit terminal · line 6

Quoted 4 lines
meta/classes/devshell.bbclass +2 -0
 DEVSHELL = "${SHELL}"
 
+# Tools used in devshell
+HOSTTOOLS_NONFATAL += "vi vim emacs nano"

Thinking about this further, I think we need to restore PATH for the devshell. We can't really go down the road of trying to add in links for any tool the developer may want to use...

Yes, that would be great.

// Robert

Quoted 5 lines

Cheers,

Richard