staging: rtl8723bs: Follow linux-kernel coding style

Use one space around most binary operators

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +6 -7

index 7f22ca9..18f0ac2 100644
@@ -222,7 +222,7 @@
 /*  BIT4 - RF,					0: non-support, 1: support */
 /*  BIT5 - RF_TXPWR_TRACK,	0: non-support, 1: support */
 /*  BIT6 - RF_TXPWR_LMT,		0: non-support, 1: support */
-static int rtw_load_phy_file = (BIT2|BIT6);
+static int rtw_load_phy_file = (BIT2 | BIT6);
 module_param(rtw_load_phy_file, int, 0644);
 MODULE_PARM_DESC(rtw_load_phy_file,"PHY File Bit Map");
 static int rtw_decrypt_phy_file = 0;

@@ -440,12 +440,12 @@ u16 rtw_recv_select_queue(struct sk_buff *skb)
 	u32 priority;
 	u8 *pdata = skb->data;
 
-	memcpy(&eth_type, pdata+(ETH_ALEN<<1), 2);
+	memcpy(&eth_type, pdata + (ETH_ALEN << 1), 2);
 
 	switch (be16_to_cpu(eth_type)) {
 		case ETH_P_IP:
 
-			piphdr = (struct iphdr *)(pdata+ETH_HLEN);
+			piphdr = (struct iphdr *)(pdata + ETH_HLEN);
 
 			dscp = piphdr->tos & 0xfc;
 

@@ -561,7 +561,7 @@ struct net_device *rtw_init_netdev(struct adapter *old_padapter)
 	pnetdev->netdev_ops = &rtw_netdev_ops;
 
 	/* pnetdev->tx_timeout = NULL; */
-	pnetdev->watchdog_timeo = HZ*3; /* 3 second timeout */
+	pnetdev->watchdog_timeo = HZ * 3; /* 3 second timeout */
 	pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
 
 	/* step 2. */

@@ -748,7 +748,7 @@ u8 rtw_reset_drv_sw(struct adapter *padapter)
 	pmlmepriv->LinkDetectInfo.TrafficTransitionCount = 0;
 	pmlmepriv->LinkDetectInfo.LowPowerTransitionCount = 0;
 
-	_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY |_FW_UNDER_LINKING);
+	_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING);
 
 	pwrctrlpriv->pwr_state_check_cnts = 0;
 

@@ -935,7 +935,7 @@ static int _rtw_drv_register_netdev(struct adapter *padapter, char *name)
 		goto error_register_netdev;
 	}
 
-	DBG_871X("%s, MAC Address (if%d) = " MAC_FMT "\n", __func__, (padapter->iface_id+1), MAC_ARG(pnetdev->dev_addr));
+	DBG_871X("%s, MAC Address (if%d) = " MAC_FMT "\n", __func__, (padapter->iface_id + 1), MAC_ARG(pnetdev->dev_addr));
 
 	return ret;
 
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/28be543667f44c31e38872ec4a96bad8c167e3d8.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Use one space around (on each side of) '=' operator

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +10 -11

index 0215899..7f22ca9 100644
@@ -121,7 +121,7 @@
 
 static int rtw_enusbss = 0;/* 0:disable, 1:enable */
 
-static int rtw_hwpdn_mode =2;/* 0:disable, 1:enable, 2: by EFUSE config */
+static int rtw_hwpdn_mode = 2;/* 0:disable, 1:enable, 2: by EFUSE config */
 
 #ifdef CONFIG_HW_PWRP_DETECTION
 static int rtw_hwpwrp_detect = 1;

@@ -183,7 +183,7 @@
 
 module_param(rtw_hw_wps_pbc, int, 0644);
 
-static uint rtw_max_roaming_times =2;
+static uint rtw_max_roaming_times = 2;
 module_param(rtw_max_roaming_times, uint, 0644);
 MODULE_PARM_DESC(rtw_max_roaming_times,"The max roaming times to try");
 

@@ -255,8 +255,8 @@ static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
 
 	registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense ;
 	registry_par->vcs_type = (u8)rtw_vcs_type;
-	registry_par->rts_thresh =(u16)rtw_rts_thresh;
-	registry_par->frag_thresh =(u16)rtw_frag_thresh;
+	registry_par->rts_thresh = (u16)rtw_rts_thresh;
+	registry_par->frag_thresh = (u16)rtw_frag_thresh;
 	registry_par->preamble = (u8)rtw_preamble;
 	registry_par->scan_mode = (u8)rtw_scan_mode;
 	registry_par->adhoc_tx_pwr = (u8)rtw_adhoc_tx_pwr;

@@ -652,8 +652,8 @@ static u8 rtw_init_default_value(struct adapter *padapter)
 #ifdef CONFIG_GTK_OL
 	psecuritypriv->binstallKCK_KEK = _FAIL;
 #endif /* CONFIG_GTK_OL */
-	psecuritypriv->sw_encrypt =pregistrypriv->software_encrypt;
-	psecuritypriv->sw_decrypt =pregistrypriv->software_decrypt;
+	psecuritypriv->sw_encrypt = pregistrypriv->software_encrypt;
+	psecuritypriv->sw_decrypt = pregistrypriv->software_decrypt;
 
 	psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_Open; /* open system */
 	psecuritypriv->dot11PrivacyAlgrthm = _NO_PRIVACY_;

@@ -777,7 +777,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
 		goto exit;
 	}
 
-	padapter->cmdpriv.padapter =padapter;
+	padapter->cmdpriv.padapter = padapter;
 
 	if ((rtw_init_evt_priv(&padapter->evtpriv)) == _FAIL) {
 		RT_TRACE(_module_os_intfs_c_, _drv_err_, ("\n Can't init evt_priv\n"));

@@ -986,7 +986,7 @@ int _netdev_open(struct net_device *pnetdev)
 
 		DBG_871X("MAC Address = "MAC_FMT"\n", MAC_ARG(pnetdev->dev_addr));
 
-		status =rtw_start_drv_threads(padapter);
+		status = rtw_start_drv_threads(padapter);
 		if (status == _FAIL) {
 			DBG_871X("Initialize driver software resource Failed!\n");
 			goto netdev_open_error;

@@ -1641,7 +1641,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
 		}
 
 		/* Disable WOW, set H2C command */
-		poidparam.subcode =WOWLAN_DISABLE;
+		poidparam.subcode = WOWLAN_DISABLE;
 		padapter->HalFunc.SetHwRegHandler(padapter, HW_VAR_WOWLAN, (u8 *)&poidparam);
 
 		psta = rtw_get_stainfo(&padapter->stapriv, get_bssid(&padapter->mlmepriv));

@@ -1705,7 +1705,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
 		DBG_871X_LEVEL(_drv_always_, "do not reset timer\n");
 	}
 
-	pwrpriv->wowlan_mode =false;
+	pwrpriv->wowlan_mode = false;
 
 	/* clean driver side wake up reason. */
 	pwrpriv->wowlan_wake_reason = 0;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/7b2a57c6f3eb01142a73e92124fdf06a7504e68e.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Use spaces around most binary operators

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +6 -7

index 18f0ac2..5ceccd7 100644
@@ -1140,7 +1140,7 @@ static int pm_netdev_open(struct net_device *pnetdev, u8 bnormal)
 		}
 	}
 	else
-		status =  (_SUCCESS == ips_netdrv_open(padapter))?(0):(-1);
+		status =  (_SUCCESS == ips_netdrv_open(padapter)) ? (0) : (-1);
 
 	return status;
 }

@@ -1262,7 +1262,7 @@ void rtw_dev_unload(struct adapter *padapter)
 			rtw_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req);
 #ifdef CONFIG_WOWLAN
 			if (pwrctl->bSupportRemoteWakeup == true &&
-				pwrctl->wowlan_mode ==true) {
+				pwrctl->wowlan_mode == true) {
 				DBG_871X_LEVEL(_drv_always_, "%s bSupportRemoteWakeup ==true  do not run rtw_hal_deinit()\n", __func__);
 			}
 			else

@@ -1524,7 +1524,7 @@ int rtw_suspend_common(struct adapter *padapter)
 	while (pwrpriv->bips_processing == true)
 		msleep(1);
 
-	if ((!padapter->bup) || (padapter->bDriverStopped)||(padapter->bSurpriseRemoved))
+	if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved))
 	{
 		DBG_871X("%s bup =%d bDriverStopped =%d bSurpriseRemoved = %d\n", __func__
 			, padapter->bup, padapter->bDriverStopped, padapter->bSurpriseRemoved);

@@ -1671,7 +1671,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
 		DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);
 	}
 
-	if (padapter->pid[1]!= 0) {
+	if (padapter->pid[1] != 0) {
 		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
 		rtw_signal_process(padapter->pid[1], SIGUSR2);
 	}

@@ -1774,7 +1774,7 @@ int rtw_resume_process_ap_wow(struct adapter *padapter)
 			rtw_netif_wake_queue(pnetdev);
 	}
 
-	if (padapter->pid[1]!= 0) {
+	if (padapter->pid[1] != 0) {
 		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
 		rtw_signal_process(padapter->pid[1], SIGUSR2);
 	}

@@ -1842,7 +1842,7 @@ static int rtw_resume_process_normal(struct adapter *padapter)
 	netif_device_attach(pnetdev);
 	netif_carrier_on(pnetdev);
 
-	if (padapter->pid[1]!= 0) {
+	if (padapter->pid[1] != 0) {
 		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
 		rtw_signal_process(padapter->pid[1], SIGUSR2);
 	}
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/be22d7c63780098571fec9d490b1a83039ddbb75.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

No spaces at the start of a line

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -2

index 5ceccd7..97ff3ab 100644
@@ -597,7 +597,7 @@ u32 rtw_start_drv_threads(struct adapter *padapter)
 		_status = _FAIL;
 
 	padapter->cmdThread = kthread_run(rtw_cmd_thread, padapter, "RTW_CMD_THREAD");
-        if (IS_ERR(padapter->cmdThread))
+	if (IS_ERR(padapter->cmdThread))
 		_status = _FAIL;
 	else
 		down(&padapter->cmdpriv.terminate_cmdthread_sema); /* wait for cmd_thread to run */
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/94120b866c10e83ec66c8b96522ae7d265d254cc.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Use spaces between concatenated strings

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 50 ++++++++++++++---------------
 1 file changed, 25 insertions(+), 25 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +25 -26

index 97ff3ab..b320df8 100644
@@ -467,7 +467,7 @@ static int rtw_ndev_notifier_call(struct notifier_block * nb, unsigned long stat
 	if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl)
 		return NOTIFY_DONE;
 
-	DBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT" state:%lu\n", FUNC_NDEV_ARG(dev), state);
+	DBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev), state);
 
 	switch (state) {
 	case NETDEV_CHANGENAME:

@@ -497,7 +497,7 @@ static int rtw_ndev_init(struct net_device *dev)
 {
 	struct adapter *adapter = rtw_netdev_priv(dev);
 
-	DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(adapter));
+	DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(adapter));
 	strncpy(adapter->old_ifname, dev->name, IFNAMSIZ);
 	rtw_adapter_proc_init(dev);
 

@@ -508,7 +508,7 @@ static void rtw_ndev_uninit(struct net_device *dev)
 {
 	struct adapter *adapter = rtw_netdev_priv(dev);
 
-	DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(adapter));
+	DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n", FUNC_ADPT_ARG(adapter));
 	rtw_adapter_proc_deinit(dev);
 }
 

@@ -984,7 +984,7 @@ int _netdev_open(struct net_device *pnetdev)
 			goto netdev_open_error;
 		}
 
-		DBG_871X("MAC Address = "MAC_FMT"\n", MAC_ARG(pnetdev->dev_addr));
+		DBG_871X("MAC Address = " MAC_FMT "\n", MAC_ARG(pnetdev->dev_addr));
 
 		status = rtw_start_drv_threads(padapter);
 		if (status == _FAIL) {

@@ -1203,7 +1203,7 @@ static int netdev_close(struct net_device *pnetdev)
 
 void rtw_ndev_destructor(struct net_device *ndev)
 {
-	DBG_871X(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(ndev));
+	DBG_871X(FUNC_NDEV_FMT "\n", FUNC_NDEV_ARG(ndev));
 
 	if (ndev->ieee80211_ptr)
 		kfree((u8 *)ndev->ieee80211_ptr);

@@ -1292,7 +1292,7 @@ static int rtw_suspend_free_assoc_resource(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 
 	if (rtw_chk_roam_flags(padapter, RTW_ROAM_ON_RESUME)) {
 		if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)

@@ -1333,7 +1333,7 @@ static int rtw_suspend_free_assoc_resource(struct adapter *padapter)
 		rtw_indicate_disconnect(padapter);
 	}
 
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return _SUCCESS;
 }
 

@@ -1347,7 +1347,7 @@ int rtw_suspend_wow(struct adapter *padapter)
 	struct wowlan_ioctl_param poidparam;
 	int ret = _SUCCESS;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 
 
 	DBG_871X("wowlan_mode: %d\n", pwrpriv->wowlan_mode);

@@ -1401,7 +1401,7 @@ int rtw_suspend_wow(struct adapter *padapter)
 		}
 
 		if (rtw_get_ch_setting_union(padapter, &ch, &bw, &offset) != 0) {
-			DBG_871X(FUNC_ADPT_FMT" back to linked/linking union - ch:%u, bw:%u, offset:%u\n",
+			DBG_871X(FUNC_ADPT_FMT " back to linked/linking union - ch:%u, bw:%u, offset:%u\n",
 				FUNC_ADPT_ARG(padapter), ch, bw, offset);
 			set_channel_bwmode(padapter, ch, offset, bw);
 		}

@@ -1416,7 +1416,7 @@ int rtw_suspend_wow(struct adapter *padapter)
 	{
 		DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);
 	}
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return ret;
 }
 #endif /* ifdef CONFIG_WOWLAN */

@@ -1430,7 +1430,7 @@ int rtw_suspend_ap_wow(struct adapter *padapter)
 	struct wowlan_ioctl_param poidparam;
 	int ret = _SUCCESS;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 
 	pwrpriv->wowlan_ap_mode = true;
 

@@ -1462,14 +1462,14 @@ int rtw_suspend_ap_wow(struct adapter *padapter)
 	DBG_871X_LEVEL(_drv_always_, "%s: wowmode suspending\n", __func__);
 
 	if (rtw_get_ch_setting_union(padapter, &ch, &bw, &offset) != 0) {
-		DBG_871X(FUNC_ADPT_FMT" back to linked/linking union - ch:%u, bw:%u, offset:%u\n",
+		DBG_871X(FUNC_ADPT_FMT " back to linked/linking union - ch:%u, bw:%u, offset:%u\n",
 			 FUNC_ADPT_ARG(padapter), ch, bw, offset);
 		set_channel_bwmode(padapter, ch, offset, bw);
 	}
 
 	rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, 0, "AP-WOWLAN");
 
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return ret;
 }
 #endif /* ifdef CONFIG_AP_WOWLAN */

@@ -1480,7 +1480,7 @@ static int rtw_suspend_normal(struct adapter *padapter)
 	struct net_device *pnetdev = padapter->pnetdev;
 	int ret = _SUCCESS;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 	if (pnetdev) {
 		netif_carrier_off(pnetdev);
 		rtw_netif_stop_queue(pnetdev);

@@ -1501,7 +1501,7 @@ static int rtw_suspend_normal(struct adapter *padapter)
 	if (padapter->intf_deinit)
 		padapter->intf_deinit(adapter_to_dvobj(padapter));
 
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return ret;
 }
 

@@ -1599,7 +1599,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
 	struct sta_info *psta = NULL;
 	int ret = _SUCCESS;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 
 	if (padapter) {
 		pnetdev = padapter->pnetdev;

@@ -1710,7 +1710,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
 	/* clean driver side wake up reason. */
 	pwrpriv->wowlan_wake_reason = 0;
 exit:
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return ret;
 }
 #endif /* ifdef CONFIG_WOWLAN */

@@ -1725,7 +1725,7 @@ int rtw_resume_process_ap_wow(struct adapter *padapter)
 	struct wowlan_ioctl_param poidparam;
 	int ret = _SUCCESS;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 
 	if (padapter) {
 		pnetdev = padapter->pnetdev;

@@ -1785,7 +1785,7 @@ int rtw_resume_process_ap_wow(struct adapter *padapter)
 	/* clean driver side wake up reason. */
 	pwrpriv->wowlan_wake_reason = 0;
 exit:
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 	return ret;
 }
 #endif /* ifdef CONFIG_APWOWLAN */

@@ -1811,7 +1811,7 @@ static int rtw_resume_process_normal(struct adapter *padapter)
 	psdpriv = padapter->dvobj;
 	pdbgpriv = &psdpriv->drv_dbg;
 
-	DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", FUNC_ADPT_ARG(padapter));
 	/*  interface init */
 	/* if (sdio_init(adapter_to_dvobj(padapter)) != _SUCCESS) */
 	if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapter)) != _SUCCESS))

@@ -1849,21 +1849,21 @@ static int rtw_resume_process_normal(struct adapter *padapter)
 
 
 	if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
-		DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
+		DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
 
 		if (rtw_chk_roam_flags(padapter, RTW_ROAM_ON_RESUME))
 			rtw_roaming(padapter, NULL);
 
 	} else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
-		DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
+		DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
 		rtw_ap_restore_network(padapter);
 	} else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
-		DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
+		DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
 	} else {
-		DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - ???\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
+		DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - ???\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
 	}
 
-	DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", FUNC_ADPT_ARG(padapter));
+	DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", FUNC_ADPT_ARG(padapter));
 
 exit:
 	return ret;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/86078625c574018711c48bf66ebb5f62d540ac79.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Space required after ','

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +6 -7

index b320df8..ecb01cf 100644
@@ -45,7 +45,7 @@
 static int rtw_power_mgnt = 1;
 static int rtw_ips_mode = IPS_NORMAL;
 module_param(rtw_ips_mode, int, 0644);
-MODULE_PARM_DESC(rtw_ips_mode,"The default IPS mode");
+MODULE_PARM_DESC(rtw_ips_mode, "The default IPS mode");
 
 static int rtw_smart_ps = 2;
 

@@ -185,7 +185,7 @@
 
 static uint rtw_max_roaming_times = 2;
 module_param(rtw_max_roaming_times, uint, 0644);
-MODULE_PARM_DESC(rtw_max_roaming_times,"The max roaming times to try");
+MODULE_PARM_DESC(rtw_max_roaming_times, "The max roaming times to try");
 
 module_param(rtw_mc2u_disable, int, 0644);
 

@@ -206,10 +206,10 @@
 static int rtw_tx_pwr_by_rate = 0;
 
 module_param(rtw_tx_pwr_lmt_enable, int, 0644);
-MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable,"0:Disable, 1:Enable, 2: Depend on efuse");
+MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable, "0:Disable, 1:Enable, 2: Depend on efuse");
 
 module_param(rtw_tx_pwr_by_rate, int, 0644);
-MODULE_PARM_DESC(rtw_tx_pwr_by_rate,"0:Disable, 1:Enable, 2: Depend on efuse");
+MODULE_PARM_DESC(rtw_tx_pwr_by_rate, "0:Disable, 1:Enable, 2: Depend on efuse");
 
 char *rtw_phy_file_path = "";
 module_param(rtw_phy_file_path, charp, 0644);

@@ -224,10 +224,10 @@
 /*  BIT6 - RF_TXPWR_LMT,		0: non-support, 1: support */
 static int rtw_load_phy_file = (BIT2 | BIT6);
 module_param(rtw_load_phy_file, int, 0644);
-MODULE_PARM_DESC(rtw_load_phy_file,"PHY File Bit Map");
+MODULE_PARM_DESC(rtw_load_phy_file, "PHY File Bit Map");
 static int rtw_decrypt_phy_file = 0;
 module_param(rtw_decrypt_phy_file, int, 0644);
-MODULE_PARM_DESC(rtw_decrypt_phy_file,"Enable Decrypt PHY File");
+MODULE_PARM_DESC(rtw_decrypt_phy_file, "Enable Decrypt PHY File");
 
 int _netdev_open(struct net_device *pnetdev);
 int netdev_open (struct net_device *pnetdev);
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/f38c5d1ba5518dce605cd9eb5d7adbdee3f7544d.1505052882.git.harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Quoted 1 line · Harsha Sharma

Use spaces between concatenated strings

Perhaps all the entry/exit ones could be dropped, and the ohters could be rewritten to use more standard kernel debugging functionalities.

julia

Quoted 5 lines

Signed-off-by Harsha Sharma <[email protected] <javascript:>>

---

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 50 

++++++++++++++---------------

Review

Quoted 3 lines

 1 file changed, 25 insertions(+), 25 deletions(-) 

(quoted diff) +0 -0

b/drivers/staging/rtl8723bs/os_dep/os_intfs.c

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_ndev_notifier_call(struct

Quoted 4 lines

index 97ff3ab..b320df8 100644

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

@@ -467,7 +467,7 @@ static int rtw_ndev_notifier_call(struct 

notifier_block * nb, unsigned long stat

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_ndev_notifier_call(struct notifier_block * nb, unsigned long stat

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl) 
                 return NOTIFY_DONE; 
 
-        DBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT" state:%lu\n", 

FUNC_NDEV_ARG(dev), state);

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_ndev_notifier_call(struct · line 470

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT " state:%lu\n", 

FUNC_NDEV_ARG(dev), state);

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_ndev_init(struct net_device *dev) · line 500

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         switch (state) { 
         case NETDEV_CHANGENAME: 

@@ -497,7 +497,7 @@ static int rtw_ndev_init(struct net_device *dev) 
 { 
         struct adapter *adapter = rtw_netdev_priv(dev); 
 
-        DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n", 

FUNC_ADPT_ARG(adapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_ndev_init(struct net_device *dev) · line 500

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n", 

FUNC_ADPT_ARG(adapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static void rtw_ndev_uninit(struct net_device *dev) · line 511

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         strncpy(adapter->old_ifname, dev->name, IFNAMSIZ); 
         rtw_adapter_proc_init(dev); 
 

@@ -508,7 +508,7 @@ static void rtw_ndev_uninit(struct net_device *dev) 
 { 
         struct adapter *adapter = rtw_netdev_priv(dev); 
 
-        DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n", 

FUNC_ADPT_ARG(adapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static void rtw_ndev_uninit(struct net_device *dev) · line 511

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n", 

FUNC_ADPT_ARG(adapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int _netdev_open(struct net_device *pnetdev) · line 987

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         rtw_adapter_proc_deinit(dev); 
 } 
 

@@ -984,7 +984,7 @@ int _netdev_open(struct net_device *pnetdev) 
                         goto netdev_open_error; 
                 } 
 
-                DBG_871X("MAC Address = "MAC_FMT"\n", 

MAC_ARG(pnetdev->dev_addr));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int _netdev_open(struct net_device *pnetdev) · line 987

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X("MAC Address = " MAC_FMT "\n", 

MAC_ARG(pnetdev->dev_addr));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int netdev_close(struct net_device

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

                 status = rtw_start_drv_threads(padapter); 
                 if (status == _FAIL) { 

@@ -1203,7 +1203,7 @@ static int netdev_close(struct net_device 

*pnetdev)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct

Quoted 9 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -1

 void rtw_ndev_destructor(struct net_device *ndev) 
 { 
-        DBG_871X(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(ndev)); 
+        DBG_871X(FUNC_NDEV_FMT "\n", FUNC_NDEV_ARG(ndev)); 
 
         if (ndev->ieee80211_ptr) 
                 kfree((u8 *)ndev->ieee80211_ptr); 

@@ -1292,7 +1292,7 @@ static int rtw_suspend_free_assoc_resource(struct 

adapter *padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

 { 
         struct mlme_priv *pmlmepriv = &padapter->mlmepriv; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct · line 1295

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         if (rtw_chk_roam_flags(padapter, RTW_ROAM_ON_RESUME)) { 
                 if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) 

@@ -1333,7 +1333,7 @@ static int rtw_suspend_free_assoc_resource(struct 

adapter *padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

                 rtw_indicate_disconnect(padapter); 
         } 
 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_free_assoc_resource(struct · line 1336

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1350

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         return _SUCCESS; 
 } 
 

@@ -1347,7 +1347,7 @@ int rtw_suspend_wow(struct adapter *padapter) 
         struct wowlan_ioctl_param poidparam; 
         int ret = _SUCCESS; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1350

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1403

Quoted 7 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         DBG_871X("wowlan_mode: %d\n", pwrpriv->wowlan_mode); 

@@ -1401,7 +1401,7 @@ int rtw_suspend_wow(struct adapter *padapter) 
                 } 
 
                 if (rtw_get_ch_setting_union(padapter, &ch, &bw, 

&offset) != 0) {

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1404

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

-                        DBG_871X(FUNC_ADPT_FMT" back to linked/linking 

union - ch:%u, bw:%u, offset:%u\n",

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1404

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                        DBG_871X(FUNC_ADPT_FMT " back to linked/linking 

union - ch:%u, bw:%u, offset:%u\n",

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1405

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

                                 FUNC_ADPT_ARG(padapter), ch, bw, 

offset);

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1417

Quoted 5 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

                         set_channel_bwmode(padapter, ch, offset, bw); 
                 } 

@@ -1416,7 +1416,7 @@ int rtw_suspend_wow(struct adapter *padapter) 
         { 
                 DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### 

wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1419

Quoted 2 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         } 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter) · line 1419

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1433

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         return ret; 
 } 
 #endif /* ifdef CONFIG_WOWLAN */ 

@@ -1430,7 +1430,7 @@ int rtw_suspend_ap_wow(struct adapter *padapter) 
         struct wowlan_ioctl_param poidparam; 
         int ret = _SUCCESS; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1433

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1462

Quoted 5 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         pwrpriv->wowlan_ap_mode = true; 
 

@@ -1462,14 +1462,14 @@ int rtw_suspend_ap_wow(struct adapter *padapter) 
         DBG_871X_LEVEL(_drv_always_, "%s: wowmode suspending\n", 

__func__);

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1463

Quoted 2 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         if (rtw_get_ch_setting_union(padapter, &ch, &bw, &offset) != 0) 

{

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1464

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

-                DBG_871X(FUNC_ADPT_FMT" back to linked/linking union - 

ch:%u, bw:%u, offset:%u\n",

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1464

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X(FUNC_ADPT_FMT " back to linked/linking union - 

ch:%u, bw:%u, offset:%u\n",

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter)

Quoted 7 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

                          FUNC_ADPT_ARG(padapter), ch, bw, offset); 
                 set_channel_bwmode(padapter, ch, offset, bw); 
         } 
 
         rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, 0, "AP-WOWLAN"); 
 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_ap_wow(struct adapter *padapter) · line 1471

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         return ret; 
 } 
 #endif /* ifdef CONFIG_AP_WOWLAN */ 

@@ -1480,7 +1480,7 @@ static int rtw_suspend_normal(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         struct net_device *pnetdev = padapter->pnetdev; 
         int ret = _SUCCESS; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter · line 1483

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         if (pnetdev) { 
                 netif_carrier_off(pnetdev); 
                 rtw_netif_stop_queue(pnetdev); 

@@ -1501,7 +1501,7 @@ static int rtw_suspend_normal(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         if (padapter->intf_deinit) 
                 padapter->intf_deinit(adapter_to_dvobj(padapter)); 
 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_suspend_normal(struct adapter · line 1504

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         return ret; 
 } 
 

@@ -1599,7 +1599,7 @@ int rtw_resume_process_wow(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         struct sta_info *psta = NULL; 
         int ret = _SUCCESS; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter · line 1602

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         if (padapter) { 
                 pnetdev = padapter->pnetdev; 

@@ -1710,7 +1710,7 @@ int rtw_resume_process_wow(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         /* clean driver side wake up reason. */ 
         pwrpriv->wowlan_wake_reason = 0; 
 exit: 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter · line 1713

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_ap_wow(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         return ret; 
 } 
 #endif /* ifdef CONFIG_WOWLAN */ 

@@ -1725,7 +1725,7 @@ int rtw_resume_process_ap_wow(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_suspend_wow(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         struct wowlan_ioctl_param poidparam; 
         int ret = _SUCCESS; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_ap_wow(struct adapter · line 1728

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_ap_wow(struct adapter

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         if (padapter) { 
                 pnetdev = padapter->pnetdev; 

@@ -1785,7 +1785,7 @@ int rtw_resume_process_ap_wow(struct adapter 

*padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_wow(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         /* clean driver side wake up reason. */ 
         pwrpriv->wowlan_wake_reason = 0; 
 exit: 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c int rtw_resume_process_ap_wow(struct adapter · line 1788

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         return ret; 
 } 
 #endif /* ifdef CONFIG_APWOWLAN */ 

@@ -1811,7 +1811,7 @@ static int rtw_resume_process_normal(struct 

adapter *padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct adapter *padapter)

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         psdpriv = padapter->dvobj; 
         pdbgpriv = &psdpriv->drv_dbg; 
 
-        DBG_871X("==> "FUNC_ADPT_FMT" entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1814

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("==> " FUNC_ADPT_FMT " entry....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct adapter *padapter)

Quoted 3 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

         /*  interface init */ 
         /* if (sdio_init(adapter_to_dvobj(padapter)) != _SUCCESS) */ 
         if ((padapter->intf_init) && 

(padapter->intf_init(adapter_to_dvobj(padapter)) != _SUCCESS))

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -0

@@ -1849,21 +1849,21 @@ static int rtw_resume_process_normal(struct 

adapter *padapter)

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1850

Quoted 4 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { 
-                DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - 

WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1850

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - 

WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct adapter *padapter)

Quoted 6 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

                 if (rtw_chk_roam_flags(padapter, RTW_ROAM_ON_RESUME)) 
                         rtw_roaming(padapter, NULL); 
 
         } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { 
-                DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - 

WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1855

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - 

WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct adapter *padapter)

Quoted 3 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

                 rtw_ap_restore_network(padapter); 
         } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { 
-                DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - 

WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1858

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - 

WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1860

Quoted 2 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         } else { 
-                DBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x - ???\n", 

FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1860

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+                DBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x - ???\n", 

FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1863

Quoted 3 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

         } 
 
-        DBG_871X("<== "FUNC_ADPT_FMT" exit....\n", 

FUNC_ADPT_ARG(padapter));

drivers/staging/rtl8723bs/os_dep/os_intfs.c static int rtw_resume_process_normal(struct · line 1863

Quoted 1 line

drivers/staging/rtl8723bs/os_dep/os_intfs.c +1 -0

+        DBG_871X("<== " FUNC_ADPT_FMT " exit....\n", 

FUNC_ADPT_ARG(padapter));

Quoted 8 lines

drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -1

 exit: 
         return ret; 
-- 

1.9.1

Signature · 1 line

You received this message because you are subscribed to the Google 

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/86078625c574018711c48bf66ebb5f62d540ac79.1505052882.git.harshasharmaiitr%40gmail.com.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

On Monday, September 11, 2017 at 4:40:30 PM UTC+5:30, Julia Lawall wrote:

On Sun, 10 Sep 2017, Harsha Sharma wrote:

> Use spaces between concatenated strings

Perhaps all the entry/exit ones could be dropped, and the ohters could be
rewritten to use more standard kernel debugging functionalities.

julia

Hi,
Sorry but I didn't get you.
Thanks a lot for your time.

Regards,
Harsha Sharmaￜ

      >
      > Signed-off-by: Harsha Sharma <[email protected]>
      > ---
      > ï¿œdrivers/staging/rtl8723bs/os_dep/os_intfs.c | 50
      ++++++++++++++---------------
      > ￜ1 file changed, 25 insertions(+), 25 deletions(-)
      >
      > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
      b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
      > index 97ff3ab..b320df8 100644
      > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
      > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
      > @@ -467,7 +467,7 @@ static int rtw_ndev_notifier_call(struct
      notifier_block * nb, unsigned long stat
      > ￜￜￜￜￜￜￜￜￜif (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl)
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜreturn NOTIFY_DONE;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT"
      state:%lu\n", FUNC_NDEV_ARG(dev), state);
      > +ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_info_, FUNC_NDEV_FMT "
      state:%lu\n", FUNC_NDEV_ARG(dev), state);
      >
      > ￜￜￜￜￜￜￜￜￜswitch (state) {
      > ￜￜￜￜￜￜￜￜￜcase NETDEV_CHANGENAME:
      > @@ -497,7 +497,7 @@ static int rtw_ndev_init(struct net_device
      *dev)
      > ￜ{
      > ￜￜￜￜￜￜￜￜￜstruct adapter *adapter = rtw_netdev_priv(dev);
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n",
      FUNC_ADPT_ARG(adapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n",
      FUNC_ADPT_ARG(adapter));
      > ￜￜￜￜￜￜￜￜￜstrncpy(adapter->old_ifname, dev->name, IFNAMSIZ);
      > ￜￜￜￜￜￜￜￜￜrtw_adapter_proc_init(dev);
      >
      > @@ -508,7 +508,7 @@ static void rtw_ndev_uninit(struct
      net_device *dev)
      > ￜ{
      > ￜￜￜￜￜￜￜￜￜstruct adapter *adapter = rtw_netdev_priv(dev);
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT"\n",
      FUNC_ADPT_ARG(adapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT "\n",
      FUNC_ADPT_ARG(adapter));
      > ￜￜￜￜￜￜￜￜￜrtw_adapter_proc_deinit(dev);
      > ￜ}
      >
      > @@ -984,7 +984,7 @@ int _netdev_open(struct net_device
      *pnetdev)
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜgoto netdev_open_error;
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜ}
      >
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X("MAC Address = "MAC_FMT"\n",
      MAC_ARG(pnetdev->dev_addr));
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X("MAC Address = " MAC_FMT "\n",
      MAC_ARG(pnetdev->dev_addr));
      >
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜstatus = rtw_start_drv_threads(padapter);
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜif (status == _FAIL) {
      > @@ -1203,7 +1203,7 @@ static int netdev_close(struct
      net_device *pnetdev)
      >
      > ï¿œvoid rtw_ndev_destructor(struct net_device *ndev)
      > ￜ{
      > -ￜￜￜￜￜￜￜￜDBG_871X(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(ndev));
      > +ￜￜￜￜￜￜￜￜDBG_871X(FUNC_NDEV_FMT "\n", FUNC_NDEV_ARG(ndev));
      >
      > ￜￜￜￜￜￜￜￜￜif (ndev->ieee80211_ptr)
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜkfree((u8 *)ndev->ieee80211_ptr);
      > @@ -1292,7 +1292,7 @@ static int
      rtw_suspend_free_assoc_resource(struct adapter *padapter)
      > ￜ{
      > ￜￜￜￜￜￜￜￜￜstruct mlme_priv *pmlmepriv = &padapter->mlmepriv;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      >
      > ￜￜￜￜￜￜￜￜￜif (rtw_chk_roam_flags(padapter, RTW_ROAM_ON_RESUME))
      {
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜif (check_fwstate(pmlmepriv,
      WIFI_STATION_STATE)
      > @@ -1333,7 +1333,7 @@ static int
      rtw_suspend_free_assoc_resource(struct adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜrtw_indicate_disconnect(padapter);
      > ￜￜￜￜￜￜￜￜￜ}
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn _SUCCESS;
      > ￜ}
      >
      > @@ -1347,7 +1347,7 @@ int rtw_suspend_wow(struct adapter
      *padapter)
      > ￜￜￜￜￜￜￜￜￜstruct wowlan_ioctl_param poidparam;
      > ￜￜￜￜￜￜￜￜￜint ret = _SUCCESS;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      >
      >
      > ￜￜￜￜￜￜￜￜￜDBG_871X("wowlan_mode: %d\n", pwrpriv->wowlan_mode);
      > @@ -1401,7 +1401,7 @@ int rtw_suspend_wow(struct adapter
      *padapter)
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜ}
      >
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜif (rtw_get_ch_setting_union(padapter, &ch,
      &bw, &offset) != 0) {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" back to
      linked/linking union - ch:%u, bw:%u, offset:%u\n",
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " back to
      linked/linking union - ch:%u, bw:%u, offset:%u\n",
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜFUNC_ADPT_ARG(padapter), ch,
      bw, offset);
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜset_channel_bwmode(padapter, ch,
      offset, bw);
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜ}
      > @@ -1416,7 +1416,7 @@ int rtw_suspend_wow(struct adapter
      *padapter)
      > ￜￜￜￜￜￜￜￜￜ{
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, "%s: ### ERROR
      ### wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);
      > ￜￜￜￜￜￜￜￜￜ}
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > ￜ}
      > ￜ#endif /* ifdef CONFIG_WOWLAN */
      > @@ -1430,7 +1430,7 @@ int rtw_suspend_ap_wow(struct adapter
      *padapter)
      > ￜￜￜￜￜￜￜￜￜstruct wowlan_ioctl_param poidparam;
      > ￜￜￜￜￜￜￜￜￜint ret = _SUCCESS;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      >
      > ￜￜￜￜￜￜￜￜￜpwrpriv->wowlan_ap_mode = true;
      >
      > @@ -1462,14 +1462,14 @@ int rtw_suspend_ap_wow(struct adapter
      *padapter)
      > ￜￜￜￜￜￜￜￜￜDBG_871X_LEVEL(_drv_always_, "%s: wowmode
      suspending\n", __func__);
      >
      > ￜￜￜￜￜￜￜￜￜif (rtw_get_ch_setting_union(padapter, &ch, &bw,
      &offset) != 0) {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" back to
      linked/linking union - ch:%u, bw:%u, offset:%u\n",
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " back to
      linked/linking union - ch:%u, bw:%u, offset:%u\n",
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜ FUNC_ADPT_ARG(padapter), ch, bw,
      offset);
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜset_channel_bwmode(padapter, ch, offset, bw);
      > ￜￜￜￜￜￜￜￜￜ}
      >
      > ￜￜￜￜￜￜￜￜￜrtw_set_ps_mode(padapter, PS_MODE_MIN, 0, 0,
      "AP-WOWLAN");
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > ￜ}
      > ￜ#endif /* ifdef CONFIG_AP_WOWLAN */
      > @@ -1480,7 +1480,7 @@ static int rtw_suspend_normal(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜstruct net_device *pnetdev = padapter->pnetdev;
      > ￜￜￜￜￜￜￜￜￜint ret = _SUCCESS;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜif (pnetdev) {
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜnetif_carrier_off(pnetdev);
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜrtw_netif_stop_queue(pnetdev);
      > @@ -1501,7 +1501,7 @@ static int rtw_suspend_normal(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜif (padapter->intf_deinit)
      >
      ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜpadapter->intf_deinit(adapter_to_dvobj(padapter));
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > ￜ}
      >
      > @@ -1599,7 +1599,7 @@ int rtw_resume_process_wow(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜstruct sta_info *psta = NULL;
      > ￜￜￜￜￜￜￜￜￜint ret = _SUCCESS;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      >
      > ￜￜￜￜￜￜￜￜￜif (padapter) {
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜpnetdev = padapter->pnetdev;
      > @@ -1710,7 +1710,7 @@ int rtw_resume_process_wow(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜ/* clean driver side wake up reason. */
      > ￜￜￜￜￜￜￜￜￜpwrpriv->wowlan_wake_reason = 0;
      > ï¿œexit:
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > ￜ}
      > ￜ#endif /* ifdef CONFIG_WOWLAN */
      > @@ -1725,7 +1725,7 @@ int rtw_resume_process_ap_wow(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜstruct wowlan_ioctl_param poidparam;
      > ￜￜￜￜￜￜￜￜￜint ret = _SUCCESS;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      >
      > ￜￜￜￜￜￜￜￜￜif (padapter) {
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜpnetdev = padapter->pnetdev;
      > @@ -1785,7 +1785,7 @@ int rtw_resume_process_ap_wow(struct
      adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜ/* clean driver side wake up reason. */
      > ￜￜￜￜￜￜￜￜￜpwrpriv->wowlan_wake_reason = 0;
      > ï¿œexit:
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > ￜ}
      > ￜ#endif /* ifdef CONFIG_APWOWLAN */
      > @@ -1811,7 +1811,7 @@ static int
      rtw_resume_process_normal(struct adapter *padapter)
      > ￜￜￜￜￜￜￜￜￜpsdpriv = padapter->dvobj;
      > ￜￜￜￜￜￜￜￜￜpdbgpriv = &psdpriv->drv_dbg;
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("==> "FUNC_ADPT_FMT" entry....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("==> " FUNC_ADPT_FMT " entry....\n",
      FUNC_ADPT_ARG(padapter));
      > ￜￜￜￜￜￜￜￜￜ/* ￜinterface init */
      > ￜￜￜￜￜￜￜￜￜ/* if (sdio_init(adapter_to_dvobj(padapter)) !=
      _SUCCESS) */
      > ￜￜￜￜￜￜￜￜￜif ((padapter->intf_init) &&
      (padapter->intf_init(adapter_to_dvobj(padapter)) != _SUCCESS))
      > @@ -1849,21 +1849,21 @@ static int
      rtw_resume_process_normal(struct adapter *padapter)
      >
      >
      > ￜￜￜￜￜￜￜￜￜif (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x -
      WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x -
      WIFI_STATION_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      >
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜif (rtw_chk_roam_flags(padapter,
      RTW_ROAM_ON_RESUME))
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜrtw_roaming(padapter, NULL);
      >
      > ￜￜￜￜￜￜￜￜￜ} else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x -
      WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x -
      WIFI_AP_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      > ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜrtw_ap_restore_network(padapter);
      > ￜￜￜￜￜￜￜￜￜ} else if (check_fwstate(pmlmepriv,
      WIFI_ADHOC_STATE)) {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x -
      WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x -
      WIFI_ADHOC_STATE\n", FUNC_ADPT_ARG(padapter),
      get_fwstate(pmlmepriv));
      > ￜￜￜￜￜￜￜￜￜ} else {
      > -ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT" fwstate:0x%08x -
      ???\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
      > +ￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜￜDBG_871X(FUNC_ADPT_FMT " fwstate:0x%08x -
      ???\n", FUNC_ADPT_ARG(padapter), get_fwstate(pmlmepriv));
      > ￜￜￜￜￜￜￜￜￜ}
      >
      > -ￜￜￜￜￜￜￜￜDBG_871X("<== "FUNC_ADPT_FMT" exit....\n",
      FUNC_ADPT_ARG(padapter));
      > +ￜￜￜￜￜￜￜￜDBG_871X("<== " FUNC_ADPT_FMT " exit....\n",
      FUNC_ADPT_ARG(padapter));
      >
      > ï¿œexit:
      > ￜￜￜￜￜￜￜￜￜreturn ret;
      > --
      > 1.9.1
      >
      > --
      > You received this message because you are subscribed to the
      Google Groups "outreachy-kernel" group.
      > To unsubscribe from this group and stop receiving emails from
      it, send an email to [email protected].
      > To post to this group, send email to
      [email protected].
      > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/86078625c574018711c48bf6
      6ebb5f62d540ac79.1505052882.git.harshasharmaiitr%40gmail.com.
      > For more options, visit https://groups.google.com/d/optout.
      >

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/331e385f-53e0-486d-9457- 3afe47e26240%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Space required after ','

Signed-off-by Harsha Sharma <[email protected]>

Acked-by Julia Lawall <[email protected]>

Remove space between function name and open parenthesis '('

Signed-off-by Harsha Sharma <[email protected]>

---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Quoted 6 lines · Harsha Sharma

Remove space between function name and open parenthesis '('

Signed-off-by Harsha Sharma <[email protected] <javascript:>>

---

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++--- 
 1 file changed, 3 insertions(+), 3 deletions(-) 

This and patch 8/10, have the same subject line (well, one letter different), yet they do different things, please either merge them together or give them better names.

thanks,

Hello,

greg k-h

On Sun, Sep 10, 2017 at 11:04:34PM +0530, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '(' >
> Signed-off-by: Harsha Sharma <[email protected]> > ---
> �drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++--- > �1 file changed, 3 insertions(+), 3 deletions(-)

This and patch 8/10, have the same subject line (well, one letter different), yet they do different things, please either merge them together or give them better names.

thanks,

Hello,
Thanks a lot for your feedback.
Sorry but I have a doubt. Should I send the whole patchset again with required changes ? Also I was working on branch first-patchset for this patchset.

Remove space between function name and open parenthesis '(' Remove space before ';', '++', ','

Signed-off-by Harsha Sharma <[email protected]>

---
Change in v2:
-Merge patches 07/10 and 08/10

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/rtl8723bs/os_dep/os_intfs.c +6 -7

index eb21821..61be2b8 100644
@@ -235,8 +235,8 @@
 MODULE_PARM_DESC(rtw_decrypt_phy_file, "Enable Decrypt PHY File");
 
 int _netdev_open(struct net_device *pnetdev);
-int netdev_open (struct net_device *pnetdev);
-static int netdev_close (struct net_device *pnetdev);
+int netdev_open(struct net_device *pnetdev);
+static int netdev_close(struct net_device *pnetdev);
 
 static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
 {

@@ -258,7 +258,7 @@ static uint loadparam(struct adapter *padapter, _nic_hdl pnetdev)
 	if (registry_par->channel > 14)
 		registry_par->channel = 1;
 
-	registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense ;
+	registry_par->vrtl_carrier_sense = (u8)rtw_vrtl_carrier_sense;
 	registry_par->vcs_type = (u8)rtw_vcs_type;
 	registry_par->rts_thresh = (u16)rtw_rts_thresh;
 	registry_par->frag_thresh = (u16)rtw_frag_thresh;

@@ -607,7 +607,7 @@ u32 rtw_start_drv_threads(struct adapter *padapter)
 	return _status;
 }
 
-void rtw_stop_drv_threads (struct adapter *padapter)
+void rtw_stop_drv_threads(struct adapter *padapter)
 {
 	RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+rtw_stop_drv_threads\n"));
 

@@ -1228,7 +1228,7 @@ void rtw_dev_unload(struct adapter *padapter)
 				DBG_871X("stop cmdthd timeout\n");
 				break;
 			} else {
-				cnt ++;
+				cnt++;
 				DBG_871X("cmdthd is running(%d)\n", cnt);
 				msleep(10);
 			}

@@ -1879,7 +1879,7 @@ int rtw_resume_common(struct adapter *padapter)
 		pwrpriv->pno_in_resume = false;
 	#endif
 	}
-	DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__ , ret,
+	DBG_871X_LEVEL(_drv_always_, "%s:%d in %d ms\n", __func__, ret,
 		jiffies_to_msecs(jiffies - start_time));
 
 	return ret;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505210936-24971-1-git-send-email-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Space required after ','

Signed-off-by Harsha Sharma <[email protected]>

---
Changes in v2:
-Rebase against staging-testing and solve merge conflicts

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Quoted 9 lines · Harsha Sharma

Space required after ','

Signed-off-by Harsha Sharma <[email protected]>

---
Changes in v2:
-Rebase against staging-testing and solve merge conflicts

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Where are the rest of the patches in this series, I only seem to have 2 (patch 6 and patch 7 out of 10.)

If you have to resend patches, please always do so as a unique series, If I have taken some of a previous series, please then send the new ones out as a totally unique series, as that is what they now are.

Remember, make it totally obvious what I, as a maintainer, need to do here. I have no memory of previous patch submissions, or what happened on something else somewhere else. I deal with thousands of patches, and as such, have no short-term memory :)

thanks,

greg k-h