drm/omap: Make omapdss API more generic + related patches
Subsystems (3)
Re: [PATCH v3 2/3] drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops
In reply to Jyri SarhaQuoted 5 lines · Jyri Sarha
Add
get_ovl_name()andget_mgr_name()todispc_opsand get rid of adhoc names here and there in the omapdrm code. This moves the names of hardware entities to omapdss side where they have to be when new omapdss backend drivers are introduced.
Quoted 8 lines
Signed-off-by Jyri Sarha <[email protected]>--- drivers/gpu/drm/omapdrm/dss/dispc.c | 21 +++++++++++++++++++++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +++ drivers/gpu/drm/omapdrm/omap_crtc.c | 11 ++--------- drivers/gpu/drm/omapdrm/omap_irq.c | 19 +++++++------------ drivers/gpu/drm/omapdrm/omap_plane.c | 13 +++---------- 5 files changed, 36 insertions(+), 31 deletions(-)
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
v3 cover drm/omap: Make omapdss API more generic + related patches
Since v2:
- Simplify dispc_mgr_has_framedone()
- dispc_hw_to_api_irq() and dispc_api_to_hw_irq() use new dispc_irq_bits[]
- rename dispc_ops read_irqstatus() to read_and_clear_irqstatus() and remove clearmask
- precalculate priv->irq_uf_mask in omap_drm_irq_install() and use it in omap_irq_fifo_underflow()
Here is the v2 round:
https://lists.freedesktop.org/archives/dri-devel/2018-January/161353.html
Since RFC:
This the v2 rouns of a this RFC patch:
https://patchwork.kernel.org/patch/10066245/
The first patch is a simple fix that should be applied in any case.
I did not split the mgr_has_framedone() callback as a separate patch. It quite literally replaces the mgr_get_framedone_irq() and makes no sense without the "drm/omap: Make omapdss API more generic"-patch.
Best regards,
Jyri
Jyri Sarha (3):
drm/omap: Fail probe if irq registration fails drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops drm/omap: Make omapdss API more generic
drivers/gpu/drm/omapdrm/dss/dispc.c | 113 ++++++++++++++++++++++++------ drivers/gpu/drm/omapdrm/dss/dispc.h | 33 +++++++++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 67 ++++++++---------- drivers/gpu/drm/omapdrm/omap_crtc.c | 27 +++----- drivers/gpu/drm/omapdrm/omap_crtc.h | 2 +- drivers/gpu/drm/omapdrm/omap_drv.c | 4 +- drivers/gpu/drm/omapdrm/omap_drv.h | 3 +- drivers/gpu/drm/omapdrm/omap_irq.c | 125 +++++++++++++++------------------- drivers/gpu/drm/omapdrm/omap_irq.h | 2 +- drivers/gpu/drm/omapdrm/omap_plane.c | 18 ++--- drivers/gpu/drm/omapdrm/omap_plane.h | 1 + 11 files changed, 237 insertions(+), 158 deletions(-)
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v3 1/3 drm/omap: Fail probe if irq registration fails
Call to omap_drm_irq_install() may fail with an error code. In such a case the driver probe should fail.
--- drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/omapdrm/omap_drv.c +2 -2
@@ -329,9 +329,9 @@ static int omap_modeset_init(struct drm_device *dev)drm_mode_config_reset (dev); -omap_drm_irq_install (dev); + ret =omap_drm_irq_install (dev); -return 0 ; +return ret; }/*
Signature · 8 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v3 2/3 drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops
In reply to Jyri SarhaAdd get_ovl_name() and get_mgr_name() to dispc_ops and get rid of adhoc names here and there in the omapdrm code. This moves the names of hardware entities to omapdss side where they have to be when new omapdss backend drivers are introduced.
--- drivers/gpu/drm/omapdrm/dss/dispc.c | 21 +++++++++++++++++++++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +++ drivers/gpu/drm/omapdrm/omap_crtc.c | 11 ++--------- drivers/gpu/drm/omapdrm/omap_irq.c | 19 +++++++------------ drivers/gpu/drm/omapdrm/omap_plane.c | 13 +++---------- 5 files changed, 36 insertions(+), 31 deletions(-)
drivers/gpu/drm/omapdrm/dss/dispc.c +21 -0
@@ -680,6 +680,24 @@ void dispc_runtime_put(void)WARN_ON (r <0 && r != -ENOSYS ); } +static const char *dispc_get_ovl_name (enum omap_plane_id plane) +{ +static const char *ovl_names[] = { + [OMAP_DSS_GFX ] ="GFX" , + [OMAP_DSS_VIDEO1 ] ="VID1" , + [OMAP_DSS_VIDEO2 ] ="VID2" , + [OMAP_DSS_VIDEO3 ] ="VID3" , + [OMAP_DSS_WB ] ="WB" , + }; + +return ovl_names[plane]; +} + +static const char *dispc_get_mgr_name (enum omap_channel channel) +{ +return mgr_desc[channel].name; +} +static u32 dispc_mgr_get_vsync_irq (enum omap_channel channel) {return mgr_desc[channel].vsync_irq;
@@ -4506,6 +4524,9 @@ static void dispc_errata_i734_wa(void) .get_num_ovls = dispc_get_num_ovls, .get_num_mgrs = dispc_get_num_mgrs, + .get_ovl_name = dispc_get_ovl_name, + .get_mgr_name = dispc_get_mgr_name, + .get_memory_bandwidth_limit = dispc_get_memory_bandwidth_limit, .mgr_enable = dispc_mgr_enable,
drivers/gpu/drm/omapdrm/dss/omapdss.h +3 -0
@@ -691,6 +691,9 @@ struct dispc_ops {int (*get_num_ovls)(void );int (*get_num_mgrs)(void ); +const char *(*get_ovl_name)(enum omap_plane_id plane); +const char *(*get_mgr_name)(enum omap_channel channel); +u32 (*get_memory_bandwidth_limit)(void);void (*mgr_enable)(enum omap_channel channel,bool enable);
drivers/gpu/drm/omapdrm/omap_crtc.c +2 -9
@@ -662,13 +662,6 @@ static void omap_crtc_reset(struct drm_crtc *crtc)* Init and Cleanup */ -static const char *channel_names[] = { - [OMAP_DSS_CHANNEL_LCD ] ="lcd" , - [OMAP_DSS_CHANNEL_DIGIT ] ="tv" , - [OMAP_DSS_CHANNEL_LCD2 ] ="lcd2" , - [OMAP_DSS_CHANNEL_LCD3 ] ="lcd3" , -}; -void omap_crtc_pre_init (void ) {memset (omap_crtcs,0 ,sizeof (omap_crtcs));
@@ -696,7 +689,7 @@ struct drm_crtc *omap_crtc_init(struct drm_device *dev, channel = out->dispc_channel;omap_dss_put_device (out); -DBG ("%s" , channel_names[channel]); +DBG ("%s" , priv->dispc_ops->get_mgr_name (channel));/* Multiple displays on same channel is not allowed */ if (WARN_ON (omap_crtcs[channel] !=NULL ))
@@ -711,7 +704,7 @@ struct drm_crtc *omap_crtc_init(struct drm_device *dev,init_waitqueue_head (&omap_crtc->pending_wait); omap_crtc->channel = channel; - omap_crtc->name = channel_names[channel]; + omap_crtc->name = priv->dispc_ops->get_mgr_name (channel); ret =drm_crtc_init_with_planes (dev, crtc, plane,NULL , &omap_crtc_funcs,NULL );
drivers/gpu/drm/omapdrm/omap_irq.c +7 -12
@@ -144,15 +144,10 @@ static void omap_irq_fifo_underflow(struct omap_drm_private *priv, { static DEFINE_RATELIMIT_STATE(_rs, DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST); -static const struct { -const char *name; -u32 mask; - } sources[] = { - {"gfx" ,DISPC_IRQ_GFX_FIFO_UNDERFLOW }, - {"vid1" ,DISPC_IRQ_VID1_FIFO_UNDERFLOW }, - {"vid2" ,DISPC_IRQ_VID2_FIFO_UNDERFLOW }, - {"vid3" ,DISPC_IRQ_VID3_FIFO_UNDERFLOW }, - }; +static const u32 irqbits[] = {DISPC_IRQ_GFX_FIFO_UNDERFLOW , +DISPC_IRQ_VID1_FIFO_UNDERFLOW , +DISPC_IRQ_VID2_FIFO_UNDERFLOW , +DISPC_IRQ_VID3_FIFO_UNDERFLOW };const u32 mask =DISPC_IRQ_GFX_FIFO_UNDERFLOW |DISPC_IRQ_VID1_FIFO_UNDERFLOW
@@ -172,9 +167,9 @@ static void omap_irq_fifo_underflow(struct omap_drm_private *priv,DRM_ERROR ("FIFO underflow on " ); -for (i =0 ; i <ARRAY_SIZE (sources); ++i) { -if (sources[i].mask & irqstatus) -pr_cont ("%s " , sources[i].name); +for (i =0 ; i <ARRAY_SIZE (irqbits); ++i) { +if (irqbits[i] & irqstatus) +pr_cont ("%s " , priv->dispc_ops->get_ovl_name (i)); }pr_cont ("(0x%08x)\n" , irqstatus);
drivers/gpu/drm/omapdrm/omap_plane.c +3 -11
@@ -239,13 +239,6 @@ static int omap_plane_atomic_get_property(struct drm_plane *plane, .atomic_get_property = omap_plane_atomic_get_property, }; -static const char *plane_id_to_name[] = { - [OMAP_DSS_GFX ] ="gfx" , - [OMAP_DSS_VIDEO1 ] ="vid1" , - [OMAP_DSS_VIDEO2 ] ="vid2" , - [OMAP_DSS_VIDEO3 ] ="vid3" , -}; -static const enum omap_plane_id plane_idx_to_id[] = {OMAP_DSS_GFX ,OMAP_DSS_VIDEO1 ,
@@ -272,7 +265,7 @@ struct drm_plane *omap_plane_init(struct drm_device *dev, id = plane_idx_to_id[idx]; -DBG ("%s: type=%d" , plane_id_to_name[id], type); +DBG ("%s: type=%d" , priv->dispc_ops->get_ovl_name (id), type); omap_plane =kzalloc (sizeof (*omap_plane),GFP_KERNEL );if (!omap_plane)
@@ -282,7 +275,7 @@ struct drm_plane *omap_plane_init(struct drm_device *dev,for (nformats =0 ; formats[nformats]; ++nformats) ; omap_plane->id = id; - omap_plane->name = plane_id_to_name[id]; + omap_plane->name = priv->dispc_ops->get_ovl_name (id); plane = &omap_plane->base;
@@ -301,8 +294,7 @@ struct drm_plane *omap_plane_init(struct drm_device *dev, error:dev_err (dev->dev,"%s(): could not create plane: %s\n" , - __func__, plane_id_to_name[id]); + __func__, priv->dispc_ops->get_ovl_name (id));kfree (omap_plane);return NULL ; --
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v3 3/3 drm/omap: Make omapdss API more generic
In reply to Jyri SarhaThe new omapdss API is HW independent and cleans up some of the DSS5 specific hacks from the omapdrm side and gets rid off the DSS5 IRQ register bits and replace them with HW independent generic u64 based macros. The new macros make it more straight forward to implement the IRQ code for the future DSS versions that do not share the same register structure as DSS2 to DSS5 has.
--- drivers/gpu/drm/omapdrm/dss/dispc.c | 106 ++++++++++++++++++++++-------- drivers/gpu/drm/omapdrm/dss/dispc.h | 33 ++++++++++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 64 ++++++++---------- drivers/gpu/drm/omapdrm/omap_crtc.c | 16 +++-- drivers/gpu/drm/omapdrm/omap_crtc.h | 2 +- drivers/gpu/drm/omapdrm/omap_drv.h | 3 +- drivers/gpu/drm/omapdrm/omap_irq.c | 120 +++++++++++++++------------------- drivers/gpu/drm/omapdrm/omap_irq.h | 2 +- drivers/gpu/drm/omapdrm/omap_plane.c | 7 ++ drivers/gpu/drm/omapdrm/omap_plane.h | 1 + 10 files changed, 214 insertions(+), 140 deletions(-)
drivers/gpu/drm/omapdrm/dss/dispc.c +79 -27
@@ -698,27 +698,10 @@ static const char *dispc_get_mgr_name(enum omap_channel channel)return mgr_desc[channel].name; } -static u32 dispc_mgr_get_vsync_irq (enum omap_channel channel) +static bool dispc_mgr_has_framedone (enum omap_channel channel) { -return mgr_desc[channel].vsync_irq; -} - -static u32 dispc_mgr_get_framedone_irq (enum omap_channel channel) -{ -if (channel ==OMAP_DSS_CHANNEL_DIGIT && dispc.feat->no_framedone_tv) -return 0 ; - -return mgr_desc[channel].framedone_irq; -} - -static u32 dispc_mgr_get_sync_lost_irq (enum omap_channel channel) -{ -return mgr_desc[channel].sync_lost_irq; -} - -u32 dispc_wb_get_framedone_irq (void ) -{ -return DISPC_IRQ_FRAMEDONEWB ; +return channel !=OMAP_DSS_CHANNEL_DIGIT || + !dispc.feat->no_framedone_tv; }static void dispc_mgr_enable (enum omap_channel channel,bool enable)
@@ -3604,6 +3587,77 @@ static void dispc_write_irqenable(u32 mask)dispc_read_reg (DISPC_IRQENABLE ); } +struct dispc_irq_bit { +u32 hw; +u64 api; +}; + +static const struct dispc_irq_bit dispc_irq_bits[] = { + {DISPC_IRQ_OCP_ERR ,DSS_IRQ_DEVICE_OCP_ERR }, + + {DISPC_IRQ_FRAMEDONE ,DSS_IRQ_MGR_FRAME_DONE (0 ) }, + {DISPC_IRQ_VSYNC ,DSS_IRQ_MGR_VSYNC_EVEN (0 ) }, + {DISPC_IRQ_SYNC_LOST ,DSS_IRQ_MGR_SYNC_LOST (0 ) }, + + {DISPC_IRQ_EVSYNC_EVEN ,DSS_IRQ_MGR_VSYNC_EVEN (1 ) }, + {DISPC_IRQ_EVSYNC_ODD ,DSS_IRQ_MGR_VSYNC_ODD (1 ) }, + {DISPC_IRQ_SYNC_LOST_DIGIT ,DSS_IRQ_MGR_SYNC_LOST (1 ) }, + {DISPC_IRQ_FRAMEDONETV ,DSS_IRQ_MGR_FRAME_DONE (1 ) }, + + {DISPC_IRQ_SYNC_LOST2 ,DSS_IRQ_MGR_SYNC_LOST (2 ) }, + {DISPC_IRQ_VSYNC2 ,DSS_IRQ_MGR_VSYNC_EVEN (2 ) }, + {DISPC_IRQ_FRAMEDONE2 ,DSS_IRQ_MGR_FRAME_DONE (2 ) }, + + {DISPC_IRQ_SYNC_LOST3 ,DSS_IRQ_MGR_SYNC_LOST (3 ) }, + {DISPC_IRQ_VSYNC3 ,DSS_IRQ_MGR_VSYNC_EVEN (3 ) }, + {DISPC_IRQ_FRAMEDONE3 ,DSS_IRQ_MGR_FRAME_DONE (3 ) }, + + {DISPC_IRQ_GFX_FIFO_UNDERFLOW ,DSS_IRQ_OVL_FIFO_UNDERFLOW (0 ) }, + {DISPC_IRQ_VID1_FIFO_UNDERFLOW ,DSS_IRQ_OVL_FIFO_UNDERFLOW (1 ) }, + {DISPC_IRQ_VID2_FIFO_UNDERFLOW ,DSS_IRQ_OVL_FIFO_UNDERFLOW (2 ) }, + {DISPC_IRQ_VID3_FIFO_UNDERFLOW ,DSS_IRQ_OVL_FIFO_UNDERFLOW (3 ) }, +}; + +static u64 dispc_hw_to_api_irq (u32 hw) +{ +u64 api =0 ; +int i; + +for (i =0 ; i <ARRAY_SIZE (dispc_irq_bits); i++) +if (hw & dispc_irq_bits[i].hw) + api |= dispc_irq_bits[i].api; + +return api; +} + +static u32 dispc_api_to_hw_irq (u64 api) +{ +u32 hw =0 ; +int i; + +for (i =0 ; i <ARRAY_SIZE (dispc_irq_bits); i++) +if (api & dispc_irq_bits[i].api) + hw |= dispc_irq_bits[i].hw; + +return hw; +} + +static u64 dispc_api_read_and_clear_irqstatus (void ) +{ +u32 hw_status =dispc_read_irqstatus (); + +dispc_clear_irqstatus (hw_status); + +return dispc_hw_to_api_irq (hw_status); +} + +static void dispc_api_write_irqenable (u64 enable) +{ +u32 hw_enable =dispc_api_to_hw_irq (enable); + +dispc_write_irqenable (hw_enable); +} +void dispc_enable_sidle (void ) {REG_FLD_MOD (DISPC_SYSCONFIG ,2 ,4 ,3 );/* SIDLEMODE: smart idle */
@@ -4453,7 +4507,7 @@ static void dispc_errata_i734_wa_fini(void)static void dispc_errata_i734_wa (void ) { -u32 framedone_irq =dispc_mgr_get_framedone_irq (OMAP_DSS_CHANNEL_LCD ); +u32 framedone_irq =DISPC_IRQ_FRAMEDONE ;struct omap_overlay_info ovli;struct dss_lcd_mgr_config lcd_conf;u32 gatestate;
@@ -4511,9 +4565,8 @@ static void dispc_errata_i734_wa(void) }static const struct dispc_ops dispc_ops = { - .read_irqstatus = dispc_read_irqstatus, - .clear_irqstatus = dispc_clear_irqstatus, - .write_irqenable = dispc_write_irqenable, + .read_and_clear_irqstatus = dispc_api_read_and_clear_irqstatus, + .write_irqenable = dispc_api_write_irqenable, .request_irq = dispc_request_irq, .free_irq = dispc_free_irq,
@@ -4527,13 +4580,12 @@ static void dispc_errata_i734_wa(void) .get_ovl_name = dispc_get_ovl_name, .get_mgr_name = dispc_get_mgr_name, + .mgr_has_framedone = dispc_mgr_has_framedone, + .get_memory_bandwidth_limit = dispc_get_memory_bandwidth_limit, .mgr_enable = dispc_mgr_enable, .mgr_is_enabled = dispc_mgr_is_enabled, - .mgr_get_vsync_irq = dispc_mgr_get_vsync_irq, - .mgr_get_framedone_irq = dispc_mgr_get_framedone_irq, - .mgr_get_sync_lost_irq = dispc_mgr_get_sync_lost_irq, .mgr_go_busy = dispc_mgr_go_busy, .mgr_go = dispc_mgr_go, .mgr_set_lcd_config = dispc_mgr_set_lcd_config,
drivers/gpu/drm/omapdrm/dss/dispc.h +33 -0
@@ -18,6 +18,39 @@#ifndef __OMAP2_DISPC_REG_H#define __OMAP2_DISPC_REG_H +/* DISPC IRQ bits */ +#define DISPC_IRQ_FRAMEDONE (1 << 0) +#define DISPC_IRQ_VSYNC (1 << 1) +#define DISPC_IRQ_EVSYNC_EVEN (1 << 2) +#define DISPC_IRQ_EVSYNC_ODD (1 << 3) +#define DISPC_IRQ_ACBIAS_COUNT_STAT (1 << 4) +#define DISPC_IRQ_PROG_LINE_NUM (1 << 5) +#define DISPC_IRQ_GFX_FIFO_UNDERFLOW (1 << 6) +#define DISPC_IRQ_GFX_END_WIN (1 << 7) +#define DISPC_IRQ_PAL_GAMMA_MASK (1 << 8) +#define DISPC_IRQ_OCP_ERR (1 << 9) +#define DISPC_IRQ_VID1_FIFO_UNDERFLOW (1 << 10) +#define DISPC_IRQ_VID1_END_WIN (1 << 11) +#define DISPC_IRQ_VID2_FIFO_UNDERFLOW (1 << 12) +#define DISPC_IRQ_VID2_END_WIN (1 << 13) +#define DISPC_IRQ_SYNC_LOST (1 << 14) +#define DISPC_IRQ_SYNC_LOST_DIGIT (1 << 15) +#define DISPC_IRQ_WAKEUP (1 << 16) +#define DISPC_IRQ_SYNC_LOST2 (1 << 17) +#define DISPC_IRQ_VSYNC2 (1 << 18) +#define DISPC_IRQ_VID3_END_WIN (1 << 19) +#define DISPC_IRQ_VID3_FIFO_UNDERFLOW (1 << 20) +#define DISPC_IRQ_ACBIAS_COUNT_STAT2 (1 << 21) +#define DISPC_IRQ_FRAMEDONE2 (1 << 22) +#define DISPC_IRQ_FRAMEDONEWB (1 << 23) +#define DISPC_IRQ_FRAMEDONETV (1 << 24) +#define DISPC_IRQ_WBBUFFEROVERFLOW (1 << 25) +#define DISPC_IRQ_WBUNCOMPLETEERROR (1 << 26) +#define DISPC_IRQ_SYNC_LOST3 (1 << 27) +#define DISPC_IRQ_VSYNC3 (1 << 28) +#define DISPC_IRQ_ACBIAS_COUNT_STAT3 (1 << 29) +#define DISPC_IRQ_FRAMEDONE3 (1 << 30) +/* DISPC common registers */ #define DISPC_REVISION 0x0000#define DISPC_SYSCONFIG 0x0010
drivers/gpu/drm/omapdrm/dss/omapdss.h +27 -37
86 lines not on this page · raw message
drivers/gpu/drm/omapdrm/omap_crtc.c +9 -7
@@ -149,7 +149,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)struct omap_crtc *omap_crtc =to_omap_crtc (crtc);enum omap_channel channel = omap_crtc->channel;struct omap_irq_wait *wait; -u32 framedone_irq, vsync_irq; +u64 vsync_irq, framedone_irq;int ret;if (WARN_ON (omap_crtc->enabled == enable))
@@ -169,8 +169,10 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) omap_crtc->ignore_digit_sync_lost = true; } - framedone_irq = priv->dispc_ops->mgr_get_framedone_irq (channel); - vsync_irq = priv->dispc_ops->mgr_get_vsync_irq (channel); + + vsync_irq = (DSS_IRQ_MGR_VSYNC_EVEN (channel) | +DSS_IRQ_MGR_VSYNC_ODD (channel)); + framedone_irq =DSS_IRQ_MGR_FRAME_DONE (channel);if (enable) { wait =omap_irq_wait_init (dev, vsync_irq,1 );
@@ -184,7 +186,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)* even and odd frames. */ -if (framedone_irq) +if (priv->dispc_ops->mgr_has_framedone (channel)) wait =omap_irq_wait_init (dev, framedone_irq,1 );else wait =omap_irq_wait_init (dev, vsync_irq,2 );
@@ -272,17 +274,17 @@ static void omap_crtc_dss_unregister_framedone(* Setup, Flush and Page Flip */ -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus) +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus) {struct omap_crtc *omap_crtc =to_omap_crtc (crtc);if (omap_crtc->ignore_digit_sync_lost) { - irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT ; + irqstatus &= ~DSS_IRQ_MGR_SYNC_LOST (omap_crtc->channel);if (!irqstatus)return ; } -DRM_ERROR_RATELIMITED ("%s: errors: %08x\n" , omap_crtc->name, irqstatus); +DRM_ERROR_RATELIMITED ("%s: errors: %016llx\n" , omap_crtc->name, irqstatus); }void omap_crtc_vblank_irq (struct drm_crtc *crtc)
drivers/gpu/drm/omapdrm/omap_crtc.h +1 -1
@@ -37,7 +37,7 @@struct drm_crtc *omap_crtc_init (struct drm_device *dev,struct drm_plane *plane,struct omap_dss_device *dssdev);int omap_crtc_wait_pending (struct drm_crtc *crtc); -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus); +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus);void omap_crtc_vblank_irq (struct drm_crtc *crtc);#endif /* __OMAPDRM_CRTC_H__ */
drivers/gpu/drm/omapdrm/omap_drv.h +2 -1
@@ -81,7 +81,8 @@ struct omap_drm_private {/* irq handling: */ spinlock_t wait_lock;/* protects the wait_list */ struct list_head wait_list;/* list of omap_irq_wait */ -uint32_t irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_uf_mask;/* underflow irq bits for all planes */ /* memory bandwidth limit if it is needed on the platform */ unsigned int max_bandwidth;
drivers/gpu/drm/omapdrm/omap_irq.c +54 -66
253 lines not on this page · raw message
drivers/gpu/drm/omapdrm/omap_irq.h +1 -1
@@ -32,7 +32,7 @@int omap_drm_irq_install (struct drm_device *dev);struct omap_irq_wait *omap_irq_wait_init (struct drm_device *dev, -uint32_t irqmask,int count); +u64 irqmask,int count);int omap_irq_wait (struct drm_device *dev,struct omap_irq_wait *wait,unsigned long timeout);
drivers/gpu/drm/omapdrm/omap_plane.c +7 -0
@@ -239,6 +239,13 @@ static int omap_plane_atomic_get_property(struct drm_plane *plane, .atomic_get_property = omap_plane_atomic_get_property, }; +enum omap_plane_id omap_plane_get_id (struct drm_plane *plane) +{ +struct omap_plane *omap_plane =to_omap_plane (plane); + +return omap_plane->id; +} +static const enum omap_plane_id plane_idx_to_id[] = {OMAP_DSS_GFX ,OMAP_DSS_VIDEO1 ,
drivers/gpu/drm/omapdrm/omap_plane.h +1 -1
@@ -33,6 +33,6 @@ struct drm_plane *omap_plane_init(struct drm_device *dev, u32 possible_crtcs);void omap_plane_install_properties (struct drm_plane *plane,struct drm_mode_object *obj); +enum omap_plane_id omap_plane_get_id (struct drm_plane *plane);#endif /* __OMAPDRM_PLANE_H__ */ --
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 1/3] drm/omap: Fail probe if irq registration fails
In reply to Jyri SarhaQuoted 13 lines · Jyri Sarha
Call to
omap_drm_irq_install()may fail with an error code. In such a case the driver probe should fail.Signed-off-by Jyri Sarha <[email protected]>--- drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/omapdrm/omap_drv.c +0
-0
drivers/gpu/drm/omapdrm/omap_drv.c static int omap_modeset_init(struct drm_device *dev) · line 335
Quoted 9 lines
drivers/gpu/drm/omapdrm/omap_drv.c +2
-2@@ -329,9 +329,9 @@ static int omap_modeset_init(struct drm_device *dev)drm_mode_config_reset (dev); -omap_drm_irq_install (dev); + ret =omap_drm_irq_install (dev); -return 0 ; +return ret; }
It's better to do "if (ret) return ret;" so that it's easy (and less error prone) to modify the code later.
Other than that:
Tomi
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 3/3] drm/omap: Make omapdss API more generic
In reply to Jyri SarhaQuoted 8 lines · Jyri Sarha
The new omapdss API is HW independent and cleans up some of the DSS5 specific hacks from the omapdrm side and gets rid off the DSS5 IRQ register bits and replace them with HW independent generic u64 based macros. The new macros make it more straight forward to implement the IRQ code for the future DSS versions that do not share the same register structure as DSS2 to DSS5 has.
Signed-off-by Jyri Sarha <[email protected]>
<snip>
Can you add a comment here that describes the layout of the u64 irq bits container.
Quoted 78 lines
drivers/gpu/drm/omapdrm/dss/omapdss.h +24
-6+#define DSS_IRQ_DEVICE_OCP_ERR BIT_ULL(0) + +#define DSS_IRQ_MGR_BIT_N (ch, bit) (4 + 4 * ch + bit) +#define DSS_IRQ_OVL_BIT_N (ovl, bit) \ + (DSS_IRQ_MGR_BIT_N(DSS_MAX_CHANNELS, 0) + 1 * ovl + bit) + +#define DSS_IRQ_MGR_BIT (ch, bit) BIT_ULL(DSS_IRQ_MGR_BIT_N(ch, bit)) +#define DSS_IRQ_OVL_BIT (ovl, bit) BIT_ULL(DSS_IRQ_OVL_BIT_N(ovl, bit)) + +#define DSS_IRQ_MGR_MASK (ch) \ + GENMASK_ULL(DSS_IRQ_MGR_BIT_N(ch, 3), DSS_IRQ_MGR_BIT_N(ch, 0)) +#define DSS_IRQ_OVL_MASK (ovl) \ + GENMASK_ULL(DSS_IRQ_OVL_BIT_N(ovl, 0), DSS_IRQ_OVL_BIT_N(ovl, 0)) + +#define DSS_IRQ_MGR_FRAME_DONE (ch) DSS_IRQ_MGR_BIT(ch, 0) +#define DSS_IRQ_MGR_VSYNC_EVEN (ch) DSS_IRQ_MGR_BIT(ch, 1) +#define DSS_IRQ_MGR_VSYNC_ODD (ch) DSS_IRQ_MGR_BIT(ch, 2) +#define DSS_IRQ_MGR_SYNC_LOST (ch) DSS_IRQ_MGR_BIT(ch, 3) + +#define DSS_IRQ_OVL_FIFO_UNDERFLOW (ovl) DSS_IRQ_OVL_BIT(ovl, 0)struct omap_dss_device ;struct dss_lcd_mgr_config ;@@ -678,9 +670,8 @@ void dss_mgr_unregister_framedone_handler(enum omap_channel channel,/* dispc ops */ struct dispc_ops { -u32 (*read_irqstatus)(void ); -void (*clear_irqstatus)(u32 mask); -void (*write_irqenable)(u32 mask); +u64 (*read_and_clear_irqstatus)(void ); +void (*write_irqenable)(u64 enable);int (*request_irq)(irq_handler_t handler,void *dev_id);void (*free_irq)(void *dev_id);@@ -694,13 +685,12 @@ struct dispc_ops {const char *(*get_ovl_name)(enum omap_plane_id plane);const char *(*get_mgr_name)(enum omap_channel channel); +bool (*mgr_has_framedone)(enum omap_channel channel); +u32 (*get_memory_bandwidth_limit)(void);void (*mgr_enable)(enum omap_channel channel,bool enable);bool (*mgr_is_enabled)(enum omap_channel channel); -u32 (*mgr_get_vsync_irq)(enum omap_channel channel); -u32 (*mgr_get_framedone_irq)(enum omap_channel channel); -u32 (*mgr_get_sync_lost_irq)(enum omap_channel channel);bool (*mgr_go_busy)(enum omap_channel channel);void (*mgr_go)(enum omap_channel channel); void (*mgr_set_lcd_config)(enum omap_channel channel,drivers/gpu/drm/omapdrm/omap_crtc.c +5
-3@@ -149,7 +149,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)struct omap_crtc *omap_crtc =to_omap_crtc (crtc);enum omap_channel channel = omap_crtc->channel;struct omap_irq_wait *wait; -u32 framedone_irq, vsync_irq; +u64 vsync_irq, framedone_irq;int ret;if (WARN_ON (omap_crtc->enabled == enable))@@ -169,8 +169,10 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) omap_crtc->ignore_digit_sync_lost = true; } - framedone_irq = priv->dispc_ops->mgr_get_framedone_irq (channel); - vsync_irq = priv->dispc_ops->mgr_get_vsync_irq (channel); + + vsync_irq = (DSS_IRQ_MGR_VSYNC_EVEN (channel) | +DSS_IRQ_MGR_VSYNC_ODD (channel)); + framedone_irq =DSS_IRQ_MGR_FRAME_DONE (channel);if (enable) { wait =omap_irq_wait_init (dev, vsync_irq,1 );
drivers/gpu/drm/omapdrm/omap_crtc.c static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) · line 189
Quoted 5 lines
drivers/gpu/drm/omapdrm/omap_crtc.c +1
-1@@ -184,7 +186,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)* even and odd frames. */ -if (framedone_irq) +if (priv->dispc_ops->mgr_has_framedone (channel))
Is it valid to do DSS_IRQ_MGR_FRAME_DONE(channel) above, even if there's no framedone irq for the channel? Well, I know it won't crash, but from code-cleanliness point of view, perhaps it's better to first check if we have a framedone, and only then get it.
Quoted 75 lines
drivers/gpu/drm/omapdrm/omap_crtc.c +3
-3wait =omap_irq_wait_init (dev, framedone_irq,1 ); else wait =omap_irq_wait_init (dev, vsync_irq,2 );@@ -272,17 +274,17 @@ static void omap_crtc_dss_unregister_framedone(* Setup, Flush and Page Flip */ -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus) +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus) {struct omap_crtc *omap_crtc =to_omap_crtc (crtc);if (omap_crtc->ignore_digit_sync_lost) { - irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT ; + irqstatus &= ~DSS_IRQ_MGR_SYNC_LOST (omap_crtc->channel);if (!irqstatus)return ; } -DRM_ERROR_RATELIMITED ("%s: errors: %08x\n" , omap_crtc->name, irqstatus); +DRM_ERROR_RATELIMITED ("%s: errors: %016llx\n" , omap_crtc->name, irqstatus); }void omap_crtc_vblank_irq (struct drm_crtc *crtc)drivers/gpu/drm/omapdrm/omap_crtc.h +1
-1@@ -37,7 +37,7 @@struct drm_crtc *omap_crtc_init (struct drm_device *dev,struct drm_plane *plane,struct omap_dss_device *dssdev);int omap_crtc_wait_pending (struct drm_crtc *crtc); -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus); +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus);void omap_crtc_vblank_irq (struct drm_crtc *crtc);#endif /* __OMAPDRM_CRTC_H__ */ drivers/gpu/drm/omapdrm/omap_drv.h +2
-1@@ -81,7 +81,8 @@ struct omap_drm_private {/* irq handling: */ spinlock_t wait_lock;/* protects the wait_list */ struct list_head wait_list;/* list of omap_irq_wait */ -uint32_t irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_uf_mask;/* underflow irq bits for all planes */ /* memory bandwidth limit if it is needed on the platform */ unsigned int max_bandwidth;drivers/gpu/drm/omapdrm/omap_irq.c +2
-4@@ -20,25 +20,24 @@struct omap_irq_wait {struct list_head node;wait_queue_head_t wq; -uint32_t irqmask; +u64 irqmask;int count; };/* call with wait_lock and dispc runtime held */ -static void omap_irq_update (struct drm_device *dev) +static void omap_irq_full_mask (struct drm_device *dev,u64 *irqmask) {struct omap_drm_private *priv = dev->dev_private;struct omap_irq_wait *wait; -uint32_t irqmask = priv->irq_mask;assert_spin_locked (&priv->wait_lock); -list_for_each_entry (wait, &priv->wait_list, node)
drivers/gpu/drm/omapdrm/omap_irq.c line 41
Quoted 10 lines
drivers/gpu/drm/omapdrm/omap_irq.c +4
-3- irqmask |= wait->irqmask; + *irqmask = priv->irq_mask; -DBG ("irqmask=%08x" , irqmask); +list_for_each_entry (wait, &priv->wait_list, node) + *irqmask |= wait->irqmask; - priv->dispc_ops->write_irqenable (irqmask); +DBG ("irqmask 0x%016llx" , *irqmask); }
Wouldn't it make more sense for omap_irq_full_mask() to return the mask?
Tomi
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Jyri Sarha
Since v2:
- Simplifydispc_mgr_has_framedone()
-dispc_hw_to_api_irq()anddispc_api_to_hw_irq()use new dispc_irq_bits[]
- renamedispc_opsread_irqstatus()toread_and_clear_irqstatus()and remove clearmask
- precalculatepriv->irq_uf_maskinomap_drm_irq_install()and use it inomap_irq_fifo_underflow()
Can you run these through checkpatch? There was at least one issue that needs to be fixed:
WARNING: static const char * array should probably be static const char
* const
Other than the small comments I sent, I think it looks good.
Laurent, do you have any objections?
I think we probably will change the design later on how the irqs are handled (possibly move the irq handling code away from the common parts), but I think this cleans up things nicely for the time being.
Tomi
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 3/3] drm/omap: Make omapdss API more generic
In reply to Tomi ValkeinenArgh, sorry I forgot about these in the previous post. (And the comment for "drm/omap: Fail probe if irq registration fails").
Quoted 8 lines · Tomi Valkeinen
Quoted 7 lines · Jyri Sarha
The new omapdss API is HW independent and cleans up some of the DSS5 specific hacks from the omapdrm side and gets rid off the DSS5 IRQ register bits and replace them with HW independent generic u64 based macros. The new macros make it more straight forward to implement the IRQ code for the future DSS versions that do not share the same register structure as DSS2 to DSS5 has.
Quoted 5 lines
Quoted 1 line
Signed-off-by Jyri Sarha <[email protected]><snip>
Can you add a comment here that describes the layout of the u64 irq bits container.
Would this do:
/*
* Based on the above 2 defines the bellow defines describe following
* u64 IRQ bits:
* bit group |dev |mrg0|mrg1|mrg2|mrg3|mrg4|mrg5|mrg6|mrg7| olv0-7
|<unused> | * bit use |D |FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|UUUU|UUUU| | | | | | * bit number|0-3 |4-7 |8-11| 12-35 | 36-43 | 44-63 |
*
* device bits: D = OCP error
* mgr bits: F = frame done, E = vsync even, O = vsync odd,
* ovl bits: U = fifo underflow
*/
Quoted 81 lines
Quoted 81 lines
drivers/gpu/drm/omapdrm/dss/omapdss.h +24
-6+#define DSS_IRQ_DEVICE_OCP_ERR BIT_ULL(0) + +#define DSS_IRQ_MGR_BIT_N (ch, bit) (4 + 4 * ch + bit) +#define DSS_IRQ_OVL_BIT_N (ovl, bit) \ + (DSS_IRQ_MGR_BIT_N(DSS_MAX_CHANNELS, 0) + 1 * ovl + bit) + +#define DSS_IRQ_MGR_BIT (ch, bit) BIT_ULL(DSS_IRQ_MGR_BIT_N(ch, bit)) +#define DSS_IRQ_OVL_BIT (ovl, bit) BIT_ULL(DSS_IRQ_OVL_BIT_N(ovl, bit)) + +#define DSS_IRQ_MGR_MASK (ch) \ + GENMASK_ULL(DSS_IRQ_MGR_BIT_N(ch, 3), DSS_IRQ_MGR_BIT_N(ch, 0)) +#define DSS_IRQ_OVL_MASK (ovl) \ + GENMASK_ULL(DSS_IRQ_OVL_BIT_N(ovl, 0), DSS_IRQ_OVL_BIT_N(ovl, 0)) + +#define DSS_IRQ_MGR_FRAME_DONE (ch) DSS_IRQ_MGR_BIT(ch, 0) +#define DSS_IRQ_MGR_VSYNC_EVEN (ch) DSS_IRQ_MGR_BIT(ch, 1) +#define DSS_IRQ_MGR_VSYNC_ODD (ch) DSS_IRQ_MGR_BIT(ch, 2) +#define DSS_IRQ_MGR_SYNC_LOST (ch) DSS_IRQ_MGR_BIT(ch, 3) + +#define DSS_IRQ_OVL_FIFO_UNDERFLOW (ovl) DSS_IRQ_OVL_BIT(ovl, 0)struct omap_dss_device ;struct dss_lcd_mgr_config ;@@ -678,9 +670,8 @@ void dss_mgr_unregister_framedone_handler(enum omap_channel channel,/* dispc ops */ struct dispc_ops { -u32 (*read_irqstatus)(void ); -void (*clear_irqstatus)(u32 mask); -void (*write_irqenable)(u32 mask); +u64 (*read_and_clear_irqstatus)(void ); +void (*write_irqenable)(u64 enable);int (*request_irq)(irq_handler_t handler,void *dev_id);void (*free_irq)(void *dev_id);@@ -694,13 +685,12 @@ struct dispc_ops {const char *(*get_ovl_name)(enum omap_plane_id plane);const char *(*get_mgr_name)(enum omap_channel channel); +bool (*mgr_has_framedone)(enum omap_channel channel); +u32 (*get_memory_bandwidth_limit)(void);void (*mgr_enable)(enum omap_channel channel,bool enable);bool (*mgr_is_enabled)(enum omap_channel channel); -u32 (*mgr_get_vsync_irq)(enum omap_channel channel); -u32 (*mgr_get_framedone_irq)(enum omap_channel channel); -u32 (*mgr_get_sync_lost_irq)(enum omap_channel channel);bool (*mgr_go_busy)(enum omap_channel channel);void (*mgr_go)(enum omap_channel channel); void (*mgr_set_lcd_config)(enum omap_channel channel,drivers/gpu/drm/omapdrm/omap_crtc.c +5
-3@@ -149,7 +149,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)struct omap_crtc *omap_crtc =to_omap_crtc (crtc);enum omap_channel channel = omap_crtc->channel;struct omap_irq_wait *wait; -u32 framedone_irq, vsync_irq; +u64 vsync_irq, framedone_irq;int ret;if (WARN_ON (omap_crtc->enabled == enable))@@ -169,8 +169,10 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) omap_crtc->ignore_digit_sync_lost = true; } - framedone_irq = priv->dispc_ops->mgr_get_framedone_irq (channel); - vsync_irq = priv->dispc_ops->mgr_get_vsync_irq (channel); + + vsync_irq = (DSS_IRQ_MGR_VSYNC_EVEN (channel) | +DSS_IRQ_MGR_VSYNC_ODD (channel)); + framedone_irq =DSS_IRQ_MGR_FRAME_DONE (channel);if (enable) { wait =omap_irq_wait_init (dev, vsync_irq,1 );@@ -184,7 +186,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)* even and odd frames. */
Quoted 6 lines
drivers/gpu/drm/omapdrm/omap_crtc.c static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) · line 189
Quoted 2 lines
drivers/gpu/drm/omapdrm/omap_crtc.c +1
-1-if (framedone_irq) +if (priv->dispc_ops->mgr_has_framedone (channel))Is it valid to do
DSS_IRQ_MGR_FRAME_DONE(channel)above, even if there's no framedone irq for the channel? Well, I know it won't crash, but from code-cleanliness point of view, perhaps it's better to first check if we have a framedone, and only then get it.
Yes it is valid. Those are the generic IRQ bits, the mgr_has_framedone() just checks whether the back end can produce such and IRQ. But certainly I can remove the framedone_irq variable and use literal in omap_irq_wait_init(), if you like.
Quoted 78 lines
Quoted 78 lines
drivers/gpu/drm/omapdrm/omap_crtc.c +3
-3wait =omap_irq_wait_init (dev, framedone_irq,1 ); else wait =omap_irq_wait_init (dev, vsync_irq,2 );@@ -272,17 +274,17 @@ static void omap_crtc_dss_unregister_framedone(* Setup, Flush and Page Flip */ -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus) +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus) {struct omap_crtc *omap_crtc =to_omap_crtc (crtc);if (omap_crtc->ignore_digit_sync_lost) { - irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT ; + irqstatus &= ~DSS_IRQ_MGR_SYNC_LOST (omap_crtc->channel);if (!irqstatus)return ; } -DRM_ERROR_RATELIMITED ("%s: errors: %08x\n" , omap_crtc->name, irqstatus); +DRM_ERROR_RATELIMITED ("%s: errors: %016llx\n" , omap_crtc->name, irqstatus); }void omap_crtc_vblank_irq (struct drm_crtc *crtc)drivers/gpu/drm/omapdrm/omap_crtc.h +1
-1@@ -37,7 +37,7 @@struct drm_crtc *omap_crtc_init (struct drm_device *dev,struct drm_plane *plane,struct omap_dss_device *dssdev);int omap_crtc_wait_pending (struct drm_crtc *crtc); -void omap_crtc_error_irq (struct drm_crtc *crtc,uint32_t irqstatus); +void omap_crtc_error_irq (struct drm_crtc *crtc,u64 irqstatus);void omap_crtc_vblank_irq (struct drm_crtc *crtc);#endif /* __OMAPDRM_CRTC_H__ */ drivers/gpu/drm/omapdrm/omap_drv.h +2
-1@@ -81,7 +81,8 @@ struct omap_drm_private {/* irq handling: */ spinlock_t wait_lock;/* protects the wait_list */ struct list_head wait_list;/* list of omap_irq_wait */ -uint32_t irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_mask;/* enabled irqs in addition to wait_list */ +u64 irq_uf_mask;/* underflow irq bits for all planes */ /* memory bandwidth limit if it is needed on the platform */ unsigned int max_bandwidth;drivers/gpu/drm/omapdrm/omap_irq.c +3
-5@@ -20,25 +20,24 @@struct omap_irq_wait {struct list_head node;wait_queue_head_t wq; -uint32_t irqmask; +u64 irqmask;int count; };/* call with wait_lock and dispc runtime held */ -static void omap_irq_update (struct drm_device *dev) +static void omap_irq_full_mask (struct drm_device *dev,u64 *irqmask) {struct omap_drm_private *priv = dev->dev_private;struct omap_irq_wait *wait; -uint32_t irqmask = priv->irq_mask;assert_spin_locked (&priv->wait_lock); -list_for_each_entry (wait, &priv->wait_list, node) - irqmask |= wait->irqmask; + *irqmask = priv->irq_mask;
Quoted 8 lines
drivers/gpu/drm/omapdrm/omap_irq.c line 41
Quoted 7 lines
drivers/gpu/drm/omapdrm/omap_irq.c +3
-2-DBG ("irqmask=%08x" , irqmask); +list_for_each_entry (wait, &priv->wait_list, node) + *irqmask |= wait->irqmask; - priv->dispc_ops->write_irqenable (irqmask); +DBG ("irqmask 0x%016llx" , *irqmask); }Wouldn't it make more sense for
omap_irq_full_mask()to return the mask?
Yes it would. I'll change that.
Quoted 2 lines
Tomi
Signature · 8 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 3/3] drm/omap: Make omapdss API more generic
Quoted 28 lines · Jyri Sarha
Argh, sorry I forgot about these in the previous post. (And the comment for "drm/omap: Fail probe if irq registration fails").
Quoted 8 lines · Tomi Valkeinen
Quoted 7 lines · Jyri Sarha
The new omapdss API is HW independent and cleans up some of the DSS5 specific hacks from the omapdrm side and gets rid off the DSS5 IRQ register bits and replace them with HW independent generic u64 based macros. The new macros make it more straight forward to implement the IRQ code for the future DSS versions that do not share the same register structure as DSS2 to DSS5 has.
Quoted 5 lines
Quoted 1 line
Signed-off-by Jyri Sarha <[email protected]><snip>
Can you add a comment here that describes the layout of the u64 irq bits container.
Would this do:
/*
* Based on the above 2 defines the bellow defines describe following
* u64 IRQ bits:
* bit group |dev |mrg0|mrg1|mrg2|mrg3|mrg4|mrg5|mrg6|mrg7| olv0-7|<unused> | * bit use |D |FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|FEOL|UUUU|UUUU| | | | | | * bit number|0-3 |4-7 |8-11| 12-35 | 36-43 | 44-63 |
Quoted 5 lines
*
* device bits: D = OCP error
* mgr bits: F = frame done, E = vsync even, O = vsync odd,
* ovl bits: U = fifo underflow
*/
I think it would be enough just saying that first 4 bits are reserved for generic irqs, then 8 managers each with 4 bits, and then 8 overlays with 1 bit. The defines below are readable, but if there's a comment with a hint on how to decipher them, everything becomes much clearer.
But now that you already wrote a full description, it's fine =). Although more work to change it later.
Quoted 88 lines
Quoted 81 lines
Quoted 81 lines
drivers/gpu/drm/omapdrm/dss/omapdss.h +24
-6+#define DSS_IRQ_DEVICE_OCP_ERR BIT_ULL(0) + +#define DSS_IRQ_MGR_BIT_N (ch, bit) (4 + 4 * ch + bit) +#define DSS_IRQ_OVL_BIT_N (ovl, bit) \ + (DSS_IRQ_MGR_BIT_N(DSS_MAX_CHANNELS, 0) + 1 * ovl + bit) + +#define DSS_IRQ_MGR_BIT (ch, bit) BIT_ULL(DSS_IRQ_MGR_BIT_N(ch, bit)) +#define DSS_IRQ_OVL_BIT (ovl, bit) BIT_ULL(DSS_IRQ_OVL_BIT_N(ovl, bit)) + +#define DSS_IRQ_MGR_MASK (ch) \ + GENMASK_ULL(DSS_IRQ_MGR_BIT_N(ch, 3), DSS_IRQ_MGR_BIT_N(ch, 0)) +#define DSS_IRQ_OVL_MASK (ovl) \ + GENMASK_ULL(DSS_IRQ_OVL_BIT_N(ovl, 0), DSS_IRQ_OVL_BIT_N(ovl, 0)) + +#define DSS_IRQ_MGR_FRAME_DONE (ch) DSS_IRQ_MGR_BIT(ch, 0) +#define DSS_IRQ_MGR_VSYNC_EVEN (ch) DSS_IRQ_MGR_BIT(ch, 1) +#define DSS_IRQ_MGR_VSYNC_ODD (ch) DSS_IRQ_MGR_BIT(ch, 2) +#define DSS_IRQ_MGR_SYNC_LOST (ch) DSS_IRQ_MGR_BIT(ch, 3) + +#define DSS_IRQ_OVL_FIFO_UNDERFLOW (ovl) DSS_IRQ_OVL_BIT(ovl, 0)struct omap_dss_device ;struct dss_lcd_mgr_config ;@@ -678,9 +670,8 @@ void dss_mgr_unregister_framedone_handler(enum omap_channel channel,/* dispc ops */ struct dispc_ops { -u32 (*read_irqstatus)(void ); -void (*clear_irqstatus)(u32 mask); -void (*write_irqenable)(u32 mask); +u64 (*read_and_clear_irqstatus)(void ); +void (*write_irqenable)(u64 enable);int (*request_irq)(irq_handler_t handler,void *dev_id);void (*free_irq)(void *dev_id);@@ -694,13 +685,12 @@ struct dispc_ops {const char *(*get_ovl_name)(enum omap_plane_id plane);const char *(*get_mgr_name)(enum omap_channel channel); +bool (*mgr_has_framedone)(enum omap_channel channel); +u32 (*get_memory_bandwidth_limit)(void);void (*mgr_enable)(enum omap_channel channel,bool enable);bool (*mgr_is_enabled)(enum omap_channel channel); -u32 (*mgr_get_vsync_irq)(enum omap_channel channel); -u32 (*mgr_get_framedone_irq)(enum omap_channel channel); -u32 (*mgr_get_sync_lost_irq)(enum omap_channel channel);bool (*mgr_go_busy)(enum omap_channel channel);void (*mgr_go)(enum omap_channel channel); void (*mgr_set_lcd_config)(enum omap_channel channel,drivers/gpu/drm/omapdrm/omap_crtc.c +5
-3@@ -149,7 +149,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)struct omap_crtc *omap_crtc =to_omap_crtc (crtc);enum omap_channel channel = omap_crtc->channel;struct omap_irq_wait *wait; -u32 framedone_irq, vsync_irq; +u64 vsync_irq, framedone_irq;int ret;if (WARN_ON (omap_crtc->enabled == enable))@@ -169,8 +169,10 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) omap_crtc->ignore_digit_sync_lost = true; } - framedone_irq = priv->dispc_ops->mgr_get_framedone_irq (channel); - vsync_irq = priv->dispc_ops->mgr_get_vsync_irq (channel); + + vsync_irq = (DSS_IRQ_MGR_VSYNC_EVEN (channel) | +DSS_IRQ_MGR_VSYNC_ODD (channel)); + framedone_irq =DSS_IRQ_MGR_FRAME_DONE (channel);if (enable) { wait =omap_irq_wait_init (dev, vsync_irq,1 );@@ -184,7 +186,7 @@ static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)* even and odd frames. */ Quoted 6 lines
drivers/gpu/drm/omapdrm/omap_crtc.c static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable) · line 189
Quoted 2 lines
drivers/gpu/drm/omapdrm/omap_crtc.c +1
-1-if (framedone_irq) +if (priv->dispc_ops->mgr_has_framedone (channel))Is it valid to do
DSS_IRQ_MGR_FRAME_DONE(channel)above, even if there's no framedone irq for the channel? Well, I know it won't crash, but from code-cleanliness point of view, perhaps it's better to first check if we have a framedone, and only then get it.
Quoted 4 lines
Yes it is valid. Those are the generic IRQ bits, the
mgr_has_framedone()just checks whether the back end can produce such and IRQ. But certainly I can remove theframedone_irqvariable and use literal inomap_irq_wait_init(), if you like.
Ok. Yes, I think it's ok as it is. Or, well, I think framedone_irq variable is only used once, so... perhaps the whole variable can be dropped.
Tomi
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel