net: stmmac: Coalesce and tail addr fixes
Subsystems (4)
cover net: stmmac: Coalesce and tail addr fixes
The fix for coalesce timer and a fix in tail address setting that impacts XGMAC2 operation.
Jose Abreu (2):
net: stmmac: Rework coalesce timer and fix multi-queue races
net: stmmac: Fixup the tail addr setting in xmit path
drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 182 +++++++++++++++------- 3 files changed, 129 insertions(+), 64 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 net: stmmac: Rework coalesce timer and fix multi-queue races
This follows David Miller advice and tries to fix coalesce timer in multi-queue scenarios.
We are now using per-queue coalesce values and per-queue TX timer.
Coalesce timer default values was changed to 1ms and the coalesce frames to 25.
Tested in B2B setup between XGMAC2 and GMAC5.
---
Jerome,
Can I have your Tested-by in this patch?
Thanks and Best Regards,
Jose Miguel Abreu
--- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 177 +++++++++++++++------- 3 files changed, 126 insertions(+), 62 deletions(-)
drivers/net/ethernet/stmicro/stmmac/common.h +2 -2
@@ -258,10 +258,10 @@ struct stmmac_safety_stats {#define MAX_DMA_RIWT 0xff#define MIN_DMA_RIWT 0x20/* Tx coalesce parameters */ -#define STMMAC_COAL_TX_TIMER 40000 +#define STMMAC_COAL_TX_TIMER 1000#define STMMAC_MAX_COAL_TX_TICK 100000#define STMMAC_TX_MAX_FRAMES 256 -#define STMMAC_TX_FRAMES 64 +#define STMMAC_TX_FRAMES 25/* Packets types */ enum packets_types {
drivers/net/ethernet/stmicro/stmmac/stmmac.h +4 -3
@@ -48,6 +48,9 @@ struct stmmac_tx_info {/* Frequently used values are kept adjacent for cache effect */ struct stmmac_tx_queue { +u32 tx_count_frames; +int tx_timer_active; +struct timer_list txtimer;u32 queue_index;struct stmmac_priv *priv_data;struct dma_extended_desc *dma_etx____cacheline_aligned_in_smp ;
@@ -59,6 +62,7 @@ struct stmmac_tx_queue {dma_addr_t dma_tx_phy;u32 tx_tail_addr;u32 mss; +struct napi_struct napi____cacheline_aligned_in_smp ; };struct stmmac_rx_queue {
@@ -109,15 +113,12 @@ struct stmmac_pps_cfg {struct stmmac_priv {/* Frequently used values are kept adjacent for cache effect */ -u32 tx_count_frames;u32 tx_coal_frames;u32 tx_coal_timer; -bool tx_timer_armed;int tx_coalesce;int hwts_tx_en;bool tx_path_in_lpi_mode; -struct timer_list txtimer;bool tso;unsigned int dma_buf_sz;
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +120 -57
363 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Quoted 17 lines · Jose Abreu
This follows David Miller advice and tries to fix coalesce timer in multi-queue scenarios.
We are now using per-queue coalesce values and per-queue TX timer.
Coalesce timer default values was changed to 1ms and the coalesce frames to 25.
Tested in B2B setup between XGMAC2 and GMAC5.
Signed-off-by Jose Abreu <[email protected]>Cc Jerome Brunet <[email protected]>Cc Martin Blumenstingl <[email protected]>Cc David S. Miller <[email protected]>Cc Joao Pinto <[email protected]>Cc Giuseppe Cavallaro <[email protected]>Cc Alexandre Torgue <[email protected]>
Quoted 4 lines
---
Jerome,Can I have your Tested-by in this patch?
You had it on what you sent in the RFT, but this different.
Like with the RFT, the network breakdown we had is no longer reproduced. However this patch wreck the Rx throughput (680MBps -> 35MBps)
BTW, this patch and the RFT assume that 4ae0169fd1b3 ("net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit") is still applied but I believe David reverted the patch.
If you still need this change, you should include it back in your changeset.
Quoted 8 lines
Thanks and Best Regards,
Jose Miguel Abreu--- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 177 +++++++++++++++------- 3 files changed, 126 insertions(+), 62 deletions(-)
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Quoted 2 lines · Jerome Brunet
You had it on what you sent in the RFT, but this different.
Yeah, I had to fix the logic where tx queues != rx queues...
Quoted 3 lines
Like with the RFT, the network breakdown we had is no longer reproduced. However this patch wreck the Rx throughput (680MBps -> 35MBps)
Damn, thats low. And I cant reproduce it here :/
Strange because I barely messed around with RX path...
Can you try attached patch in top of this one please?
Quoted 6 lines
BTW, this patch and the RFT assume that
4ae0169fd1b3("net: stmmac: Do not keep rearming the coalesce timer instmmac_xmit") is still applied but I believe David reverted the patch.If you still need this change, you should include it back in your changeset.
Yes I know it was reverted but -net was not merged into -next yet...
Thanks and Best Regards,
Jose Miguel Abreu
Quoted 9 lines
Quoted 8 lines
Thanks and Best Regards,
Jose Miguel Abreu--- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 177 +++++++++++++++------- 3 files changed, 126 insertions(+), 62 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 -3
@@ -2247,10 +2247,8 @@ static void stmmac_tx_timer(struct timer_list *t)struct stmmac_tx_queue *tx_q =from_timer (tx_q, t, txtimer);struct stmmac_priv *priv = tx_q->priv_data; -if (napi_schedule_prep (&tx_q->napi)) { -stmmac_disable_dma_irq (priv, priv->ioaddr, tx_q->queue_index); +if (napi_schedule_prep (&tx_q->napi))__napi_schedule (&tx_q->napi); - } tx_q->tx_timer_active =0 ; }
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Quoted 7 lines · Jose Abreu
Quoted 2 lines · Jerome Brunet
You had it on what you sent in the RFT, but this different.
Yeah, I had to fix the logic where tx queues != rx queues...
Quoted 1 line
Quoted 8 lines
Quoted 2 lines
Like with the RFT, the network breakdown we had is no longer reproduced. However this patch wreck the Rx throughput (680MBps -> 35MBps)
Damn, thats low. And I cant reproduce it here :/
Strange because I barely messed around with RX path...
Can you try attached patch in top of this one please?
Situation is even worse with this.
I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt anymore. Looks like a the same kind of network breakdown we had previously
Quoted 23 lines
Quoted 7 lines
BTW, this patch and the RFT assume that
4ae0169fd1b3("net: stmmac: Do not keep rearming the coalesce timer instmmac_xmit") is still applied but I believe David reverted the patch.If you still need this change, you should include it back in your changeset.
Yes I know it was reverted but -net was not merged into -next yet...
Thanks and Best Regards,
Jose Miguel AbreuQuoted 8 lines
Quoted 8 lines
Thanks and Best Regards,
Jose Miguel Abreu--- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 177 +++++++++++++++------- 3 files changed, 126 insertions(+), 62 deletions(-)
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Hi Jerome,
Quoted 5 lines · Jerome Brunet
Situation is even worse with this.
I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt anymore. Looks like a the same kind of network breakdown we had previously
I was able to reproduce your problem and the attached fixup patch fixed it up for me. Can you please try?
Thanks and Best Regards,
Jose Miguel Abreu
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +12 -12
@@ -1861,14 +1861,14 @@ static int stmmac_tx_clean(struct stmmac_priv *priv, int limit, u32 queue) {struct stmmac_tx_queue *tx_q = &priv->tx_queue[queue];unsigned int bytes_compl =0 , pkts_compl =0 ; -unsigned int entry, count =0 ; +unsigned int entry;netif_tx_lock (priv->dev); priv->xstats.tx_clean++; entry = tx_q->dirty_tx; -while ((entry != tx_q->cur_tx) && (count < limit)) { +while ((entry != tx_q->cur_tx) && (pkts_compl < limit)) {struct sk_buff *skb = tx_q->tx_skbuff[entry];struct dma_desc *p;int status;
@@ -1884,8 +1884,6 @@ static int stmmac_tx_clean(struct stmmac_priv *priv, int limit, u32 queue)if (unlikely (status & tx_dma_own))break ; - count++; -/* Make sure descriptor fields are read after reading * the own bit. */
@@ -1955,7 +1953,7 @@ static int stmmac_tx_clean(struct stmmac_priv *priv, int limit, u32 queue) }netif_tx_unlock (priv->dev); -return count; +return pkts_compl; }/**
@@ -2072,8 +2070,11 @@ static void stmmac_dma_interrupt(struct stmmac_priv *priv)if (likely (status[chan] & handle_rx)) {struct stmmac_rx_queue *rx_q = &priv->rx_queue[chan]; -if (likely (napi_schedule_prep (&rx_q->napi))) +if (likely (napi_schedule_prep (&rx_q->napi))) { +stmmac_disable_dma_irq (priv, priv->ioaddr, + rx_q->queue_index);__napi_schedule (&rx_q->napi); + } } }
@@ -2085,8 +2086,11 @@ static void stmmac_dma_interrupt(struct stmmac_priv *priv)if (status[chan] & handle_tx) {struct stmmac_tx_queue *tx_q = &priv->tx_queue[chan]; -if (likely (napi_schedule_prep (&tx_q->napi))) +if (likely (napi_schedule_prep (&tx_q->napi))) { +stmmac_disable_dma_irq (priv, priv->ioaddr, + tx_q->queue_index);__napi_schedule (&tx_q->napi); + } } }
@@ -2247,11 +2251,7 @@ static void stmmac_tx_timer(struct timer_list *t)struct stmmac_tx_queue *tx_q =from_timer (tx_q, t, txtimer);struct stmmac_priv *priv = tx_q->priv_data; -if (napi_schedule_prep (&tx_q->napi)) { -stmmac_disable_dma_irq (priv, priv->ioaddr, tx_q->queue_index); -__napi_schedule (&tx_q->napi); - } - +stmmac_tx_clean (priv, ~0 , tx_q->queue_index); tx_q->tx_timer_active =0 ; }
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Quoted 11 lines · Jose Abreu
Hi Jerome,
Quoted 5 lines · Jerome Brunet
Situation is even worse with this.
I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt anymore. Looks like a the same kind of network breakdown we had previouslyI was able to reproduce your problem and the attached fixup patch fixed it up for me. Can you please try?
I suppose this applies on top the initial patch, not the previous fixup (judging from the rejection) Could you details the baseline for each patch you send, its not easy to follow.
BTW, there something weird (at least for me) with the patch you attach. git always refuse to apply them and even patch complains:
git apply fixup2.patch
error: patch failed: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1861
error: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: patch does not apply
patch -p1 < fixup2.patch
(Stripping trailing CRs from patch; use --binary to disable.) patching file drivers/net/ethernet/stmicro/stmmac/stmmac_main.c Hunk #6 succeeded at 2252 (offset 1 line).
patch unexpectedly ends in middle of line
patch unexpectedly ends in middle of line
Anyway, with this second fixup, I'm back to square one:
I can boot but iperf3 won't hold for long
# iperf3 -c 10.1.2.124 -p 12345 -t 600 Connecting to host 10.1.2.124, port 12345 [ 4] local 10.1.4.59 port 38650 connected to 10.1.2.124 port 12345 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 80.8 MBytes 678 Mbits/sec 1 300 KBytes [ 4] 1.00-2.00 sec 81.1 MBytes 680 Mbits/sec 0 329 KBytes [ 4] 2.00-3.00 sec 80.7 MBytes 677 Mbits/sec 0 335 KBytes [ 4] 3.00-4.00 sec 81.7 MBytes 685 Mbits/sec 0 337 KBytes [ 4] 4.00-5.00 sec 81.0 MBytes 680 Mbits/sec 0 341 KBytes [ 4] 5.00-6.00 sec 81.0 MBytes 680 Mbits/sec 0 344 KBytes [ 4] 6.00-7.00 sec 80.7 MBytes 677 Mbits/sec 0 345 KBytes [ 4] 7.00-8.00 sec 81.5 MBytes 684 Mbits/sec 0 346 KBytes [ 4] 8.00-9.00 sec 81.2 MBytes 680 Mbits/sec 0 348 KBytes [ 4] 9.00-10.00 sec 5.59 MBytes 46.9 Mbits/sec 2 1.41 KBytes [ 4] 10.00-11.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 11.00-12.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 12.00-13.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 13.00-14.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
Quoted 3 lines
Thanks and Best Regards,
Jose Miguel Abreu
Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races
Hi Jerome,
Quoted 21 lines · Jerome Brunet
Quoted 9 lines · Jose Abreu
Hi Jerome,
Quoted 4 lines · Jerome Brunet
Situation is even worse with this.
I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt anymore. Looks like a the same kind of network breakdown we had previouslyI was able to reproduce your problem and the attached fixup patch fixed it up for me. Can you please try?
I suppose this applies on top the initial patch, not the previous fixup (judging from the rejection) Could you details the baseline for each patch you send, its not easy to follow.
BTW, there something weird (at least for me) with the patch you attach. git always refuse to apply them and even patch complains:
git apply fixup2.patch
error: patch failed:drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1861
error:drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: patch does not apply
Quoted 6 lines
patch -p1 < fixup2.patch
(Stripping trailing CRs from patch; use --binary to disable.) patching filedrivers/net/ethernet/stmicro/stmmac/stmmac_main.cHunk #6 succeeded at 2252 (offset 1 line).
patch unexpectedly ends in middle of line
patch unexpectedly ends in middle of line
I just do "git diff <file> > out.patch". Maybe not the best thing to do then.
Quoted 15 lines
Anyway, with this second fixup, I'm back to square one:
I can boot but iperf3 won't hold for long# iperf3 -c 10.1.2.124 -p 12345 -t 600 Connecting to host 10.1.2.124, port 12345 [ 4] local 10.1.4.59 port 38650 connected to 10.1.2.124 port 12345 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.00 sec 80.8 MBytes 678 Mbits/sec 1 300 KBytes [ 4] 1.00-2.00 sec 81.1 MBytes 680 Mbits/sec 0 329 KBytes [ 4] 2.00-3.00 sec 80.7 MBytes 677 Mbits/sec 0 335 KBytes [ 4] 3.00-4.00 sec 81.7 MBytes 685 Mbits/sec 0 337 KBytes [ 4] 4.00-5.00 sec 81.0 MBytes 680 Mbits/sec 0 341 KBytes [ 4] 5.00-6.00 sec 81.0 MBytes 680 Mbits/sec 0 344 KBytes
Quoted 8 lines
[ 4] 6.00-7.00 sec 80.7 MBytes 677 Mbits/sec 0 345 KBytes [ 4] 7.00-8.00 sec 81.5 MBytes 684 Mbits/sec 0 346 KBytes [ 4] 8.00-9.00 sec 81.2 MBytes 680 Mbits/sec 0 348 KBytes [ 4] 9.00-10.00 sec 5.59 MBytes 46.9 Mbits/sec 2 1.41 KBytes [ 4] 10.00-11.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 11.00-12.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes [ 4] 12.00-13.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes [ 4] 13.00-14.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
Okay, so this is odd because I now have a similar setup as yours and is working perfectly fine:
---
# dmesg | grep -i stmmac stmmaceth f0008000.ethernet: PTP uses main clock stmmaceth f0008000.ethernet: User ID: 0x10, Synopsys ID: 0x37 stmmaceth f0008000.ethernet: DWMAC1000 stmmaceth f0008000.ethernet: DMA HW capability register supported stmmaceth f0008000.ethernet: RX Checksum Offload Engine supported stmmaceth f0008000.ethernet: COE Type 2 stmmaceth f0008000.ethernet: TX Checksum insertion supported stmmaceth f0008000.ethernet: Normal descriptors stmmaceth f0008000.ethernet: Ring mode enabled stmmaceth f0008000.ethernet: Enable RX Mitigation via HW Watchdog Timer libphy: stmmac: probed stmmaceth f0008000.ethernet eth0: device MAC address 0e:67:f6:6c:59:c6 Micrel KSZ9031 Gigabit PHY stmmac-0:00: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0008000.ethernet eth0: No Safety Features support found stmmaceth f0008000.ethernet eth0: PTP not supported by HW stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off stmmaceth f0008000.ethernet eth0: Link is Down stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
---
# iperf3 -c 192.168.0.3 -t 600 Connecting to host 192.168.0.3, port 5201 [ 4] local 192.168.0.1 port 46796 connected to 192.168.0.3 port 5201 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.01 sec 101 MBytes 841 Mbits/sec 1 467 KBytes [ 4] 1.01-2.00 sec 112 MBytes 945 Mbits/sec 0 475 KBytes [ 4] 2.00-3.01 sec 114 MBytes 947 Mbits/sec 0 481 KBytes [ 4] 3.01-4.00 sec 112 MBytes 945 Mbits/sec 0 486 KBytes [ 4] 4.00-5.00 sec 113 MBytes 947 Mbits/sec 0 506 KBytes [ 4] 5.00-6.01 sec 113 MBytes 947 Mbits/sec 0 520 KBytes [ 4] 6.01-7.00 sec 112 MBytes 950 Mbits/sec 0 625 KBytes [ 4] 7.00-8.01 sec 114 MBytes 948 Mbits/sec 0 625 KBytes [ 4] 8.01-9.00 sec 112 MBytes 948 Mbits/sec 0 625 KBytes [ 4] 9.00-10.00 sec 114 MBytes 955 Mbits/sec 0 998 KBytes [ 4] 10.00-11.01 sec 114 MBytes 949 Mbits/sec 0 998 KBytes [ 4] 11.01-12.00 sec 113 MBytes 949 Mbits/sec 0 998 KBytes [ 4] 12.00-13.00 sec 114 MBytes 954 Mbits/sec 0 998 KBytes [ 4] 13.00-14.00 sec 114 MBytes 950 Mbits/sec 0 998 KBytes [ 4] 14.00-15.01 sec 114 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 15.01-16.00 sec 113 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 16.00-17.00 sec 114 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 17.00-18.01 sec 114 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 18.01-19.00 sec 113 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 19.00-20.00 sec 114 MBytes 951 Mbits/sec 0 998 KBytes [ 4] 20.00-21.00 sec 112 MBytes 947 Mbits/sec 0 998 KBytes
[ And just keeps going on ]
---
Note that although the User ID is not the same (0x10 vs 0x11) the callbacks and the sw flow is the same, there are no differences regarding User ID in stmmac driver, only the Synopsys ID is used.
Maybe some feature is not enabled in your HW ?
Thanks and Best Regards,
Jose Miguel Abreu
Quoted 5 lines
Quoted 4 lines
Thanks and Best Regards,
Jose Miguel Abreu
PATCH 2/2 net: stmmac: Fixup the tail addr setting in xmit path
In reply to Jose AbreuCurrently we are always setting the tail address of descriptor list to the end of the pre-allocated list.
According to databook this is not correct. Tail address should point to the last available descriptor + 1, which means we have to update the tail address everytime we call the xmit function.
This should make no impact in older versions of MAC but in newer versions there are some DMA features which allows the IP to fetch descriptors in advance and in a non sequential order so its critical that we set the tail address correctly.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +3 -2
@@ -2224,8 +2224,7 @@ static int stmmac_init_dma_engine(struct stmmac_priv *priv)stmmac_init_tx_chan (priv, priv->ioaddr, priv->plat->dma_cfg, tx_q->dma_tx_phy, chan); - tx_q->tx_tail_addr = tx_q->dma_tx_phy + - (DMA_TX_SIZE *sizeof (struct dma_desc )); + tx_q->tx_tail_addr = tx_q->dma_tx_phy;stmmac_set_tx_tail_ptr (priv, priv->ioaddr, tx_q->tx_tail_addr, chan); }
@@ -3015,6 +3014,7 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)netdev_tx_sent_queue (netdev_get_tx_queue (dev, queue), skb->len); + tx_q->tx_tail_addr = tx_q->dma_tx_phy + (tx_q->cur_tx *sizeof (*desc));stmmac_set_tx_tail_ptr (priv, priv->ioaddr, tx_q->tx_tail_addr, queue);if (priv->tx_coal_timer && !tx_q->tx_timer_active) {
@@ -3235,6 +3235,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)stmmac_enable_dma_transmission (priv, priv->ioaddr); + tx_q->tx_tail_addr = tx_q->dma_tx_phy + (tx_q->cur_tx *sizeof (*desc));stmmac_set_tx_tail_ptr (priv, priv->ioaddr, tx_q->tx_tail_addr, queue);if (priv->tx_coal_timer && !tx_q->tx_timer_active) {
Signature · 1 line
2.7.4