Skip to contentSkip to conversation

staging: vboxvideo: Remove chekpatch issues

PATCH Superseded Shayenne da Luz Moura 2 participants 2 messages Oct 25, 2018 – Oct 26, 2018

lore
Share & tools
lore
#0 lore raw

cover staging: vboxvideo: Remove chekpatch issues

This series cleans the following checkpatch.pl issues:

CHECK: Prefer kernel type 'u32' over 'uint32_t'
CHECK: Avoid using bool structure members because of possible alignment issues

Shayenne da Luz Moura (2):
staging: vboxvideo: Change uint32_t to u32
staging: vboxvideo: Use unsigned int instead bool

 drivers/staging/vboxvideo/vbox_drv.h        | 14 +++++++-------
 drivers/staging/vboxvideo/vbox_mode.c       |  2 +-
 drivers/staging/vboxvideo/vboxvideo_guest.h |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.19.1
#1 lore raw

Hi,

Quoted 8 lines · Shayenne da Luz Moura

This series cleans the following checkpatch.pl issues:

CHECK: Prefer kernel type 'u32' over 'uint32_t'
CHECK: Avoid using bool structure members because of possible alignment issues

Shayenne da Luz Moura (2):
staging: vboxvideo: Change uint32_t to u32
staging: vboxvideo: Use unsigned int instead bool

Why am I receiving only the cover letter of this series? Please resend so that I get all the patches.

Also at least the first patch is wrong, the drm headers use uint32_t in the prototype definition of the callback functions we are defining, so the vboxvideo code should use the same even if the compiler does not warn about the callback implementation having different parameter types in this case.

Regards,

Hans

Quoted 6 lines
  drivers/staging/vboxvideo/vbox_drv.h        | 14 +++++++-------
  drivers/staging/vboxvideo/vbox_mode.c       |  2 +-
  drivers/staging/vboxvideo/vboxvideo_guest.h |  2 +-
  3 files changed, 9 insertions(+), 9 deletions(-)