drm/tilcdc: Remove "ti, tilcdc, tfp410" and mark "ti, tilcdc, panel" obsolete
Subsystems (4)
v2 cover drm/tilcdc: Remove "ti, tilcdc, tfp410" and mark "ti, tilcdc, panel" obsolete
Since v1:
- Add Reviewed-by: Laurent Pinchart <[email protected]> to "drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver"
- Add "drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe"
Nobody should any more use the old tilcdc bundled drivers anymore. The driver is fully capable of using the generic drm bridge and panel drivers. However, the obsolete "ti,tilcdc,panel" binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around.
I'll wait with merging the "ti,tilcdc,panel" patches until these patches have been merged:
https://lists.freedesktop.org/archives/dri-devel/2019-December/247301.html
https://lists.freedesktop.org/archives/dri-devel/2019-December/247594.html
So I can refer to them as an example in the comments.
But I'll merge "drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver" trough drm-misc in couple days if I do not hear any objections.
Jyri Sarha (3):
drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver
dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
.../bindings/display/tilcdc/panel.txt | 6 + .../bindings/display/tilcdc/tfp410.txt | 21 - drivers/gpu/drm/tilcdc/Makefile | 1 - drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 - drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 + drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 379 ------------------ drivers/gpu/drm/tilcdc/tilcdc_tfp410.h | 15 - 7 files changed, 16 insertions(+), 419 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/tilcdc/tfp410.txt delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.h
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/3 drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver
Remove obsolete bundled tfp410 driver with its "ti,tilcdc,tfp410" devicetree binding. No platform has ever used this driver in the mainline kernel and if anybody connects tfp410 to tilcdc he or she should use the generic drm tfp410 bridge driver.
--- .../bindings/display/tilcdc/tfp410.txt | 21 - drivers/gpu/drm/tilcdc/Makefile | 1 - drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 - drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 379 ------------------ drivers/gpu/drm/tilcdc/tilcdc_tfp410.h | 15 - 5 files changed, 419 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/tilcdc/tfp410.txt delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.h
Documentation/devicetree/bindings/display/tilcdc/tfp410.txt deleted +0 -21
@@ -1,21 +0,0 @@ -Device-Tree bindings for tilcdc DRM TFP410 output driver - -Required properties: - - compatible: value should be "ti,tilcdc,tfp410". - - i2c: the phandle for the i2c device to use for DDC - -Recommended properties: - - pinctrl-names, pinctrl-0: the pincontrol settings to configure - muxing properly for pins that connect to TFP410 device - - powerdn-gpio: the powerdown GPIO, pulled low to power down the - TFP410 device (for DPMS_OFF) - -Example: - - dvicape { - compatible = "ti,tilcdc,tfp410"; - i2c = <&i2c2>; - pinctrl-names = "default"; - pinctrl-0 = <&bone_dvi_cape_dvi_00A1_pins>; - powerdn-gpio = <&gpio2 31 0>; - };
drivers/gpu/drm/tilcdc/Makefile +0 -1
@@ -6,7 +6,6 @@ endif tilcdc-y := \ tilcdc_plane.o \ tilcdc_crtc.o \ - tilcdc_tfp410.o \ tilcdc_panel.o \ tilcdc_external.o \ tilcdc_drv.o
drivers/gpu/drm/tilcdc/tilcdc_drv.c +0 -3
@@ -30,7 +30,6 @@#include "tilcdc_external.h" #include "tilcdc_panel.h" #include "tilcdc_regs.h" -#include "tilcdc_tfp410.h" static LIST_HEAD (module_list);
@@ -649,7 +648,6 @@ static struct platform_driver tilcdc_platform_driver = {static int __init tilcdc_drm_init (void ) {DBG ("init" ); -tilcdc_tfp410_init ();tilcdc_panel_init ();return platform_driver_register (&tilcdc_platform_driver); }
@@ -659,7 +657,6 @@ static void __exit tilcdc_drm_fini(void)DBG ("fini" );platform_driver_unregister (&tilcdc_platform_driver);tilcdc_panel_fini (); -tilcdc_tfp410_fini (); }module_init (tilcdc_drm_init);
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c deleted +0 -379
379 lines not on this page · raw message
drivers/gpu/drm/tilcdc/tilcdc_tfp410.h deleted +0 -15
@@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* -* Copyright (C) 2012 Texas Instruments -* Author: Rob Clark <[email protected]> -*/ - -#ifndef __TILCDC_TFP410_H__ -#define __TILCDC_TFP410_H__ - -/* sub-module for tfp410 dvi adaptor */ - -int tilcdc_tfp410_init (void ); -void tilcdc_tfp410_fini (void ); - -#endif /* __TILCDC_TFP410_H__ */
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/3 dt-bindings: display: Add obsolete note to "ti, tilcdc, panel" binding
In reply to Jyri SarhaThe "ti,tilcdc,panel" binding should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding. However, the obsolete binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around.
--- Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/tilcdc/panel.txt +6 -0
@@ -1,5 +1,11 @@ Device-Tree bindings for tilcdc DRM generic panel output driver +NOTE: This binding (and the related driver) is obsolete and should not + be used anymore. Please refer to drm panel-common binding (and + to a generic drm panel driver like panel-simple). + Documentation/devicetree/bindings/display/panel/panel-common.yaml + (drivers/gpu/drm/panel/panel-simple.c) + Required properties: - compatible: value should be "ti,tilcdc,panel". - panel-info: configuration info to configure LCDC correctly for the panel
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 3/3 drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
In reply to Jyri SarhaAdd WARN() to the beginnig of tilcdc-panel probe. The obsolete tilcdc-panel driver should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding.
--- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/tilcdc/tilcdc_panel.c +10 -0
@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)struct pinctrl *pinctrl;int ret; +/* +* The obsolete tilcdc-panel driver should not be used +* anymore, since tilcdc is fully capable of using generic drm +* panels like panel-simple and panel-common binding. +*/ + +WARN (true, +"tilcdc-panel is obsolte and should not be used. Please update your configuration!\n" , +dev_name (&pdev->dev)); +/* bail out early if no DT data: */ if (!node) {dev_err (&pdev->dev,"device-tree data is missing\n" );
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
Hi Jyri,
Thank you for the patch.
Quoted 1 line · Jyri Sarha
Add
WARN()to the beginnig of tilcdc-panel probe. The obsolete
s/beginnig/beginning/
Quoted 14 lines
tilcdc-panel driver should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding.
Signed-off-by Jyri Sarha <[email protected]>--- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/gpu/drm/tilcdc/tilcdc_panel.c +0
-0
drivers/gpu/drm/tilcdc/tilcdc_panel.c static int panel_probe(struct platform_device *pdev) · line 315
Quoted 7 lines
drivers/gpu/drm/tilcdc/tilcdc_panel.c +4
-0@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)struct pinctrl *pinctrl;int ret; +/* +* The obsolete tilcdc-panel driver should not be used +* anymore, since tilcdc is fully capable of using generic drm +* panels like panel-simple and panel-common binding.
Indentation should use tabs.
drivers/gpu/drm/tilcdc/tilcdc_panel.c static int panel_probe(struct platform_device *pdev) · line 319
Quoted 4 lines
drivers/gpu/drm/tilcdc/tilcdc_panel.c +4
-0+*/ + + WARN(true, + "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
s/obsolte/obsolete/ or deprecated ?
You may want to explicitly state what it should be updated to :-)
Quoted 5 lines
drivers/gpu/drm/tilcdc/tilcdc_panel.c +2
-0+ dev_name(&pdev->dev)); +/* bail out early if no DT data: */ if (!node) {dev_err (&pdev->dev,"device-tree data is missing\n" );
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding
In reply to Jyri SarhaHi Jyri,
Thank you for the patch.
Quoted 6 lines · Jyri Sarha
The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding. However, the obsolete binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around.
But can't we drop the bindings instead of marking them as obsolete, even if we keep the driver around for some time ?
Also, would it make sense to set a date for the removal of the driver, and add it to the WARN() message in patch 3/3 ?
Quoted 21 lines
Signed-off-by Jyri Sarha <[email protected]>--- Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ 1 file changed, 6 insertions(+)Documentation/devicetree/bindings/display/tilcdc/panel.txt +6
-0@@ -1,5 +1,11 @@ Device-Tree bindings for tilcdc DRM generic panel output driver +NOTE: This binding (and the related driver) is obsolete and should not + be used anymore. Please refer to drm panel-common binding (and + to a generic drm panel driver like panel-simple). + Documentation/devicetree/bindings/display/panel/panel-common.yaml + (drivers/gpu/drm/panel/panel-simple.c) + Required properties: - compatible: value should be "ti,tilcdc,panel". - panel-info: configuration info to configure LCDC correctly for the panel
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding
Quoted 12 lines · Laurent Pinchart
Hi Jyri,
Thank you for the patch.
Quoted 6 lines · Jyri Sarha
The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding. However, the obsolete binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around.
Quoted 3 lines
But can't we drop the bindings instead of marking them as obsolete, even if we keep the driver around for some time ?
I guess that would be alright too.
Quoted 3 lines
Also, would it make sense to set a date for the removal of the driver, and add it to the
WARN()message in patch 3/3 ?
Not sure about a date. I would feel quite uncomfortable of removing the driver, while there is still mainline DTSes using "ti,tilcdc,panel". I guess the next step would be putting the legacy panel driver behind a default = N config option. Then I would probably hear something if there are people actively using those DTSes. Maybe the date could be about that too.
BR,
Jyri
Quoted 22 lines
Quoted 21 lines
Signed-off-by Jyri Sarha <[email protected]>--- Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ 1 file changed, 6 insertions(+)Documentation/devicetree/bindings/display/tilcdc/panel.txt +6
-0@@ -1,5 +1,11 @@ Device-Tree bindings for tilcdc DRM generic panel output driver +NOTE: This binding (and the related driver) is obsolete and should not + be used anymore. Please refer to drm panel-common binding (and + to a generic drm panel driver like panel-simple). + Documentation/devicetree/bindings/display/panel/panel-common.yaml + (drivers/gpu/drm/panel/panel-simple.c) + Required properties: - compatible: value should be "ti,tilcdc,panel". - panel-info: configuration info to configure LCDC correctly for the panel
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Re: [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding
Hi Jyri,
Quoted 19 lines · Jyri Sarha
Quoted 11 lines · Laurent Pinchart
Quoted 6 lines · Jyri Sarha
The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding. However, the obsolete binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around.
But can't we drop the bindings instead of marking them as obsolete, even if we keep the driver around for some time ?
I guess that would be alright too.
Quoted 3 lines
Also, would it make sense to set a date for the removal of the driver, and add it to the
WARN()message in patch 3/3 ?
Quoted 6 lines
Not sure about a date. I would feel quite uncomfortable of removing the driver, while there is still mainline DTSes using "ti,tilcdc,panel". I guess the next step would be putting the legacy panel driver behind a default = N config option. Then I would probably hear something if there are people actively using those DTSes. Maybe the date could be about that too.
The mainline DTSes are not really an issue, they should be fixed in mainline to use new bindings, and all will be good. The problem is systems using out-of-tree DTSes, or systems that will upgrade the kernel but not the DT.
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Signed-off-by Jyri Sarha <[email protected]>--- Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ 1 file changed, 6 insertions(+)Documentation/devicetree/bindings/display/tilcdc/panel.txt +6
-0@@ -1,5 +1,11 @@ Device-Tree bindings for tilcdc DRM generic panel output driver +NOTE: This binding (and the related driver) is obsolete and should not + be used anymore. Please refer to drm panel-common binding (and + to a generic drm panel driver like panel-simple). + Documentation/devicetree/bindings/display/panel/panel-common.yaml + (drivers/gpu/drm/panel/panel-simple.c) + Required properties: - compatible: value should be "ti,tilcdc,panel". - panel-info: configuration info to configure LCDC correctly for the panel
Signature · 3 lines
Regards, Laurent Pinchart