Skip to contentSkip to conversation

Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS.

PATCH Superseded Sam Muhammed 4 participants 19 messages Mar 24, 2020 – Mar 30, 2020 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS.

This driver has multiple WARNINGS and CHECKS, Changes been made to match coding style and standards. Modifications:
- Remove Comparison to NULL.
- Proper usage of kzalloc().
- Reformat single statement blocks.
- Including preferred header.
- Putting spaces around operators.
- Using the proper SPDK comment style.

Sam Muhammed (6):
Staging: kpc2000: kpc_dma: Remove comparison to NULL.
Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().
Staging: kpc2000: kpc_dma: Remove unnecessary braces.
Staging: kpc2000: kpc_dma: Use spaces around operators.
Staging: kpc2000: kpc_dma: Include the preferred header.
Staging: kpc2000: kpc_dma: Use the SPDK comment style.

 drivers/staging/kpc2000/kpc_dma/dma.c         |  9 ++--
 drivers/staging/kpc2000/kpc_dma/fileops.c     | 44 +++++++++----------
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  |  9 ++--
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.h  |  4 +-
 4 files changed, 31 insertions(+), 35 deletions(-)

---
2.20.1

#1 lore raw

PATCH 1/6 Staging: kpc2000: kpc_dma: Remove comparison to NULL.

Comparison to NULL been used across the driver,
remove them and use (!var) instead.

Checkpatch.pl: CHECK:
Comparison to NULL could be written "!desc"... etc

---
 drivers/staging/kpc2000/kpc_dma/dma.c            |  2 +-
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 12 ++++++------
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h |  4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/kpc2000/kpc_dma/dma.c +1 -1
index 51a4dd534a0d..4bfbc717bc07 100644
@@ -236,7 +236,7 @@ int  count_descriptors_available(struct kpc_dma_device *eng)
 	struct kpc_dma_descriptor *cur = eng->desc_next;
 
 	while (cur != eng->desc_completed) {
-		BUG_ON(cur == NULL);
+		BUG_ON(!cur);
 		count++;
 		cur = cur->Next;
 	}
drivers/staging/kpc2000/kpc_dma/fileops.c +6 -6
index 40525540dde6..5eb6c5f24feb 100644
@@ -124,7 +124,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 		pcnt = count_parts_for_sge(sg);
 		for (p = 0 ; p < pcnt ; p++) {
 			// Fill out the descriptor
-			BUG_ON(desc == NULL);
+			BUG_ON(!desc);
 			clear_desc(desc);
 			if (p != pcnt-1) {
 				desc->DescByteCount = 0x80000;
@@ -203,11 +203,11 @@ void  transfer_complete_cb(struct aio_cb_data *acd, size_t xfr_count, u32 flags)
 {
 	unsigned int i;
 
-	BUG_ON(acd == NULL);
-	BUG_ON(acd->user_pages == NULL);
-	BUG_ON(acd->sgt.sgl == NULL);
-	BUG_ON(acd->ldev == NULL);
-	BUG_ON(acd->ldev->pldev == NULL);
+	BUG_ON(!acd);
+	BUG_ON(!acd->user_pages);
+	BUG_ON(!acd->sgt.sgl);
+	BUG_ON(!acd->ldev);
+	BUG_ON(!acd->ldev->pldev);
 
 	for (i = 0 ; i < acd->page_count ; i++) {
 		if (!PageReserved(acd->user_pages[i])) {
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h +2 -2
index 4c8cc866b826..8b9c978257b9 100644
@@ -198,14 +198,14 @@ u32  GetEngineCompletePtr(struct kpc_dma_device *eng)
 static inline
 void  lock_engine(struct kpc_dma_device *eng)
 {
-	BUG_ON(eng == NULL);
+	BUG_ON(!eng);
 	mutex_lock(&eng->sem);
 }
 
 static inline
 void  unlock_engine(struct kpc_dma_device *eng)
 {
-	BUG_ON(eng == NULL);
+	BUG_ON(!eng);
 	mutex_unlock(&eng->sem);
 }
 

---
2.20.1

#2 lore raw

PATCH 2/6 Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

In reply to Sam Muhammed

Modify struct allocations in kzalloc() to match the coding standards.

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...) over kzalloc(sizeof(struct var)...)

---
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5eb6c5f24feb..21ebab7dbc7b 100644
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
 		return -EBUSY; /* already open */
 	}
 
-	priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -1
index ec79a8500caf..25ea16a1981e 100644
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
 	int rv = 0;
 	dev_t dev;
 
-	struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+	struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
 	if (!ldev) {
 		dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);

---
2.20.1

#7 lore raw

PATCH 3/6 Staging: kpc2000: kpc_dma: Remove unnecessary braces.

In reply to Sam Muhammed

Removing braces of single statement blocks,
they are not really needed.

---
 drivers/staging/kpc2000/kpc_dma/dma.c         |  5 ++---
 drivers/staging/kpc2000/kpc_dma/fileops.c     | 20 +++++++++----------
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  |  3 +--
 3 files changed, 12 insertions(+), 16 deletions(-)
drivers/staging/kpc2000/kpc_dma/dma.c +2 -3
index 4bfbc717bc07..5ccc93ed2b61 100644
@@ -97,11 +97,10 @@ int  setup_dma_engine(struct kpc_dma_device *eng, u32 desc_cnt)
 	if (WARN(!(caps & ENG_CAP_PRESENT), "%s() called for DMA Engine at %p which isn't present in hardware!\n", __func__, eng))
 		return -ENXIO;
 
-	if (caps & ENG_CAP_DIRECTION) {
+	if (caps & ENG_CAP_DIRECTION)
 		eng->dir = DMA_FROM_DEVICE;
-	} else {
+	else
 		eng->dir = DMA_TO_DEVICE;
-	}
 
 	eng->desc_pool_cnt = desc_cnt;
 	eng->desc_pool = dma_pool_create("KPC DMA Descriptors", &eng->pldev->dev, sizeof(struct kpc_dma_descriptor), DMA_DESC_ALIGNMENT, 4096);
drivers/staging/kpc2000/kpc_dma/fileops.c +9 -11
index 21ebab7dbc7b..d93097ed781c 100644
@@ -126,11 +126,11 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			// Fill out the descriptor
 			BUG_ON(!desc);
 			clear_desc(desc);
-			if (p != pcnt-1) {
+			if (p != pcnt-1)
 				desc->DescByteCount = 0x80000;
-			} else {
+			else
 				desc->DescByteCount = sg_dma_len(sg) - (p * 0x80000);
-			}
+
 			desc->DescBufferByteCount = desc->DescByteCount;
 
 			desc->DescControlFlags |= DMA_DESC_CTL_IRQONERR;
@@ -148,9 +148,9 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescSystemAddrMS = (dma_addr & 0xFFFFFFFF00000000UL) >> 32;
 
 			user_ctl = acd->priv->user_ctl;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1) {
+			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
 				user_ctl = acd->priv->user_ctl_last;
-			}
+
 			desc->DescUserControlLS = (user_ctl & 0x00000000FFFFFFFFUL) >>  0;
 			desc->DescUserControlMS = (user_ctl & 0xFFFFFFFF00000000UL) >> 32;
 
@@ -188,9 +188,9 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 	sg_free_table(&acd->sgt);
  err_dma_map_sg:
  err_alloc_sg_table:
-	for (i = 0 ; i < acd->page_count ; i++) {
+	for (i = 0 ; i < acd->page_count ; i++)
 		put_page(acd->user_pages[i]);
-	}
+
  err_get_user_pages:
 	kfree(acd->user_pages);
  err_alloc_userpages:
@@ -210,16 +210,14 @@ void  transfer_complete_cb(struct aio_cb_data *acd, size_t xfr_count, u32 flags)
 	BUG_ON(!acd->ldev->pldev);
 
 	for (i = 0 ; i < acd->page_count ; i++) {
-		if (!PageReserved(acd->user_pages[i])) {
+		if (!PageReserved(acd->user_pages[i]))
 			set_page_dirty(acd->user_pages[i]);
-		}
 	}
 
 	dma_unmap_sg(&acd->ldev->pldev->dev, acd->sgt.sgl, acd->sgt.nents, acd->ldev->dir);
 
-	for (i = 0 ; i < acd->page_count ; i++) {
+	for (i = 0 ; i < acd->page_count ; i++)
 		put_page(acd->user_pages[i]);
-	}
 
 	sg_free_table(&acd->sgt);
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -2
index 25ea16a1981e..bc81afb6ade2 100644
@@ -26,9 +26,8 @@ struct kpc_dma_device *kpc_dma_lookup_device(int minor)
 
 	mutex_lock(&kpc_dma_mtx);
 	list_for_each_entry(c, &kpc_dma_list, list) {
-		if (c->pldev->id == minor) {
+		if (c->pldev->id == minor)
 			goto out;
-		}
 	}
 	c = NULL; // not-found case
 out:

---
2.20.1

#9 lore raw

PATCH 4/6 Staging: kpc2000: kpc_dma: Use spaces around operators.

In reply to Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +6 -6
index d93097ed781c..e599ae1bdfd0 100644
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;
 
 	return last - first + 1;
 }
@@ -83,7 +83,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 	}
 
 	// Allocate and setup the sg_table (scatterlist entries)
-	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE-1), iov_len, GFP_KERNEL);
+	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE - 1), iov_len, GFP_KERNEL);
 	if (rv) {
 		dev_err(&priv->ldev->pldev->dev, "Couldn't alloc sg_table (%ld)\n", rv);
 		goto err_alloc_sg_table;
@@ -126,7 +126,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			// Fill out the descriptor
 			BUG_ON(!desc);
 			clear_desc(desc);
-			if (p != pcnt-1)
+			if (p != pcnt - 1)
 				desc->DescByteCount = 0x80000;
 			else
 				desc->DescByteCount = sg_dma_len(sg) - (p * 0x80000);
@@ -136,7 +136,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescControlFlags |= DMA_DESC_CTL_IRQONERR;
 			if (i == 0 && p == 0)
 				desc->DescControlFlags |= DMA_DESC_CTL_SOP;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->DescControlFlags |= DMA_DESC_CTL_EOP | DMA_DESC_CTL_IRQONDONE;
 
 			desc->DescCardAddrLS = (card_addr & 0xFFFFFFFF);
@@ -148,13 +148,13 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescSystemAddrMS = (dma_addr & 0xFFFFFFFF00000000UL) >> 32;
 
 			user_ctl = acd->priv->user_ctl;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				user_ctl = acd->priv->user_ctl_last;
 
 			desc->DescUserControlLS = (user_ctl & 0x00000000FFFFFFFFUL) >>  0;
 			desc->DescUserControlMS = (user_ctl & 0xFFFFFFFF00000000UL) >> 32;
 
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->acd = acd;
 
 			dev_dbg(&priv->ldev->pldev->dev, "  Filled descriptor %p (acd = %p)\n", desc, desc->acd);

---
2.20.1

#17 lore raw

PATCH 5/6 Staging: kpc2000: kpc_dma: Include the preferred header.

In reply to Sam Muhammed

<linux/io.h> is the preferred header to include
instead of <asm/io.h>.

Checkpatch.pl WARNING:
Use #include <linux/io.h> instead of <asm/io.h>

---
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -1
index bc81afb6ade2..0bdd345cc8c8 100644
@@ -2,7 +2,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/types.h>
-#include <asm/io.h>
+#include <linux/io.h>
 #include <linux/export.h>
 #include <linux/slab.h>
 #include <linux/platform_device.h>

---
2.20.1

#18 lore raw

PATCH 6/6 Staging: kpc2000: kpc_dma: Use the SPDK comment style.

In reply to Sam Muhammed

SPDK-License-Identifier comment should have this form // SPDX-License-Identifier: <GPL-...>

---
 drivers/staging/kpc2000/kpc_dma/dma.c            | 2 +-
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/kpc2000/kpc_dma/dma.c +1 -1
index 5ccc93ed2b61..452a3f7c835d 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
+// SPDX-License-Identifier: GPL-2.0+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/types.h>
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index e599ae1bdfd0..15089a8f78c0 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
+// SPDX-License-Identifier: GPL-2.0+
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/mm.h>
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -1
index 0bdd345cc8c8..c3b30551e0ca 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
+// SPDX-License-Identifier: GPL-2.0+
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/types.h>

---
2.20.1

#10 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

In reply to Sam Muhammed
Quoted 13 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index d93097ed781c..e599ae1bdfd0 100644

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 5 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;

It seems that the & operators were lined up before and that is not the case any more.

julia

Quoted 54 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +5 -6
 	return last - first + 1;
 }
@@ -83,7 +83,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 	}
 
 	// Allocate and setup the sg_table (scatterlist entries)
-	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE-1), iov_len, GFP_KERNEL);
+	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE - 1), iov_len, GFP_KERNEL);
 	if (rv) {
 		dev_err(&priv->ldev->pldev->dev, "Couldn't alloc sg_table (%ld)\n", rv);
 		goto err_alloc_sg_table;
@@ -126,7 +126,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			// Fill out the descriptor
 			BUG_ON(!desc);
 			clear_desc(desc);
-			if (p != pcnt-1)
+			if (p != pcnt - 1)
 				desc->DescByteCount = 0x80000;
 			else
 				desc->DescByteCount = sg_dma_len(sg) - (p * 0x80000);
@@ -136,7 +136,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescControlFlags |= DMA_DESC_CTL_IRQONERR;
 			if (i == 0 && p == 0)
 				desc->DescControlFlags |= DMA_DESC_CTL_SOP;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->DescControlFlags |= DMA_DESC_CTL_EOP | DMA_DESC_CTL_IRQONDONE;
 
 			desc->DescCardAddrLS = (card_addr & 0xFFFFFFFF);
@@ -148,13 +148,13 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescSystemAddrMS = (dma_addr & 0xFFFFFFFF00000000UL) >> 32;
 
 			user_ctl = acd->priv->user_ctl;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				user_ctl = acd->priv->user_ctl_last;
 
 			desc->DescUserControlLS = (user_ctl & 0x00000000FFFFFFFFUL) >>  0;
 			desc->DescUserControlMS = (user_ctl & 0xFFFFFFFF00000000UL) >> 32;
 
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->acd = acd;
 
 			dev_dbg(&priv->ldev->pldev->dev, "  Filled descriptor %p (acd = %p)\n", desc, desc->acd);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/d881bf9d5c442ae5a0d6669624355f7af73f5fac.1585082158.git.jane.pnx9%40gmail.com.

#8 lore raw

Re: [Outreachy kernel] [PATCH 3/6] Staging: kpc2000: kpc_dma: Remove unnecessary braces.

In reply to Sam Muhammed
Quoted 1 line · Sam Muhammed

Removing braces of single statement blocks,

removing is not imperative.

Quoted 112 lines

they are not really needed.

---
 drivers/staging/kpc2000/kpc_dma/dma.c         |  5 ++---
 drivers/staging/kpc2000/kpc_dma/fileops.c     | 20 +++++++++----------
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  |  3 +--
 3 files changed, 12 insertions(+), 16 deletions(-)
drivers/staging/kpc2000/kpc_dma/dma.c +2 -3
index 4bfbc717bc07..5ccc93ed2b61 100644
@@ -97,11 +97,10 @@ int  setup_dma_engine(struct kpc_dma_device *eng, u32 desc_cnt)
 	if (WARN(!(caps & ENG_CAP_PRESENT), "%s() called for DMA Engine at %p which isn't present in hardware!\n", __func__, eng))
 		return -ENXIO;
 
-	if (caps & ENG_CAP_DIRECTION) {
+	if (caps & ENG_CAP_DIRECTION)
 		eng->dir = DMA_FROM_DEVICE;
-	} else {
+	else
 		eng->dir = DMA_TO_DEVICE;
-	}
 
 	eng->desc_pool_cnt = desc_cnt;
 	eng->desc_pool = dma_pool_create("KPC DMA Descriptors", &eng->pldev->dev, sizeof(struct kpc_dma_descriptor), DMA_DESC_ALIGNMENT, 4096);
drivers/staging/kpc2000/kpc_dma/fileops.c +9 -11
index 21ebab7dbc7b..d93097ed781c 100644
@@ -126,11 +126,11 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			// Fill out the descriptor
 			BUG_ON(!desc);
 			clear_desc(desc);
-			if (p != pcnt-1) {
+			if (p != pcnt-1)
 				desc->DescByteCount = 0x80000;
-			} else {
+			else
 				desc->DescByteCount = sg_dma_len(sg) - (p * 0x80000);
-			}
+
 			desc->DescBufferByteCount = desc->DescByteCount;
 
 			desc->DescControlFlags |= DMA_DESC_CTL_IRQONERR;
@@ -148,9 +148,9 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescSystemAddrMS = (dma_addr & 0xFFFFFFFF00000000UL) >> 32;
 
 			user_ctl = acd->priv->user_ctl;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1) {
+			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
 				user_ctl = acd->priv->user_ctl_last;
-			}
+
 			desc->DescUserControlLS = (user_ctl & 0x00000000FFFFFFFFUL) >>  0;
 			desc->DescUserControlMS = (user_ctl & 0xFFFFFFFF00000000UL) >> 32;
 
@@ -188,9 +188,9 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 	sg_free_table(&acd->sgt);
  err_dma_map_sg:
  err_alloc_sg_table:
-	for (i = 0 ; i < acd->page_count ; i++) {
+	for (i = 0 ; i < acd->page_count ; i++)
 		put_page(acd->user_pages[i]);
-	}
+
  err_get_user_pages:
 	kfree(acd->user_pages);
  err_alloc_userpages:
@@ -210,16 +210,14 @@ void  transfer_complete_cb(struct aio_cb_data *acd, size_t xfr_count, u32 flags)
 	BUG_ON(!acd->ldev->pldev);
 
 	for (i = 0 ; i < acd->page_count ; i++) {
-		if (!PageReserved(acd->user_pages[i])) {
+		if (!PageReserved(acd->user_pages[i]))
 			set_page_dirty(acd->user_pages[i]);
-		}
 	}
 
 	dma_unmap_sg(&acd->ldev->pldev->dev, acd->sgt.sgl, acd->sgt.nents, acd->ldev->dir);
 
-	for (i = 0 ; i < acd->page_count ; i++) {
+	for (i = 0 ; i < acd->page_count ; i++)
 		put_page(acd->user_pages[i]);
-	}
 
 	sg_free_table(&acd->sgt);
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -3
index 25ea16a1981e..bc81afb6ade2 100644
@@ -26,9 +26,8 @@ struct kpc_dma_device *kpc_dma_lookup_device(int minor)
 
 	mutex_lock(&kpc_dma_mtx);
 	list_for_each_entry(c, &kpc_dma_list, list) {
-		if (c->pldev->id == minor) {
+		if (c->pldev->id == minor)
 			goto out;
-		}
 	}
 	c = NULL; // not-found case
 out:
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0a3ec63321dce008fc8dd790f42ef8490135b307.1585082158.git.jane.pnx9%40gmail.com.

#3 lore raw

Re: [Outreachy kernel] [PATCH 2/6] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

In reply to Sam Muhammed
Quoted 2 lines · Sam Muhammed

Modify struct allocations in kzalloc() to match the coding standards.

The subject line is more informative than the log message... Modify doesn't say anything about what you did.

julia

Quoted 44 lines

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...) over kzalloc(sizeof(struct var)...)

---
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5eb6c5f24feb..21ebab7dbc7b 100644
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
 		return -EBUSY; /* already open */
 	}
 
-	priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -2
index ec79a8500caf..25ea16a1981e 100644
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
 	int rv = 0;
 	dev_t dev;
 
-	struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+	struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
 	if (!ldev) {
 		dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585082158.git.jane.pnx9%40gmail.com.

#4 lore raw

Re: [Outreachy kernel] [PATCH 2/6] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

In reply to Sam Muhammed
Quoted 5 lines · Sam Muhammed

Modify struct allocations in kzalloc() to match the coding standards.

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...) over kzalloc(sizeof(struct var)...)

You could consider why the former is better than the latter (although not everyone agrees that this is the case).

julia

Quoted 41 lines
---
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5eb6c5f24feb..21ebab7dbc7b 100644
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
 		return -EBUSY; /* already open */
 	}
 
-	priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -2
index ec79a8500caf..25ea16a1981e 100644
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
 	int rv = 0;
 	dev_t dev;
 
-	struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+	struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
 	if (!ldev) {
 		dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585082158.git.jane.pnx9%40gmail.com.

#11 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

In reply to Julia Lawall
Quoted 11 lines · Julia Lawall
Quoted 8 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Quoted 14 lines

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 10 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index d93097ed781c..e599ae1bdfd0 100644
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;

It seems that the & operators were lined up before and that is not the case any more.

Yes, why they were aligned anyways?
should i align them back or remove the space in the first statement?

Sam

Quoted 56 lines

julia

Quoted 54 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +5 -6
 	return last - first + 1;
 }
@@ -83,7 +83,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 	}
 
 	// Allocate and setup the sg_table (scatterlist entries)
-	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE-1), iov_len, GFP_KERNEL);
+	rv = sg_alloc_table_from_pages(&acd->sgt, acd->user_pages, acd->page_count, iov_base & (PAGE_SIZE - 1), iov_len, GFP_KERNEL);
 	if (rv) {
 		dev_err(&priv->ldev->pldev->dev, "Couldn't alloc sg_table (%ld)\n", rv);
 		goto err_alloc_sg_table;
@@ -126,7 +126,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			// Fill out the descriptor
 			BUG_ON(!desc);
 			clear_desc(desc);
-			if (p != pcnt-1)
+			if (p != pcnt - 1)
 				desc->DescByteCount = 0x80000;
 			else
 				desc->DescByteCount = sg_dma_len(sg) - (p * 0x80000);
@@ -136,7 +136,7 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescControlFlags |= DMA_DESC_CTL_IRQONERR;
 			if (i == 0 && p == 0)
 				desc->DescControlFlags |= DMA_DESC_CTL_SOP;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->DescControlFlags |= DMA_DESC_CTL_EOP | DMA_DESC_CTL_IRQONDONE;
 
 			desc->DescCardAddrLS = (card_addr & 0xFFFFFFFF);
@@ -148,13 +148,13 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
 			desc->DescSystemAddrMS = (dma_addr & 0xFFFFFFFF00000000UL) >> 32;
 
 			user_ctl = acd->priv->user_ctl;
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				user_ctl = acd->priv->user_ctl_last;
 
 			desc->DescUserControlLS = (user_ctl & 0x00000000FFFFFFFFUL) >>  0;
 			desc->DescUserControlMS = (user_ctl & 0xFFFFFFFF00000000UL) >> 32;
 
-			if (i == acd->mapped_entry_count-1 && p == pcnt-1)
+			if (i == acd->mapped_entry_count - 1 && p == pcnt - 1)
 				desc->acd = acd;
 
 			dev_dbg(&priv->ldev->pldev->dev, "  Filled descriptor %p (acd = %p)\n", desc, desc->acd);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/d881bf9d5c442ae5a0d6669624355f7af73f5fac.1585082158.git.jane.pnx9%40gmail.com.

#5 lore raw

Re: [Outreachy kernel] [PATCH 2/6] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

In reply to Julia Lawall
Quoted 12 lines · Julia Lawall
Quoted 5 lines · Sam Muhammed

Modify struct allocations in kzalloc() to match the coding standards.

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...) over kzalloc(sizeof(struct var)...)

You could consider why the former is better than the latter (although not everyone agrees that this is the case).

That's right, this log message is poor.
i'll make another revision with these changes but i want to add another small patch to the series, so this makes it a new series? or adding in the log message that a new patch is added will be enough?

Thank You
Sam

Quoted 43 lines

julia

Quoted 41 lines
---
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5eb6c5f24feb..21ebab7dbc7b 100644
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
 		return -EBUSY; /* already open */
 	}
 
-	priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -2
index ec79a8500caf..25ea16a1981e 100644
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
 	int rv = 0;
 	dev_t dev;
 
-	struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+	struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
 	if (!ldev) {
 		dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585082158.git.jane.pnx9%40gmail.com.

#12 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

In reply to Sam Muhammed
Quoted 27 lines · Sam Muhammed
Quoted 11 lines · Julia Lawall
Quoted 8 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Quoted 14 lines

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 10 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index d93097ed781c..e599ae1bdfd0 100644
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;

It seems that the & operators were lined up before and that is not the case any more.

Quoted 1 line

Yes, why they were aligned anyways?

Because it is easier to understand the code that way, don't you think?

#13 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Sam Muhammed
Quoted 25 lines · Julia Lawall
Quoted 13 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index d93097ed781c..e599ae1bdfd0 100644

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 5 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;

It seems that the & operators were lined up before and that is not the case any more.

Quoted 4 lines
Quoted 1 line

Yes, why they were aligned anyways?

Because it is easier to understand the code that way, don't you think?

My bad, iam not used to see the patterns yes, so aligning the first statement to the second would be a different change? or since a change is made anyways they both would go together?

#6 lore raw

Re: [Outreachy kernel] [PATCH 2/6] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

In reply to Sam Muhammed
Quoted 10 lines · Sam Muhammed
Quoted 9 lines · Julia Lawall
Quoted 5 lines · Sam Muhammed

Modify struct allocations in kzalloc() to match the coding standards.

Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...) over kzalloc(sizeof(struct var)...)

Quoted 8 lines
Quoted 3 lines

You could consider why the former is better than the latter (although not everyone agrees that this is the case).

That's right, this log message is poor.
i'll make another revision with these changes but i want to add another small patch to the series, so this makes it a new series? or adding in the log message that a new patch is added will be enough?

Should be enough.

julia

Quoted 50 lines

Thank You
Sam

Quoted 43 lines

julia

Quoted 41 lines
---
 drivers/staging/kpc2000/kpc_dma/fileops.c        | 2 +-
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
index 5eb6c5f24feb..21ebab7dbc7b 100644
@@ -253,7 +253,7 @@ int  kpc_dma_open(struct inode *inode, struct file *filp)
 		return -EBUSY; /* already open */
 	}
 
-	priv = kzalloc(sizeof(struct dev_private_data), GFP_KERNEL);
+	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +1 -2
index ec79a8500caf..25ea16a1981e 100644
@@ -98,7 +98,7 @@ int  kpc_dma_probe(struct platform_device *pldev)
 	int rv = 0;
 	dev_t dev;
 
-	struct kpc_dma_device *ldev = kzalloc(sizeof(struct kpc_dma_device), GFP_KERNEL);
+	struct kpc_dma_device *ldev = kzalloc(sizeof(*ldev), GFP_KERNEL);
 
 	if (!ldev) {
 		dev_err(&pldev->dev, "%s: unable to kzalloc space for kpc_dma_device\n", __func__);
---

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585082158.git.jane.pnx9%40gmail.com.

#14 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

In reply to Sam Muhammed
Quoted 29 lines · On Wed, 25 Mar 2020 08:57:30 -0400 Sam Muhammed <[email protected]> wrote:
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Sam Muhammed
Quoted 25 lines · Julia Lawall
Quoted 13 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index d93097ed781c..e599ae1bdfd0 100644

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 5 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;  

It seems that the & operators were lined up before and that is not the case any more.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes, why they were aligned anyways?

Because it is easier to understand the code that way, don't you think?

My bad, iam not used to see the patterns yes, so aligning the first statement to the second would be a different change? or since a change is made anyways they both would go together?

I think yes, this should be a single patch, because:

1. realigning the first line is needed only as you edit the second one,

2. with two patches the alignment would be "broken" after the first one (this is especially a hard rule with build failures and warnings, but the concept usually applies to these cases as well)

...however, why would you ask this question and anyway re-post the series 89 minutes later? Mind that this is a good way to get your patches ignored by some maintainers.

Signature · 1 line
Stefano
#15 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

Quoted 44 lines · Stefano Brivio
Quoted 29 lines · On Wed, 25 Mar 2020 08:57:30 -0400 Sam Muhammed <[email protected]> wrote:
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Sam Muhammed
Quoted 25 lines · Julia Lawall
Quoted 13 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index d93097ed781c..e599ae1bdfd0 100644

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 5 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;  

It seems that the & operators were lined up before and that is not the case any more.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes, why they were aligned anyways?

Because it is easier to understand the code that way, don't you think?

My bad, iam not used to see the patterns yes, so aligning the first statement to the second would be a different change? or since a change is made anyways they both would go together?

I think yes, this should be a single patch, because:

1. realigning the first line is needed only as you edit the second one,

Quoted 8 lines

2. with two patches the alignment would be "broken" after the first one (this is especially a hard rule with build failures and warnings, but the concept usually applies to these cases as well)

...however, why would you ask this question and anyway re-post the series 89 minutes later? Mind that this is a good way to get your patches ignored by some maintainers.

But reading through Julia's comment about it and re-considering the change, my question was already answered with Julia's comment as of _if i make a change, i should keep the style and not break the alignment_

So i probably shouldn't ask the question from the first place and read Julia's comment more carefully. :)

Thank You.

Sam

#16 lore raw

Re: [Outreachy kernel] [PATCH 4/6] Staging: kpc2000: kpc_dma: Use spaces around operators.

Quoted 54 lines · On Mon, 30 Mar 2020 07:55:45 -0400 Sam Muhammed <[email protected]> wrote:
Quoted 44 lines · Stefano Brivio
Quoted 29 lines · On Wed, 25 Mar 2020 08:57:30 -0400 Sam Muhammed <[email protected]> wrote:
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Sam Muhammed
Quoted 25 lines · Julia Lawall
Quoted 13 lines · Sam Muhammed

Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.

---
 drivers/staging/kpc2000/kpc_dma/fileops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/kpc2000/kpc_dma/fileops.c +0 -0
index d93097ed781c..e599ae1bdfd0 100644

drivers/staging/kpc2000/kpc_dma/fileops.c static inline · line 22

Quoted 5 lines
drivers/staging/kpc2000/kpc_dma/fileops.c +1 -1
@@ -19,7 +19,7 @@ static inline
 unsigned int  count_pages(unsigned long iov_base, size_t iov_len)
 {
 	unsigned long first = (iov_base             & PAGE_MASK) >> PAGE_SHIFT;
-	unsigned long last  = ((iov_base+iov_len-1) & PAGE_MASK) >> PAGE_SHIFT;
+	unsigned long last  = ((iov_base + iov_len - 1) & PAGE_MASK) >> PAGE_SHIFT;    

It seems that the & operators were lined up before and that is not the case any more.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes, why they were aligned anyways?

Because it is easier to understand the code that way, don't you think?

My bad, iam not used to see the patterns yes, so aligning the first statement to the second would be a different change? or since a change is made anyways they both would go together?

I think yes, this should be a single patch, because:

1. realigning the first line is needed only as you edit the second one,

Quoted 8 lines

2. with two patches the alignment would be "broken" after the first one (this is especially a hard rule with build failures and warnings, but the concept usually applies to these cases as well)

...however, why would you ask this question and anyway re-post the series 89 minutes later? Mind that this is a good way to get your patches ignored by some maintainers.

Quoted 7 lines

But reading through Julia's comment about it and re-considering the change, my question was already answered with Julia's comment as of _if i make a change, i should keep the style and not break the alignment_

So i probably shouldn't ask the question from the first place and read Julia's comment more carefully. :)

Fine, I really don't mind that part... but it would be nice if you could answer your question yourself on the list, so that:

1. other applicants benefit from it

2. nobody has to wonder if you're still waiting for an answer (my case here)

Signature · 1 line
Stefano