mmc: zynqmp_sdhci: Add support for Tap delay
Subsystems (2)
cover mmc: zynqmp_sdhci: Add support for Tap delay
Hi,
this patchset adding support for Tap delay programming for ZynqMP and Versal.
Based on mainline discussion also DT properties have been introduced which are documented here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v5.7-rc6&id=fec81c5bca2499b4a263667860018c2ce47f4f51
The patchset is using these DT properties which are optional. Default values are also listed.
The patchset is based on:
https://lists.denx.de/pipermail/u-boot/2020-May/410326.html
Also new code is adding checking for SOCs which are not needed at that time when patch is applied (For example "mmc: zynq_sdhci: Read clock phase delays from dt" and IS_ENABLED(CONFIG_ARCH_ZYNQMP)...
But I kept it there for more cleaner patches built on the top.
Thanks,
Michal
Ashok Reddy Soma (5):
Revert "mmc: zynq: parse dt when probing"
mmc: zynq_sdhci: Define timing macro's
mmc: zynq_sdhci: Set tapdelays based on clk phase delays
mmc: zynq_sdhci: Add clock phase delays for Versal
mmc: zynq_sdhci: Extend UHS timings till hs200
Michal Simek (2):
mmc: zynq_sdhci: Move macro to the top
mmc: zynq_sdhci: Read clock phase delays from dt
drivers/mmc/sdhci.c | 3 +- drivers/mmc/zynq_sdhci.c | 406 ++++++++++++++++++++++++++++++++++++--- include/mmc.h | 13 ++ include/sdhci.h | 1 + 4 files changed, 398 insertions(+), 25 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/7 Revert "mmc: zynq: parse dt when probing"
From: Ashok Reddy Soma <[email protected]>
This reverts commit 942b5fc03218d1c94468fc658e7dec65dabcc830.
This is partial revert of the above commit.
mmc_of_parse() is reading no-1-8-v from device tree and if set, it is clearing the UHS speed capabilities of cfg->host_caps. cfg->host_caps &= ~(UHS_CAPS | MMC_MODE_HS200 |
MMC_MODE_HS400 | MMC_MODE_HS400_ES);
This is still missing to clear UHS speeds like SDHCI_SUPPORT_SDR104, SDHCI_SUPPORT_SDR50 and SDHCI_SUPPORT_DDR50.
Even if we clear the flags SDHCI_SUPPORT_XXX in mmc_of_parse(), these speed flags are getting set again in cfg->host_caps in sdhci_setup_cfg().
The reason for this is, SDHCI_SUPPORT_XXX flags are cleared only if controller is not capable of supporting MMC_VDD_165_195 volts.
if (caps & SDHCI_CAN_VDD_180)
cfg->voltages |= MMC_VDD_165_195;
if (!(cfg->voltages & MMC_VDD_165_195))
caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50);
It means "no-1-8-v", which is read from DT is not coming in to effect. So it is better we keep the host quirks(SDHCI_QUIRK_NO_1_8_V) to clear UHS speeds based on no-1-8-v from device tree.
Hence revert the functionality related to no-1-8-v only, rest is fine in the patch.
---
drivers/mmc/sdhci.c | 3 ++- drivers/mmc/zynq_sdhci.c | 5 +++++ include/sdhci.h | 1 + 3 files changed, 8 insertions(+), 1 deletion(-)
drivers/mmc/sdhci.c +2 -1
@@ -844,7 +844,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, cfg->host_caps &= ~MMC_MODE_HS_52MHz; } -if (!(cfg->voltages &MMC_VDD_165_195 )) +if (!(cfg->voltages &MMC_VDD_165_195 ) || + (host->quirks &SDHCI_QUIRK_NO_1_8_V )) caps_1 &= ~(SDHCI_SUPPORT_SDR104 |SDHCI_SUPPORT_SDR50 |SDHCI_SUPPORT_DDR50 );
drivers/mmc/zynq_sdhci.c +5 -0
@@ -28,6 +28,7 @@ struct arasan_sdhci_priv {struct sdhci_host *host;u8 deviceid;u8 bank; +u8 no_1p8; };#if defined(CONFIG_ARCH_ZYNQMP )
@@ -236,6 +237,9 @@ static int arasan_sdhci_probe(struct udevice *dev) host->quirks |=SDHCI_QUIRK_BROKEN_HISPD_MODE ;#endif +if (priv->no_1p8) + host->quirks |=SDHCI_QUIRK_NO_1_8_V ; + plat->cfg.f_max =CONFIG_ZYNQ_SDHCI_MAX_FREQ ; ret =mmc_of_parse (dev, &plat->cfg);
@@ -277,6 +281,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev) priv->deviceid =dev_read_u32_default (dev,"xlnx,device_id" ,-1 ); priv->bank =dev_read_u32_default (dev,"xlnx,mio_bank" ,-1 ); + priv->no_1p8 =dev_read_bool (dev,"no-1-8-v" );return 0 ; }
include/sdhci.h +1 -0
@@ -244,6 +244,7 @@#define SDHCI_QUIRK_BROKEN_HISPD_MODE BIT(5)#define SDHCI_QUIRK_WAIT_SEND_CMD (1 << 6)#define SDHCI_QUIRK_USE_WIDE8 (1 << 8) +#define SDHCI_QUIRK_NO_1_8_V (1 << 9)/* to make gcc happy */ struct sdhci_host ;
Signature · 1 line
2.26.2
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
In reply to Michal SimekFrom: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in zynq_sdhci.c with these new macro's.
---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)
drivers/mmc/zynq_sdhci.c +11 -13
@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40
include/mmc.h +13 -0
@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ +/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3 +#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ /**
Signature · 1 line
2.26.2
PATCH 3/7 mmc: zynq_sdhci: Move macro to the top
In reply to Michal SimekJust group macros below headers. Other patches will be using this location too.
---
drivers/mmc/zynq_sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/zynq_sdhci.c +2 -2
@@ -19,6 +19,8 @@#include <sdhci.h> #include <zynqmp_tap_delay.h> +#define SDHCI_TUNING_LOOP_COUNT 40 +struct arasan_sdhci_plat {struct mmc_config cfg;struct mmc mmc;
@@ -46,8 +48,6 @@ static const u8 mode2timing[] = { [MMC_HS_200] = MMC_TIMING_MMC_HS200, }; -#define SDHCI_TUNING_LOOP_COUNT 40 -static void arasan_zynqmp_dll_reset (struct sdhci_host *host,u8 deviceid) {u16 clk;
Signature · 1 line
2.26.2
PATCH 4/7 mmc: zynq_sdhci: Read clock phase delays from dt
In reply to Michal SimekDefine input and output clock phase delays with pre-defined values.
Define arasan_sdhci_clk_data type structure and add it to priv structure and store these clock phase delays in it.
Read input and output clock phase delays from dt. If these values are not passed through dt, use pre-defined values.
---
drivers/mmc/zynq_sdhci.c | 85 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+)
drivers/mmc/zynq_sdhci.c +85 -0
@@ -20,6 +20,12 @@#include <zynqmp_tap_delay.h> #define SDHCI_TUNING_LOOP_COUNT 40 +#define MMC_BANK2 0x2 + +struct arasan_sdhci_clk_data { +int clk_phase_in[MMC_TIMING_MMC_HS400 +1 ]; +int clk_phase_out[MMC_TIMING_MMC_HS400 +1 ]; +};struct arasan_sdhci_plat {struct mmc_config cfg;
@@ -28,12 +34,17 @@ struct arasan_sdhci_plat {struct arasan_sdhci_priv {struct sdhci_host *host; +struct arasan_sdhci_clk_data clk_data;u8 deviceid;u8 bank;u8 no_1p8; };#if defined(CONFIG_ARCH_ZYNQMP ) +/* Default settings for ZynqMP Clock Phases */ +const u32 zynqmp_iclk_phases[] = {0 ,63 ,63 ,0 ,63 ,0 ,0 ,183 ,54 ,0 ,0 }; +const u32 zynqmp_oclk_phases[] = {0 ,72 ,60 ,0 ,60 ,72 ,135 ,48 ,72 ,135 ,0 }; +static const u8 mode2timing[] = { [MMC_LEGACY ] =MMC_TIMING_LEGACY , [MMC_HS] = MMC_TIMING_MMC_HS,
@@ -168,6 +179,79 @@ static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) priv->bank); } +static void arasan_dt_read_clk_phase (struct udevice *dev,unsigned char timing, +const char *prop) +{ +struct arasan_sdhci_priv *priv =dev_get_priv (dev); +struct arasan_sdhci_clk_data *clk_data = &priv->clk_data; +u32 clk_phase[2 ] = {0 }; + +/* +* Read Tap Delay values from DT, if the DT does not contain the +* Tap Values then use the pre-defined values +*/ +if (dev_read_u32_array (dev, prop, &clk_phase[0 ],2 )) { +dev_dbg (dev,"Using predefined clock phase for %s = %d %d\n" , + prop, clk_data->clk_phase_in[timing], + clk_data->clk_phase_out[timing]); +return ; + } + +/* The values read are Input and Output Clock Delays in order */ + clk_data->clk_phase_in[timing] = clk_phase[0 ]; + clk_data->clk_phase_out[timing] = clk_phase[1 ]; +} + +/** +* arasan_dt_parse_clk_phases - Read Tap Delay values from DT +* +* Called at initialization to parse the values of Tap Delays. +* +* @dev: Pointer to our struct udevice. +*/ +static void arasan_dt_parse_clk_phases (struct udevice *dev) +{ +struct arasan_sdhci_priv *priv =dev_get_priv (dev); +struct arasan_sdhci_clk_data *clk_data = &priv->clk_data; +int i; + +if (IS_ENABLED (CONFIG_ARCH_ZYNQMP ) && +device_is_compatible (dev,"xlnx,zynqmp-8.9a" )) { +for (i =0 ; i <=MMC_TIMING_MMC_HS400 ; i++) { + clk_data->clk_phase_in[i] = zynqmp_iclk_phases[i]; + clk_data->clk_phase_out[i] = zynqmp_oclk_phases[i]; + } + +if (priv->bank ==MMC_BANK2 ) { + clk_data->clk_phase_out[MMC_TIMING_UHS_SDR104 ] =90 ; + clk_data->clk_phase_out[MMC_TIMING_MMC_HS200 ] =90 ; + } + } + +arasan_dt_read_clk_phase (dev,MMC_TIMING_LEGACY , +"clk-phase-legacy" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_MMC_HS , +"clk-phase-mmc-hs" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_SD_HS , +"clk-phase-sd-hs" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_UHS_SDR12 , +"clk-phase-uhs-sdr12" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_UHS_SDR25 , +"clk-phase-uhs-sdr25" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_UHS_SDR50 , +"clk-phase-uhs-sdr50" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_UHS_SDR104 , +"clk-phase-uhs-sdr104" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_UHS_DDR50 , +"clk-phase-uhs-ddr50" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_MMC_DDR52 , +"clk-phase-mmc-ddr52" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_MMC_HS200 , +"clk-phase-mmc-hs200" ); +arasan_dt_read_clk_phase (dev,MMC_TIMING_MMC_HS400 , +"clk-phase-mmc-hs400" ); +} +static void arasan_sdhci_set_control_reg (struct sdhci_host *host) {struct mmc *mmc = (struct mmc *)host->mmc;
@@ -271,6 +355,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev)#if defined(CONFIG_ARCH_ZYNQMP ) priv->host->ops = &arasan_ops; +arasan_dt_parse_clk_phases (dev);#endif priv->host->ioaddr = (void *)dev_read_addr (dev);
Signature · 1 line
2.26.2
PATCH 5/7 mmc: zynq_sdhci: Set tapdelays based on clk phase delays
In reply to Michal SimekFrom: Ashok Reddy Soma <[email protected]>
Define and use functions for setting input and output tapdelays based on clk phase delays.
---
drivers/mmc/zynq_sdhci.c | 128 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 123 insertions(+), 5 deletions(-)
drivers/mmc/zynq_sdhci.c +123 -5
@@ -166,17 +166,135 @@ static int arasan_sdhci_execute_tuning(struct mmc *mmc, u8 opcode)return 0 ; } +/** +* sdhci_zynqmp_sdcardclk_set_phase - Set the SD Output Clock Tap Delays +* +* Set the SD Output Clock Tap Delays for Output path +* +* @host: Pointer to the sdhci_host structure. +* @degrees: The clock phase shift between 0 - 359. +* Return: 0 on success and error value on error +*/ +static int sdhci_zynqmp_sdcardclk_set_phase (struct sdhci_host *host, +int degrees) +{ +struct arasan_sdhci_priv *priv =dev_get_priv (host->mmc->dev); +struct mmc *mmc = (struct mmc *)host->mmc; +u8 tap_delay, tap_max =0 ; +int ret; +int timing = mode2timing[mmc->selected_mode]; + +/* +* This is applicable for SDHCI_SPEC_300 and above +* ZynqMP does not set phase for <=25MHz clock. +* If degrees is zero, no need to do anything. +*/ +if (host->version <SDHCI_SPEC_300 || + timing ==MMC_TIMING_LEGACY || + timing ==MMC_TIMING_UHS_SDR12 || !degrees) +return 0 ; + +switch (timing) { +case MMC_TIMING_MMC_HS : +case MMC_TIMING_SD_HS : +case MMC_TIMING_UHS_SDR25 : +case MMC_TIMING_UHS_DDR50 : +case MMC_TIMING_MMC_DDR52 : +/* For 50MHz clock, 30 Taps are available */ + tap_max =30 ; +break ; +case MMC_TIMING_UHS_SDR50 : +/* For 100MHz clock, 15 Taps are available */ + tap_max =15 ; +break ; +case MMC_TIMING_UHS_SDR104 : +case MMC_TIMING_MMC_HS200 : +/* For 200MHz clock, 8 Taps are available */ + tap_max =8 ; +default : +break ; + } + + tap_delay = (degrees * tap_max) /360 ; + +arasan_zynqmp_set_tapdelay (priv->deviceid,0 , tap_delay); + +return ret; +} + +/** +* sdhci_zynqmp_sampleclk_set_phase - Set the SD Input Clock Tap Delays +* +* Set the SD Input Clock Tap Delays for Input path +* +* @host: Pointer to the sdhci_host structure. +* @degrees: The clock phase shift between 0 - 359. +* Return: 0 on success and error value on error +*/ +static int sdhci_zynqmp_sampleclk_set_phase (struct sdhci_host *host, +int degrees) +{ +struct arasan_sdhci_priv *priv =dev_get_priv (host->mmc->dev); +struct mmc *mmc = (struct mmc *)host->mmc; +u8 tap_delay, tap_max =0 ; +int ret; +int timing = mode2timing[mmc->selected_mode]; + +/* +* This is applicable for SDHCI_SPEC_300 and above +* ZynqMP does not set phase for <=25MHz clock. +* If degrees is zero, no need to do anything. +*/ +if (host->version <SDHCI_SPEC_300 || + timing ==MMC_TIMING_LEGACY || + timing ==MMC_TIMING_UHS_SDR12 || !degrees) +return 0 ; + +switch (timing) { +case MMC_TIMING_MMC_HS : +case MMC_TIMING_SD_HS : +case MMC_TIMING_UHS_SDR25 : +case MMC_TIMING_UHS_DDR50 : +case MMC_TIMING_MMC_DDR52 : +/* For 50MHz clock, 120 Taps are available */ + tap_max =120 ; +break ; +case MMC_TIMING_UHS_SDR50 : +/* For 100MHz clock, 60 Taps are available */ + tap_max =60 ; +break ; +case MMC_TIMING_UHS_SDR104 : +case MMC_TIMING_MMC_HS200 : +/* For 200MHz clock, 30 Taps are available */ + tap_max =30 ; +default : +break ; + } + + tap_delay = (degrees * tap_max) /360 ; + +arasan_zynqmp_set_tapdelay (priv->deviceid, tap_delay,0 ); + +return ret; +} +static void arasan_sdhci_set_tapdelay (struct sdhci_host *host) {struct arasan_sdhci_priv *priv =dev_get_priv (host->mmc->dev); +struct arasan_sdhci_clk_data *clk_data = &priv->clk_data;struct mmc *mmc = (struct mmc *)host->mmc; -u8 uhsmode; +struct udevice *dev = mmc->dev; +u8 timing = mode2timing[mmc->selected_mode]; +u32 iclk_phase = clk_data->clk_phase_in[timing]; +u32 oclk_phase = clk_data->clk_phase_out[timing]; - uhsmode = mode2timing[mmc->selected_mode]; +dev_dbg (dev,"%s, host:%s, mode:%d\n" , __func__, host->name, timing); -if (uhsmode >=UHS_SDR25_BUS_SPEED ) -arasan_zynqmp_set_tapdelay (priv->deviceid, uhsmode, - priv->bank); +if (IS_ENABLED (CONFIG_ARCH_ZYNQMP ) && +device_is_compatible (dev,"xlnx,zynqmp-8.9a" )) { +sdhci_zynqmp_sampleclk_set_phase (host, iclk_phase); +sdhci_zynqmp_sdcardclk_set_phase (host, oclk_phase); + } } static void arasan_dt_read_clk_phase(struct udevice *dev, unsigned char timing,
Signature · 1 line
2.26.2
PATCH 6/7 mmc: zynq_sdhci: Add clock phase delays for Versal
In reply to Michal SimekFrom: Ashok Reddy Soma <[email protected]>
Define default values for input and output clock phase delays for Versal. Also define functions for setting tapdelays based on these clock phase delays.
---
drivers/mmc/zynq_sdhci.c | 160 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 156 insertions(+), 4 deletions(-)
drivers/mmc/zynq_sdhci.c +156 -4
@@ -19,6 +19,12 @@#include <sdhci.h> #include <zynqmp_tap_delay.h> +#define SDHCI_ARASAN_ITAPDLY_REGISTER 0xF0F8 +#define SDHCI_ARASAN_OTAPDLY_REGISTER 0xF0FC +#define SDHCI_ITAPDLY_CHGWIN 0x200 +#define SDHCI_ITAPDLY_ENABLE 0x100 +#define SDHCI_OTAPDLY_ENABLE 0x40 +#define SDHCI_TUNING_LOOP_COUNT 40#define MMC_BANK2 0x2
@@ -40,11 +46,15 @@ struct arasan_sdhci_priv {u8 no_1p8; }; -#if defined(CONFIG_ARCH_ZYNQMP ) +#if defined(CONFIG_ARCH_ZYNQMP ) || defined(CONFIG_ARCH_VERSAL )/* Default settings for ZynqMP Clock Phases */ const u32 zynqmp_iclk_phases[] = {0 ,63 ,63 ,0 ,63 ,0 ,0 ,183 ,54 ,0 ,0 };const u32 zynqmp_oclk_phases[] = {0 ,72 ,60 ,0 ,60 ,72 ,135 ,48 ,72 ,135 ,0 }; +/* Default settings for Versal Clock Phases */ +const u32 versal_iclk_phases[] = {0 ,132 ,132 ,0 ,132 ,0 ,0 ,162 ,90 ,0 ,0 }; +const u32 versal_oclk_phases[] = {0 ,60 ,48 ,0 ,48 ,72 ,90 ,36 ,60 ,90 ,0 }; +static const u8 mode2timing[] = { [MMC_LEGACY ] =MMC_TIMING_LEGACY , [MMC_HS] = MMC_TIMING_MMC_HS,
@@ -278,6 +288,138 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct sdhci_host *host,return ret; } +/** +* sdhci_versal_sdcardclk_set_phase - Set the SD Output Clock Tap Delays +* +* Set the SD Output Clock Tap Delays for Output path +* +* @host: Pointer to the sdhci_host structure. +* @degrees: The clock phase shift between 0 - 359. +* Return: 0 on success and error value on error +*/ +static int sdhci_versal_sdcardclk_set_phase (struct sdhci_host *host, +int degrees) +{ +struct mmc *mmc = (struct mmc *)host->mmc; +u8 tap_delay, tap_max =0 ; +int ret; +int timing = mode2timing[mmc->selected_mode]; + +/* +* This is applicable for SDHCI_SPEC_300 and above +* Versal does not set phase for <=25MHz clock. +* If degrees is zero, no need to do anything. +*/ +if (host->version <SDHCI_SPEC_300 || + timing ==MMC_TIMING_LEGACY || + timing ==MMC_TIMING_UHS_SDR12 || !degrees) +return 0 ; + +switch (timing) { +case MMC_TIMING_MMC_HS : +case MMC_TIMING_SD_HS : +case MMC_TIMING_UHS_SDR25 : +case MMC_TIMING_UHS_DDR50 : +case MMC_TIMING_MMC_DDR52 : +/* For 50MHz clock, 30 Taps are available */ + tap_max =30 ; +break ; +case MMC_TIMING_UHS_SDR50 : +/* For 100MHz clock, 15 Taps are available */ + tap_max =15 ; +break ; +case MMC_TIMING_UHS_SDR104 : +case MMC_TIMING_MMC_HS200 : +/* For 200MHz clock, 8 Taps are available */ + tap_max =8 ; +default : +break ; + } + + tap_delay = (degrees * tap_max) /360 ; + +/* Set the Clock Phase */ +if (tap_delay) { +u32 regval; + + regval =sdhci_readl (host,SDHCI_ARASAN_OTAPDLY_REGISTER ); + regval |=SDHCI_OTAPDLY_ENABLE ; +sdhci_writel (host, regval,SDHCI_ARASAN_OTAPDLY_REGISTER ); + regval |= tap_delay; +sdhci_writel (host, regval,SDHCI_ARASAN_OTAPDLY_REGISTER ); + } + +return ret; +} + +/** +* sdhci_versal_sampleclk_set_phase - Set the SD Input Clock Tap Delays +* +* Set the SD Input Clock Tap Delays for Input path +* +* @host: Pointer to the sdhci_host structure. +* @degrees: The clock phase shift between 0 - 359. +* Return: 0 on success and error value on error +*/ +static int sdhci_versal_sampleclk_set_phase (struct sdhci_host *host, +int degrees) +{ +struct mmc *mmc = (struct mmc *)host->mmc; +u8 tap_delay, tap_max =0 ; +int ret; +int timing = mode2timing[mmc->selected_mode]; + +/* +* This is applicable for SDHCI_SPEC_300 and above +* Versal does not set phase for <=25MHz clock. +* If degrees is zero, no need to do anything. +*/ +if (host->version <SDHCI_SPEC_300 || + timing ==MMC_TIMING_LEGACY || + timing ==MMC_TIMING_UHS_SDR12 || !degrees) +return 0 ; + +switch (timing) { +case MMC_TIMING_MMC_HS : +case MMC_TIMING_SD_HS : +case MMC_TIMING_UHS_SDR25 : +case MMC_TIMING_UHS_DDR50 : +case MMC_TIMING_MMC_DDR52 : +/* For 50MHz clock, 120 Taps are available */ + tap_max =120 ; +break ; +case MMC_TIMING_UHS_SDR50 : +/* For 100MHz clock, 60 Taps are available */ + tap_max =60 ; +break ; +case MMC_TIMING_UHS_SDR104 : +case MMC_TIMING_MMC_HS200 : +/* For 200MHz clock, 30 Taps are available */ + tap_max =30 ; +default : +break ; + } + + tap_delay = (degrees * tap_max) /360 ; + +/* Set the Clock Phase */ +if (tap_delay) { +u32 regval; + + regval =sdhci_readl (host,SDHCI_ARASAN_ITAPDLY_REGISTER ); + regval |=SDHCI_ITAPDLY_CHGWIN ; +sdhci_writel (host, regval,SDHCI_ARASAN_ITAPDLY_REGISTER ); + regval |=SDHCI_ITAPDLY_ENABLE ; +sdhci_writel (host, regval,SDHCI_ARASAN_ITAPDLY_REGISTER ); + regval |= tap_delay; +sdhci_writel (host, regval,SDHCI_ARASAN_ITAPDLY_REGISTER ); + regval &= ~SDHCI_ITAPDLY_CHGWIN ; +sdhci_writel (host, regval,SDHCI_ARASAN_ITAPDLY_REGISTER ); + } + +return ret; +} +static void arasan_sdhci_set_tapdelay (struct sdhci_host *host) {struct arasan_sdhci_priv *priv =dev_get_priv (host->mmc->dev);
@@ -294,6 +436,10 @@ static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) device_is_compatible(dev, "xlnx,zynqmp-8.9a")) {sdhci_zynqmp_sampleclk_set_phase (host, iclk_phase);sdhci_zynqmp_sdcardclk_set_phase (host, oclk_phase); + } else if (IS_ENABLED(CONFIG_ARCH_VERSAL) && + device_is_compatible(dev, "xlnx,versal-8.9a")) { +sdhci_versal_sampleclk_set_phase (host, iclk_phase); +sdhci_versal_sdcardclk_set_phase (host, oclk_phase); } }
@@ -346,6 +492,14 @@ static void arasan_dt_parse_clk_phases(struct udevice *dev) } } +if (IS_ENABLED (CONFIG_ARCH_VERSAL ) && +device_is_compatible (dev,"xlnx,versal-8.9a" )) { +for (i =0 ; i <=MMC_TIMING_MMC_HS400 ; i++) { + clk_data->clk_phase_in[i] = versal_iclk_phases[i]; + clk_data->clk_phase_out[i] = versal_oclk_phases[i]; + } + } +arasan_dt_read_clk_phase (dev,MMC_TIMING_LEGACY ,"clk-phase-legacy" ); arasan_dt_read_clk_phase(dev, MMC_TIMING_MMC_HS,
@@ -388,9 +542,7 @@ static void arasan_sdhci_set_control_reg(struct sdhci_host *host) mmc->selected_mode <= UHS_DDR50)sdhci_set_uhs_timing (host); } -#endif -#if defined(CONFIG_ARCH_ZYNQMP )const struct sdhci_ops arasan_ops = { .platform_execute_tuning = &arasan_sdhci_execute_tuning, .set_delay = &arasan_sdhci_set_tapdelay,
@@ -471,7 +623,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev) priv->host->name = dev->name; -#if defined(CONFIG_ARCH_ZYNQMP ) +#if defined(CONFIG_ARCH_ZYNQMP ) || defined(CONFIG_ARCH_VERSAL ) priv->host->ops = &arasan_ops;arasan_dt_parse_clk_phases (dev);#endif
Signature · 1 line
2.26.2
PATCH 7/7 mmc: zynq_sdhci: Extend UHS timings till hs200
In reply to Michal SimekFrom: Ashok Reddy Soma <[email protected]>
Fix the condition to set UHS timings for speeds upto HS200.
---
drivers/mmc/zynq_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/zynq_sdhci.c +1 -1
@@ -539,7 +539,7 @@ static void arasan_sdhci_set_control_reg(struct sdhci_host *host) }if (mmc->selected_mode >SD_HS && - mmc->selected_mode <=UHS_DDR50 ) + mmc->selected_mode <=MMC_HS_200 )sdhci_set_uhs_timing (host); }
Signature · 1 line
2.26.2
PATCH 1/7 Revert "mmc: zynq: parse dt when probing"
In reply to Michal SimekHi
Quoted 21 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
This reverts commit
942b5fc03218d1c94468fc658e7dec65dabcc830.This is partial revert of the above commit.
mmc_of_parse()is reading no-1-8-v from device tree and if set, it is clearing the UHS speed capabilities ofcfg->host_caps.cfg->host_caps&= ~(UHS_CAPS |MMC_MODE_HS200|MMC_MODE_HS400 | MMC_MODE_HS400_ES);This is still missing to clear UHS speeds like
SDHCI_SUPPORT_SDR104,SDHCI_SUPPORT_SDR50andSDHCI_SUPPORT_DDR50.Even if we clear the flags
SDHCI_SUPPORT_XXXinmmc_of_parse(), these speed flags are getting set again incfg->host_capsinsdhci_setup_cfg().The reason for this is,
SDHCI_SUPPORT_XXXflags are cleared only if controller is not capable of supportingMMC_VDD_165_195volts.
Quoted 6 lines
if (caps &
SDHCI_CAN_VDD_180)cfg->voltages |= MMC_VDD_165_195;if (!(cfg->voltages &
MMC_VDD_165_195))caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50);
I don't have a target to test with zynq_sdhci.
If there is no effect no-1-8-v property, i think that it needs to fix main problem. I will check about this.
Quoted 7 lines
It means "no-1-8-v", which is read from DT is not coming in to effect. So it is better we keep the host
quirks(SDHCI_QUIRK_NO_1_8_V)to clear UHS speeds based on no-1-8-v from device tree.Hence revert the functionality related to no-1-8-v only, rest is fine in the patch.
Anyway, I don't have any objection about reverting it.
Quoted 67 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/sdhci.c | 3 ++- drivers/mmc/zynq_sdhci.c | 5 +++++ include/sdhci.h | 1 + 3 files changed, 8 insertions(+), 1 deletion(-)drivers/mmc/sdhci.c +2
-1@@ -844,7 +844,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, cfg->host_caps &= ~MMC_MODE_HS_52MHz; } -if (!(cfg->voltages &MMC_VDD_165_195 )) +if (!(cfg->voltages &MMC_VDD_165_195 ) || + (host->quirks &SDHCI_QUIRK_NO_1_8_V )) caps_1 &= ~(SDHCI_SUPPORT_SDR104 |SDHCI_SUPPORT_SDR50 |SDHCI_SUPPORT_DDR50 );drivers/mmc/zynq_sdhci.c +5
-0@@ -28,6 +28,7 @@ struct arasan_sdhci_priv {struct sdhci_host *host;u8 deviceid;u8 bank; +u8 no_1p8; };#if defined(CONFIG_ARCH_ZYNQMP )@@ -236,6 +237,9 @@ static int arasan_sdhci_probe(struct udevice *dev) host->quirks |=SDHCI_QUIRK_BROKEN_HISPD_MODE ;#endif +if (priv->no_1p8) + host->quirks |=SDHCI_QUIRK_NO_1_8_V ; + plat->cfg.f_max =CONFIG_ZYNQ_SDHCI_MAX_FREQ ; ret =mmc_of_parse (dev, &plat->cfg);@@ -277,6 +281,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev) priv->deviceid =dev_read_u32_default (dev,"xlnx,device_id" ,-1 ); priv->bank =dev_read_u32_default (dev,"xlnx,mio_bank" ,-1 ); + priv->no_1p8 =dev_read_bool (dev,"no-1-8-v" );return 0 ; }include/sdhci.h +1
-0@@ -244,6 +244,7 @@#define SDHCI_QUIRK_BROKEN_HISPD_MODE BIT(5)#define SDHCI_QUIRK_WAIT_SEND_CMD (1 << 6)#define SDHCI_QUIRK_USE_WIDE8 (1 << 8) +#define SDHCI_QUIRK_NO_1_8_V (1 << 9)/* to make gcc happy */ struct sdhci_host ;
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
In reply to Michal SimekQuoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.
Even though it's similar to linux, does it need to add new macro?
Quoted 70 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h +13
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ +/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3 +#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ /**
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
Michal,
Quoted 62 lines · Jaehoon Chung
Quoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.Even though it's similar to linux, does it need to add new macro?
Quoted 53 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h +0
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */
Quoted 15 lines
Quoted 5 lines
include/mmc.h +5
-0+/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3include/mmc.h enum mmc_voltage { · line 377
Quoted 10 lines
include/mmc.h +8
-0+#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */
There's already an
enum bus_mode {
MMC_LEGACY,
MMC_HS,
SD_HS,
MMC_HS_52,
MMC_DDR_52,
UHS_SDR12,
UHS_SDR25,
UHS_SDR50,
UHS_DDR50,
UHS_SDR104,
MMC_HS_200,
MMC_HS_400,
MMC_HS_400_ES,
MMC_MODES_END
};in this file. Thats what the mmc core uses to represent timing. Please use the same symbols.
Thanks,
Faiz
PATCH 1/7 Revert "mmc: zynq: parse dt when probing"
In reply to Jaehoon ChungQuoted 27 lines · Jaehoon Chung
Hi
Quoted 24 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
This reverts commit
942b5fc03218d1c94468fc658e7dec65dabcc830.This is partial revert of the above commit.
mmc_of_parse()is reading no-1-8-v from device tree and if set, it is clearing the UHS speed capabilities ofcfg->host_caps.cfg->host_caps&= ~(UHS_CAPS |MMC_MODE_HS200|MMC_MODE_HS400 | MMC_MODE_HS400_ES);This is still missing to clear UHS speeds like
SDHCI_SUPPORT_SDR104,SDHCI_SUPPORT_SDR50andSDHCI_SUPPORT_DDR50.Even if we clear the flags
SDHCI_SUPPORT_XXXinmmc_of_parse(), these speed flags are getting set again incfg->host_capsinsdhci_setup_cfg().The reason for this is,
SDHCI_SUPPORT_XXXflags are cleared only if controller is not capable of supportingMMC_VDD_165_195volts.if (caps &
SDHCI_CAN_VDD_180)cfg->voltages |= MMC_VDD_165_195;
Quoted 7 lines
Quoted 3 lines
if (!(cfg->voltages &
MMC_VDD_165_195))caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50);I don't have a target to test with
zynq_sdhci.
If there is no effect no-1-8-v property, i think that it needs to fix main problem. I will check about this.
Have you had any time to take a look at it?
Thanks,
Michal
PATCH 1/7 Revert "mmc: zynq: parse dt when probing"
Hi,
Quoted 32 lines · Michal Simek
Quoted 31 lines · Jaehoon Chung
Hi
Quoted 27 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
This reverts commit
942b5fc03218d1c94468fc658e7dec65dabcc830.This is partial revert of the above commit.
mmc_of_parse()is reading no-1-8-v from device tree and if set, it is clearing the UHS speed capabilities ofcfg->host_caps.cfg->host_caps&= ~(UHS_CAPS |MMC_MODE_HS200|MMC_MODE_HS400 | MMC_MODE_HS400_ES);This is still missing to clear UHS speeds like
SDHCI_SUPPORT_SDR104,SDHCI_SUPPORT_SDR50andSDHCI_SUPPORT_DDR50.Even if we clear the flags
SDHCI_SUPPORT_XXXinmmc_of_parse(), these speed flags are getting set again incfg->host_capsinsdhci_setup_cfg().The reason for this is,
SDHCI_SUPPORT_XXXflags are cleared only if controller is not capable of supportingMMC_VDD_165_195volts.if (caps &
SDHCI_CAN_VDD_180)cfg->voltages |= MMC_VDD_165_195;if (!(cfg->voltages &
MMC_VDD_165_195))caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_DDR50);
Quoted 5 lines
Quoted 3 lines
I don't have a target to test with
zynq_sdhci.
If there is no effect no-1-8-v property, i think that it needs to fix main problem. I will check about this.Have you had any time to take a look at it?
Sorry for late. I think it was similar issue on my environment. I will share result within this week.
If it's urgent, then after merging i will find solution to fix it.
Best Regards,
Jaehoon Chung
Quoted 4 lines
Thanks,
Michal
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
In reply to Faiz AbbasHi Faiz,
Quoted 112 lines
-----Original Message-----
From: Faiz Abbas <[email protected]>
Sent: Wednesday, May 27, 2020 12:28 PM
To: Jaehoon Chung <[email protected]>; Michal Simek <[email protected]>; u-boot at lists.denx.de; git <[email protected]>
Cc: Ashok Reddy Soma <[email protected]>; Heinrich Schuchardt <[email protected]>; Lokesh Vutla <[email protected]>; Marek Vasut <[email protected]>; Masahiro Yamada <[email protected]>; Peng Fan <[email protected]>; Sam Protsenko <[email protected]>; Simon Glass <[email protected]>; Yann Gautier <[email protected]>
Subject: Re: [PATCH 2/7] mmc:zynq_sdhci: Define timing macro'sMichal,
Quoted 61 lines · Jaehoon Chung
Quoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.Even though it's similar to linux, does it need to add new macro?
Quoted 52 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h index renamed from include/mmc.h +0
-0
82562193cc48..05d8ab8eeac6100644include/mmc.h +0
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ Quoted 15 lines
Quoted 5 lines
include/mmc.h +5
-0+/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3include/mmc.h enum mmc_voltage { · line 377
Quoted 10 lines
include/mmc.h +8
-0+#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ There's already an
enum bus_mode { MMC_LEGACY, MMC_HS, SD_HS, MMC_HS_52, MMC_DDR_52, UHS_SDR12, UHS_SDR25, UHS_SDR50, UHS_DDR50, UHS_SDR104, MMC_HS_200, MMC_HS_400, MMC_HS_400_ES, MMC_MODES_END };
Quoted 2 lines
in this file. Thats what the mmc core uses to represent timing. Please use the same symbols.
The enum and macro differ in values. For example UHS_SDR12 macro value is 3 whereas enum will be 5.
This is a problem when accessing below arrays. I take these reference values from linux driver.
If the values change in future, it will be easy for u-boot driver to just copy and paste from linux driver if we use macro's.
/* Default settings for ZynqMP Clock Phases */
const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63, 0, 0, 183, 54, 0, 0};
const u32 zynqmp_oclk_phases[] = {0, 72, 60, 0, 60, 72, 135, 48, 72, 135, 0};
I also see that xenon_sdhci.c has defined these macro's locally.
https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/mmc/xenon_sdhci.c#L98
So I have added these macro's in include/mmc.h for everyone's use.
Quoted 3 lines
Thanks,
Faiz
Thanks,
Ashok
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
Hi Ashok,
Quoted 121 lines · Ashok Reddy Soma
Hi Faiz,
Quoted 112 lines
-----Original Message-----
From: Faiz Abbas <[email protected]>
Sent: Wednesday, May 27, 2020 12:28 PM
To: Jaehoon Chung <[email protected]>; Michal Simek <[email protected]>; u-boot at lists.denx.de; git <[email protected]>
Cc: Ashok Reddy Soma <[email protected]>; Heinrich Schuchardt <[email protected]>; Lokesh Vutla <[email protected]>; Marek Vasut <[email protected]>; Masahiro Yamada <[email protected]>; Peng Fan <[email protected]>; Sam Protsenko <[email protected]>; Simon Glass <[email protected]>; Yann Gautier <[email protected]>
Subject: Re: [PATCH 2/7] mmc:zynq_sdhci: Define timing macro'sMichal,
Quoted 61 lines · Jaehoon Chung
Quoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.Even though it's similar to linux, does it need to add new macro?
Quoted 52 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h index renamed from include/mmc.h +0
-0
82562193cc48..05d8ab8eeac6100644include/mmc.h +0
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ Quoted 15 lines
Quoted 5 lines
include/mmc.h +5
-0+/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3include/mmc.h enum mmc_voltage { · line 377
Quoted 10 lines
include/mmc.h +8
-0+#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ There's already an
enum bus_mode { MMC_LEGACY, MMC_HS, SD_HS, MMC_HS_52, MMC_DDR_52, UHS_SDR12, UHS_SDR25, UHS_SDR50, UHS_DDR50, UHS_SDR104, MMC_HS_200, MMC_HS_400, MMC_HS_400_ES, MMC_MODES_END };Quoted 2 lines
in this file. Thats what the mmc core uses to represent timing. Please use the same symbols.
The enum and macro differ in values. For example
UHS_SDR12macro value is 3 whereas enum will be 5.
This is a problem when accessing below arrays. I take these reference values from linux driver.
If the values change in future, it will be easy for u-boot driver to just copy and paste from linux driver if we use macro's.
Quoted 9 lines
/* Default settings for ZynqMP Clock Phases */
const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63, 0, 0, 183, 54, 0, 0};
const u32 zynqmp_oclk_phases[] = {0, 72, 60, 0, 60, 72, 135, 48, 72, 135, 0};I also see that
xenon_sdhci.chas defined these macro's locally.
https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/mmc/xenon_sdhci.c#L98So I have added these macro's in
include/mmc.hfor everyone's use.
A better approach would be to try to bring the U-boot macro in line with kernel. That way more drivers can take advantage of the similarities. Adding extra symbols just confuses people about which ones are being used in core and which ones in your driver.
Thanks,
Faiz
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
In reply to Ashok Reddy SomaQuoted 114 lines · Ashok Reddy Soma
Hi Faiz,
Quoted 112 lines
-----Original Message-----
From: Faiz Abbas <[email protected]>
Sent: Wednesday, May 27, 2020 12:28 PM
To: Jaehoon Chung <[email protected]>; Michal Simek <[email protected]>; u-boot at lists.denx.de; git <[email protected]>
Cc: Ashok Reddy Soma <[email protected]>; Heinrich Schuchardt <[email protected]>; Lokesh Vutla <[email protected]>; Marek Vasut <[email protected]>; Masahiro Yamada <[email protected]>; Peng Fan <[email protected]>; Sam Protsenko <[email protected]>; Simon Glass <[email protected]>; Yann Gautier <[email protected]>
Subject: Re: [PATCH 2/7] mmc:zynq_sdhci: Define timing macro'sMichal,
Quoted 61 lines · Jaehoon Chung
Quoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.Even though it's similar to linux, does it need to add new macro?
Quoted 52 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h index renamed from include/mmc.h +0
-0
82562193cc48..05d8ab8eeac6100644include/mmc.h +0
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ Quoted 15 lines
Quoted 5 lines
include/mmc.h +5
-0+/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3include/mmc.h enum mmc_voltage { · line 377
Quoted 10 lines
include/mmc.h +8
-0+#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ There's already an
enum bus_mode { MMC_LEGACY, MMC_HS, SD_HS, MMC_HS_52, MMC_DDR_52, UHS_SDR12, UHS_SDR25, UHS_SDR50, UHS_DDR50, UHS_SDR104, MMC_HS_200, MMC_HS_400, MMC_HS_400_ES, MMC_MODES_END };
Quoted 6 lines
Quoted 2 lines
in this file. Thats what the mmc core uses to represent timing. Please use the same symbols.
The enum and macro differ in values. For example
UHS_SDR12macro value is 3 whereas enum will be 5.
This is a problem when accessing below arrays. I take these reference values from linux driver.
If the values change in future, it will be easy for u-boot driver to just copy and paste from linux driver if we use macro's.
enum bus_mode is a specification which mode is. MMc_TIMING_xxx is a specification which timing is. As i know, its meaning is a little different. But it's not reason that can't use it. *specification* is using to make more readable. I don't have any objection to add or not. But i don't agree about copy and paste everything from linux driver.
Anyway, I don't know why you have to fix array value.
const u32 zynqmap_iclk_phases[] = {
[UHS_SDR12] = 0, ... }
Is it impossible to assign to proper value into array?
Quoted 9 lines
/* Default settings for ZynqMP Clock Phases */
const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63, 0, 0, 183, 54, 0, 0};
const u32 zynqmp_oclk_phases[] = {0, 72, 60, 0, 60, 72, 135, 48, 72, 135, 0};I also see that
xenon_sdhci.chas defined these macro's locally.
https://protect2.fireeye.com/url?k=34df76b5-69117766-34defdfa-000babff317b-0937b081dc4534f6&q=1&u=https%3A%2F%2Fgitlab.denx.de%2Fu-boot%2Fu-boot%2F-%2Fblob%2Fmaster%2Fdrivers%2Fmmc%2Fxenon_sdhci.c%23L98So I have added these macro's in
include/mmc.hfor everyone's use.
If you want to use this for everyone, i think that it needs to change subject. Your subject looks like adding it only for zynq_sdhci.
I think Peng also has his opinion. let's wait for his opinion.
Best Regards,
Jaehoon Chung
Quoted 8 lines
Quoted 4 lines
Thanks,
FaizThanks,
Ashok
PATCH 2/7 mmc: zynq_sdhci: Define timing macro's
Hi Jaehoon,
Quoted 133 lines
-----Original Message-----
From: Jaehoon Chung <[email protected]>
Sent: Wednesday, June 10, 2020 4:07 PM
To: Ashok Reddy Soma <[email protected]>; Faiz Abbas <[email protected]>; Michal Simek <[email protected]>; u- boot at lists.denx.de; git <[email protected]>
Cc: Heinrich Schuchardt <[email protected]>; Lokesh Vutla <[email protected]>; Marek Vasut <[email protected]>; Masahiro Yamada <[email protected]>; Peng Fan <[email protected]>; Sam Protsenko <[email protected]>; Simon Glass <[email protected]>; Yann Gautier <[email protected]>
Subject: Re: [PATCH 2/7] mmc:zynq_sdhci: Define timing macro'sQuoted 10 lines · Ashok Reddy Soma
Hi Faiz,
Quoted 8 lines
-----Original Message-----
From: Faiz Abbas <[email protected]>
Sent: Wednesday, May 27, 2020 12:28 PM
To: Jaehoon Chung <[email protected]>; Michal Simek <[email protected]>; u-boot at lists.denx.de; git <[email protected]>
Cc: Ashok Reddy Soma <[email protected]>; Heinrich Schuchardt <[email protected]>; Lokesh Vutla <[email protected]>; Marek Vasut <[email protected]>; Masahiro Yamada <[email protected]>;Peng
Quoted 1 line
Quoted 1 line
Fan <[email protected]>; Sam Protsenko
Quoted 102 lines
Quoted 102 lines
Simon Glass <[email protected]>; Yann Gautier <[email protected]>
Subject: Re: [PATCH 2/7] mmc:zynq_sdhci: Define timing macro'sMichal,
Quoted 61 lines · Jaehoon Chung
Quoted 5 lines · Michal Simek
From: Ashok Reddy Soma <[email protected]>
Define timing macro's for all the available speeds of mmc. This is done similar to linux. Replace other macro's used in
zynq_sdhci.cwith these new macro's.Even though it's similar to linux, does it need to add new macro?
Quoted 52 lines
Signed-off-by Ashok Reddy Soma <[email protected]>Signed-off-by Michal Simek <[email protected]>---
drivers/mmc/zynq_sdhci.c | 24 +++++++++++------------- include/mmc.h | 13 +++++++++++++ 2 files changed, 24 insertions(+), 13 deletions(-)drivers/mmc/zynq_sdhci.c +11
-13@@ -32,20 +32,18 @@ struct arasan_sdhci_priv { };#if defined(CONFIG_ARCH_ZYNQMP ) -#define MMC_HS200_BUS_SPEED 5 -static const u8 mode2timing[] = { - [MMC_LEGACY ] =UHS_SDR12_BUS_SPEED , - [MMC_HS ] =HIGH_SPEED_BUS_SPEED , - [SD_HS ] =HIGH_SPEED_BUS_SPEED , - [MMC_HS_52 ] =HIGH_SPEED_BUS_SPEED , - [MMC_DDR_52 ] =HIGH_SPEED_BUS_SPEED , - [UHS_SDR12 ] =UHS_SDR12_BUS_SPEED , - [UHS_SDR25 ] =UHS_SDR25_BUS_SPEED , - [UHS_SDR50 ] =UHS_SDR50_BUS_SPEED , - [UHS_DDR50 ] =UHS_DDR50_BUS_SPEED , - [UHS_SDR104 ] =UHS_SDR104_BUS_SPEED , - [MMC_HS_200 ] =MMC_HS200_BUS_SPEED , + [MMC_LEGACY ] =MMC_TIMING_LEGACY , + [MMC_HS ] =MMC_TIMING_MMC_HS , + [SD_HS ] =MMC_TIMING_SD_HS , + [MMC_HS_52 ] =MMC_TIMING_UHS_SDR50 , + [MMC_DDR_52 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR12 ] =MMC_TIMING_UHS_SDR12 , + [UHS_SDR25 ] =MMC_TIMING_UHS_SDR25 , + [UHS_SDR50 ] =MMC_TIMING_UHS_SDR50 , + [UHS_DDR50 ] =MMC_TIMING_UHS_DDR50 , + [UHS_SDR104 ] =MMC_TIMING_UHS_SDR104 , + [MMC_HS_200 ] =MMC_TIMING_MMC_HS200 , };#define SDHCI_TUNING_LOOP_COUNT 40include/mmc.h index renamed from include/mmc.h +0
-0
82562193cc48..05d8ab8eeac6100644include/mmc.h +0
-0@@ -360,6 +360,19 @@ enum mmc_voltage {#define MMC_NUM_BOOT_PARTITION 2#define MMC_PART_RPMB 3/* RPMB partition number */ Quoted 15 lines
Quoted 5 lines
include/mmc.h +5
-0+/* timing specification used */ +#define MMC_TIMING_LEGACY 0 +#define MMC_TIMING_MMC_HS 1 +#define MMC_TIMING_SD_HS 2 +#define MMC_TIMING_UHS_SDR12 3include/mmc.h enum mmc_voltage { · line 377
Quoted 10 lines
include/mmc.h +8
-0+#define MMC_TIMING_UHS_SDR25 4 +#define MMC_TIMING_UHS_SDR50 5 +#define MMC_TIMING_UHS_SDR104 6 +#define MMC_TIMING_UHS_DDR50 7 +#define MMC_TIMING_MMC_DDR52 8 +#define MMC_TIMING_MMC_HS200 9 +#define MMC_TIMING_MMC_HS400 10 +/* Driver model support */ There's already an
enum bus_mode { MMC_LEGACY, MMC_HS, SD_HS, MMC_HS_52, MMC_DDR_52, UHS_SDR12, UHS_SDR25, UHS_SDR50, UHS_DDR50, UHS_SDR104, MMC_HS_200, MMC_HS_400, MMC_HS_400_ES, MMC_MODES_END };Quoted 4 lines
Quoted 2 lines
in this file. Thats what the mmc core uses to represent timing. Please use the same symbols.
The enum and macro differ in values. For example
UHS_SDR12macro value
Quoted 8 lines
is 3 whereas enum will be 5.
Quoted 1 line
This is a problem when accessing below arrays. I take these reference
values from linux driver.
Quoted 1 line
If the values change in future, it will be easy for u-boot driver to just copy
and paste from linux driver if we use macro's.
enum
bus_modeis a specification which mode is.MMc_TIMING_xxxis a specification which timing is.
Correct, these timing macro's are being used for setting phase delays. That was the background.
Quoted 7 lines
As i know, its meaning is a little different. But it's not reason that can't use it. *specification* is using to make more readable. I don't have any objection to add or not.
But i don't agree about copy and paste everything from linux driver.Anyway, I don't know why you have to fix array value.
Quoted 7 lines
const u32 zynqmap_iclk_phases[] = {
[UHS_SDR12] = 0, ... }Is it impossible to assign to proper value into array?
It can be done, I just quoted a example.
Quoted 11 lines
Quoted 11 lines
/* Default settings for ZynqMP Clock Phases */
const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63, 0, 0, 183, 54, 0, 0};
const u32 zynqmp_oclk_phases[] = {0, 72, 60, 0, 60, 72, 135, 48, 72,
135, 0};I also see that
xenon_sdhci.chas defined these macro's locally.
https://protect2.fireeye.com/url?k=34df76b5-69117766-34defdfa-000babff
317b-0937b081dc4534f6&q=1&u=https%3A%2F%2Fgitlab.denx.de%2Fu-
Quoted 7 lines
boot%2Fu-
Quoted 3 lines
boot%2F-%2Fblob%2Fmaster%2Fdrivers%2Fmmc%2Fxenon_sdhci.c%23L98
So I have added these macro's in
include/mmc.hfor everyone's use.If you want to use this for everyone, i think that it needs to change subject. Your subject looks like adding it only for
zynq_sdhci.
Sure, I will change the subject and send v2.
Quoted 2 lines
I think Peng also has his opinion. let's wait for his opinion.
Sure.
Quoted 12 lines
Best Regards,
Jaehoon ChungQuoted 8 lines
Quoted 4 lines
Thanks,
FaizThanks,
Ashok