btrfs: add ioctls and send/receive support for reading/writing compressed data
Subsystems (3)
v12 cover btrfs: add ioctls and send/receive support for reading/writing compressed data
From: Omar Sandoval <[email protected]>
This series has three parts: new Btrfs ioctls for reading/writing compressed data, support for sending compressed data via Btrfs send, and btrfs-progs support for sending/receiving compressed data and writing it with the new ioctl.
Patches 1 and 2 are VFS changes exporting a couple of helpers for checks needed by reads and writes. Patches 3-8 are preparatory Btrfs changes for compressed reads and writes. Patch 6 is a cleanup. Patch 9 adds the compressed read ioctl and patch 10 adds the compressed write ioctl.
The main use-case for this interface is Btrfs send/receive. Currently, when sending data from one compressed filesystem to another, the sending side decompresses the data and the receiving side recompresses it before writing it out. This is wasteful and can be avoided if we can just send and write compressed extents.
Patches 11 and 12 are cleanups for Btrfs send. Patches 13-17 add the Btrfs send support. See the previous posting for more details and benchmarks [1]. Patches 13-15 prepare some protocol changes for send stream v2. Patch 16 implements compressed send. Patch 17 enables send stream v2 and compressed send in the send ioctl when requested.
These patches are based on Dave Sterba's Btrfs misc-next branch [2], which is in turn currently based on v5.16-rc1. Test cases are here [3].
Changes since v11 [4]:
- Rebased.
- Reworked send stream protocol versioning based on Dave's approach.
- Split up cow_file_range_inline() change into refactoring change and functional change.
- Added enforcement that BTRFS_SEND_A_DATA is always sent last.
- Fixed uninitialized variable reported by kernel test robot.
- Cleaned up some more style nits.
- Added and clarified some comments.
- Changed "page" nomenclature to "sector" for LZO.
1: https://lore.kernel.org/linux-btrfs/[email protected]/
2: https://github.com/kdave/btrfs-devel/tree/misc-next
3: https://github.com/osandov/xfstests/tree/btrfs-encoded-io
4: https://lore.kernel.org/linux-btrfs/[email protected]/
Omar Sandoval (17):
fs: export rw_verify_area()
fs: export variant of generic_write_checks without iov_iter
btrfs: don't advance offset for compressed bios in
btrfs_csum_one_bio()
btrfs: add ram_bytes and offset to btrfs_ordered_extent
btrfs: support different disk extent size for delalloc
btrfs: clean up cow_file_range_inline()
btrfs: optionally extend i_size in cow_file_range_inline()
btrfs: add definitions + documentation for encoded I/O ioctls
btrfs: add BTRFS_IOC_ENCODED_READ
btrfs: add BTRFS_IOC_ENCODED_WRITE
btrfs: send: remove unused send_ctx::{total,cmd}_send_size
btrfs: send: fix maximum command numbering
btrfs: add send stream v2 definitions
btrfs: send: write larger chunks when using stream v2
btrfs: send: allocate send buffer with alloc_page() and vmap() for v2
btrfs: send: send compressed extents with encoded writes
btrfs: send: enable support for stream v2 and compressed writes
fs/btrfs/compression.c | 10 +- fs/btrfs/compression.h | 6 +- fs/btrfs/ctree.h | 17 +- fs/btrfs/delalloc-space.c | 18 +- fs/btrfs/file-item.c | 32 +- fs/btrfs/file.c | 68 ++- fs/btrfs/inode.c | 927 +++++++++++++++++++++++++++++++++---- fs/btrfs/ioctl.c | 208 +++++++++ fs/btrfs/ordered-data.c | 131 ++---- fs/btrfs/ordered-data.h | 25 +- fs/btrfs/relocation.c | 2 +- fs/btrfs/send.c | 324 +++++++++++-- fs/btrfs/send.h | 39 +- fs/internal.h | 5 - fs/read_write.c | 34 +- include/linux/fs.h | 2 + include/uapi/linux/btrfs.h | 142 +++++- 17 files changed, 1704 insertions(+), 286 deletions(-)
The btrfs-progs patches were written by Boris Burkov with some updates from me. Patches 1-4 are preparation. Patch 5 implements encoded writes. Patch 6 implements the fallback to decompressing. Patches 7 and 8 implement the other commands. Patch 9 adds the new btrfs send options. Patch 10 adds a test case.
Boris Burkov (10):
btrfs-progs: receive: support v2 send stream larger tlv_len
btrfs-progs: receive: dynamically allocate sctx->read_buf
btrfs-progs: receive: support v2 send stream DATA tlv format
btrfs-progs: receive: add send stream v2 cmds and attrs to send.h
btrfs-progs: receive: process encoded_write commands
btrfs-progs: receive: encoded_write fallback to explicit decode and
write
btrfs-progs: receive: process fallocate commands
btrfs-progs: receive: process setflags ioctl commands
btrfs-progs: send: stream v2 ioctl flags
btrfs-progs: receive: add tests for basic encoded_write send/receive
Documentation/btrfs-receive.asciidoc | 4 + Documentation/btrfs-send.asciidoc | 18 +- cmds/receive-dump.c | 31 +- cmds/receive.c | 347 +++++++++++++++++- cmds/send.c | 92 ++++- common/send-stream.c | 165 +++++++-- common/send-stream.h | 7 + ioctl.h | 151 +++++++- kernel-shared/send.h | 39 +- libbtrfs/send-stream.c | 2 +- .../052-receive-write-encoded/test.sh | 114 ++++++ 11 files changed, 924 insertions(+), 46 deletions(-) create mode 100755 tests/misc-tests/052-receive-write-encoded/test.sh
Signature · 1 line
2.34.0
PATCH v12 1/17 fs: export rw_verify_area()
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in rw_verify_area(), let's just export it.
--- fs/internal.h | 5 ----- fs/read_write.c | 1 + include/linux/fs.h | 1 + 3 files changed, 2 insertions(+), 5 deletions(-)
fs/internal.h +0 -5
@@ -157,11 +157,6 @@ extern char *simple_dname(struct dentry *, char *, int);extern void dput_to_list (struct dentry *,struct list_head *);extern void shrink_dentry_list (struct list_head *); -/* -* read_write.c -*/ -extern int rw_verify_area (int ,struct file *,const loff_t *,size_t ); -/* * pipe.c */
fs/read_write.c +1 -0
@@ -385,6 +385,7 @@ int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_treturn security_file_permission (file, read_write ==READ ?MAY_READ :MAY_WRITE ); } +EXPORT_SYMBOL (rw_verify_area);static ssize_t new_sync_read (struct file *filp,char __user *buf,size_t len,loff_t *ppos) {
include/linux/fs.h +1 -0
@@ -3244,6 +3244,7 @@ extern loff_t fixed_size_llseek(struct file *file, loff_t offset, int whence, loff_t size);extern loff_t no_seek_end_llseek_size (struct file *,loff_t ,int ,loff_t );extern loff_t no_seek_end_llseek (struct file *,loff_t ,int ); +extern int rw_verify_area (int ,struct file *,const loff_t *,size_t );extern int generic_file_open (struct inode * inode,struct file * filp);extern int nonseekable_open (struct inode * inode,struct file * filp);extern int stream_open (struct inode * inode,struct file * filp);
Signature · 1 line
2.34.0
PATCH v12 2/17 fs: export variant of generic_write_checks without iov_iter
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Encoded I/O in Btrfs needs to check a write with a given logical size without an iov_iter that matches that size (because the iov_iter we have is for the compressed data). So, factor out the parts of generic_write_check() that don't need an iov_iter into a new generic_write_checks_count() function and export that.
--- fs/read_write.c | 33 ++++++++++++++++++++------------- include/linux/fs.h | 1 + 2 files changed, 21 insertions(+), 13 deletions(-)
fs/read_write.c +20 -13
@@ -1618,24 +1618,16 @@ int generic_write_check_limits(struct file *file, loff_t pos, loff_t *count)return 0 ; } -/* -* Performs necessary checks before doing a write -* -* Can adjust writing position or amount of bytes to write. -* Returns appropriate error code that caller should return or -* zero in case that write should be allowed. -*/ -ssize_t generic_write_checks (struct kiocb *iocb,struct iov_iter *from) +/* Like generic_write_checks(), but takes size of write instead of iter. */ +int generic_write_checks_count (struct kiocb *iocb,loff_t *count) {struct file *file = iocb->ki_filp;struct inode *inode = file->f_mapping->host; -loff_t count; -int ret;if (IS_SWAPFILE (inode))return -ETXTBSY ; -if (!iov_iter_count (from)) +if (!*count)return 0 ;/* FIXME: this is for backwards compatibility with 2.4 */
@@ -1645,8 +1637,23 @@ ssize_t generic_write_checks(struct kiocb *iocb, struct iov_iter *from)if ((iocb->ki_flags &IOCB_NOWAIT ) && !(iocb->ki_flags &IOCB_DIRECT ))return -EINVAL ; - count =iov_iter_count (from); - ret =generic_write_check_limits (file, iocb->ki_pos, &count); +return generic_write_check_limits (iocb->ki_filp, iocb->ki_pos, count); +} +EXPORT_SYMBOL (generic_write_checks_count); + +/* +* Performs necessary checks before doing a write +* +* Can adjust writing position or amount of bytes to write. +* Returns appropriate error code that caller should return or +* zero in case that write should be allowed. +*/ +ssize_t generic_write_checks (struct kiocb *iocb,struct iov_iter *from) +{ +loff_t count =iov_iter_count (from); +int ret; + + ret =generic_write_checks_count (iocb, &count);if (ret)return ret;
include/linux/fs.h +1 -0
@@ -3201,6 +3201,7 @@ extern int sb_min_blocksize(struct super_block *, int);extern int generic_file_mmap (struct file *,struct vm_area_struct *);extern int generic_file_readonly_mmap (struct file *,struct vm_area_struct *);extern ssize_t generic_write_checks (struct kiocb *,struct iov_iter *); +extern int generic_write_checks_count (struct kiocb *iocb,loff_t *count);extern int generic_write_check_limits (struct file *file,loff_t pos,loff_t *count);extern int generic_file_rw_checks (struct file *file_in,struct file *file_out);
Signature · 1 line
2.34.0
PATCH v12 3/17 btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio()
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
btrfs_csum_one_bio() loops over each filesystem block in the bio while keeping a cursor of its current logical position in the file in order to look up the ordered extent to add the checksums to. However, this doesn't make much sense for compressed extents, as a sector on disk does not correspond to a sector of decompressed file data. It happens to work because 1) the compressed bio always covers one ordered extent and 2) the size of the bio is always less than the size of the ordered extent. However, the second point will not always be true for encoded writes.
Let's add a boolean parameter to btrfs_csum_one_bio() to indicate that it can assume that the bio only covers one ordered extent. Since we're already changing the signature, let's get rid of the contig parameter and make it implied by the offset parameter, similar to the change we recently made to btrfs_lookup_bio_sums(). Additionally, let's rename nr_sectors to blockcount to make it clear that it's the number of filesystem blocks, not the number of 512-byte sectors.
--- fs/btrfs/compression.c | 3 ++- fs/btrfs/ctree.h | 2 +- fs/btrfs/file-item.c | 32 ++++++++++++++------------------ fs/btrfs/inode.c | 8 ++++---- 4 files changed, 21 insertions(+), 24 deletions(-)
fs/btrfs/compression.c +2 -1
@@ -590,7 +590,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,if (submit) {if (!skip_sum) { - ret =btrfs_csum_one_bio (inode, bio, start,1 ); + ret =btrfs_csum_one_bio (inode, bio, start, + true);if (ret) goto finish_cb; }
fs/btrfs/ctree.h +1 -1
@@ -3169,7 +3169,7 @@ int btrfs_csum_file_blocks(struct btrfs_trans_handle *trans,struct btrfs_root *root, struct btrfs_ordered_sum *sums);blk_status_t btrfs_csum_one_bio (struct btrfs_inode *inode,struct bio *bio, -u64 file_start,int contig); +u64 offset,bool one_ordered);int btrfs_lookup_csums_range (struct btrfs_root *root,u64 start,u64 end,struct list_head *list,int search_commit); void btrfs_extent_item_to_extent_map(struct btrfs_inode *inode,
fs/btrfs/file-item.c +14 -18
@@ -613,28 +613,28 @@ int btrfs_lookup_csums_range(struct btrfs_root *root, u64 start, u64 end,* btrfs_csum_one_bio - Calculates checksums of the data contained inside a bio * @inode: Owner of the data inside the bio * @bio: Contains the data to be checksummed -* @file_start: offset in file this bio begins to describe -* @contig: Boolean. If true/1 means all bio vecs in this bio are -* contiguous and they begin at @file_start in the file. False/0 -* means this bio can contain potentially discontiguous bio vecs -* so the logical offset of each should be calculated separately. +* @offset: If (u64)-1, @bio may contain discontiguous bio vecs, so the +* file offsets are determined from the page offsets in the bio. +* Otherwise, this is the starting file offset of the bio vecs in +* @bio, which must be contiguous. +* @one_ordered: If true, @bio only refers to one ordered extent. */ blk_status_t btrfs_csum_one_bio (struct btrfs_inode *inode,struct bio *bio, -u64 file_start,int contig) +u64 offset,bool one_ordered) {struct btrfs_fs_info *fs_info = inode->root->fs_info;SHASH_DESC_ON_STACK (shash, fs_info->csum_shash);struct btrfs_ordered_sum *sums;struct btrfs_ordered_extent *ordered =NULL ; +const bool use_page_offsets = (offset == (u64)-1 );char *data;struct bvec_iter iter;struct bio_vec bvec;int index; -int nr_sectors; +int blockcount;unsigned long total_bytes =0 ;unsigned long this_sum_bytes =0 ;int i; -u64 offset;unsigned nofs_flag; nofs_flag =memalloc_nofs_save ();
@@ -648,18 +648,13 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio, sums->len = bio->bi_iter.bi_size;INIT_LIST_HEAD (&sums->list); -if (contig) - offset = file_start; -else - offset =0 ;/* shut up gcc */ - sums->bytenr = bio->bi_iter.bi_sector <<9 ; index =0 ; shash->tfm = fs_info->csum_shash;bio_for_each_segment (bvec, bio, iter) { -if (!contig) +if (use_page_offsets) offset =page_offset (bvec.bv_page) + bvec.bv_offset;if (!ordered) {
@@ -678,13 +673,14 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio, } } - nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, + blockcount =BTRFS_BYTES_TO_BLKS (fs_info, bvec.bv_len + fs_info->sectorsize -1 ); -for (i =0 ; i < nr_sectors; i++) { -if (offset >= ordered->file_offset + ordered->num_bytes || - offset < ordered->file_offset) { +for (i =0 ; i < blockcount; i++) { +if (!one_ordered && + !in_range (offset, ordered->file_offset, + ordered->num_bytes)) {unsigned long bytes_left; sums->len = this_sum_bytes;
fs/btrfs/inode.c +4 -4
@@ -2308,7 +2308,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode,static blk_status_t btrfs_submit_bio_start (struct inode *inode,struct bio *bio,u64 dio_file_offset) { -return btrfs_csum_one_bio (BTRFS_I (inode), bio,0 ,0 ); +return btrfs_csum_one_bio (BTRFS_I (inode), bio, (u64)-1 , false); }/*
@@ -2560,7 +2560,7 @@ blk_status_t btrfs_submit_data_bio(struct inode *inode, struct bio *bio, 0, btrfs_submit_bio_start); goto out; }else if (!skip_sum) { - ret =btrfs_csum_one_bio (BTRFS_I (inode), bio,0 ,0 ); + ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, (u64)-1 , false);if (ret) goto out; }
@@ -8162,7 +8162,7 @@ static blk_status_t btrfs_submit_bio_start_direct_io(struct inode *inode,struct bio *bio, u64 dio_file_offset) { - return btrfs_csum_one_bio(BTRFS_I(inode), bio, dio_file_offset, 1); + return btrfs_csum_one_bio(BTRFS_I(inode), bio, dio_file_offset, false); }static void btrfs_end_dio_bio (struct bio *bio)
@@ -8219,7 +8219,7 @@ static inline blk_status_t btrfs_submit_dio_bio(struct bio *bio,* If we aren't doing async submit, calculate the csum of the * bio now. */ - ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, file_offset,1 ); + ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, file_offset, false);if (ret) goto err; }else {
Signature · 1 line
2.34.0
PATCH v12 4/17 btrfs: add ram_bytes and offset to btrfs_ordered_extent
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, we only create ordered extents when ram_bytes == num_bytes and offset == 0. However, BTRFS_IOC_ENCODED_WRITE writes may create extents which only refer to a subset of the full unencoded extent, so we need to plumb these fields through the ordered extent infrastructure and pass them down to insert_reserved_file_extent().
Since we're changing the btrfs_add_ordered_extent* signature, let's get rid of the trivial wrappers and add a kernel-doc.
--- fs/btrfs/inode.c | 58 ++++++++++++-------- fs/btrfs/ordered-data.c | 119 ++++++++++++---------------------------- fs/btrfs/ordered-data.h | 22 +++++--- 3 files changed, 82 insertions(+), 117 deletions(-)
fs/btrfs/inode.c +35 -23
@@ -980,11 +980,14 @@ static int submit_one_async_extent(struct btrfs_inode *inode, }free_extent_map (em); - ret =btrfs_add_ordered_extent_compress (inode, start,/* file_offset */ - ins.objectid,/* disk_bytenr */ - async_extent->ram_size,/* num_bytes */ - ins.offset,/* disk_num_bytes */ - async_extent->compress_type); + ret =btrfs_add_ordered_extent (inode, start,/* file_offset */ + async_extent->ram_size,/* num_bytes */ + async_extent->ram_size,/* ram_bytes */ + ins.objectid,/* disk_bytenr */ + ins.offset,/* disk_num_bytes */ +0 ,/* offset */ +1 <<BTRFS_ORDERED_COMPRESSED , + async_extent->compress_type);if (ret) {btrfs_drop_extent_cache (inode, start, end,0 ); goto out_free_reserve;
@@ -1233,9 +1236,10 @@ static noinline int cow_file_range(struct btrfs_inode *inode, }free_extent_map (em); - ret =btrfs_add_ordered_extent (inode, start, ins.objectid, - ram_size, cur_alloc_size, -BTRFS_ORDERED_REGULAR ); + ret =btrfs_add_ordered_extent (inode, start, ram_size, ram_size, + ins.objectid, cur_alloc_size,0 , +1 <<BTRFS_ORDERED_REGULAR , +BTRFS_COMPRESS_NONE );if (ret) goto out_drop_extent_cache;
@@ -1893,10 +1897,11 @@ static noinline int run_delalloc_nocow(struct btrfs_inode *inode, goto error; }free_extent_map (em); - ret =btrfs_add_ordered_extent (inode, cur_offset, - disk_bytenr, num_bytes, - num_bytes, -BTRFS_ORDERED_PREALLOC ); + ret =btrfs_add_ordered_extent (inode, + cur_offset, num_bytes, num_bytes, + disk_bytenr, num_bytes,0 , +1 <<BTRFS_ORDERED_PREALLOC , +BTRFS_COMPRESS_NONE );if (ret) { btrfs_drop_extent_cache(inode, cur_offset, cur_offset + num_bytes - 1,
@@ -1905,9 +1910,11 @@ static noinline int run_delalloc_nocow(struct btrfs_inode *inode, } }else { ret =btrfs_add_ordered_extent (inode, cur_offset, + num_bytes, num_bytes, disk_bytenr, num_bytes, - num_bytes, -BTRFS_ORDERED_NOCOW ); +0 , +1 <<BTRFS_ORDERED_NOCOW , +BTRFS_COMPRESS_NONE );if (ret) goto error; }
@@ -2864,6 +2871,7 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans,struct btrfs_key ins;u64 disk_num_bytes =btrfs_stack_file_extent_disk_num_bytes (stack_fi);u64 disk_bytenr =btrfs_stack_file_extent_disk_bytenr (stack_fi); +u64 offset =btrfs_stack_file_extent_offset (stack_fi);u64 num_bytes =btrfs_stack_file_extent_num_bytes (stack_fi);u64 ram_bytes =btrfs_stack_file_extent_ram_bytes (stack_fi);struct btrfs_drop_extents_args drop_args = {0 };
@@ -2938,7 +2946,8 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans, goto out; ret =btrfs_alloc_reserved_file_extent (trans, root,btrfs_ino (inode), - file_pos, qgroup_reserved, &ins); + file_pos - offset, + qgroup_reserved, &ins); out:btrfs_free_path (path);
@@ -2964,20 +2973,20 @@ static int insert_ordered_extent_file_extent(struct btrfs_trans_handle *trans, struct btrfs_ordered_extent *oe) {struct btrfs_file_extent_item stack_fi; -u64 logical_len;bool update_inode_bytes; +u64 num_bytes = oe->num_bytes; +u64 ram_bytes = oe->ram_bytes;memset (&stack_fi,0 ,sizeof (stack_fi));btrfs_set_stack_file_extent_type (&stack_fi,BTRFS_FILE_EXTENT_REG );btrfs_set_stack_file_extent_disk_bytenr (&stack_fi, oe->disk_bytenr);btrfs_set_stack_file_extent_disk_num_bytes (&stack_fi, oe->disk_num_bytes); +btrfs_set_stack_file_extent_offset (&stack_fi, oe->offset);if (test_bit (BTRFS_ORDERED_TRUNCATED , &oe->flags)) - logical_len = oe->truncated_len; -else - logical_len = oe->num_bytes; -btrfs_set_stack_file_extent_num_bytes (&stack_fi, logical_len); -btrfs_set_stack_file_extent_ram_bytes (&stack_fi, logical_len); + num_bytes = ram_bytes = oe->truncated_len; +btrfs_set_stack_file_extent_num_bytes (&stack_fi, num_bytes); +btrfs_set_stack_file_extent_ram_bytes (&stack_fi, ram_bytes);btrfs_set_stack_file_extent_compression (&stack_fi, oe->compress_type);/* Encryption and other encoding is reserved and all 0 */
@@ -7399,8 +7408,11 @@ static struct extent_map *btrfs_create_dio_extent(struct btrfs_inode *inode,if (IS_ERR (em)) goto out; } - ret =btrfs_add_ordered_extent_dio (inode, start, block_start, len, - block_len, type); + ret =btrfs_add_ordered_extent (inode, start, len, len, block_start, + block_len,0 , + (1 << type) | + (1 <<BTRFS_ORDERED_DIRECT ), +BTRFS_COMPRESS_NONE );if (ret) {if (em) {free_extent_map (em);
fs/btrfs/ordered-data.c +34 -85
167 lines not on this page · raw message
fs/btrfs/ordered-data.h +13 -9
@@ -76,6 +76,13 @@ enum { BTRFS_ORDERED_PENDING, }; +/* BTRFS_ORDERED_* flags that specify the type of the extent. */ +#define BTRFS_ORDERED_TYPE_FLAGS ((1UL << BTRFS_ORDERED_REGULAR) | \ + (1UL << BTRFS_ORDERED_NOCOW) | \ + (1UL << BTRFS_ORDERED_PREALLOC) | \ + (1UL << BTRFS_ORDERED_COMPRESSED) | \ + (1UL << BTRFS_ORDERED_DIRECT)) +struct btrfs_ordered_extent {/* logical offset in the file */ u64 file_offset;
@@ -84,9 +91,11 @@ struct btrfs_ordered_extent {* These fields directly correspond to the same fields in * btrfs_file_extent_item. */ -u64 disk_bytenr;u64 num_bytes; +u64 ram_bytes; +u64 disk_bytenr;u64 disk_num_bytes; +u64 offset;/* number of bytes that still need writing */ u64 bytes_left;
@@ -179,14 +188,9 @@ bool btrfs_dec_test_ordered_pending(struct btrfs_inode *inode,struct btrfs_ordered_extent **cached, u64 file_offset, u64 io_size);int btrfs_add_ordered_extent (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes,u64 disk_num_bytes, -int type); -int btrfs_add_ordered_extent_dio (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes, -u64 disk_num_bytes,int type); -int btrfs_add_ordered_extent_compress (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes, -u64 disk_num_bytes,int compress_type); +u64 num_bytes,u64 ram_bytes,u64 disk_bytenr, +u64 disk_num_bytes,u64 offset,int flags, +int compress_type);void btrfs_add_ordered_sum (struct btrfs_ordered_extent *entry,struct btrfs_ordered_sum *sum); struct btrfs_ordered_extent *btrfs_lookup_ordered_extent(struct btrfs_inode *inode,
Signature · 1 line
2.34.0
PATCH v12 5/17 btrfs: support different disk extent size for delalloc
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, we always reserve the same extent size in the file and extent size on disk for delalloc because the former is the worst case for the latter. For BTRFS_IOC_ENCODED_WRITE writes, we know the exact size of the extent on disk, which may be less than or greater than (for bookends) the size in the file. Add a disk_num_bytes parameter to btrfs_delalloc_reserve_metadata() so that we can reserve the correct amount of csum bytes. No functional change.
--- fs/btrfs/ctree.h | 3 ++- fs/btrfs/delalloc-space.c | 18 ++++++++++-------- fs/btrfs/file.c | 3 ++- fs/btrfs/inode.c | 4 ++-- fs/btrfs/relocation.c | 2 +- 5 files changed, 17 insertions(+), 13 deletions(-)
fs/btrfs/ctree.h +2 -1
@@ -2823,7 +2823,8 @@ void btrfs_subvolume_release_metadata(struct btrfs_root *root, struct btrfs_block_rsv *rsv);void btrfs_delalloc_release_extents (struct btrfs_inode *inode,u64 num_bytes); -int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes); +int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes, +u64 disk_num_bytes);u64 btrfs_account_ro_block_groups_free_space (struct btrfs_space_info *sinfo);int btrfs_error_unpin_extent_range (struct btrfs_fs_info *fs_info,u64 start,u64 end);
fs/btrfs/delalloc-space.c +10 -8
@@ -267,11 +267,11 @@ static void btrfs_calculate_inode_block_rsv_size(struct btrfs_fs_info *fs_info, }static void calc_inode_reservations (struct btrfs_fs_info *fs_info, -u64 num_bytes,u64 *meta_reserve, -u64 *qgroup_reserve) +u64 num_bytes,u64 disk_num_bytes, +u64 *meta_reserve,u64 *qgroup_reserve) {u64 nr_extents =count_max_extents (num_bytes); -u64 csum_leaves =btrfs_csum_bytes_to_leaves (fs_info, num_bytes); +u64 csum_leaves =btrfs_csum_bytes_to_leaves (fs_info, disk_num_bytes);u64 inode_update =btrfs_calc_metadata_size (fs_info,1 ); *meta_reserve = btrfs_calc_insert_metadata_size(fs_info,
@@ -285,7 +285,8 @@ static void calc_inode_reservations(struct btrfs_fs_info *fs_info, *qgroup_reserve = nr_extents * fs_info->nodesize; } -int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes) +int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes, +u64 disk_num_bytes) {struct btrfs_root *root = inode->root;struct btrfs_fs_info *fs_info = root->fs_info;
@@ -315,6 +316,7 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes) } num_bytes =ALIGN (num_bytes, fs_info->sectorsize); + disk_num_bytes =ALIGN (disk_num_bytes, fs_info->sectorsize);/* * We always want to do it this way, every other way is wrong and ends
@@ -326,8 +328,8 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes)* everything out and try again, which is bad. This way we just * over-reserve slightly, and clean up the mess when we are done. */ -calc_inode_reservations (fs_info, num_bytes, &meta_reserve, - &qgroup_reserve); +calc_inode_reservations (fs_info, num_bytes, disk_num_bytes, + &meta_reserve, &qgroup_reserve); ret =btrfs_qgroup_reserve_meta_prealloc (root, qgroup_reserve, true);if (ret)return ret;
@@ -346,7 +348,7 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes)spin_lock (&inode->lock); nr_extents =count_max_extents (num_bytes);btrfs_mod_outstanding_extents (inode, nr_extents); - inode->csum_bytes += num_bytes; + inode->csum_bytes += disk_num_bytes;btrfs_calculate_inode_block_rsv_size (fs_info, inode);spin_unlock (&inode->lock);
@@ -451,7 +453,7 @@ int btrfs_delalloc_reserve_space(struct btrfs_inode *inode, ret =btrfs_check_data_free_space (inode, reserved, start, len);if (ret <0 )return ret; - ret =btrfs_delalloc_reserve_metadata (inode, len); + ret =btrfs_delalloc_reserve_metadata (inode, len, len);if (ret <0 )btrfs_free_reserved_data_space (inode, *reserved, start, len);return ret;
fs/btrfs/file.c +2 -1
@@ -1749,7 +1749,8 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb, fs_info->sectorsize);WARN_ON (reserve_bytes ==0 ); ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), - reserve_bytes); + reserve_bytes, + reserve_bytes);if (ret) {if (!only_release_metadata) btrfs_free_reserved_data_space(BTRFS_I(inode),
fs/btrfs/inode.c +2 -2
@@ -5050,7 +5050,7 @@ int btrfs_truncate_block(struct btrfs_inode *inode, loff_t from, loff_t len, goto out; } } - ret =btrfs_delalloc_reserve_metadata (inode, blocksize); + ret =btrfs_delalloc_reserve_metadata (inode, blocksize, blocksize);if (ret <0 ) {if (!only_release_metadata) btrfs_free_reserved_data_space(inode, data_reserved,
@@ -7812,7 +7812,7 @@ static int btrfs_get_blocks_direct_write(struct extent_map **map,struct extent_map *em2;/* We can NOCOW, so only need to reserve metadata space. */ - ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), len); + ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), len, len);if (ret <0 ) {/* Our caller expects us to free the input extent map. */ free_extent_map (em);
fs/btrfs/relocation.c +1 -1
@@ -2996,7 +2996,7 @@ static int relocate_one_page(struct inode *inode, struct file_ra_state *ra,/* Reserve metadata for this range */ ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), - clamped_len); + clamped_len, clamped_len);if (ret) goto release_page;
Signature · 1 line
2.34.0
PATCH v12 6/17 btrfs: clean up cow_file_range_inline()
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
The start parameter to cow_file_range_inline() (and insert_inline_extent()) is always 0, so get rid of it and simplify the logic in those two functions. Pass btrfs_inode to insert_inline_extent() and remove the redundant root parameter. Also document the requirements for creating an inline extent. No functional change.
--- fs/btrfs/inode.c | 88 +++++++++++++++++++++--------------------------- 1 file changed, 38 insertions(+), 50 deletions(-)
fs/btrfs/inode.c +38 -50
@@ -233,12 +233,13 @@ static int btrfs_init_inode_security(struct btrfs_trans_handle *trans,* no overlapping inline items exist in the btree */ static int insert_inline_extent (struct btrfs_trans_handle *trans, -struct btrfs_path *path,bool extent_inserted, -struct btrfs_root *root,struct inode *inode, -u64 start,size_t size,size_t compressed_size, +struct btrfs_path *path, +struct btrfs_inode *inode,bool extent_inserted, +size_t size,size_t compressed_size,int compress_type,struct page **compressed_pages) { +struct btrfs_root *root = inode->root;struct extent_buffer *leaf;struct page *page =NULL ;char *kaddr;
@@ -246,7 +247,6 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,struct btrfs_file_extent_item *ei;int ret;size_t cur_size = size; -unsigned long offset;ASSERT ((compressed_size >0 && compressed_pages) || (compressed_size ==0 && !compressed_pages));
@@ -258,8 +258,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,struct btrfs_key key;size_t datasize; - key.objectid =btrfs_ino (BTRFS_I (inode)); - key.offset = start; + key.objectid =btrfs_ino (inode); + key.offset =0 ; key.type =BTRFS_EXTENT_DATA_KEY ; datasize =btrfs_file_extent_calc_inline_size (cur_size);
@@ -297,12 +297,10 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,btrfs_set_file_extent_compression (leaf, ei, compress_type); }else { - page =find_get_page (inode->i_mapping, - start >>PAGE_SHIFT ); + page =find_get_page (inode->vfs_inode.i_mapping,0 );btrfs_set_file_extent_compression (leaf, ei,0 ); kaddr =kmap_atomic (page); - offset =offset_in_page (start); -write_extent_buffer (leaf, kaddr + offset, ptr, size); +write_extent_buffer (leaf, kaddr, ptr, size);kunmap_atomic (kaddr);put_page (page); }
@@ -313,8 +311,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* We align size to sectorsize for inline extents just for simplicity * sake. */ - size =ALIGN (size, root->fs_info->sectorsize); - ret =btrfs_inode_set_file_extent_range (BTRFS_I (inode), start, size); + ret =btrfs_inode_set_file_extent_range (inode,0 , +ALIGN (size, root->fs_info->sectorsize));if (ret) goto fail;
@@ -327,7 +325,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* before we unlock the pages. Otherwise we * could end up racing with unlink. */ -BTRFS_I (inode)->disk_i_size = inode->i_size; + inode->disk_i_size =i_size_read (&inode->vfs_inode); + fail:return ret; }
@@ -338,8 +337,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* does the checks required to make sure the data is small enough * to fit as an inline extent. */ -static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, -u64 end,size_t compressed_size, +static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 size, +size_t compressed_size,int compress_type,struct page **compressed_pages) {
@@ -347,26 +346,21 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start,struct btrfs_root *root = inode->root;struct btrfs_fs_info *fs_info = root->fs_info;struct btrfs_trans_handle *trans; -u64 isize =i_size_read (&inode->vfs_inode); -u64 actual_end =min (end +1 , isize); -u64 inline_len = actual_end - start; -u64 aligned_end =ALIGN (end, fs_info->sectorsize); -u64 data_len = inline_len; +u64 data_len = compressed_size ? compressed_size : size;int ret;struct btrfs_path *path; -if (compressed_size) - data_len = compressed_size; - -if (start >0 || - actual_end > fs_info->sectorsize || +/* +* We can create an inline extent if it ends at or beyond the current +* i_size, is no larger than a sector (decompressed), and the (possibly +* compressed) data fits in a leaf and the configured maximum inline +* size. +*/ +if (size <i_size_read (&inode->vfs_inode) || + size > fs_info->sectorsize || data_len >BTRFS_MAX_INLINE_DATA_SIZE (fs_info) || - (!compressed_size && - (actual_end & (fs_info->sectorsize -1 )) ==0 ) || - end +1 < isize || - data_len > fs_info->max_inline) { + data_len > fs_info->max_inline)return 1 ; - } path =btrfs_alloc_path ();if (!path)
@@ -380,30 +374,21 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, trans->block_rsv = &inode->block_rsv; drop_args.path = path; - drop_args.start = start; - drop_args.end = aligned_end; + drop_args.start =0 ; + drop_args.end = fs_info->sectorsize; drop_args.drop_cache = true; drop_args.replace_extent = true; - -if (compressed_size && compressed_pages) - drop_args.extent_item_size =btrfs_file_extent_calc_inline_size ( - compressed_size); -else - drop_args.extent_item_size =btrfs_file_extent_calc_inline_size ( - inline_len); - + drop_args.extent_item_size =btrfs_file_extent_calc_inline_size (data_len); ret =btrfs_drop_extents (trans, root, inode, &drop_args);if (ret) {btrfs_abort_transaction (trans, ret); goto out; } -if (isize > actual_end) - inline_len =min_t (u64, isize, actual_end); - ret =insert_inline_extent (trans, path, drop_args.extent_inserted, - root, &inode->vfs_inode, start, - inline_len, compressed_size, - compress_type, compressed_pages); + ret =insert_inline_extent (trans, path, inode, + drop_args.extent_inserted, size, + compressed_size, compress_type, + compressed_pages);if (ret && ret != -ENOSPC ) {btrfs_abort_transaction (trans, ret); goto out;
@@ -412,7 +397,7 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, goto out; } -btrfs_update_inode_bytes (inode, inline_len, drop_args.bytes_found); +btrfs_update_inode_bytes (inode, size, drop_args.bytes_found); ret =btrfs_update_inode (trans, root, inode);if (ret && ret != -ENOSPC ) {btrfs_abort_transaction (trans, ret);
@@ -734,12 +719,12 @@ static noinline int compress_file_range(struct async_chunk *async_chunk)/* we didn't compress the entire range, try * to make an uncompressed inline extent. */ - ret =cow_file_range_inline (BTRFS_I (inode), start, end, + ret =cow_file_range_inline (BTRFS_I (inode), actual_end,0 ,BTRFS_COMPRESS_NONE ,NULL ); }else {/* try making a compressed inline extent */ - ret =cow_file_range_inline (BTRFS_I (inode), start, end, + ret =cow_file_range_inline (BTRFS_I (inode), actual_end, total_compressed, compress_type, pages); }
@@ -1154,8 +1139,11 @@ static noinline int cow_file_range(struct btrfs_inode *inode,* So here we skip inline extent creation completely. */ if (start ==0 && fs_info->sectorsize ==PAGE_SIZE ) { +u64 actual_end =min_t (u64,i_size_read (&inode->vfs_inode), + end +1 ); +/* lets try to make an inline extent */ - ret =cow_file_range_inline (inode, start, end,0 , + ret =cow_file_range_inline (inode, actual_end,0 ,BTRFS_COMPRESS_NONE ,NULL );if (ret ==0 ) {/*
Signature · 1 line
2.34.0
PATCH v12 7/17 btrfs: optionally extend i_size in cow_file_range_inline()
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, an inline extent is always created after i_size is extended from btrfs_dirty_pages(). However, for encoded writes, we only want to update i_size after we successfully created the inline extent. Add an update_i_size parameter to cow_file_range_inline() and insert_inline_extent() and pass in the size of the extent rather than determining it from i_size.
--- fs/btrfs/inode.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
fs/btrfs/inode.c +16 -7
@@ -237,7 +237,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans, struct btrfs_inode *inode, bool extent_inserted, size_t size, size_t compressed_size, int compress_type, - struct page **compressed_pages) + struct page **compressed_pages, + bool update_i_size) { struct btrfs_root *root = inode->root;struct extent_buffer *leaf;
@@ -247,6 +248,7 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,struct btrfs_file_extent_item *ei;int ret;size_t cur_size = size; +u64 i_size;ASSERT ((compressed_size >0 && compressed_pages) || (compressed_size ==0 && !compressed_pages));
@@ -325,7 +327,12 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* before we unlock the pages. Otherwise we * could end up racing with unlink. */ - inode->disk_i_size =i_size_read (&inode->vfs_inode); + i_size =i_size_read (&inode->vfs_inode); +if (update_i_size && size > i_size) { +i_size_write (&inode->vfs_inode, size); + i_size = size; + } + inode->disk_i_size = i_size; fail:return ret;
@@ -340,7 +347,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans, static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 size,size_t compressed_size,int compress_type, -struct page **compressed_pages) +struct page **compressed_pages, +bool update_i_size) {struct btrfs_drop_extents_args drop_args = {0 };struct btrfs_root *root = inode->root;
@@ -388,7 +396,7 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 size, ret =insert_inline_extent (trans, path, inode, drop_args.extent_inserted, size, compressed_size, compress_type, - compressed_pages); + compressed_pages, update_i_size);if (ret && ret != -ENOSPC ) {btrfs_abort_transaction (trans, ret); goto out;
@@ -721,12 +729,13 @@ static noinline int compress_file_range(struct async_chunk *async_chunk)*/ ret =cow_file_range_inline (BTRFS_I (inode), actual_end,0 ,BTRFS_COMPRESS_NONE , -NULL ); +NULL , false); }else {/* try making a compressed inline extent */ ret =cow_file_range_inline (BTRFS_I (inode), actual_end, total_compressed, - compress_type, pages); + compress_type, pages, + false); }if (ret <=0 ) { unsigned long clear_flags = EXTENT_DELALLOC |
@@ -1144,7 +1153,7 @@ static noinline int cow_file_range(struct btrfs_inode *inode,/* lets try to make an inline extent */ ret =cow_file_range_inline (inode, actual_end,0 , -BTRFS_COMPRESS_NONE ,NULL ); +BTRFS_COMPRESS_NONE ,NULL , false);if (ret ==0 ) {/* * We use DO_ACCOUNTING here because we need the
Signature · 1 line
2.34.0
PATCH v12 8/17 btrfs: add definitions + documentation for encoded I/O ioctls
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
In order to allow sending and receiving compressed data without decompressing it, we need an interface to write pre-compressed data directly to the filesystem and the matching interface to read compressed data without decompressing it. This adds the definitions for ioctls to do that and detailed explanations of how to use them.
--- include/uapi/linux/btrfs.h | 132 +++++++++++++++++++++++++++++++++++++ 1 file changed, 132 insertions(+)
include/uapi/linux/btrfs.h +132 -0
@@ -868,6 +868,134 @@ struct btrfs_ioctl_get_subvol_rootref_args {__u8 align[7 ]; }; +/* +* Data and metadata for an encoded read or write. +* +* Encoded I/O bypasses any encoding automatically done by the filesystem (e.g., +* compression). This can be used to read the compressed contents of a file or +* write pre-compressed data directly to a file. +* +* BTRFS_IOC_ENCODED_READ and BTRFS_IOC_ENCODED_WRITE are essentially +* preadv/pwritev with additional metadata about how the data is encoded and the +* size of the unencoded data. +* +* BTRFS_IOC_ENCODED_READ fills the given iovecs with the encoded data, fills +* the metadata fields, and returns the size of the encoded data. It reads one +* extent per call. It can also read data which is not encoded. +* +* BTRFS_IOC_ENCODED_WRITE uses the metadata fields, writes the encoded data +* from the iovecs, and returns the size of the encoded data. Note that the +* encoded data is not validated when it is written; if it is not valid (e.g., +* it cannot be decompressed), then a subsequent read may return an error. +* +* Since the filesystem page cache contains decoded data, encoded I/O bypasses +* the page cache. Encoded I/O requires CAP_SYS_ADMIN. +*/ +struct btrfs_ioctl_encoded_io_args { +/* Input parameters for both reads and writes. */ + +/* +* iovecs containing encoded data. +* +* For reads, if the size of the encoded data is larger than the sum of +* iov[n].iov_len for 0 <= n < iovcnt, then the ioctl fails with +* ENOBUFS. +* +* For writes, the size of the encoded data is the sum of iov[n].iov_len +* for 0 <= n < iovcnt. This must be less than 128 KiB (this limit may +* increase in the future). This must also be less than or equal to +* unencoded_len. +*/ +const struct iovec __user *iov; +/* Number of iovecs. */ +unsigned long iovcnt; +/* +* Offset in file. +* +* For writes, must be aligned to the sector size of the filesystem. +*/ +__s64 offset; +/* Currently must be zero. */ +__u64 flags; + +/* +* For reads, the following members are output parameters that will +* contain the returned metadata for the encoded data. +* For writes, the following members must be set to the metadata for the +* encoded data. +*/ + +/* +* Length of the data in the file. +* +* Must be less than or equal to unencoded_len - unencoded_offset. For +* writes, must be aligned to the sector size of the filesystem unless +* the data ends at or beyond the current end of the file. +*/ +__u64 len; +/* +* Length of the unencoded (i.e., decrypted and decompressed) data. +* +* For writes, must be no more than 128 KiB (this limit may increase in +* the future). If the unencoded data is actually longer than +* unencoded_len, then it is truncated; if it is shorter, then it is +* extended with zeroes. +*/ +__u64 unencoded_len; +/* +* Offset from the first byte of the unencoded data to the first byte of +* logical data in the file. +* +* Must be less than unencoded_len. +*/ +__u64 unencoded_offset; +/* +* BTRFS_ENCODED_IO_COMPRESSION_* type. +* +* For writes, must not be BTRFS_ENCODED_IO_COMPRESSION_NONE. +*/ +__u32 compression; +/* Currently always BTRFS_ENCODED_IO_ENCRYPTION_NONE. */ +__u32 encryption; +/* +* Reserved for future expansion. +* +* For reads, always returned as zero. Users should check for non-zero +* bytes. If there are any, then the kernel has a newer version of this +* structure with additional information that the user definition is +* missing. +* +* For writes, must be zeroed. +*/ +__u8 reserved[32 ]; +}; + +/* Data is not compressed. */ +#define BTRFS_ENCODED_IO_COMPRESSION_NONE 0 +/* Data is compressed as a single zlib stream. */ +#define BTRFS_ENCODED_IO_COMPRESSION_ZLIB 1 +/* +* Data is compressed as a single zstd frame with the windowLog compression +* parameter set to no more than 17. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_ZSTD 2 +/* +* Data is compressed sector by sector (using the sector size indicated by the +* name of the constant) with LZO1X and wrapped in the format documented in +* fs/btrfs/lzo.c. For writes, the compression sector size must match the +* filesystem sector size. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_4K 3 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_8K 4 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_16K 5 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_32K 6 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_64K 7 +#define BTRFS_ENCODED_IO_COMPRESSION_TYPES 8 + +/* Data is not encrypted. */ +#define BTRFS_ENCODED_IO_ENCRYPTION_NONE 0 +#define BTRFS_ENCODED_IO_ENCRYPTION_TYPES 1 +/* Error codes as returned by the kernel */ enum btrfs_err_code {BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET =1 ,
@@ -996,5 +1124,9 @@ enum btrfs_err_code { struct btrfs_ioctl_ino_lookup_user_args)#define BTRFS_IOC_SNAP_DESTROY_V2 _IOW(BTRFS_IOCTL_MAGIC, 63, \ struct btrfs_ioctl_vol_args_v2) +#define BTRFS_IOC_ENCODED_READ _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args) +#define BTRFS_IOC_ENCODED_WRITE _IOW(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args)#endif /* _UAPI_LINUX_BTRFS_H */
Signature · 1 line
2.34.0
PATCH v12 9/17 btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.
This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.
--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 496 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 106 ++++++++++ 3 files changed, 606 insertions(+)
fs/btrfs/ctree.h +4 -0
@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;
fs/btrfs/inode.c +496 -0
502 lines not on this page · raw message
fs/btrfs/ioctl.c +106 -0
130 lines not on this page · raw message
Signature · 1 line
2.34.0
PATCH v12 10/17 btrfs: add BTRFS_IOC_ENCODED_WRITE
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
The implementation resembles direct I/O: we have to flush any ordered extents, invalidate the page cache, and do the io tree/delalloc/extent map/ordered extent dance. From there, we can reuse the compression code with a minor modification to distinguish the write from writeback. This also creates inline extents when possible.
--- fs/btrfs/compression.c | 7 +- fs/btrfs/compression.h | 6 +- fs/btrfs/ctree.h | 4 + fs/btrfs/file.c | 65 ++++++++-- fs/btrfs/inode.c | 256 +++++++++++++++++++++++++++++++++++++++- fs/btrfs/ioctl.c | 102 ++++++++++++++++ fs/btrfs/ordered-data.c | 12 +- fs/btrfs/ordered-data.h | 5 +- 8 files changed, 437 insertions(+), 20 deletions(-)
fs/btrfs/compression.c +5 -2
@@ -382,7 +382,8 @@ static void finish_compressed_bio_write(struct compressed_bio *cb) cb->start, cb->start + cb->len -1 , !cb->errors); -end_compressed_writeback (inode, cb); +if (cb->writeback) +end_compressed_writeback (inode, cb);/* Note, our inode could be gone now */ /*
@@ -505,7 +506,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,struct page **compressed_pages, unsigned int nr_pages, unsigned int write_flags, - struct cgroup_subsys_state *blkcg_css) + struct cgroup_subsys_state *blkcg_css, + bool writeback) { struct btrfs_fs_info *fs_info = inode->root->fs_info;struct bio *bio =NULL ;
@@ -530,6 +532,7 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start, cb->mirror_num =0 ; cb->compressed_pages = compressed_pages; cb->compressed_len = compressed_len; + cb->writeback = writeback; cb->orig_bio =NULL ; cb->nr_pages = nr_pages;
fs/btrfs/compression.h +5 -1
@@ -52,6 +52,9 @@ struct compressed_bio {/* The compression algorithm for this bio */ u8 compress_type; +/* Whether this is a write for writeback. */ +bool writeback; +/* IO errors */ u8 errors;int mirror_num;
@@ -95,7 +98,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,struct page **compressed_pages, unsigned int nr_pages, unsigned int write_flags, - struct cgroup_subsys_state *blkcg_css); + struct cgroup_subsys_state *blkcg_css, + bool writeback);blk_status_t btrfs_submit_compressed_read (struct inode *inode,struct bio *bio,int mirror_num,unsigned long bio_flags);
fs/btrfs/ctree.h +4 -0
@@ -3278,6 +3278,8 @@ void btrfs_writepage_endio_finish_ordered(struct btrfs_inode *inode,struct btrfs_ioctl_encoded_io_args ;ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter,struct btrfs_ioctl_encoded_io_args *encoded); +ssize_t btrfs_do_encoded_write (struct kiocb *iocb,struct iov_iter *from, +const struct btrfs_ioctl_encoded_io_args *encoded);extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;
@@ -3338,6 +3340,8 @@ int btrfs_replace_file_extents(struct btrfs_inode *inode, struct btrfs_trans_handle **trans_out);int btrfs_mark_extent_written (struct btrfs_trans_handle *trans,struct btrfs_inode *inode,u64 start,u64 end); +ssize_t btrfs_do_write_iter (struct kiocb *iocb,struct iov_iter *from, +const struct btrfs_ioctl_encoded_io_args *encoded);int btrfs_release_file (struct inode *inode,struct file *file); int btrfs_dirty_pages(struct btrfs_inode *inode, struct page **pages, size_t num_pages, loff_t pos, size_t write_bytes,
fs/btrfs/file.c +54 -11
94 lines not on this page · raw message
fs/btrfs/inode.c +254 -2
280 lines not on this page · raw message
fs/btrfs/ioctl.c +102 -0
123 lines not on this page · raw message
fs/btrfs/ordered-data.c +9 -3
@@ -521,9 +521,15 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,spin_lock (&btrfs_inode->lock);btrfs_mod_outstanding_extents (btrfs_inode,-1 );spin_unlock (&btrfs_inode->lock); -if (root != fs_info->tree_root) -btrfs_delalloc_release_metadata (btrfs_inode, entry->num_bytes, - false); +if (root != fs_info->tree_root) { +u64 release; + +if (test_bit (BTRFS_ORDERED_ENCODED , &entry->flags)) + release = entry->disk_num_bytes; +else + release = entry->num_bytes; +btrfs_delalloc_release_metadata (btrfs_inode, release, false); + }percpu_counter_add_batch (&fs_info->ordered_bytes, -entry->num_bytes, fs_info->delalloc_batch);
fs/btrfs/ordered-data.h +4 -1
@@ -74,6 +74,8 @@ enum {BTRFS_ORDERED_LOGGED_CSUM ,/* We wait for this extent to complete in the current transaction */ BTRFS_ORDERED_PENDING , +/* BTRFS_IOC_ENCODED_WRITE */ + BTRFS_ORDERED_ENCODED, };/* BTRFS_ORDERED_* flags that specify the type of the extent. */
@@ -81,7 +83,8 @@ enum { (1UL <<BTRFS_ORDERED_NOCOW ) | \ (1UL <<BTRFS_ORDERED_PREALLOC ) | \ (1UL <<BTRFS_ORDERED_COMPRESSED ) | \ - (1UL << BTRFS_ORDERED_DIRECT)) + (1UL <<BTRFS_ORDERED_DIRECT ) | \ + (1UL << BTRFS_ORDERED_ENCODED)) struct btrfs_ordered_extent {/* logical offset in the file */
Signature · 1 line
2.34.0
PATCH v12 11/17 btrfs: send: remove unused send_ctx::{total,cmd}_send_size
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
We collect these statistics but have never used them for anything.
--- fs/btrfs/send.c | 4 ---- 1 file changed, 4 deletions(-)
fs/btrfs/send.c +0 -4
@@ -81,8 +81,6 @@ struct send_ctx {char *send_buf;u32 send_size;u32 send_max_size; -u64 total_send_size; -u64 cmd_send_size[BTRFS_SEND_C_MAX +1 ];u64 flags;/* 'flags' member of btrfs_ioctl_send_args is u64 */ /* Protocol version compatibility requested */ u32 proto;
@@ -722,8 +720,6 @@ static int send_cmd(struct send_ctx *sctx) ret =write_buf (sctx->send_filp, sctx->send_buf, sctx->send_size, &sctx->send_off); - sctx->total_send_size += sctx->send_size; - sctx->cmd_send_size[get_unaligned_le16 (&hdr->cmd)] += sctx->send_size; sctx->send_size =0 ;return ret;
Signature · 1 line
2.34.0
PATCH v12 12/17 btrfs: send: fix maximum command numbering
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Commit e77fbf990316 ("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and __BTRFS_SEND_C_MAX_V1 is accordingly 23. But then __BTRFS_SEND_C_MAX_V2 is 24, suggesting that v2 has a command numbered 23, and __BTRFS_SEND_C_MAX is 25, suggesting that 23 and 24 are valid commands.
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating __BTRFS_SEND_C_MAX for every new version.
--- fs/btrfs/send.c | 4 ++-- fs/btrfs/send.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
fs/btrfs/send.c +2 -2
@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;default :return false; } }
fs/btrfs/send.h +2 -2
@@ -77,10 +77,10 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , - __BTRFS_SEND_C_MAX_V1, +BTRFS_SEND_C_MAX_V1 =BTRFS_SEND_C_UPDATE_EXTENT ,/* Version 2 */ - __BTRFS_SEND_C_MAX_V2, +BTRFS_SEND_C_MAX_V2 =BTRFS_SEND_C_MAX_V1 ,/* End */ __BTRFS_SEND_C_MAX,
Signature · 1 line
2.34.0
PATCH v12 13/17 btrfs: add send stream v2 definitions
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
This adds the definitions of the new commands for send stream version 2 and their respective attributes: fallocate, FS_IOC_SETFLAGS (a.k.a. chattr), and encoded writes. It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k. These will be implemented in subsequent changes, and then the ioctl will accept the new version and flag.
--- fs/btrfs/send.c | 2 +- fs/btrfs/send.h | 35 +++++++++++++++++++++++++++++++++-- include/uapi/linux/btrfs.h | 7 +++++++ 3 files changed, 41 insertions(+), 3 deletions(-)
fs/btrfs/send.c +1 -1
@@ -7292,7 +7292,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE ; + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;
fs/btrfs/send.h +33 -2
@@ -12,7 +12,11 @@#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +/* +* In send stream v1, no command is larger than 64k. In send stream v2, no limit +* should be assumed. +*/ +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64Kenum btrfs_tlv_type {BTRFS_TLV_U8 ,
@@ -80,7 +84,10 @@ enum btrfs_send_cmd {BTRFS_SEND_C_MAX_V1 =BTRFS_SEND_C_UPDATE_EXTENT ,/* Version 2 */ -BTRFS_SEND_C_MAX_V2 =BTRFS_SEND_C_MAX_V1 , +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , +BTRFS_SEND_C_MAX_V2 =BTRFS_SEND_C_ENCODED_WRITE ,/* End */ __BTRFS_SEND_C_MAX,
@@ -91,6 +98,7 @@ enum btrfs_send_cmd {enum {BTRFS_SEND_A_UNSPEC , +/* Version 1 */ BTRFS_SEND_A_UUID ,BTRFS_SEND_A_CTRANSID ,
@@ -113,6 +121,11 @@ enum {BTRFS_SEND_A_PATH_LINK ,BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA , BTRFS_SEND_A_CLONE_UUID,
@@ -120,7 +133,25 @@ enum {BTRFS_SEND_A_CLONE_PATH ,BTRFS_SEND_A_CLONE_OFFSET ,BTRFS_SEND_A_CLONE_LEN , +BTRFS_SEND_A_MAX_V1 =BTRFS_SEND_A_CLONE_LEN , +/* Version 2 */ +BTRFS_SEND_A_FALLOCATE_MODE , + +BTRFS_SEND_A_SETFLAGS_FLAGS , + +BTRFS_SEND_A_UNENCODED_FILE_LEN , +BTRFS_SEND_A_UNENCODED_LEN , +BTRFS_SEND_A_UNENCODED_OFFSET , +/* +* COMPRESSION and ENCRYPTION default to NONE (0) if omitted from +* BTRFS_SEND_C_ENCODED_WRITE. +*/ +BTRFS_SEND_A_COMPRESSION , +BTRFS_SEND_A_ENCRYPTION , +BTRFS_SEND_A_MAX_V2 =BTRFS_SEND_A_ENCRYPTION , + +/* End */ __BTRFS_SEND_A_MAX, };#define BTRFS_SEND_A_MAX (__BTRFS_SEND_A_MAX - 1)
include/uapi/linux/btrfs.h +7 -0
@@ -776,6 +776,13 @@ struct btrfs_ioctl_received_subvol_args {*/ #define BTRFS_SEND_FLAG_VERSION 0x8 +/* +* Send compressed data using the ENCODED_WRITE command instead of decompressing +* the data and sending it with the WRITE command. This requires protocol +* version >= 2. +*/ +#define BTRFS_SEND_FLAG_COMPRESSED 0x10 +#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \
Signature · 1 line
2.34.0
PATCH v12 14/17 btrfs: send: write larger chunks when using stream v2
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
The length field of the send stream TLV header is 16 bits. This means that the maximum amount of data that can be sent for one write is 64k minus one. However, encoded writes must be able to send the maximum compressed extent (128k) in one command. To support this, send stream version 2 encodes the DATA attribute differently: it has no length field, and the length is implicitly up to the end of containing command (which has a 32-bit length field). Although this is necessary for encoded writes, normal writes can benefit from it, too.
Also add a check to enforce that the DATA attribute is last. It is only strictly necessary for v2, but we might as well make v1 consistent with it.
For v2, let's bump up the send buffer to the maximum compressed extent size plus 16k for the other metadata (144k total). Since this will most likely be vmalloc'd (and always will be after the next commit), we round it up to the next page since we might as well use the rest of the page on systems with >16k pages.
--- fs/btrfs/send.c | 42 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 8 deletions(-)
fs/btrfs/send.c +34 -8
@@ -81,6 +81,7 @@ struct send_ctx {char *send_buf;u32 send_size;u32 send_max_size; +bool put_data;u64 flags;/* 'flags' member of btrfs_ioctl_send_args is u64 */ /* Protocol version compatibility requested */ u32 proto;
@@ -584,6 +585,9 @@ static int tlv_put(struct send_ctx *sctx, u16 attr, const void *data, int len)int total_len =sizeof (*hdr) + len;int left = sctx->send_max_size - sctx->send_size; +if (WARN_ON_ONCE (sctx->put_data)) +return -EINVAL ; +if (unlikely (left < total_len))return -EOVERFLOW ;
@@ -721,6 +725,7 @@ static int send_cmd(struct send_ctx *sctx) &sctx->send_off); sctx->send_size =0 ; + sctx->put_data = false;return ret; }
@@ -4902,14 +4907,30 @@ static inline u64 max_send_read_size(const struct send_ctx *sctx)static int put_data_header (struct send_ctx *sctx,u32 len) { -struct btrfs_tlv_header *hdr; +if (WARN_ON_ONCE (sctx->put_data)) +return -EINVAL ; + sctx->put_data = true; +if (sctx->proto >=2 ) { +/* +* In v2, the data attribute header doesn't include a length; it +* is implicitly to the end of the command. +*/ +if (sctx->send_max_size - sctx->send_size <2 + len) +return -EOVERFLOW ; +put_unaligned_le16 (BTRFS_SEND_A_DATA , + sctx->send_buf + sctx->send_size); + sctx->send_size +=2 ; + }else { +struct btrfs_tlv_header *hdr; -if (sctx->send_max_size - sctx->send_size <sizeof (*hdr) + len) -return -EOVERFLOW ; - hdr = (struct btrfs_tlv_header *)(sctx->send_buf + sctx->send_size); -put_unaligned_le16 (BTRFS_SEND_A_DATA , &hdr->tlv_type); -put_unaligned_le16 (len, &hdr->tlv_len); - sctx->send_size +=sizeof (*hdr); +if (sctx->send_max_size - sctx->send_size <sizeof (*hdr) + len) +return -EOVERFLOW ; + hdr = (struct btrfs_tlv_header *)(sctx->send_buf + + sctx->send_size); +put_unaligned_le16 (BTRFS_SEND_A_DATA , &hdr->tlv_type); +put_unaligned_le16 (len, &hdr->tlv_len); + sctx->send_size +=sizeof (*hdr); + }return 0 ; }
@@ -7292,7 +7313,12 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; +if (sctx->proto >=2 ) { + sctx->send_max_size =ALIGN (SZ_16K +BTRFS_MAX_COMPRESSED , +PAGE_SIZE ); + }else { + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; + } sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;
Signature · 1 line
2.34.0
PATCH v12 16/17 btrfs: send: send compressed extents with encoded writes
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Now that all of the pieces are in place, we can use the ENCODED_WRITE command to send compressed extents when appropriate.
--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 10 +- fs/btrfs/send.c | 234 +++++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 225 insertions(+), 23 deletions(-)
fs/btrfs/ctree.h +4 -0
@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +int btrfs_encoded_io_compression_from_extent (int compress_type); +int btrfs_encoded_read_regular_fill_pages (struct inode *inode,u64 file_offset, +u64 disk_bytenr,u64 disk_io_size, +struct page **pages);struct btrfs_ioctl_encoded_io_args ;ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter,struct btrfs_ioctl_encoded_io_args *encoded);
fs/btrfs/inode.c +4 -6
@@ -10527,7 +10527,7 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } -static int btrfs_encoded_io_compression_from_extent (int compress_type) +int btrfs_encoded_io_compression_from_extent (int compress_type) {switch (compress_type) {case BTRFS_COMPRESS_NONE :
@@ -10731,11 +10731,9 @@ static void btrfs_encoded_read_endio(struct bio *bio)bio_put (bio); } -static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, -u64 file_offset, -u64 disk_bytenr, -u64 disk_io_size, -struct page **pages) +int btrfs_encoded_read_regular_fill_pages (struct inode *inode,u64 file_offset, +u64 disk_bytenr,u64 disk_io_size, +struct page **pages) {struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb);struct btrfs_encoded_read_private priv = {
fs/btrfs/send.c +217 -17
296 lines not on this page · raw message
Signature · 1 line
2.34.0
PATCH v12 15/17 btrfs: send: allocate send buffer with alloc_page() and vmap() for v2
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
For encoded writes, we need the raw pages for reading compressed data directly via a bio. So, replace kvmalloc() with vmap() so we have access to the raw pages. 144k is large enough that it usually gets allocated with vmalloc(), anyways.
--- fs/btrfs/send.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-)
fs/btrfs/send.c +31 -2
@@ -82,6 +82,7 @@ struct send_ctx {u32 send_size;u32 send_max_size;bool put_data; +struct page **send_buf_pages;u64 flags;/* 'flags' member of btrfs_ioctl_send_args is u64 */ /* Protocol version compatibility requested */ u32 proto;
@@ -7225,6 +7226,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)struct btrfs_root *clone_root;struct send_ctx *sctx =NULL ;u32 i; +u32 send_buf_num_pages =0 ;u64 *clone_sources_tmp =NULL ;int clone_sources_to_rollback =0 ;size_t alloc_size;
@@ -7316,10 +7318,28 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)if (sctx->proto >=2 ) { sctx->send_max_size =ALIGN (SZ_16K +BTRFS_MAX_COMPRESSED ,PAGE_SIZE ); + send_buf_num_pages = sctx->send_max_size >>PAGE_SHIFT ; + sctx->send_buf_pages =kcalloc (send_buf_num_pages, +sizeof (*sctx->send_buf_pages), +GFP_KERNEL ); +if (!sctx->send_buf_pages) { + send_buf_num_pages =0 ; + ret = -ENOMEM ; + goto out; + } +for (i =0 ; i < send_buf_num_pages; i++) { + sctx->send_buf_pages[i] =alloc_page (GFP_KERNEL ); +if (!sctx->send_buf_pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + sctx->send_buf =vmap (sctx->send_buf_pages, send_buf_num_pages, +VM_MAP ,PAGE_KERNEL ); }else { sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; + sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL ); } - sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ; goto out;
@@ -7526,7 +7546,16 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)fput (sctx->send_filp);kvfree (sctx->clone_roots); -kvfree (sctx->send_buf); +if (sctx->proto >=2 ) { +vunmap (sctx->send_buf); +for (i =0 ; i < send_buf_num_pages; i++) { +if (sctx->send_buf_pages[i]) +__free_page (sctx->send_buf_pages[i]); + } +kfree (sctx->send_buf_pages); + }else { +kvfree (sctx->send_buf); + }name_cache_free (sctx);
Signature · 1 line
2.34.0
PATCH v12 17/17 btrfs: send: enable support for stream v2 and compressed writes
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Now that the new support is implemented, allow the ioctl to accept the v2 and the compressed flag, and update the version in sysfs.
--- fs/btrfs/send.c | 7 +++++-- fs/btrfs/send.h | 2 +- include/uapi/linux/btrfs.h | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-)
fs/btrfs/send.c +5 -2
@@ -685,8 +685,7 @@ static int send_header(struct send_ctx *sctx)struct btrfs_stream_header hdr;strcpy (hdr.magic,BTRFS_SEND_STREAM_MAGIC ); - hdr.version =cpu_to_le32 (BTRFS_SEND_STREAM_VERSION ); - + hdr.version =cpu_to_le32 (sctx->proto);return write_buf (sctx->send_filp, &hdr,sizeof (hdr), &sctx->send_off); }
@@ -7496,6 +7495,10 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) }else { sctx->proto =1 ; } +if ((arg->flags &BTRFS_SEND_FLAG_COMPRESSED ) && sctx->proto <2 ) { + ret = -EINVAL ; + goto out; + } sctx->send_filp =fget (arg->send_fd);if (!sctx->send_filp) {
fs/btrfs/send.h +1 -1
@@ -10,7 +10,7 @@#include "ctree.h" #define BTRFS_SEND_STREAM_MAGIC "btrfs-stream" -#define BTRFS_SEND_STREAM_VERSION 1 +#define BTRFS_SEND_STREAM_VERSION 2/* * In send stream v1, no command is larger than 64k. In send stream v2, no limit
include/uapi/linux/btrfs.h +2 -1
@@ -787,7 +787,8 @@ struct btrfs_ioctl_received_subvol_args { (BTRFS_SEND_FLAG_NO_FILE_DATA | \BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \BTRFS_SEND_FLAG_OMIT_END_CMD | \ - BTRFS_SEND_FLAG_VERSION) +BTRFS_SEND_FLAG_VERSION | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
Signature · 1 line
2.34.0
PATCH v12 1/10 btrfs-progs: receive: support v2 send stream larger tlv_len
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
An encoded extent can be up to 128K in length, which exceeds the largest value expressible by the current send stream format's 16 bit tlv_len field. Since encoded writes cannot be split into multiple writes by btrfs send, the send stream format must change to accommodate encoded writes.
Supporting this changed format requires retooling how we store the commands we have processed. We currently store pointers to the struct btrfs_tlv_headers in the command buffer. This is not sufficient to represent the new BTRFS_SEND_A_DATA format. Instead, parse the attribute headers and store them in a new struct btrfs_send_attribute which has a 32-bit length field. This is transparent to users of the various TLV_GET macros.
--- common/send-stream.c | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-)
common/send-stream.c +25 -9
@@ -24,13 +24,23 @@#include "crypto/crc32c.h" #include "common/utils.h" +struct btrfs_send_attribute { +u16 tlv_type; +/* +* Note: in btrfs_tlv_header, this is __le16, but we need 32 bits for +* attributes with file data as of version 2 of the send stream format +*/ +u32 tlv_len; +char *data; +}; +struct btrfs_send_stream {char read_buf[BTRFS_SEND_BUF_SIZE ];int fd;int cmd;struct btrfs_cmd_header *cmd_hdr; -struct btrfs_tlv_header *cmd_attrs[BTRFS_SEND_A_MAX +1 ]; +struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];u32 version;/*
@@ -152,6 +162,7 @@ static int read_cmd(struct btrfs_send_stream *sctx)struct btrfs_tlv_header *tlv_hdr;u16 tlv_type;u16 tlv_len; +struct btrfs_send_attribute *send_attr; tlv_hdr = (struct btrfs_tlv_header *)data; tlv_type =le16_to_cpu (tlv_hdr->tlv_type);
@@ -164,10 +175,15 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_attrs[tlv_type] = tlv_hdr; + send_attr = &sctx->cmd_attrs[tlv_type]; + send_attr->tlv_type = tlv_type; + send_attr->tlv_len = tlv_len; + pos +=sizeof (*tlv_hdr); + data +=sizeof (*tlv_hdr); - data +=sizeof (*tlv_hdr) + tlv_len; - pos +=sizeof (*tlv_hdr) + tlv_len; + send_attr->data = data; + pos += send_attr->tlv_len; + data += send_attr->tlv_len; } sctx->cmd = cmd;
@@ -180,7 +196,7 @@ out:static int tlv_get (struct btrfs_send_stream *sctx,int attr,void **data,int *len) {int ret; -struct btrfs_tlv_header *hdr; +struct btrfs_send_attribute *send_attr;if (attr <=0 || attr >BTRFS_SEND_A_MAX ) {error ("invalid attribute requested, attr = %d" , attr);
@@ -188,15 +204,15 @@ static int tlv_get(struct btrfs_send_stream *sctx, int attr, void **data, int *l goto out; } - hdr = sctx->cmd_attrs[attr]; -if (!hdr) { + send_attr = &sctx->cmd_attrs[attr]; +if (!send_attr->data) {error ("attribute %d requested but not present" , attr); ret = -ENOENT ; goto out; } - *len =le16_to_cpu (hdr->tlv_len); - *data = hdr +1 ; + *len = send_attr->tlv_len; + *data = send_attr->data; ret =0 ;
Signature · 1 line
2.34.0
PATCH v12 2/10 btrfs-progs: receive: dynamically allocate sctx->read_buf
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
In send stream v2, write commands can now be an arbitrary size. For that reason, we can no longer allocate a fixed array in sctx for read_cmd. Instead, read_cmd dynamically allocates sctx->read_buf. To avoid needless reallocations, we reuse read_buf between read_cmd calls by also keeping track of the size of the allocated buffer in sctx->read_buf_sz.
We do the first allocation of the old default size at the start of processing the stream, and we only reallocate if we encounter a command that needs a larger buffer.
--- common/send-stream.c | 56 ++++++++++++++++++++++++++++-------------- kernel-shared/send.h | 2 +- libbtrfs/send-stream.c | 2 +- 3 files changed, 39 insertions(+), 21 deletions(-)
common/send-stream.c +37 -19
@@ -35,11 +35,11 @@ struct btrfs_send_attribute { };struct btrfs_send_stream { -char read_buf[BTRFS_SEND_BUF_SIZE ]; +char *read_buf; +size_t read_buf_sz;int fd;int cmd; -struct btrfs_cmd_header *cmd_hdr;struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];u32 version;
@@ -111,11 +111,12 @@ static int read_cmd(struct btrfs_send_stream *sctx)u32 pos;u32 crc;u32 crc2; +struct btrfs_cmd_header *cmd_hdr; +size_t buf_len;memset (sctx->cmd_attrs,0 ,sizeof (sctx->cmd_attrs)); -ASSERT (sizeof (*sctx->cmd_hdr) <=sizeof (sctx->read_buf)); - ret =read_buf (sctx, sctx->read_buf,sizeof (*sctx->cmd_hdr)); + ret =read_buf (sctx, sctx->read_buf,sizeof (*cmd_hdr));if (ret <0 ) goto out;if (ret) {
@@ -124,18 +125,25 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; - cmd =le16_to_cpu (sctx->cmd_hdr->cmd); - cmd_len =le32_to_cpu (sctx->cmd_hdr->len); + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; + cmd_len =le32_to_cpu (cmd_hdr->len); + cmd =le16_to_cpu (cmd_hdr->cmd); + buf_len =sizeof (*cmd_hdr) + cmd_len; +if (sctx->read_buf_sz < buf_len) { +void *new_read_buf; -if (cmd_len +sizeof (*sctx->cmd_hdr) >=sizeof (sctx->read_buf)) { - ret = -EINVAL ; -error ("command length %u too big for buffer %zu" , - cmd_len,sizeof (sctx->read_buf)); - goto out; + new_read_buf =realloc (sctx->read_buf, buf_len); +if (!new_read_buf) { + ret = -ENOMEM ; +error ("failed to reallocate read buffer for cmd" ); + goto out; + } + sctx->read_buf = new_read_buf; + sctx->read_buf_sz = buf_len; +/* We need to reset cmd_hdr after realloc of sctx->read_buf */ + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; } - - data = sctx->read_buf +sizeof (*sctx->cmd_hdr); + data = sctx->read_buf +sizeof (*cmd_hdr); ret =read_buf (sctx, data, cmd_len);if (ret <0 ) goto out;
@@ -145,11 +153,12 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - crc =le32_to_cpu (sctx->cmd_hdr->crc); - sctx->cmd_hdr->crc =0 ; + crc =le32_to_cpu (cmd_hdr->crc); +/* in send, crc is computed with header crc = 0, replicate that */ + cmd_hdr->crc =0 ; crc2 =crc32c (0 , (unsigned char *)sctx->read_buf, -sizeof (*sctx->cmd_hdr) + cmd_len); +sizeof (*cmd_hdr) + cmd_len);if (crc != crc2) { ret = -EINVAL ;
@@ -537,19 +546,28 @@ int btrfs_read_and_process_send_stream(int fd, goto out; } + sctx.read_buf =malloc (BTRFS_SEND_BUF_SIZE_V1 ); +if (!sctx.read_buf) { + ret = -ENOMEM ; +error ("unable to allocate send stream read buffer" ); + goto out; + } + sctx.read_buf_sz =BTRFS_SEND_BUF_SIZE_V1 ; +while (1 ) { ret =read_and_process_cmd (&sctx);if (ret <0 ) { last_err = ret; errors++;if (max_errors >0 && errors >= max_errors) - goto out; +break ; }else if (ret >0 ) {if (!honor_end_cmd) ret =0 ; - goto out; +break ; } } +free (sctx.read_buf); out:if (last_err && !ret)
kernel-shared/send.h +1 -1
@@ -33,7 +33,7 @@ extern "C" {#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE (64 * 1024) +#define BTRFS_SEND_BUF_SIZE_V1 (64 * 1024)#define BTRFS_SEND_READ_SIZE (1024 * 48)enum btrfs_tlv_type {
libbtrfs/send-stream.c +1 -1
@@ -22,7 +22,7 @@#include "crypto/crc32c.h" struct btrfs_send_stream { -char read_buf[BTRFS_SEND_BUF_SIZE ]; +char read_buf[BTRFS_SEND_BUF_SIZE_V1 ];int fd;int cmd;
Signature · 1 line
2.34.0
PATCH v12 3/10 btrfs-progs: receive: support v2 send stream DATA tlv format
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
The new format privileges the BTRFS_SEND_A_DATA attribute by guaranteeing it will always be the last attribute in any command that needs it, and by implicitly encoding the data length as the difference between the total command length in the command header and the sizes of the rest of the attributes (and of course the tlv_type identifying the DATA attribute). To parse the new stream, we must read the tlv_type and if it is not DATA, we proceed normally, but if it is DATA, we don't parse a tlv_len but simply compute the length.
In addition, we add some bounds checking when parsing each chunk of data, as well as for the tlv_len itself.
--- common/send-stream.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-)
common/send-stream.c +26 -10
@@ -168,28 +168,44 @@ static int read_cmd(struct btrfs_send_stream *sctx) pos =0 ;while (pos < cmd_len) { -struct btrfs_tlv_header *tlv_hdr;u16 tlv_type; -u16 tlv_len;struct btrfs_send_attribute *send_attr; - tlv_hdr = (struct btrfs_tlv_header *)data; - tlv_type =le16_to_cpu (tlv_hdr->tlv_type); - tlv_len =le16_to_cpu (tlv_hdr->tlv_len); +if (cmd_len - pos <sizeof (__le16)) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } + tlv_type =le16_to_cpu (*(__le16 *)data);if (tlv_type ==0 || tlv_type >BTRFS_SEND_A_MAX ) { -error ("invalid tlv in cmd tlv_type = %hu, tlv_len = %hu" , - tlv_type, tlv_len); +error ("invalid tlv in cmd tlv_type = %hu" , tlv_type); ret = -EINVAL ; goto out; } send_attr = &sctx->cmd_attrs[tlv_type]; send_attr->tlv_type = tlv_type; - send_attr->tlv_len = tlv_len; - pos +=sizeof (*tlv_hdr); - data +=sizeof (*tlv_hdr); + pos +=sizeof (tlv_type); + data +=sizeof (tlv_type); +if (sctx->version ==2 && tlv_type ==BTRFS_SEND_A_DATA ) { + send_attr->tlv_len = cmd_len - pos; + }else { +if (cmd_len - pos <sizeof (__le16)) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } + send_attr->tlv_len =le16_to_cpu (*(__le16 *)data); + pos +=sizeof (__le16); + data +=sizeof (__le16); + } +if (cmd_len - pos < send_attr->tlv_len) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } send_attr->data = data; pos += send_attr->tlv_len; data += send_attr->tlv_len;
Signature · 1 line
2.34.0
PATCH v12 4/10 btrfs-progs: receive: add send stream v2 cmds and attrs to send.h
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Send stream v2 adds three commands and several attributes associated to those commands. Before we implement processing them, add all the commands and attributes. This avoids leaving the enums in an intermediate state that doesn't correspond to any version of send stream.
--- kernel-shared/send.h | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
kernel-shared/send.h +34 -1
@@ -34,7 +34,6 @@ extern "C" {#define BTRFS_SEND_STREAM_VERSION 1#define BTRFS_SEND_BUF_SIZE_V1 (64 * 1024) -#define BTRFS_SEND_READ_SIZE (1024 * 48)enum btrfs_tlv_type {BTRFS_TLV_U8 ,
@@ -70,6 +69,7 @@ struct btrfs_tlv_header {enum btrfs_send_cmd {BTRFS_SEND_C_UNSPEC , +/* Version 1 */ BTRFS_SEND_C_SUBVOL ,BTRFS_SEND_C_SNAPSHOT ,
@@ -98,6 +98,15 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , +BTRFS_SEND_C_MAX_V1 =BTRFS_SEND_C_UPDATE_EXTENT , + +/* Version 2 */ +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , +BTRFS_SEND_C_MAX_V2 =BTRFS_SEND_C_ENCODED_WRITE , + +/* End */ __BTRFS_SEND_C_MAX, };#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1)
@@ -106,6 +115,7 @@ enum btrfs_send_cmd {enum {BTRFS_SEND_A_UNSPEC , +/* Version 1 */ BTRFS_SEND_A_UUID ,BTRFS_SEND_A_CTRANSID ,
@@ -128,6 +138,11 @@ enum {BTRFS_SEND_A_PATH_LINK ,BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA , BTRFS_SEND_A_CLONE_UUID,
@@ -135,7 +150,25 @@ enum {BTRFS_SEND_A_CLONE_PATH ,BTRFS_SEND_A_CLONE_OFFSET ,BTRFS_SEND_A_CLONE_LEN , +BTRFS_SEND_A_MAX_V1 =BTRFS_SEND_A_CLONE_LEN , +/* Version 2 */ +BTRFS_SEND_A_FALLOCATE_MODE , + +BTRFS_SEND_A_SETFLAGS_FLAGS , + +BTRFS_SEND_A_UNENCODED_FILE_LEN , +BTRFS_SEND_A_UNENCODED_LEN , +BTRFS_SEND_A_UNENCODED_OFFSET , +/* +* COMPRESSION and ENCRYPTION default to NONE (0) if omitted from +* BTRFS_SEND_C_ENCODED_WRITE. +*/ +BTRFS_SEND_A_COMPRESSION , +BTRFS_SEND_A_ENCRYPTION , +BTRFS_SEND_A_MAX_V2 =BTRFS_SEND_A_ENCRYPTION , + +/* End */ __BTRFS_SEND_A_MAX, };#define BTRFS_SEND_A_MAX (__BTRFS_SEND_A_MAX - 1)
Signature · 1 line
2.34.0
PATCH v12 5/10 btrfs-progs: receive: process encoded_write commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Add a new btrfs_send_op and support for both dumping and proper receive processing which does actual encoded writes.
Encoded writes are only allowed on a file descriptor opened with an extra flag that allows encoded writes, so we also add support for this flag when opening or reusing a file for writing.
--- cmds/receive-dump.c | 16 +++++- cmds/receive.c | 48 ++++++++++++++++ common/send-stream.c | 29 ++++++++++ common/send-stream.h | 4 ++ ioctl.h | 132 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 228 insertions(+), 1 deletion(-)
cmds/receive-dump.c +15 -1
@@ -319,6 +319,19 @@ static int print_update_extent(const char *path, u64 offset, u64 len, offset, len); } +static int print_encoded_write (const char *path,const void *data,u64 offset, +u64 len,u64 unencoded_file_len, +u64 unencoded_len,u64 unencoded_offset, +u32 compression,u32 encryption,void *user) +{ +return PRINT_DUMP (user, path,"encoded_write" , +"offset=%llu len=%llu, unencoded_file_len=%llu, " +"unencoded_len=%llu, unencoded_offset=%llu, " +"compression=%u, encryption=%u" , + offset, len, unencoded_file_len, unencoded_len, + unencoded_offset, compression, encryption); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -340,5 +353,6 @@ struct btrfs_send_ops btrfs_print_send_ops = { .chmod = print_chmod, .chown = print_chown, .utimes = print_utimes, - .update_extent = print_update_extent + .update_extent = print_update_extent, + .encoded_write = print_encoded_write, };
cmds/receive.c +48 -0
78 lines not on this page · raw message
common/send-stream.c +29 -0
@@ -357,6 +357,8 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)struct timespec mt;u8 uuid[BTRFS_UUID_SIZE ];u8 clone_uuid[BTRFS_UUID_SIZE ]; +u32 compression; +u32 encryption;u64 tmp;u64 tmp2;u64 ctransid;
@@ -366,6 +368,9 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)u64 clone_offset;u64 offset;u64 ino; +u64 unencoded_file_len; +u64 unencoded_len; +u64 unencoded_offset;int len;int xattr_len;
@@ -452,6 +457,30 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); ret = sctx->ops->write (path, data, offset, len, sctx->user);break ; +case BTRFS_SEND_C_ENCODED_WRITE : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_FILE_LEN , + &unencoded_file_len); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_LEN , &unencoded_len); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_OFFSET , + &unencoded_offset); +/* Compression and encryption default to none if omitted. */ +if (sctx->cmd_attrs[BTRFS_SEND_A_COMPRESSION ].data) +TLV_GET_U32 (sctx,BTRFS_SEND_A_COMPRESSION , &compression); +else + compression =BTRFS_ENCODED_IO_COMPRESSION_NONE ; +if (sctx->cmd_attrs[BTRFS_SEND_A_ENCRYPTION ].data) +TLV_GET_U32 (sctx,BTRFS_SEND_A_ENCRYPTION , &encryption); +else + encryption =BTRFS_ENCODED_IO_ENCRYPTION_NONE ; +TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); + ret = sctx->ops->encoded_write (path, data, offset, len, + unencoded_file_len, + unencoded_len, unencoded_offset, + compression, encryption, + sctx->user); +break ;case BTRFS_SEND_C_CLONE :TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path);TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset);
common/send-stream.h +4 -0
@@ -53,6 +53,10 @@ struct btrfs_send_ops { struct timespec *mt, struct timespec *ct, void *user);int (*update_extent)(const char *path,u64 offset,u64 len,void *user); +int (*encoded_write)(const char *path,const void *data,u64 offset, +u64 len,u64 unencoded_file_len,u64 unencoded_len, +u64 unencoded_offset,u32 compression, +u32 encryption,void *user); }; int btrfs_read_and_process_send_stream(int fd,
ioctl.h +132 -0
144 lines not on this page · raw message
Signature · 1 line
2.34.0
PATCH v12 6/10 btrfs-progs: receive: encoded_write fallback to explicit decode and write
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
An encoded_write can fail if the file system it is being applied to does not support encoded writes or if it can't find enough contiguous space to accommodate the encoded extent. In those cases, we can likely still process an encoded_write by explicitly decoding the data and doing a normal write.
Add the necessary fallback path for decoding data compressed with zlib, lzo, or zstd. zlib and zstd have reusable decoding context data structures which we cache in the receive context so that we don't have to recreate them on every encoded_write.
Finally, add a command line flag for force-decompress which causes receive to always use the fallback path rather than first attempting the encoded write.
--- Documentation/btrfs-receive.asciidoc | 4 + cmds/receive.c | 261 ++++++++++++++++++++++++++- 2 files changed, 258 insertions(+), 7 deletions(-)
Documentation/btrfs-receive.asciidoc +4 -0
@@ -60,6 +60,10 @@ By default the mountpoint is searched in '/proc/self/mounts'. If '/proc' is not accessible, eg. in a chroot environment, use this option to tell us where this filesystem is mounted. +--force-decompress:: +if the stream contains compressed data (see '--compressed-data' in +`btrfs-send`(8)), always decompress it instead of writing it with encoded I/O. + --dump:: dump the stream metadata, one line per operation +
cmds/receive.c +254 -7
315 lines not on this page · raw message
Signature · 1 line
2.34.0
PATCH v12 7/10 btrfs-progs: receive: process fallocate commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Send stream v2 can emit fallocate commands, so receive must support them as well. The implementation simply passes along the arguments to the syscall. Note that mode is encoded as a u32 in send stream but fallocate takes an int, so there is a unsigned->signed conversion there.
--- cmds/receive-dump.c | 9 +++++++++ cmds/receive.c | 25 +++++++++++++++++++++++++ common/send-stream.c | 9 +++++++++ common/send-stream.h | 2 ++ 4 files changed, 45 insertions(+)
cmds/receive-dump.c +9 -0
@@ -332,6 +332,14 @@ static int print_encoded_write(const char *path, const void *data, u64 offset, unencoded_offset, compression, encryption); } +static int print_fallocate (const char *path,int mode,u64 offset,u64 len, +void *user) +{ +return PRINT_DUMP (user, path,"fallocate" , +"mode=%d offset=%llu len=%llu" , + mode, offset, len); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -355,4 +363,5 @@ struct btrfs_send_ops btrfs_print_send_ops = { .utimes = print_utimes, .update_extent = print_update_extent, .encoded_write = print_encoded_write, + .fallocate = print_fallocate, };
cmds/receive.c +25 -0
@@ -1260,6 +1260,30 @@ static int process_encoded_write(const char *path, const void *data, u64 offset, compression); } +static int process_fallocate (const char *path,int mode,u64 offset,u64 len, +void *user) +{ +int ret; +struct btrfs_receive *rctx = user; +char full_path[PATH_MAX ]; + + ret =path_cat_out (full_path, rctx->full_subvol_path, path); +if (ret <0 ) { +error ("fallocate: path invalid: %s" , path); +return ret; + } + ret =open_inode_for_write (rctx, full_path); +if (ret <0 ) +return ret; + ret =fallocate (rctx->write_fd, mode, offset, len); +if (ret <0 ) { + ret = -errno; +error ("fallocate: fallocate on %s failed: %m" , path); +return ret; + } +return 0 ; +} +static struct btrfs_send_ops send_ops = { .subvol = process_subvol, .snapshot = process_snapshot,
@@ -1283,6 +1307,7 @@ static struct btrfs_send_ops send_ops = { .utimes = process_utimes, .update_extent = process_update_extent, .encoded_write = process_encoded_write, + .fallocate = process_fallocate, }; static int do_receive(struct btrfs_receive *rctx, const char *tomnt,
common/send-stream.c +9 -0
@@ -373,6 +373,7 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)u64 unencoded_offset;int len;int xattr_len; +int fallocate_mode; ret =read_cmd (sctx);if (ret)
@@ -537,6 +538,14 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)case BTRFS_SEND_C_END : ret =1 ;break ; +case BTRFS_SEND_C_FALLOCATE : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U32 (sctx,BTRFS_SEND_A_FALLOCATE_MODE , &fallocate_mode); +TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset); +TLV_GET_U64 (sctx,BTRFS_SEND_A_SIZE , &tmp); + ret = sctx->ops->fallocate (path, fallocate_mode, offset, tmp, + sctx->user); +break ; } tlv_get_failed:
common/send-stream.h +2 -0
@@ -57,6 +57,8 @@ struct btrfs_send_ops { u64 len, u64 unencoded_file_len, u64 unencoded_len, u64 unencoded_offset, u32 compression, u32 encryption, void *user); +int (*fallocate)(const char *path,int mode,u64 offset,u64 len, +void *user); }; int btrfs_read_and_process_send_stream(int fd,
Signature · 1 line
2.34.0
PATCH v12 8/10 btrfs-progs: receive: process setflags ioctl commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
In send stream v2, send can emit a command for setting inode flags via the setflags ioctl. Pass the flags attribute through to the ioctl call in receive.
--- cmds/receive-dump.c | 6 ++++++ cmds/receive.c | 25 +++++++++++++++++++++++++ common/send-stream.c | 7 +++++++ common/send-stream.h | 1 + 4 files changed, 39 insertions(+)
cmds/receive-dump.c +6 -0
@@ -340,6 +340,11 @@ static int print_fallocate(const char *path, int mode, u64 offset, u64 len, mode, offset, len); } +static int print_setflags (const char *path,int flags,void *user) +{ +return PRINT_DUMP (user, path,"setflags" ,"flags=%d" , flags); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -364,4 +369,5 @@ struct btrfs_send_ops btrfs_print_send_ops = { .update_extent = print_update_extent, .encoded_write = print_encoded_write, .fallocate = print_fallocate, + .setflags = print_setflags, };
cmds/receive.c +25 -0
@@ -38,6 +38,7 @@#include <sys/types.h> #include <sys/uio.h> #include <sys/xattr.h> +#include <linux/fs.h> #include <uuid/uuid.h> #include <lzo/lzo1x.h>
@@ -1284,6 +1285,29 @@ static int process_fallocate(const char *path, int mode, u64 offset, u64 len,return 0 ; } +static int process_setflags (const char *path,int flags,void *user) +{ +int ret; +struct btrfs_receive *rctx = user; +char full_path[PATH_MAX ]; + + ret =path_cat_out (full_path, rctx->full_subvol_path, path); +if (ret <0 ) { +error ("setflags: path invalid: %s" , path); +return ret; + } + ret =open_inode_for_write (rctx, full_path); +if (ret <0 ) +return ret; + ret =ioctl (rctx->write_fd,FS_IOC_SETFLAGS , &flags); +if (ret <0 ) { + ret = -errno; +error ("setflags: setflags ioctl on %s failed: %m" , path); +return ret; + } +return 0 ; +} +static struct btrfs_send_ops send_ops = { .subvol = process_subvol, .snapshot = process_snapshot,
@@ -1308,6 +1332,7 @@ static struct btrfs_send_ops send_ops = { .update_extent = process_update_extent, .encoded_write = process_encoded_write, .fallocate = process_fallocate, + .setflags = process_setflags, }; static int do_receive(struct btrfs_receive *rctx, const char *tomnt,
common/send-stream.c +7 -0
@@ -374,6 +374,7 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)int len;int xattr_len;int fallocate_mode; +int setflags_flags; ret =read_cmd (sctx);if (ret)
@@ -546,8 +547,14 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx) ret = sctx->ops->fallocate (path, fallocate_mode, offset, tmp, sctx->user);break ; +case BTRFS_SEND_C_SETFLAGS : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U32 (sctx,BTRFS_SEND_A_SETFLAGS_FLAGS , &setflags_flags); + ret = sctx->ops->setflags (path, setflags_flags, sctx->user); +break ; } + tlv_get_failed: out:free (path);
common/send-stream.h +1 -0
@@ -59,6 +59,7 @@ struct btrfs_send_ops { u32 encryption, void *user);int (*fallocate)(const char *path,int mode,u64 offset,u64 len,void *user); +int (*setflags)(const char *path,int flags,void *user); }; int btrfs_read_and_process_send_stream(int fd,
Signature · 1 line
2.34.0
PATCH v12 9/10 btrfs-progs: send: stream v2 ioctl flags
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
First, add a --proto option to allow specifying the desired send protocol version. It defaults to zero, which tells the kernel to pick the latest version. This is based on Dave Sterba's patch.
Also add a --compressed-data flag to instruct the kernel to use encoded_write commands for compressed extents. This requires an explicit opt in separate from the protocol version because:
1. The user may not want compression on the receiving side, or may want a different compression algorithm/level on the receiving side.
2. It has a soft requirement for kernel support on the receiving side (btrfs-progs can fall back to decompressing and writing if the kernel doesn't support BTRFS_IOC_ENCODED_WRITE, but the user may not be prepared to pay that CPU cost). Going forward, since it's easier to update progs than the kernel, I think we'll want to make new send features that require kernel support opt-in, whereas anything that only requires a progs update can happen automatically.
--- Documentation/btrfs-send.asciidoc | 18 +++++- cmds/send.c | 92 ++++++++++++++++++++++++++++++- ioctl.h | 19 ++++++- kernel-shared/send.h | 2 +- 4 files changed, 125 insertions(+), 6 deletions(-)
Documentation/btrfs-send.asciidoc +17 -1
@@ -56,7 +56,23 @@ send in 'NO_FILE_DATA' mode The output stream does not contain any file data and thus cannot be used to transfer changes. This mode is faster and is useful to show the differences in metadata. --q|--quiet:::: + +--proto N:: +Use the send protocol version N. The default is 0, which means to use the +highest version supported by the running kernel. Version 1 was the original +protocol version. Version 2 encodes file data slightly more efficiently; it is +also required for sending compressed data directly (see '--compressed-data'). +Version 2 requires at least btrfs-progs 5.16 on both the sender and receiver +and at least Linux 5.16 on the sender. + +--compressed-data:: +Send data that is compressed on the filesystem directly without decompressing +it. If the receiver supports the 'BTRFS_IOC_ENCODED_WRITE' ioctl (in Linux +5.16), it can also write it directly without decompressing it. Otherwise, the +receiver will fall back to decompressing it and writing it normally. This +requires protocol version 2 or higher. + +-q|--quiet:: (deprecated) alias for global '-q' option -v|--verbose:: (deprecated) alias for global '-v' option
cmds/send.c +90 -2
150 lines not on this page · raw message
ioctl.h +17 -2
@@ -655,10 +655,24 @@ BUILD_ASSERT(sizeof(struct btrfs_ioctl_received_subvol_args_32) == 192);*/ #define BTRFS_SEND_FLAG_OMIT_END_CMD 0x4 +/* +* Read the protocol version in the structure +*/ +#define BTRFS_SEND_FLAG_VERSION 0x8 + +/* +* Send compressed data using the ENCODED_WRITE command instead of decompressing +* the data and sending it with the WRITE command. This requires protocol +* version >= 2. +*/ +#define BTRFS_SEND_FLAG_COMPRESSED 0x10 +#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \ - BTRFS_SEND_FLAG_OMIT_END_CMD) + BTRFS_SEND_FLAG_OMIT_END_CMD | \ + BTRFS_SEND_FLAG_VERSION | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
@@ -666,7 +680,8 @@ struct btrfs_ioctl_send_args {__u64 __user *clone_sources;/* in */ __u64 parent_root;/* in */ __u64 flags;/* in */ -__u64 reserved[4 ];/* in */ +__u32 version;/* in */ +__u8 reserved[28 ];/* in */ };/* * Size of structure depends on pointer width, was not caught in the early
kernel-shared/send.h +1 -1
@@ -31,7 +31,7 @@ extern "C" {#endif #define BTRFS_SEND_STREAM_MAGIC "btrfs-stream" -#define BTRFS_SEND_STREAM_VERSION 1 +#define BTRFS_SEND_STREAM_VERSION 2#define BTRFS_SEND_BUF_SIZE_V1 (64 * 1024)
Signature · 1 line
2.34.0
PATCH v12 10/10 btrfs-progs: receive: add tests for basic encoded_write send/receive
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Adapt the existing send/receive tests by passing '-o compress-force' to the mount commands in a new test. After writing a few files in the various compression formats, send/receive them with and without --force-decompress to test both the encoded_write path and the fallback to decode+write.
--- .../052-receive-write-encoded/test.sh | 114 ++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100755 tests/misc-tests/052-receive-write-encoded/test.sh
tests/misc-tests/052-receive-write-encoded/test.sh new file +114 -0
@@ -0,0 +1,114 @@ +#!/bin/bash +# +# test that we can send and receive encoded writes for three modes of +# transparent compression: zlib, lzo, and zstd. + +source "$TEST_TOP/common" + +check_prereq mkfs.btrfs +check_prereq btrfs + +setup_root_helper +prepare_test_dev + +here=`pwd` + +# assumes the filesystem exists, and does mount, write, snapshot, send, unmount +# for the specified encoding option +send_one() { + local str + local subv + local snap + + algorithm="$1" + shift + str="$1" + shift + + subv="subv-$algorithm" + snap="snap-$algorithm" + + run_check_mount_test_dev "-o" "compress-force=$algorithm" + cd "$TEST_MNT" || _fail "cannot chdir to TEST_MNT" + + run_check $SUDO_HELPER "$TOP/btrfs" subvolume create "$subv" + run_check $SUDO_HELPER dd if=/dev/zero of="$subv/file1" bs=1M count=1 + run_check $SUDO_HELPER dd if=/dev/zero of="$subv/file2" bs=500K count=1 + run_check $SUDO_HELPER "$TOP/btrfs" subvolume snapshot -r "$subv" "$snap" + run_check $SUDO_HELPER "$TOP/btrfs" send -f "$str" "$snap" "$@" + + cd "$here" || _fail "cannot chdir back to test directory" + run_check_umount_test_dev +} + +receive_one() { + local str + str="$1" + shift + + run_check_mkfs_test_dev + run_check_mount_test_dev + run_check $SUDO_HELPER "$TOP/btrfs" receive "$@" -v -f "$str" "$TEST_MNT" + run_check_umount_test_dev + run_check rm -f -- "$str" +} + +test_one_write_encoded() { + local str + local algorithm + algorithm="$1" + shift + str="$here/stream-$algorithm.stream" + + run_check_mkfs_test_dev + send_one "$algorithm" "$str" --compressed-data + receive_one "$str" "$@" +} + +test_one_stream_v1() { + local str + local algorithm + algorithm="$1" + shift + str="$here/stream-$algorithm.stream" + + run_check_mkfs_test_dev + send_one "$algorithm" "$str" --proto 1 + receive_one "$str" "$@" +} + +test_mix_write_encoded() { + local strzlib + local strlzo + local strzstd + strzlib="$here/stream-zlib.stream" + strlzo="$here/stream-lzo.stream" + strzstd="$here/stream-zstd.stream" + + run_check_mkfs_test_dev + + send_one "zlib" "$strzlib" --compressed-data + send_one "lzo" "$strlzo" --compressed-data + send_one "zstd" "$strzstd" --compressed-data + + receive_one "$strzlib" + receive_one "$strlzo" + receive_one "$strzstd" +} + +test_one_write_encoded "zlib" +test_one_write_encoded "lzo" +test_one_write_encoded "zstd" + +# with decompression forced +test_one_write_encoded "zlib" "--force-decompress" +test_one_write_encoded "lzo" "--force-decompress" +test_one_write_encoded "zstd" "--force-decompress" + +# send stream v1 +test_one_stream_v1 "zlib" +test_one_stream_v1 "lzo" +test_one_stream_v1 "zstd" + +# files use a mix of compression algorithms +test_mix_write_encoded
Signature · 1 line
2.34.0
Re: [PATCH v12 11/17] btrfs: send: remove unused send_ctx::{total,cmd}_send_size
In reply to Omar SandovalQuoted 3 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
We collect these statistics but have never used them for anything.
There was a protocol extension to put the progress information to the stream, so that should be also part of the v2 update.
Re: [PATCH v12 13/17] btrfs: add send stream v2 definitions
In reply to Omar Sandovalfs/btrfs/send.h enum { · line 129
Quoted 10 lines · Omar Sandoval
fs/btrfs/send.h +5
-0@@ -113,6 +121,11 @@ enum {BTRFS_SEND_A_PATH_LINK ,BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA,
I don't like the conditional meaning of the DATA attribute, I'd rather see a new one that's v2+. It's adding a complexity that's not obvious without some context.
Re: [PATCH v12 13/17] btrfs: add send stream v2 definitions
In reply to Omar SandovalQuoted 16 lines · Omar Sandoval
fs/btrfs/send.h +5
-1@@ -12,7 +12,11 @@#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +/* +* In send stream v1, no command is larger than 64k. In send stream v2, no limit +* should be assumed. +*/ +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64Kenum btrfs_tlv_type {BTRFS_TLV_U8 ,
fs/btrfs/send.h enum btrfs_send_cmd { · line 90
Quoted 8 lines
fs/btrfs/send.h +4
-1@@ -80,7 +84,10 @@ enum btrfs_send_cmd {BTRFS_SEND_C_MAX_V1 =BTRFS_SEND_C_UPDATE_EXTENT ,/* Version 2 */ - BTRFS_SEND_C_MAX_V2 = BTRFS_SEND_C_MAX_V1, +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , + BTRFS_SEND_C_MAX_V2 = BTRFS_SEND_C_ENCODED_WRITE,
The previous patch changes the MAX_V command to be equal to the previous command but that's exactly what I wanted to avoid in the protocol definition list and keep it linear.
Re: [PATCH v12 12/17] btrfs: send: fix maximum command numbering
In reply to Omar SandovalQuoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Commit
e77fbf990316("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and__BTRFS_SEND_C_MAX_V1is accordingly 23. But then__BTRFS_SEND_C_MAX_V2is 24, suggesting that v2 has a command numbered 23, and__BTRFS_SEND_C_MAXis 25, suggesting that 23 and 24 are valid commands.
The MAX definitions have the __ prefix so they're private and not meant to be used as proper commands, so nothing should suggest there are any commands with numbers 23 to 25 in the example.
Quoted 4 lines
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating
__BTRFS_SEND_C_MAXfor every new version.
It's probably a matter of taste, I'd intentionally avoid the pattern above, ie. repeating the previous command to define max.
fs/btrfs/send.c __maybe_unused · line 320
Quoted 10 lines
fs/btrfs/send.c +2
-2@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;
This seems to be the only practical difference, < or <= .
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar Sandovalfs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10537
Quoted 10 lines · Omar Sandoval
fs/btrfs/inode.c +10
-0+static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum
Should this also say it depends ont the sector (not page) size?
Quoted 15 lines
fs/btrfs/inode.c +15
-0+* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} + + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);
Please don't do chained initializations.
Quoted 102 lines
fs/btrfs/inode.c +102
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter); +if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode; +u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio (struct inode *inode, +struct bio *bio,int mirror_num, +unsigned long bio_flags) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num); +if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ; +struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio);
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10724
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status);
The WRITE_ONCE is here 3 times, I wonder if this is ok to be opencoded like that. I'd suggest to use a helper with a comment.
Quoted 96 lines
fs/btrfs/inode.c +96
-0+ } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked)
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10830
Quoted 10 lines
fs/btrfs/inode.c +10
-0+{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i; +u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE );
Power of two compile time constants can use the bitmask operations for alighnment.
Quoted 336 lines
fs/btrfs/inode.c +193
-0+ pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM); +if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode); + +if (iocb->ki_pos >= inode->i_size) { +inode_unlock_shared (inode); +return 0 ; + } + start =ALIGN_DOWN (iocb->ki_pos, fs_info->sectorsize); +/* +* We don't know how long the extent containing iocb->ki_pos is, but if +* it's compressed we know that it won't be longer than this. +*/ + lockend = start +BTRFS_MAX_UNCOMPRESSED -1 ; + +for (;;) { +struct btrfs_ordered_extent *ordered; + + ret =btrfs_wait_ordered_range (inode, start, + lockend - start +1 ); +if (ret) + goto out_unlock_inode; +lock_extent_bits (io_tree, start, lockend, &cached_state); + ordered =btrfs_lookup_ordered_range (BTRFS_I (inode), start, + lockend - start +1 ); +if (!ordered) +break ; +btrfs_put_ordered_extent (ordered); +unlock_extent_cached (io_tree, start, lockend, &cached_state); +cond_resched (); + } + + em =btrfs_get_extent (BTRFS_I (inode),NULL ,0 , start, + lockend - start +1 ); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + goto out_unlock_extent; + } + +if (em->block_start ==EXTENT_MAP_INLINE ) { +u64 extent_start = em->start; + +/* +* For inline extents we get everything we need out of the +* extent item. +*/ +free_extent_map (em); + em =NULL ; + ret =btrfs_encoded_read_inline (iocb, iter, start, lockend, + &cached_state, extent_start, + count, encoded, &unlocked); + goto out; + } + +/* +* We only want to return up to EOF even if the extent extends beyond +* that. +*/ + encoded->len = (min_t (u64,extent_map_end (em), inode->i_size) - + iocb->ki_pos); +if (em->block_start ==EXTENT_MAP_HOLE || +test_bit (EXTENT_FLAG_PREALLOC , &em->flags)) { + disk_bytenr =EXTENT_MAP_HOLE ; + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len); + }else if (test_bit (EXTENT_FLAG_COMPRESSED , &em->flags)) { + disk_bytenr = em->block_start; +/* +* Bail if the buffer isn't large enough to return the whole +* compressed extent. +*/ +if (em->block_len > count) { + ret = -ENOBUFS ; + goto out_em; + } + disk_io_size = count = em->block_len; + encoded->unencoded_len = em->ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - em->orig_start; + ret =btrfs_encoded_io_compression_from_extent ( + em->compress_type); +if (ret <0 ) + goto out_em; + encoded->compression = ret; + }else { + disk_bytenr = em->block_start + (start - em->start); +if (encoded->len > count) + encoded->len = count; +/* +* Don't read beyond what we locked. This also limits the page +* allocations that we'll do. +*/ + disk_io_size =min (lockend +1 , + iocb->ki_pos + encoded->len) - start; + encoded->len = encoded->unencoded_len = count = + start + disk_io_size - iocb->ki_pos; + disk_io_size =ALIGN (disk_io_size, fs_info->sectorsize); + } +free_extent_map (em); + em =NULL ; + +if (disk_bytenr ==EXTENT_MAP_HOLE ) { +unlock_extent_cached (io_tree, start, lockend, &cached_state); +inode_unlock_shared (inode); + unlocked = true; + ret =iov_iter_zero (count, iter); +if (ret != count) + ret = -EFAULT ; + }else { + ret =btrfs_encoded_read_regular (iocb, iter, start, lockend, + &cached_state, disk_bytenr, + disk_io_size, count, + encoded->compression, + &unlocked); + } + +out: +if (ret >=0 ) + iocb->ki_pos += encoded->len; +out_em: +free_extent_map (em); +out_unlock_extent: +if (!unlocked) +unlock_extent_cached (io_tree, start, lockend, &cached_state); +out_unlock_inode: +if (!unlocked) +inode_unlock_shared (inode); +return ret; +} +#ifdef CONFIG_SWAP /* * Add an entry indicating a block group or device which is pinned by a fs/btrfs/ioctl.c +106
-0@@ -28,6 +28,7 @@#include <linux/iversion.h> #include <linux/fileattr.h> #include <linux/fsverity.h> +#include <linux/sched/xacct.h> #include "ctree.h" #include "disk-io.h" #include "export.h" @@ -88,6 +89,22 @@ struct btrfs_ioctl_send_args_32 {#define BTRFS_IOC_SEND_32 _IOW(BTRFS_IOCTL_MAGIC, 38, \ struct btrfs_ioctl_send_args_32) + +struct btrfs_ioctl_encoded_io_args_32 { +compat_uptr_t iov; +compat_ulong_t iovcnt; +__s64 offset; +__u64 flags; +__u64 len; +__u64 unencoded_len; +__u64 unencoded_offset; +__u32 compression; +__u32 encryption; +__u32 reserved[8 ]; +}; + +#define BTRFS_IOC_ENCODED_READ_32 _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args_32)#endif /* Mask out flags that are inappropriate for the given type of inode. */ @@ -4861,6 +4878,89 @@ static int _btrfs_ioctl_send(struct file *file, void __user *argp, bool compat)return ret; } +static int btrfs_ioctl_encoded_read (struct file *file,void __user *argp, +bool compat) +{ +struct btrfs_ioctl_encoded_io_args args = {}; + size_t copy_end_kernel = offsetofend(struct btrfs_ioctl_encoded_io_args, + flags); +size_t copy_end; +struct iovec iovstack[UIO_FASTIOV ]; +struct iovec *iov = iovstack; +struct iov_iter iter; +loff_t pos; +struct kiocb kiocb; +ssize_t ret; + +if (!capable (CAP_SYS_ADMIN )) { + ret = -EPERM ; + goto out_acct; + } + +if (compat) { +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +struct btrfs_ioctl_encoded_io_args_32 args32; + + copy_end = offsetofend(struct btrfs_ioctl_encoded_io_args_32, + flags); +if (copy_from_user (&args32, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + args.iov =compat_ptr (args32.iov); + args.iovcnt = args32.iovcnt; + args.offset = args32.offset; + args.flags = args32.flags; +#else +return -ENOTTY ; +#endif + }else { + copy_end = copy_end_kernel; +if (copy_from_user (&args, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + } +if (args.flags !=0 ) { + ret = -EINVAL ; + goto out_acct; + } + + ret =import_iovec (READ , args.iov, args.iovcnt,ARRAY_SIZE (iovstack), + &iov, &iter); +if (ret <0 ) + goto out_acct; + +if (iov_iter_count (&iter) ==0 ) { + ret =0 ; + goto out_iov; + } + pos = args.offset; + ret =rw_verify_area (READ , file, &pos, args.len); +if (ret <0 ) + goto out_iov; + +init_sync_kiocb (&kiocb, file); + kiocb.ki_pos = pos; + + ret =btrfs_encoded_read (&kiocb, &iter, &args); +if (ret >=0 ) { +fsnotify_access (file); +if (copy_to_user (argp + copy_end, + (char *)&args + copy_end_kernel, +sizeof (args) - copy_end_kernel)) + ret = -EFAULT ; + } + +out_iov: +kfree (iov); +out_acct: +if (ret >0 ) +add_rchar (current, ret); +inc_syscr (current); +return ret; +} +long btrfs_ioctl (struct file *file,unsigned int cmd,unsigned long arg) {@@ -5005,6 +5105,12 @@ long btrfs_ioctl(struct file *file, unsigned intreturn fsverity_ioctl_enable (file, (const void __user *)argp);case FS_IOC_MEASURE_VERITY :return fsverity_ioctl_measure (file, argp); +case BTRFS_IOC_ENCODED_READ : +return btrfs_ioctl_encoded_read (file, argp, false); +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +case BTRFS_IOC_ENCODED_READ_32 : +return btrfs_ioctl_encoded_read (file, argp, true); +#endif }return -ENOTTY ;Signature · 1 line
2.34.0
Re: [PATCH v12 01/17] fs: export rw_verify_area()
In reply to Omar SandovalQuoted 10 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in
rw_verify_area(), let's just export it.Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>
include/linux/fs.h extern loff_t fixed_size_llseek(struct file *file, loff_t offset, · line 3247
Quoted 4 lines
include/linux/fs.h +1
-0@@ -3244,6 +3244,7 @@ extern loff_t fixed_size_llseek(struct file *file, loff_t offset, int whence, loff_t size);extern loff_t no_seek_end_llseek_size (struct file *,loff_t ,int ,loff_t );extern loff_t no_seek_end_llseek (struct file *,loff_t ,int ); +extern int rw_verify_area (int ,struct file *,const loff_t *,size_t );
Do you have an ack from VFS people for exporting a function from fs/interna.h to the normal fs.h?
Quoted 5 lines
include/linux/fs.h +0
-0extern int generic_file_open (struct inode * inode,struct file * filp);extern int nonseekable_open (struct inode * inode,struct file * filp);extern int stream_open (struct inode * inode,struct file * filp);Signature · 1 line
2.34.0
Re: [PATCH v12 14/17] btrfs: send: write larger chunks when using stream v2
In reply to Omar SandovalQuoted 11 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
The length field of the send stream TLV header is 16 bits. This means that the maximum amount of data that can be sent for one write is 64k minus one. However, encoded writes must be able to send the maximum compressed extent (128k) in one command. To support this, send stream version 2 encodes the DATA attribute differently: it has no length field, and the length is implicitly up to the end of containing command (which has a 32-bit length field). Although this is necessary for encoded writes, normal writes can benefit from it, too.
Quoted 6 lines
Also add a check to enforce that the DATA attribute is last. It is only strictly necessary for v2, but we might as well make v1 consistent with it.
For v2, let's bump up the send buffer to the maximum compressed extent size plus 16k for the other metadata (144k total).
I'm not sure we want to set the number like that, it feels quite limiting for potential compression enhancements.
Quoted 4 lines
Since this will most
likely be vmalloc'd (and always will be after the next commit), we round it up to the next page since we might as well use the rest of the page on systems with >16k pages.
Would it work also without the virtual mappings? For speedup it makes sense to use vmalloc area, but as a fallback writing in smaller portions or page by page eventually should be also possible. For that reason I don't think we should set the maximum other than what fits to 32bit number minus some overhead.
Re: [PATCH v12 12/17] btrfs: send: fix maximum command numbering
In reply to David SterbaQuoted 23 lines · David Sterba
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Commit
e77fbf990316("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and__BTRFS_SEND_C_MAX_V1is accordingly 23. But then__BTRFS_SEND_C_MAX_V2is 24, suggesting that v2 has a command numbered 23, and__BTRFS_SEND_C_MAXis 25, suggesting that 23 and 24 are valid commands.The MAX definitions have the __ prefix so they're private and not meant to be used as proper commands, so nothing should suggest there are any commands with numbers 23 to 25 in the example.
Quoted 4 lines
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating
__BTRFS_SEND_C_MAXfor every new version.It's probably a matter of taste, I'd intentionally avoid the pattern above, ie. repeating the previous command to define max.
Quoted 12 lines
fs/btrfs/send.c __maybe_unused · line 320
Quoted 10 lines
fs/btrfs/send.c +2
-2@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;This seems to be the only practical difference, < or <= .
There is another practical difference, which is more significant in my
opinion: the linear style creates "gaps" in the valid commands. Consider this, with explicit values added for clarity:
enum btrfs_send_cmd {
BTRFS_SEND_C_UNSPEC = 0,
/* Version 1 */
BTRFS_SEND_C_SUBVOL = 1,
BTRFS_SEND_C_SNAPSHOT = 2,
BTRFS_SEND_C_MKFILE = 3,
BTRFS_SEND_C_MKDIR = 4,
BTRFS_SEND_C_MKNOD = 5,
BTRFS_SEND_C_MKFIFO = 6,
BTRFS_SEND_C_MKSOCK = 7,
BTRFS_SEND_C_SYMLINK = 8,
BTRFS_SEND_C_RENAME = 9,
BTRFS_SEND_C_LINK = 10,
BTRFS_SEND_C_UNLINK = 11,
BTRFS_SEND_C_RMDIR = 12,
BTRFS_SEND_C_SET_XATTR = 13,
BTRFS_SEND_C_REMOVE_XATTR = 14,
BTRFS_SEND_C_WRITE = 15,
BTRFS_SEND_C_CLONE = 16,
BTRFS_SEND_C_TRUNCATE = 17,
BTRFS_SEND_C_CHMOD = 18,
BTRFS_SEND_C_CHOWN = 19,
BTRFS_SEND_C_UTIMES = 20,
BTRFS_SEND_C_END = 21,
BTRFS_SEND_C_UPDATE_EXTENT = 22,
__BTRFS_SEND_C_MAX_V1 = 23,
/* Version 2 */
BTRFS_SEND_C_FALLOCATE = 24,
BTRFS_SEND_C_SETFLAGS = 25,
BTRFS_SEND_C_ENCODED_WRITE = 26,
__BTRFS_SEND_C_MAX_V2 = 27,
/* End */
__BTRFS_SEND_C_MAX = 28,
};#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1) /* 27 */
Notice that BTRFS_SEND_C_UPDATE_EXTENT is 22 and the next valid command is BTRFS_SEND_C_FALLOCATE, which is 24. So 23 does not correspond to an actual command; it's a "gap". This is somewhat cosmetic, but it's an ugly wart in the protocol.
Also consider something indexing on the command number, like the cmd_send_size thing I got rid of in the previous patch:
u64 cmd_send_size[BTRFS_SEND_C_MAX + 1]
Indices 23 and 27 are wasted. It's only 16 bytes in this case, which doesn't matter practically, but it's unpleasant.
Maybe you were aware of this and fine with it, in which case we can drop this change. But I think the name repetition is less ugly than the gaps.
Re: [PATCH v12 13/17] btrfs: add send stream v2 definitions
In reply to David SterbaQuoted 4 lines · David Sterba
Quoted 3 lines · Omar Sandoval
(quoted diff) +0
-0@@ -113,6 +121,11 @@ enum { BTRFS_SEND_A_PATH_LINK,
Quoted 11 lines
Review enum { · line 129
Quoted 7 lines
(quoted diff) +5
-0BTRFS_SEND_A_FILE_OFFSET, + /* + * In send stream v2, this attribute is special: it must be the last + * attribute in a command, its header contains only the type, and its + * length is implicitly the remaining length of the command. + */ BTRFS_SEND_A_DATA,I don't like the conditional meaning of the DATA attribute, I'd rather see a new one that's v2+. It's adding a complexity that's not obvious without some context.
Hm, I could add a BTRFS_SEND_A_DATA2, but then we'd need something like this on the parsing side:
common/send-stream.c +9 -3
@@ -189,7 +189,7 @@ static int read_cmd(struct btrfs_send_stream *sctx) pos +=sizeof (tlv_type); data +=sizeof (tlv_type); -if (sctx->version ==2 && tlv_type ==BTRFS_SEND_A_DATA ) { +if (tlv_type ==BTRFS_SEND_A_DATA2 ) { send_attr->tlv_len = cmd_len - pos; }else {if (cmd_len - pos <sizeof (__le16)) {
@@ -456,7 +456,10 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)case BTRFS_SEND_C_WRITE :TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path);TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset); -TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); +if (sctx->cmd_attrs[BTRFS_SEND_A_DATA2 ].data) +TLV_GET (sctx,BTRFS_SEND_A_DATA2 , &data, &len); +else +TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); ret = sctx->ops->write (path, data, offset, len, sctx->user);break ;case BTRFS_SEND_C_ENCODED_WRITE :
@@ -476,7 +479,10 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)TLV_GET_U32 (sctx,BTRFS_SEND_A_ENCRYPTION , &encryption); else encryption =BTRFS_ENCODED_IO_ENCRYPTION_NONE ; -TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); +if (sctx->cmd_attrs[BTRFS_SEND_A_DATA2 ].data) +TLV_GET (sctx,BTRFS_SEND_A_DATA2 , &data, &len); +else +TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); ret = sctx->ops->encoded_write(path, data, offset, len, unencoded_file_len, unencoded_len, unencoded_offset,
It doesn't really make reading the attribute any clearer, and then we have to check for two attributes. But, if you prefer it this way, I can change it.
P.S. if we stick with my way, that sctx->version == 2 should probably be sctx->version >= 2
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to David SterbaQuoted 13 lines · David Sterba
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10537
Quoted 10 lines · Omar Sandoval
fs/btrfs/inode.c +10
-0+static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum Should this also say it depends ont the sector (not page) size?
Yeah, the code also needs to be changed to use the filesystem sector size now that we we support subpage LZO.
I'll clean up the other comments.
Quoted 590 lines
Quoted 15 lines
fs/btrfs/inode.c +15
-0+* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} + + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);Please don't do chained initializations.
Quoted 102 lines
fs/btrfs/inode.c +102
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter); +if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode; +u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio (struct inode *inode, +struct bio *bio,int mirror_num, +unsigned long bio_flags) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num); +if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ; +struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10724
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status);The
WRITE_ONCEis here 3 times, I wonder if this is ok to be opencoded like that. I'd suggest to use a helper with a comment.Quoted 96 lines
fs/btrfs/inode.c +96
-0+ } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked)fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10830
Quoted 10 lines
fs/btrfs/inode.c +10
-0+{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i; +u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE );Power of two compile time constants can use the bitmask operations for alighnment.
Quoted 336 lines
fs/btrfs/inode.c +193
-0+ pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM); +if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode); + +if (iocb->ki_pos >= inode->i_size) { +inode_unlock_shared (inode); +return 0 ; + } + start =ALIGN_DOWN (iocb->ki_pos, fs_info->sectorsize); +/* +* We don't know how long the extent containing iocb->ki_pos is, but if +* it's compressed we know that it won't be longer than this. +*/ + lockend = start +BTRFS_MAX_UNCOMPRESSED -1 ; + +for (;;) { +struct btrfs_ordered_extent *ordered; + + ret =btrfs_wait_ordered_range (inode, start, + lockend - start +1 ); +if (ret) + goto out_unlock_inode; +lock_extent_bits (io_tree, start, lockend, &cached_state); + ordered =btrfs_lookup_ordered_range (BTRFS_I (inode), start, + lockend - start +1 ); +if (!ordered) +break ; +btrfs_put_ordered_extent (ordered); +unlock_extent_cached (io_tree, start, lockend, &cached_state); +cond_resched (); + } + + em =btrfs_get_extent (BTRFS_I (inode),NULL ,0 , start, + lockend - start +1 ); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + goto out_unlock_extent; + } + +if (em->block_start ==EXTENT_MAP_INLINE ) { +u64 extent_start = em->start; + +/* +* For inline extents we get everything we need out of the +* extent item. +*/ +free_extent_map (em); + em =NULL ; + ret =btrfs_encoded_read_inline (iocb, iter, start, lockend, + &cached_state, extent_start, + count, encoded, &unlocked); + goto out; + } + +/* +* We only want to return up to EOF even if the extent extends beyond +* that. +*/ + encoded->len = (min_t (u64,extent_map_end (em), inode->i_size) - + iocb->ki_pos); +if (em->block_start ==EXTENT_MAP_HOLE || +test_bit (EXTENT_FLAG_PREALLOC , &em->flags)) { + disk_bytenr =EXTENT_MAP_HOLE ; + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len); + }else if (test_bit (EXTENT_FLAG_COMPRESSED , &em->flags)) { + disk_bytenr = em->block_start; +/* +* Bail if the buffer isn't large enough to return the whole +* compressed extent. +*/ +if (em->block_len > count) { + ret = -ENOBUFS ; + goto out_em; + } + disk_io_size = count = em->block_len; + encoded->unencoded_len = em->ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - em->orig_start; + ret =btrfs_encoded_io_compression_from_extent ( + em->compress_type); +if (ret <0 ) + goto out_em; + encoded->compression = ret; + }else { + disk_bytenr = em->block_start + (start - em->start); +if (encoded->len > count) + encoded->len = count; +/* +* Don't read beyond what we locked. This also limits the page +* allocations that we'll do. +*/ + disk_io_size =min (lockend +1 , + iocb->ki_pos + encoded->len) - start; + encoded->len = encoded->unencoded_len = count = + start + disk_io_size - iocb->ki_pos; + disk_io_size =ALIGN (disk_io_size, fs_info->sectorsize); + } +free_extent_map (em); + em =NULL ; + +if (disk_bytenr ==EXTENT_MAP_HOLE ) { +unlock_extent_cached (io_tree, start, lockend, &cached_state); +inode_unlock_shared (inode); + unlocked = true; + ret =iov_iter_zero (count, iter); +if (ret != count) + ret = -EFAULT ; + }else { + ret =btrfs_encoded_read_regular (iocb, iter, start, lockend, + &cached_state, disk_bytenr, + disk_io_size, count, + encoded->compression, + &unlocked); + } + +out: +if (ret >=0 ) + iocb->ki_pos += encoded->len; +out_em: +free_extent_map (em); +out_unlock_extent: +if (!unlocked) +unlock_extent_cached (io_tree, start, lockend, &cached_state); +out_unlock_inode: +if (!unlocked) +inode_unlock_shared (inode); +return ret; +} +#ifdef CONFIG_SWAP /* * Add an entry indicating a block group or device which is pinned by a fs/btrfs/ioctl.c +106
-0@@ -28,6 +28,7 @@#include <linux/iversion.h> #include <linux/fileattr.h> #include <linux/fsverity.h> +#include <linux/sched/xacct.h> #include "ctree.h" #include "disk-io.h" #include "export.h" @@ -88,6 +89,22 @@ struct btrfs_ioctl_send_args_32 {#define BTRFS_IOC_SEND_32 _IOW(BTRFS_IOCTL_MAGIC, 38, \ struct btrfs_ioctl_send_args_32) + +struct btrfs_ioctl_encoded_io_args_32 { +compat_uptr_t iov; +compat_ulong_t iovcnt; +__s64 offset; +__u64 flags; +__u64 len; +__u64 unencoded_len; +__u64 unencoded_offset; +__u32 compression; +__u32 encryption; +__u32 reserved[8 ]; +}; + +#define BTRFS_IOC_ENCODED_READ_32 _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args_32)#endif /* Mask out flags that are inappropriate for the given type of inode. */ @@ -4861,6 +4878,89 @@ static int _btrfs_ioctl_send(struct file *file, void __user *argp, bool compat)return ret; } +static int btrfs_ioctl_encoded_read (struct file *file,void __user *argp, +bool compat) +{ +struct btrfs_ioctl_encoded_io_args args = {}; + size_t copy_end_kernel = offsetofend(struct btrfs_ioctl_encoded_io_args, + flags); +size_t copy_end; +struct iovec iovstack[UIO_FASTIOV ]; +struct iovec *iov = iovstack; +struct iov_iter iter; +loff_t pos; +struct kiocb kiocb; +ssize_t ret; + +if (!capable (CAP_SYS_ADMIN )) { + ret = -EPERM ; + goto out_acct; + } + +if (compat) { +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +struct btrfs_ioctl_encoded_io_args_32 args32; + + copy_end = offsetofend(struct btrfs_ioctl_encoded_io_args_32, + flags); +if (copy_from_user (&args32, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + args.iov =compat_ptr (args32.iov); + args.iovcnt = args32.iovcnt; + args.offset = args32.offset; + args.flags = args32.flags; +#else +return -ENOTTY ; +#endif + }else { + copy_end = copy_end_kernel; +if (copy_from_user (&args, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + } +if (args.flags !=0 ) { + ret = -EINVAL ; + goto out_acct; + } + + ret =import_iovec (READ , args.iov, args.iovcnt,ARRAY_SIZE (iovstack), + &iov, &iter); +if (ret <0 ) + goto out_acct; + +if (iov_iter_count (&iter) ==0 ) { + ret =0 ; + goto out_iov; + } + pos = args.offset; + ret =rw_verify_area (READ , file, &pos, args.len); +if (ret <0 ) + goto out_iov; + +init_sync_kiocb (&kiocb, file); + kiocb.ki_pos = pos; + + ret =btrfs_encoded_read (&kiocb, &iter, &args); +if (ret >=0 ) { +fsnotify_access (file); +if (copy_to_user (argp + copy_end, + (char *)&args + copy_end_kernel, +sizeof (args) - copy_end_kernel)) + ret = -EFAULT ; + } + +out_iov: +kfree (iov); +out_acct: +if (ret >0 ) +add_rchar (current, ret); +inc_syscr (current); +return ret; +} +long btrfs_ioctl (struct file *file,unsigned int cmd,unsigned long arg) {@@ -5005,6 +5105,12 @@ long btrfs_ioctl(struct file *file, unsigned intreturn fsverity_ioctl_enable (file, (const void __user *)argp);case FS_IOC_MEASURE_VERITY :return fsverity_ioctl_measure (file, argp); +case BTRFS_IOC_ENCODED_READ : +return btrfs_ioctl_encoded_read (file, argp, false); +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +case BTRFS_IOC_ENCODED_READ_32 : +return btrfs_ioctl_encoded_read (file, argp, true); +#endif }return -ENOTTY ;Signature · 1 line
2.34.0
Re: [PATCH v12 01/17] fs: export rw_verify_area()
In reply to David SterbaQuoted 6 lines · David Sterba
Quoted 5 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in
rw_verify_area(), let's just export it.
Quoted 12 lines
include/linux/fs.h extern loff_t fixed_size_llseek(struct file *file, loff_t offset, · line 3247
Quoted 9 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>include/linux/fs.h +1
-0@@ -3244,6 +3244,7 @@ extern loff_t fixed_size_llseek(struct file *file, loff_t offset, int whence, loff_t size);extern loff_t no_seek_end_llseek_size (struct file *,loff_t ,int ,loff_t );extern loff_t no_seek_end_llseek (struct file *,loff_t ,int ); +extern int rw_verify_area (int ,struct file *,const loff_t *,size_t );Do you have an ack from VFS people for exporting a function from
fs/interna.hto the normalfs.h?
Nope, although I've sent it enough times that they should've nacked it by now if they cared. I guess I didn't cc fsdevel on this version, so I'll ping this patch on v11.
Re: [PATCH v12 14/17] btrfs: send: write larger chunks when using stream v2
In reply to David SterbaQuoted 16 lines · David Sterba
Quoted 15 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
The length field of the send stream TLV header is 16 bits. This means that the maximum amount of data that can be sent for one write is 64k minus one. However, encoded writes must be able to send the maximum compressed extent (128k) in one command. To support this, send stream version 2 encodes the DATA attribute differently: it has no length field, and the length is implicitly up to the end of containing command (which has a 32-bit length field). Although this is necessary for encoded writes, normal writes can benefit from it, too.
Also add a check to enforce that the DATA attribute is last. It is only strictly necessary for v2, but we might as well make v1 consistent with it.
Quoted 5 lines
Quoted 2 lines
For v2, let's bump up the send buffer to the maximum compressed extent size plus 16k for the other metadata (144k total).
I'm not sure we want to set the number like that, it feels quite limiting for potential compression enhancements.
This is all we need for now, but we can always raise it in the future. I amended the protocol and the progs send parsing code to assume no hard limit.
Quoted 10 lines
Quoted 4 lines
Since this will most
likely be vmalloc'd (and always will be after the next commit), we round it up to the next page since we might as well use the rest of the page on systems with >16k pages.Would it work also without the virtual mappings? For speedup it makes sense to use vmalloc area, but as a fallback writing in smaller portions or page by page eventually should be also possible. For that reason I don't think we should set the maximum other than what fits to 32bit number minus some overhead.
I think you're saying that we could allocate a smaller buffer and do smaller reads that we immediately write to the send pipe/file? So something like:
send_write() {
write_tlv_metadata_to_pipe();
while (written < to_write) {
read_small_chunk();
write_small_chunk_to_pipe();
written += size_of_small_chunk();
}
}And from the protocol's point of view, it's still one big command, although we didn't have to keep it all in memory at once.
If I'm understanding correctly, then yes, I think that's something we could do eventually. And my description of v2 allows this:
-#define BTRFS_SEND_BUF_SIZE SZ_64K
+/*
+ * In send stream v1, no command is larger than 64k. In send stream v2, no limit
+ * should be assumed.
+ */
+#define BTRFS_SEND_BUF_SIZE_V1 SZ_64K
Although receive would have to be more intelligent about reading huge commands.
Re: [PATCH v12 12/17] btrfs: send: fix maximum command numbering
In reply to Omar SandovalQuoted 94 lines · Omar Sandoval
Quoted 23 lines · David Sterba
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Commit
e77fbf990316("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and__BTRFS_SEND_C_MAX_V1is accordingly 23. But then__BTRFS_SEND_C_MAX_V2is 24, suggesting that v2 has a command numbered 23, and__BTRFS_SEND_C_MAXis 25, suggesting that 23 and 24 are valid commands.The MAX definitions have the __ prefix so they're private and not meant to be used as proper commands, so nothing should suggest there are any commands with numbers 23 to 25 in the example.
Quoted 4 lines
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating
__BTRFS_SEND_C_MAXfor every new version.It's probably a matter of taste, I'd intentionally avoid the pattern above, ie. repeating the previous command to define max.
Quoted 12 lines
fs/btrfs/send.c __maybe_unused · line 320
Quoted 10 lines
fs/btrfs/send.c +2
-2@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;This seems to be the only practical difference, < or <= .
There is another practical difference, which is more significant in my
opinion: the linear style creates "gaps" in the valid commands. Consider this, with explicit values added for clarity:enum btrfs_send_cmd { BTRFS_SEND_C_UNSPEC = 0, /* Version 1 */ BTRFS_SEND_C_SUBVOL = 1, BTRFS_SEND_C_SNAPSHOT = 2, BTRFS_SEND_C_MKFILE = 3, BTRFS_SEND_C_MKDIR = 4, BTRFS_SEND_C_MKNOD = 5, BTRFS_SEND_C_MKFIFO = 6, BTRFS_SEND_C_MKSOCK = 7, BTRFS_SEND_C_SYMLINK = 8, BTRFS_SEND_C_RENAME = 9, BTRFS_SEND_C_LINK = 10, BTRFS_SEND_C_UNLINK = 11, BTRFS_SEND_C_RMDIR = 12, BTRFS_SEND_C_SET_XATTR = 13, BTRFS_SEND_C_REMOVE_XATTR = 14, BTRFS_SEND_C_WRITE = 15, BTRFS_SEND_C_CLONE = 16, BTRFS_SEND_C_TRUNCATE = 17, BTRFS_SEND_C_CHMOD = 18, BTRFS_SEND_C_CHOWN = 19, BTRFS_SEND_C_UTIMES = 20, BTRFS_SEND_C_END = 21, BTRFS_SEND_C_UPDATE_EXTENT = 22, __BTRFS_SEND_C_MAX_V1 = 23, /* Version 2 */ BTRFS_SEND_C_FALLOCATE = 24, BTRFS_SEND_C_SETFLAGS = 25, BTRFS_SEND_C_ENCODED_WRITE = 26, __BTRFS_SEND_C_MAX_V2 = 27, /* End */ __BTRFS_SEND_C_MAX = 28, };#define
BTRFS_SEND_C_MAX(__BTRFS_SEND_C_MAX- 1) /* 27 */Notice that
BTRFS_SEND_C_UPDATE_EXTENTis 22 and the next valid command isBTRFS_SEND_C_FALLOCATE, which is 24. So 23 does not correspond to an actual command; it's a "gap". This is somewhat cosmetic, but it's an ugly wart in the protocol.Also consider something indexing on the command number, like the
cmd_send_sizething I got rid of in the previous patch:
Quoted 7 lines
u64 cmd_send_size[BTRFS_SEND_C_MAX + 1]Indices 23 and 27 are wasted. It's only 16 bytes in this case, which doesn't matter practically, but it's unpleasant.
Maybe you were aware of this and fine with it, in which case we can drop this change. But I think the name repetition is less ugly than the gaps.
Ping. Please let me know how you'd like me to proceed on this issue and my other replies. Thanks!
Re: [PATCH v12 12/17] btrfs: send: fix maximum command numbering
Quoted 97 lines · Omar Sandoval
Quoted 96 lines · Omar Sandoval
Quoted 23 lines · David Sterba
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Commit
e77fbf990316("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and__BTRFS_SEND_C_MAX_V1is accordingly 23. But then__BTRFS_SEND_C_MAX_V2is 24, suggesting that v2 has a command numbered 23, and__BTRFS_SEND_C_MAXis 25, suggesting that 23 and 24 are valid commands.The MAX definitions have the __ prefix so they're private and not meant to be used as proper commands, so nothing should suggest there are any commands with numbers 23 to 25 in the example.
Quoted 4 lines
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating
__BTRFS_SEND_C_MAXfor every new version.It's probably a matter of taste, I'd intentionally avoid the pattern above, ie. repeating the previous command to define max.
Quoted 12 lines
fs/btrfs/send.c __maybe_unused · line 320
Quoted 10 lines
fs/btrfs/send.c +2
-2@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;This seems to be the only practical difference, < or <= .
There is another practical difference, which is more significant in my
opinion: the linear style creates "gaps" in the valid commands. Consider this, with explicit values added for clarity:enum btrfs_send_cmd { BTRFS_SEND_C_UNSPEC = 0, /* Version 1 */ BTRFS_SEND_C_SUBVOL = 1, BTRFS_SEND_C_SNAPSHOT = 2, BTRFS_SEND_C_MKFILE = 3, BTRFS_SEND_C_MKDIR = 4, BTRFS_SEND_C_MKNOD = 5, BTRFS_SEND_C_MKFIFO = 6, BTRFS_SEND_C_MKSOCK = 7, BTRFS_SEND_C_SYMLINK = 8, BTRFS_SEND_C_RENAME = 9, BTRFS_SEND_C_LINK = 10, BTRFS_SEND_C_UNLINK = 11, BTRFS_SEND_C_RMDIR = 12, BTRFS_SEND_C_SET_XATTR = 13, BTRFS_SEND_C_REMOVE_XATTR = 14, BTRFS_SEND_C_WRITE = 15, BTRFS_SEND_C_CLONE = 16, BTRFS_SEND_C_TRUNCATE = 17, BTRFS_SEND_C_CHMOD = 18, BTRFS_SEND_C_CHOWN = 19, BTRFS_SEND_C_UTIMES = 20, BTRFS_SEND_C_END = 21, BTRFS_SEND_C_UPDATE_EXTENT = 22, __BTRFS_SEND_C_MAX_V1 = 23, /* Version 2 */ BTRFS_SEND_C_FALLOCATE = 24, BTRFS_SEND_C_SETFLAGS = 25, BTRFS_SEND_C_ENCODED_WRITE = 26, __BTRFS_SEND_C_MAX_V2 = 27, /* End */ __BTRFS_SEND_C_MAX = 28, };#define
BTRFS_SEND_C_MAX(__BTRFS_SEND_C_MAX- 1) /* 27 */Notice that
BTRFS_SEND_C_UPDATE_EXTENTis 22 and the next valid command isBTRFS_SEND_C_FALLOCATE, which is 24. So 23 does not correspond to an actual command; it's a "gap". This is somewhat cosmetic, but it's an ugly wart in the protocol.Also consider something indexing on the command number, like the
cmd_send_sizething I got rid of in the previous patch:u64 cmd_send_size[BTRFS_SEND_C_MAX + 1]
Quoted 8 lines
Quoted 5 lines
Indices 23 and 27 are wasted. It's only 16 bytes in this case, which doesn't matter practically, but it's unpleasant.
Maybe you were aware of this and fine with it, in which case we can drop this change. But I think the name repetition is less ugly than the gaps.
Ping. Please let me know how you'd like me to proceed on this issue and my other replies. Thanks!
New year, new ping. Thanks!
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar SandovalQuoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.
Is there a reproducer, and a fix?
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar SandovalQuoted 73 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 496 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 106 ++++++++++ 3 files changed, 606 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +22
-0@@ -10525,6 +10525,502 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } +static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum +* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} +
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10559
Quoted 10 lines
fs/btrfs/inode.c +10
-0+static ssize_t btrfs_encoded_read_inline ( +struct kiocb *iocb, +struct iov_iter *iter,u64 start, +u64 lockend, +struct extent_state **cached_state, +u64 extent_start,size_t count, +struct btrfs_ioctl_encoded_io_args *encoded, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp);
Please use btrfs_inode in all internal helpers, either as parameters or as local variable, to avoid the BTRFS_I and btrfs_sb conversions everywhere.
Quoted 23 lines
fs/btrfs/inode.c +23
-0+struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct btrfs_path *path; +struct extent_buffer *leaf; +struct btrfs_file_extent_item *item; +u64 ram_bytes; +unsigned long ptr; +void *tmp; +ssize_t ret; + + path =btrfs_alloc_path (); +if (!path) { + ret = -ENOMEM ; + goto out; + } + ret =btrfs_lookup_file_extent (NULL ,BTRFS_I (inode)->root, path, +btrfs_ino (BTRFS_I (inode)), extent_start, +0 ); +if (ret) { +if (ret >0 ) { +/* The extent item disappeared? */ + ret = -EIO ; + } + goto out;
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10592
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ } + leaf = path->nodes[0 ]; + item =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + + ram_bytes =btrfs_file_extent_ram_bytes (leaf, item); + ptr =btrfs_file_extent_inline_start (item); + + encoded->len = (min_t (u64, extent_start + ram_bytes, inode->i_size) - + iocb->ki_pos);
No need for the outer ( )
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, item)); +if (ret <0 ) + goto out; + encoded->compression = ret; +if (encoded->compression) { +size_t inline_size; + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);
I'm sure I have commented on that in the past, please don't use chained intializations. In this case something like:
count = min_t(u64, count, encoded->len); encoded->len = count; encoded->unencoded_len = count;
Quoted 15 lines
fs/btrfs/inode.c +15
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter);
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10637
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode;
This should also be btrfs_inode
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10645
Quoted 8 lines
fs/btrfs/inode.c +8
-0+u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio(struct inode *inode,
struct btrfs_inode
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10647
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ struct bio *bio, int mirror_num, + unsigned long bio_flags)
bio_flags is unused here (and in the encoded patches afaics)
Quoted 20 lines
fs/btrfs/inode.c +20
-0+{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num);
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10677
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ;
const bool uptodate = (bbio->bio.bi_status == BLK_STS_OK);
Quoted 148 lines
fs/btrfs/inode.c +148
-0+struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i;
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10835
Quoted 10 lines
fs/btrfs/inode.c +10
-0+u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE ); + pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM);
No HIGHMEM please.
Quoted 52 lines
fs/btrfs/inode.c +52
-0+if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree;
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10897
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode);
We have helpers for inode locking now, btrfs_inode_lock, that take additional parameter for cases where we want to exclude certain locking combinations.
Which also brings the question if the encoded read/write should be excluded against some other operations like eg. deduplication has to do against mmap.
Quoted 47 lines
fs/btrfs/inode.c +47
-0+ +if (iocb->ki_pos >= inode->i_size) { +inode_unlock_shared (inode); +return 0 ; + } + start =ALIGN_DOWN (iocb->ki_pos, fs_info->sectorsize); +/* +* We don't know how long the extent containing iocb->ki_pos is, but if +* it's compressed we know that it won't be longer than this. +*/ + lockend = start +BTRFS_MAX_UNCOMPRESSED -1 ; + +for (;;) { +struct btrfs_ordered_extent *ordered; + + ret =btrfs_wait_ordered_range (inode, start, + lockend - start +1 ); +if (ret) + goto out_unlock_inode; +lock_extent_bits (io_tree, start, lockend, &cached_state); + ordered =btrfs_lookup_ordered_range (BTRFS_I (inode), start, + lockend - start +1 ); +if (!ordered) +break ; +btrfs_put_ordered_extent (ordered); +unlock_extent_cached (io_tree, start, lockend, &cached_state); +cond_resched (); + } + + em =btrfs_get_extent (BTRFS_I (inode),NULL ,0 , start, + lockend - start +1 ); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + goto out_unlock_extent; + } + +if (em->block_start ==EXTENT_MAP_INLINE ) { +u64 extent_start = em->start; + +/* +* For inline extents we get everything we need out of the +* extent item. +*/ +free_extent_map (em); + em =NULL ; + ret = btrfs_encoded_read_inline(iocb, iter, start, lockend, + &cached_state, extent_start,
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10954
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ count, encoded, &unlocked); + goto out; + } + +/* +* We only want to return up to EOF even if the extent extends beyond +* that. +*/ + encoded->len = (min_t (u64,extent_map_end (em), inode->i_size) - + iocb->ki_pos);
no outer ( )
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10959
Quoted 5 lines
fs/btrfs/inode.c +5
-0+if (em->block_start ==EXTENT_MAP_HOLE || +test_bit (EXTENT_FLAG_PREALLOC , &em->flags)) { + disk_bytenr =EXTENT_MAP_HOLE ; + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);
No chained initializations
Quoted 207 lines
fs/btrfs/inode.c +64
-0+ }else if (test_bit (EXTENT_FLAG_COMPRESSED , &em->flags)) { + disk_bytenr = em->block_start; +/* +* Bail if the buffer isn't large enough to return the whole +* compressed extent. +*/ +if (em->block_len > count) { + ret = -ENOBUFS ; + goto out_em; + } + disk_io_size = count = em->block_len; + encoded->unencoded_len = em->ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - em->orig_start; + ret =btrfs_encoded_io_compression_from_extent ( + em->compress_type); +if (ret <0 ) + goto out_em; + encoded->compression = ret; + }else { + disk_bytenr = em->block_start + (start - em->start); +if (encoded->len > count) + encoded->len = count; +/* +* Don't read beyond what we locked. This also limits the page +* allocations that we'll do. +*/ + disk_io_size =min (lockend +1 , + iocb->ki_pos + encoded->len) - start; + encoded->len = encoded->unencoded_len = count = + start + disk_io_size - iocb->ki_pos; + disk_io_size =ALIGN (disk_io_size, fs_info->sectorsize); + } +free_extent_map (em); + em =NULL ; + +if (disk_bytenr ==EXTENT_MAP_HOLE ) { +unlock_extent_cached (io_tree, start, lockend, &cached_state); +inode_unlock_shared (inode); + unlocked = true; + ret =iov_iter_zero (count, iter); +if (ret != count) + ret = -EFAULT ; + }else { + ret =btrfs_encoded_read_regular (iocb, iter, start, lockend, + &cached_state, disk_bytenr, + disk_io_size, count, + encoded->compression, + &unlocked); + } + +out: +if (ret >=0 ) + iocb->ki_pos += encoded->len; +out_em: +free_extent_map (em); +out_unlock_extent: +if (!unlocked) +unlock_extent_cached (io_tree, start, lockend, &cached_state); +out_unlock_inode: +if (!unlocked) +inode_unlock_shared (inode); +return ret; +} +#ifdef CONFIG_SWAP /* * Add an entry indicating a block group or device which is pinned by a fs/btrfs/ioctl.c +106
-0@@ -28,6 +28,7 @@#include <linux/iversion.h> #include <linux/fileattr.h> #include <linux/fsverity.h> +#include <linux/sched/xacct.h> #include "ctree.h" #include "disk-io.h" #include "export.h" @@ -88,6 +89,22 @@ struct btrfs_ioctl_send_args_32 {#define BTRFS_IOC_SEND_32 _IOW(BTRFS_IOCTL_MAGIC, 38, \ struct btrfs_ioctl_send_args_32) + +struct btrfs_ioctl_encoded_io_args_32 { +compat_uptr_t iov; +compat_ulong_t iovcnt; +__s64 offset; +__u64 flags; +__u64 len; +__u64 unencoded_len; +__u64 unencoded_offset; +__u32 compression; +__u32 encryption; +__u32 reserved[8 ]; +}; + +#define BTRFS_IOC_ENCODED_READ_32 _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args_32)#endif /* Mask out flags that are inappropriate for the given type of inode. */ @@ -4861,6 +4878,89 @@ static int _btrfs_ioctl_send(struct file *file, void __user *argp, bool compat)return ret; } +static int btrfs_ioctl_encoded_read (struct file *file,void __user *argp, +bool compat) +{ +struct btrfs_ioctl_encoded_io_args args = {}; + size_t copy_end_kernel = offsetofend(struct btrfs_ioctl_encoded_io_args, + flags); +size_t copy_end; +struct iovec iovstack[UIO_FASTIOV ]; +struct iovec *iov = iovstack; +struct iov_iter iter; +loff_t pos; +struct kiocb kiocb; +ssize_t ret; + +if (!capable (CAP_SYS_ADMIN )) { + ret = -EPERM ; + goto out_acct; + } + +if (compat) { +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +struct btrfs_ioctl_encoded_io_args_32 args32; + + copy_end = offsetofend(struct btrfs_ioctl_encoded_io_args_32, + flags); +if (copy_from_user (&args32, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + args.iov =compat_ptr (args32.iov); + args.iovcnt = args32.iovcnt; + args.offset = args32.offset; + args.flags = args32.flags; +#else +return -ENOTTY ; +#endif + }else { + copy_end = copy_end_kernel; +if (copy_from_user (&args, argp, copy_end)) { + ret = -EFAULT ; + goto out_acct; + } + } +if (args.flags !=0 ) { + ret = -EINVAL ; + goto out_acct; + } + + ret =import_iovec (READ , args.iov, args.iovcnt,ARRAY_SIZE (iovstack), + &iov, &iter); +if (ret <0 ) + goto out_acct; + +if (iov_iter_count (&iter) ==0 ) { + ret =0 ; + goto out_iov; + } + pos = args.offset; + ret =rw_verify_area (READ , file, &pos, args.len); +if (ret <0 ) + goto out_iov; + +init_sync_kiocb (&kiocb, file); + kiocb.ki_pos = pos; + + ret =btrfs_encoded_read (&kiocb, &iter, &args); +if (ret >=0 ) { +fsnotify_access (file); +if (copy_to_user (argp + copy_end, + (char *)&args + copy_end_kernel, +sizeof (args) - copy_end_kernel)) + ret = -EFAULT ; + } + +out_iov: +kfree (iov); +out_acct: +if (ret >0 ) +add_rchar (current, ret); +inc_syscr (current); +return ret; +} +long btrfs_ioctl (struct file *file,unsigned int cmd,unsigned long arg) {@@ -5005,6 +5105,12 @@ long btrfs_ioctl(struct file *file, unsigned intreturn fsverity_ioctl_enable (file, (const void __user *)argp);case FS_IOC_MEASURE_VERITY :return fsverity_ioctl_measure (file, argp); +case BTRFS_IOC_ENCODED_READ : +return btrfs_ioctl_encoded_read (file, argp, false); +#if defined(CONFIG_64BIT ) && defined(CONFIG_COMPAT ) +case BTRFS_IOC_ENCODED_READ_32 : +return btrfs_ioctl_encoded_read (file, argp, true); +#endif }return -ENOTTY ;Signature · 1 line
2.34.0
Re: [PATCH v12 12/17] btrfs: send: fix maximum command numbering
In reply to Omar SandovalQuoted 84 lines · Omar Sandoval
Quoted 23 lines · David Sterba
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Commit
e77fbf990316("btrfs: send: prepare for v2 protocol") added _BTRFS_SEND_C_MAX_V* macros equal to the maximum command number for the version plus 1, but as written this creates gaps in the number space. The maximum command number is currently 22, and__BTRFS_SEND_C_MAX_V1is accordingly 23. But then__BTRFS_SEND_C_MAX_V2is 24, suggesting that v2 has a command numbered 23, and__BTRFS_SEND_C_MAXis 25, suggesting that 23 and 24 are valid commands.The MAX definitions have the __ prefix so they're private and not meant to be used as proper commands, so nothing should suggest there are any commands with numbers 23 to 25 in the example.
Quoted 4 lines
Instead, let's explicitly set BTRFS_SEND_C_MAX_V* to the maximum command number. This requires repeating the command name, but it has a clearer meaning and avoids gaps. It also doesn't require updating
__BTRFS_SEND_C_MAXfor every new version.It's probably a matter of taste, I'd intentionally avoid the pattern above, ie. repeating the previous command to define max.
Quoted 12 lines
fs/btrfs/send.c __maybe_unused · line 320
Quoted 10 lines
fs/btrfs/send.c +2
-2@@ -316,8 +316,8 @@ __maybe_unusedstatic bool proto_cmd_ok (const struct send_ctx *sctx,int cmd) {switch (sctx->proto) { -case 1 :return cmd < __BTRFS_SEND_C_MAX_V1; -case 2 :return cmd < __BTRFS_SEND_C_MAX_V2; +case 1 :return cmd <=BTRFS_SEND_C_MAX_V1 ; +case 2 :return cmd <=BTRFS_SEND_C_MAX_V2 ;This seems to be the only practical difference, < or <= .
There is another practical difference, which is more significant in my
opinion: the linear style creates "gaps" in the valid commands. Consider this, with explicit values added for clarity:enum btrfs_send_cmd { BTRFS_SEND_C_UNSPEC = 0, /* Version 1 */ BTRFS_SEND_C_SUBVOL = 1, BTRFS_SEND_C_SNAPSHOT = 2, BTRFS_SEND_C_MKFILE = 3, BTRFS_SEND_C_MKDIR = 4, BTRFS_SEND_C_MKNOD = 5, BTRFS_SEND_C_MKFIFO = 6, BTRFS_SEND_C_MKSOCK = 7, BTRFS_SEND_C_SYMLINK = 8, BTRFS_SEND_C_RENAME = 9, BTRFS_SEND_C_LINK = 10, BTRFS_SEND_C_UNLINK = 11, BTRFS_SEND_C_RMDIR = 12, BTRFS_SEND_C_SET_XATTR = 13, BTRFS_SEND_C_REMOVE_XATTR = 14, BTRFS_SEND_C_WRITE = 15, BTRFS_SEND_C_CLONE = 16, BTRFS_SEND_C_TRUNCATE = 17, BTRFS_SEND_C_CHMOD = 18, BTRFS_SEND_C_CHOWN = 19, BTRFS_SEND_C_UTIMES = 20, BTRFS_SEND_C_END = 21, BTRFS_SEND_C_UPDATE_EXTENT = 22, __BTRFS_SEND_C_MAX_V1 = 23, /* Version 2 */ BTRFS_SEND_C_FALLOCATE = 24, BTRFS_SEND_C_SETFLAGS = 25, BTRFS_SEND_C_ENCODED_WRITE = 26, __BTRFS_SEND_C_MAX_V2 = 27, /* End */ __BTRFS_SEND_C_MAX = 28, };
Quoted 1 line
#define
BTRFS_SEND_C_MAX(__BTRFS_SEND_C_MAX- 1) /* 27 */
So as a compromise to avoid gaps and also repeating the last command name in the definition, let's do it in a similar way as in your example, explicit numbering of the commands, so the number will be repated for the MAX constants.
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to David SterbaQuoted 7 lines · David Sterba
Quoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.
Is there a reproducer, and a fix?
Reproducer:
# Create a filesystem with data duplicated at 2 physical locations on the same
# disk.
$ mkfs.btrfs -f -d dup /dev/vdb
# Mount it with compression enabled.
$ mount -o compress /dev/vdb /mnt
# Write some compressible data (octal dump of random data).
$ dd if=/dev/urandom bs=4k count=1 | od > /mnt/foo
# Force it on disk.
$ sync
# Get the locations it was written to on disk.
$ ~/repos/osandov-linux/scripts/btrfs_map_physical /mnt/foo | column -ts $'\t'
FILE OFFSET FILE SIZE EXTENT OFFSET EXTENT TYPE LOGICAL SIZE LOGICAL OFFSET PHYSICAL SIZE DEVID PHYSICAL OFFSET
0 20480 0 regular,compression=zlib,dup 20480 298844160 8192 1 575668224
1 1005125632
# Corrupt one of the copies.
$ dd if=/dev/zero of=/dev/vdb bs=4k count=1 seek=575668224 oflag=seek_bytes
$ sync
# Now, re-read the file until we read it from the corrupted copy. To make sure
# we read from disk, we drop the page cache between each read.
$ while ! btrfs device stats /dev/vdb | grep -q 'corruption_errs\s\+[1-9]'; do echo 1 > /proc/sys/vm/drop_caches; cat /mnt/foo > /dev/null; done
$ dmesg | tail
[ 3240.222922] BTRFS info (device vdb): has skinny extents
[ 3240.235245] BTRFS info (device vdb): checking UUID tree
[ 3298.885372] bash (481): drop_caches: 1
[ 3298.924648] BTRFS warning (device vdb): csum failed root 5 ino 257 off 575676416 csum 0x8941f998 expected csum 0x05a3d0cd mirror 1
[ 3298.924657] BTRFS error (device vdb): bdev /dev/vdb errs: wr 0, rd 0, flush 0, corrupt 1, gen 0
[ 3298.926221] BTRFS info (device vdb): read error corrected: ino 257 off 0 (dev /dev/vdb sector 1124352)
[ 3298.926473] BTRFS info (device vdb): read error corrected: ino 257 off 4096 (dev /dev/vdb sector 1124352)
[ 3298.926516] BTRFS info (device vdb): read error corrected: ino 257 off 16384 (dev /dev/vdb sector 1124352)
[ 3298.926555] BTRFS info (device vdb): read error corrected: ino 257 off 8192 (dev /dev/vdb sector 1124352)
[ 3298.926614] BTRFS info (device vdb): read error corrected: ino 257 off 12288 (dev /dev/vdb sector 1124352)
# Now check that the copies match.
$ dd if=/dev/vdb bs=4k count=1 skip=575668224 iflag=skip_bytes status=none | sha256sum
6ffd32b49d77b9e4ae07fd1c598b8407bc4cbb2fdb7244420589703f35605996 -
$ dd if=/dev/vdb bs=4k count=1 skip=1005125632 iflag=skip_bytes status=none | sha256sum
3646164006a08d908f5cbd6131ce413c8de49566560bf7ac6bc9432ac792605d -
# Oops, they don't. Check the corrupted copy.
$ dd if=/dev/vdb bs=4k count=1 skip=575668224 iflag=skip_bytes status=none | head
0006000 006760 154362 010427 177511 151544 074422 116513 105472
0006020 045224 041623 063647 150022 006147 155332 053640 077304
0006040 173561 102237 155233 021641 165413 114564 004351 006141
0006060 075766 007723 017005 142265 175347 110221 071117 004421
0006100 045713 040102 005447 127414 173546 075206 042537 176547
0006120 120721 117062 177257 171012 130114 031767 165144 103776
0006140 054556 152447 123212 023000 062570 103502 057476 065541
0006160 064364 151221 117125 133463 076760 133756 133026 171622
0006200 164705 031677 005544 027201 130024 177437 102433 005170
0006220 144353 136645 147416 035017 173440 121605 050052 050325
# It contains decompressed data, and not even for the correct offset: this is
# the 4th block of the file.I don't have a fix. Rohit Singh from my team is ramping up and working on a fix.
This bug has been present as far back as I could follow the history. I think it's just been masked by the fact that 1) repairing the bad copies with bad data doesn't make things "worse" and 2) the page cache caches the good data, so once you've repaired it once, you don't see it again until you reboot or the page is evicted.
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to David SterbaQuoted 457 lines · David Sterba
Quoted 73 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 496 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 106 ++++++++++ 3 files changed, 606 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +22
-0@@ -10525,6 +10525,502 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } +static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum +* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} +fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10559
Quoted 10 lines
fs/btrfs/inode.c +10
-0+static ssize_t btrfs_encoded_read_inline ( +struct kiocb *iocb, +struct iov_iter *iter,u64 start, +u64 lockend, +struct extent_state **cached_state, +u64 extent_start,size_t count, +struct btrfs_ioctl_encoded_io_args *encoded, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp);Please use
btrfs_inodein all internal helpers, either as parameters or as local variable, to avoid theBTRFS_Iandbtrfs_sbconversions everywhere.Quoted 23 lines
fs/btrfs/inode.c +23
-0+struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct btrfs_path *path; +struct extent_buffer *leaf; +struct btrfs_file_extent_item *item; +u64 ram_bytes; +unsigned long ptr; +void *tmp; +ssize_t ret; + + path =btrfs_alloc_path (); +if (!path) { + ret = -ENOMEM ; + goto out; + } + ret =btrfs_lookup_file_extent (NULL ,BTRFS_I (inode)->root, path, +btrfs_ino (BTRFS_I (inode)), extent_start, +0 ); +if (ret) { +if (ret >0 ) { +/* The extent item disappeared? */ + ret = -EIO ; + } + goto out;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10592
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ } + leaf = path->nodes[0 ]; + item =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + + ram_bytes =btrfs_file_extent_ram_bytes (leaf, item); + ptr =btrfs_file_extent_inline_start (item); + + encoded->len = (min_t (u64, extent_start + ram_bytes, inode->i_size) - + iocb->ki_pos);No need for the outer ( )
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, item)); +if (ret <0 ) + goto out; + encoded->compression = ret; +if (encoded->compression) { +size_t inline_size; + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);I'm sure I have commented on that in the past, please don't use chained intializations. In this case something like:
count = min_t(u64, count, encoded->len); encoded->len = count; encoded->unencoded_len = count;Quoted 15 lines
fs/btrfs/inode.c +15
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10637
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode;This should also be
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10645
Quoted 8 lines
fs/btrfs/inode.c +8
-0+u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio(struct inode *inode,struct
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10647
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ struct bio *bio, int mirror_num, + unsigned long bio_flags)
bio_flagsis unused here (and in the encoded patches afaics)Quoted 20 lines
fs/btrfs/inode.c +20
-0+{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10677
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ;const bool uptodate = (bbio->bio.bi_status == BLK_STS_OK);Quoted 148 lines
fs/btrfs/inode.c +148
-0+struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10835
Quoted 10 lines
fs/btrfs/inode.c +10
-0+u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE ); + pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM);No HIGHMEM please.
Quoted 52 lines
fs/btrfs/inode.c +52
-0+if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10897
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode);We have helpers for inode locking now,
btrfs_inode_lock, that take additional parameter for cases where we want to exclude certain locking combinations.
Quoted 3 lines
Which also brings the question if the encoded read/write should be excluded against some other operations like eg. deduplication has to do against mmap.
I _think_ we want to exclude mmap, but I need to think some more about it. Other than this comment, I believe I've addressed your other outstanding comments and rebased my branches:
https://github.com/osandov/linux/tree/btrfs-send-encoded
https://github.com/osandov/btrfs-progs/tree/send-encoded
I'm guessing you're still looking at the send parts, so I'll figure out mmap and await further comments before resending.
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
Quoted 466 lines · Omar Sandoval
Quoted 457 lines · David Sterba
Quoted 73 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 496 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 106 ++++++++++ 3 files changed, 606 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +22
-0@@ -10525,6 +10525,502 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } +static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum +* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} +fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10559
Quoted 10 lines
fs/btrfs/inode.c +10
-0+static ssize_t btrfs_encoded_read_inline ( +struct kiocb *iocb, +struct iov_iter *iter,u64 start, +u64 lockend, +struct extent_state **cached_state, +u64 extent_start,size_t count, +struct btrfs_ioctl_encoded_io_args *encoded, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp);Please use
btrfs_inodein all internal helpers, either as parameters or as local variable, to avoid theBTRFS_Iandbtrfs_sbconversions everywhere.Quoted 23 lines
fs/btrfs/inode.c +23
-0+struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct btrfs_path *path; +struct extent_buffer *leaf; +struct btrfs_file_extent_item *item; +u64 ram_bytes; +unsigned long ptr; +void *tmp; +ssize_t ret; + + path =btrfs_alloc_path (); +if (!path) { + ret = -ENOMEM ; + goto out; + } + ret =btrfs_lookup_file_extent (NULL ,BTRFS_I (inode)->root, path, +btrfs_ino (BTRFS_I (inode)), extent_start, +0 ); +if (ret) { +if (ret >0 ) { +/* The extent item disappeared? */ + ret = -EIO ; + } + goto out;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10592
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ } + leaf = path->nodes[0 ]; + item =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + + ram_bytes =btrfs_file_extent_ram_bytes (leaf, item); + ptr =btrfs_file_extent_inline_start (item); + + encoded->len = (min_t (u64, extent_start + ram_bytes, inode->i_size) - + iocb->ki_pos);No need for the outer ( )
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, item)); +if (ret <0 ) + goto out; + encoded->compression = ret; +if (encoded->compression) { +size_t inline_size; + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);I'm sure I have commented on that in the past, please don't use chained intializations. In this case something like:
count = min_t(u64, count, encoded->len); encoded->len = count; encoded->unencoded_len = count;Quoted 15 lines
fs/btrfs/inode.c +15
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10637
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode;This should also be
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10645
Quoted 8 lines
fs/btrfs/inode.c +8
-0+u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio(struct inode *inode,struct
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10647
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ struct bio *bio, int mirror_num, + unsigned long bio_flags)
bio_flagsis unused here (and in the encoded patches afaics)Quoted 20 lines
fs/btrfs/inode.c +20
-0+{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10677
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ;const bool uptodate = (bbio->bio.bi_status == BLK_STS_OK);Quoted 148 lines
fs/btrfs/inode.c +148
-0+struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10835
Quoted 10 lines
fs/btrfs/inode.c +10
-0+u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE ); + pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM);No HIGHMEM please.
Quoted 52 lines
fs/btrfs/inode.c +52
-0+if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10897
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode);We have helpers for inode locking now,
btrfs_inode_lock, that take additional parameter for cases where we want to exclude certain locking combinations.Quoted 3 lines
Which also brings the question if the encoded read/write should be excluded against some other operations like eg. deduplication has to do against mmap.
I _think_ we want to exclude mmap, but I need to think some more about it. Other than this comment, I believe I've addressed your other outstanding comments and rebased my branches:
Quoted 5 lines
https://github.com/osandov/linux/tree/btrfs-send-encoded
https://github.com/osandov/btrfs-progs/tree/send-encodedI'm guessing you're still looking at the send parts, so I'll figure out mmap and await further comments before resending.
After looking at the code some more, I don't think we need to exclude mmap after all.
The only thing that can happen is that with this interleaving:
btrfs_page_mkwrite btrfs_encoded_read
---------------------------------------------------
(enter) (enter)
btrfs_wait_ordered_rangelock_extent_bitsbtrfs_page_set_dirtyunlock_extent_cached
(exit)
lock_extent_bits
read extent
unlock_extent_cached
(exit)we read the old data from before the page was dirtied. But there are other interleavings of a concurrent btrfs_page_mkwrite and btrfs_encoded_read that would read the old data, like:
btrfs_page_mkwrite btrfs_encoded_read
---------------------------------------------------
(enter) (enter)
btrfs_wait_ordered_range lock_extent_bitslock_extent_bits blocked
read extent
unlock_extent_cached
(exit)lock_extent_bits returnsbtrfs_page_set_dirtyunlock_extent_cached
(exit)
Or even if we were to use BTRFS_ILOCK_MMAP:
btrfs_page_mkwrite btrfs_encoded_read
-------------------------------------------------------------------
(enter) (enter)
btrfs_inode_lock(BTRFS_ILOCK_MMAP)down_read(i_mmap_lock) (blocked)
btrfs_wait_ordered_range lock_extent_bits
read extent unlock_extent_cached btrfs_inode_unlock(BTRFS_ILOCK_MMAP)down_read(i_mmap_lock) returnslock_extent_bitsbtrfs_page_set_dirtyunlock_extent_cached
In other words, this is inherently racy, so it's fine that we return the old data in this tiny window.
I pushed the change to use btrfs_inode_lock()/btrfs_inode_unlock() with BTRFS_ILOCK_SHARED to my branch. I'll resend the series as well.
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
Quoted 526 lines · Omar Sandoval
Quoted 466 lines · Omar Sandoval
Quoted 457 lines · David Sterba
Quoted 73 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 496 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 106 ++++++++++ 3 files changed, 606 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3275,6 +3275,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +22
-0@@ -10525,6 +10525,502 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } +static int btrfs_encoded_io_compression_from_extent (int compress_type) +{ +switch (compress_type) { +case BTRFS_COMPRESS_NONE : +return BTRFS_ENCODED_IO_COMPRESSION_NONE ; +case BTRFS_COMPRESS_ZLIB : +return BTRFS_ENCODED_IO_COMPRESSION_ZLIB ; +case BTRFS_COMPRESS_LZO : +/* +* The LZO format depends on the page size. 64k is the maximum +* sectorsize (and thus page size) that we support. +*/ +if (PAGE_SIZE <SZ_4K ||PAGE_SIZE >SZ_64K ) +return -EINVAL ; +return BTRFS_ENCODED_IO_COMPRESSION_LZO_4K + (PAGE_SHIFT -12 ); +case BTRFS_COMPRESS_ZSTD : +return BTRFS_ENCODED_IO_COMPRESSION_ZSTD ; +default : +return -EUCLEAN ; + } +} +fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10559
Quoted 10 lines
fs/btrfs/inode.c +10
-0+static ssize_t btrfs_encoded_read_inline ( +struct kiocb *iocb, +struct iov_iter *iter,u64 start, +u64 lockend, +struct extent_state **cached_state, +u64 extent_start,size_t count, +struct btrfs_ioctl_encoded_io_args *encoded, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp);Please use
btrfs_inodein all internal helpers, either as parameters or as local variable, to avoid theBTRFS_Iandbtrfs_sbconversions everywhere.Quoted 23 lines
fs/btrfs/inode.c +23
-0+struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct btrfs_path *path; +struct extent_buffer *leaf; +struct btrfs_file_extent_item *item; +u64 ram_bytes; +unsigned long ptr; +void *tmp; +ssize_t ret; + + path =btrfs_alloc_path (); +if (!path) { + ret = -ENOMEM ; + goto out; + } + ret =btrfs_lookup_file_extent (NULL ,BTRFS_I (inode)->root, path, +btrfs_ino (BTRFS_I (inode)), extent_start, +0 ); +if (ret) { +if (ret >0 ) { +/* The extent item disappeared? */ + ret = -EIO ; + } + goto out;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10592
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ } + leaf = path->nodes[0 ]; + item =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + + ram_bytes =btrfs_file_extent_ram_bytes (leaf, item); + ptr =btrfs_file_extent_inline_start (item); + + encoded->len = (min_t (u64, extent_start + ram_bytes, inode->i_size) - + iocb->ki_pos);No need for the outer ( )
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, item)); +if (ret <0 ) + goto out; + encoded->compression = ret; +if (encoded->compression) { +size_t inline_size; + + inline_size =btrfs_file_extent_inline_item_len (leaf, + path->slots[0 ]);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10612
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (inline_size > count) { + ret = -ENOBUFS ; + goto out; + } + count = inline_size; + encoded->unencoded_len = ram_bytes; + encoded->unencoded_offset = iocb->ki_pos - extent_start; + }else { + encoded->len = encoded->unencoded_len = count = +min_t (u64, count, encoded->len);I'm sure I have commented on that in the past, please don't use chained intializations. In this case something like:
count = min_t(u64, count, encoded->len); encoded->len = count; encoded->unencoded_len = count;Quoted 15 lines
fs/btrfs/inode.c +15
-0+ ptr += iocb->ki_pos - extent_start; + } + + tmp =kmalloc (count,GFP_NOFS ); +if (!tmp) { + ret = -ENOMEM ; + goto out; + } +read_extent_buffer (leaf, tmp, ptr, count); +btrfs_release_path (path); +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + + ret =copy_to_iter (tmp, count, iter);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10637
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret != count) + ret = -EFAULT ; +kfree (tmp); +out: +btrfs_free_path (path); +return ret; +} + +struct btrfs_encoded_read_private { +struct inode *inode;This should also be
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10645
Quoted 8 lines
fs/btrfs/inode.c +8
-0+u64 file_offset; +wait_queue_head_t wait; +atomic_t pending; +blk_status_t status; +bool skip_csum; +}; + +static blk_status_t submit_encoded_read_bio(struct inode *inode,struct
btrfs_inodefs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10647
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ struct bio *bio, int mirror_num, + unsigned long bio_flags)
bio_flagsis unused here (and in the encoded patches afaics)Quoted 20 lines
fs/btrfs/inode.c +20
-0+{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +blk_status_t ret; + +if (!priv->skip_csum) { + ret =btrfs_lookup_bio_sums (inode, bio,NULL ); +if (ret) +return ret; + } + + ret =btrfs_bio_wq_end_io (fs_info, bio,BTRFS_WQ_ENDIO_DATA ); +if (ret) { +btrfs_bio_free_csum (bbio); +return ret; + } + +atomic_inc (&priv->pending); + ret =btrfs_map_bio (fs_info, bio, mirror_num);fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10677
Quoted 10 lines
fs/btrfs/inode.c +10
-0+if (ret) { +atomic_dec (&priv->pending); +btrfs_bio_free_csum (bbio); + } +return ret; +} + +static blk_status_t btrfs_encoded_read_verify_csum (struct btrfs_bio *bbio) +{ +const bool uptodate = bbio->bio.bi_status ==BLK_STS_OK ;const bool uptodate = (bbio->bio.bi_status == BLK_STS_OK);Quoted 148 lines
fs/btrfs/inode.c +148
-0+struct btrfs_encoded_read_private *priv = bbio->bio.bi_private; +struct inode *inode = priv->inode; +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +u32 sectorsize = fs_info->sectorsize; +struct bio_vec *bvec; +struct bvec_iter_all iter_all; +u64 start = priv->file_offset; +u32 bio_offset =0 ; + +if (priv->skip_csum || !uptodate) +return bbio->bio.bi_status; + +bio_for_each_segment_all (bvec, &bbio->bio, iter_all) { +unsigned int i, nr_sectors, pgoff; + + nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, bvec->bv_len); + pgoff = bvec->bv_offset; +for (i =0 ; i < nr_sectors; i++) { +ASSERT (pgoff <PAGE_SIZE ); +if (check_data_csum (inode, bbio, bio_offset, + bvec->bv_page, pgoff, start)) +return BLK_STS_IOERR ; + start += sectorsize; + bio_offset += sectorsize; + pgoff += sectorsize; + } + } +return BLK_STS_OK ; +} + +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_bio *bbio =btrfs_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_verify_csum (bbio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in +* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_bio_free_csum (bbio); +bio_put (bio); +} + +static int btrfs_encoded_read_regular_fill_pages (struct inode *inode, +u64 file_offset, +u64 disk_bytenr, +u64 disk_io_size, +struct page **pages) +{ +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct btrfs_encoded_read_private priv = { + .inode = inode, + .file_offset = file_offset, + .pending =ATOMIC_INIT (1 ), + .skip_csum =BTRFS_I (inode)->flags &BTRFS_INODE_NODATASUM , + }; +unsigned long i =0 ; +u64 cur =0 ; +int ret; + +init_waitqueue_head (&priv.wait); +/* +* Submit bios for the extent, splitting due to bio or stripe limits as +* necessary. +*/ +while (cur < disk_io_size) { +struct extent_map *em; +struct btrfs_io_geometry geom; +struct bio *bio =NULL ; +u64 remaining; + + em =btrfs_get_chunk_map (fs_info, disk_bytenr + cur, + disk_io_size - cur); +if (IS_ERR (em)) { + ret =PTR_ERR (em); + }else { + ret =btrfs_get_io_geometry (fs_info, em,BTRFS_MAP_READ , + disk_bytenr + cur, &geom); +free_extent_map (em); + } +if (ret) { +WRITE_ONCE (priv.status,errno_to_blk_status (ret)); +break ; + } + remaining =min (geom.len, disk_io_size - cur); +while (bio || remaining) { +size_t bytes =min_t (u64, remaining,PAGE_SIZE ); + +if (!bio) { + bio =btrfs_bio_alloc (BIO_MAX_VECS ); + bio->bi_iter.bi_sector = + (disk_bytenr + cur) >>SECTOR_SHIFT ; + bio->bi_end_io = btrfs_encoded_read_endio; + bio->bi_private = &priv; + bio->bi_opf =REQ_OP_READ ; + } + +if (!bytes || +bio_add_page (bio, pages[i], bytes,0 ) < bytes) { +blk_status_t status; + + status =submit_encoded_read_bio (inode, bio,0 , +0 ); +if (status) { +WRITE_ONCE (priv.status, status); +bio_put (bio); + goto out; + } + bio =NULL ; +continue ; + } + + i++; + cur += bytes; + remaining -= bytes; + } + } + +out: +if (atomic_dec_return (&priv.pending)) +io_wait_event (priv.wait, !atomic_read (&priv.pending)); +/* See btrfs_encoded_read_endio() for ordering. */ +return blk_status_to_errno (READ_ONCE (priv.status)); +} + +static ssize_t btrfs_encoded_read_regular (struct kiocb *iocb, +struct iov_iter *iter, +u64 start,u64 lockend, +struct extent_state **cached_state, +u64 disk_bytenr,u64 disk_io_size, +size_t count,bool compressed, +bool *unlocked) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree; +struct page **pages; +unsigned long nr_pages, i;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10835
Quoted 10 lines
fs/btrfs/inode.c +10
-0+u64 cur; +size_t page_offset; +ssize_t ret; + + nr_pages =DIV_ROUND_UP (disk_io_size,PAGE_SIZE ); + pages =kcalloc (nr_pages,sizeof (struct page *),GFP_NOFS ); +if (!pages) +return -ENOMEM ; +for (i =0 ; i < nr_pages; i++) { + pages[i] =alloc_page (GFP_NOFS | __GFP_HIGHMEM);No HIGHMEM please.
Quoted 52 lines
fs/btrfs/inode.c +52
-0+if (!pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + + ret =btrfs_encoded_read_regular_fill_pages (inode, start, disk_bytenr, + disk_io_size, pages); +if (ret) + goto out; + +unlock_extent_cached (io_tree, start, lockend, cached_state); +inode_unlock_shared (inode); + *unlocked = true; + +if (compressed) { + i =0 ; + page_offset =0 ; + }else { + i = (iocb->ki_pos - start) >>PAGE_SHIFT ; + page_offset = (iocb->ki_pos - start) & (PAGE_SIZE -1 ); + } + cur =0 ; +while (cur < count) { +size_t bytes =min_t (size_t, count - cur, +PAGE_SIZE - page_offset); + +if (copy_page_to_iter (pages[i], page_offset, bytes, + iter) != bytes) { + ret = -EFAULT ; + goto out; + } + i++; + cur += bytes; + page_offset =0 ; + } + ret = count; +out: +for (i =0 ; i < nr_pages; i++) { +if (pages[i]) +__free_page (pages[i]); + } +kfree (pages); +return ret; +} + +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded) +{ +struct inode *inode =file_inode (iocb->ki_filp); +struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb); +struct extent_io_tree *io_tree = &BTRFS_I (inode)->io_tree;fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10897
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ssize_t ret; +size_t count =iov_iter_count (iter); +u64 start, lockend, disk_bytenr, disk_io_size; +struct extent_state *cached_state =NULL ; +struct extent_map *em; +bool unlocked = false; + +file_accessed (iocb->ki_filp); + +inode_lock_shared (inode);We have helpers for inode locking now,
btrfs_inode_lock, that take additional parameter for cases where we want to exclude certain locking combinations.Quoted 3 lines
Which also brings the question if the encoded read/write should be excluded against some other operations like eg. deduplication has to do against mmap.
I _think_ we want to exclude mmap, but I need to think some more about it. Other than this comment, I believe I've addressed your other outstanding comments and rebased my branches:
Quoted 5 lines
https://github.com/osandov/linux/tree/btrfs-send-encoded
https://github.com/osandov/btrfs-progs/tree/send-encodedI'm guessing you're still looking at the send parts, so I'll figure out mmap and await further comments before resending.
After looking at the code some more, I don't think we need to exclude mmap after all.
The only thing that can happen is that with this interleaving:
btrfs_page_mkwritebtrfs_encoded_read
---------------------------------------------------
(enter) (enter)
btrfs_wait_ordered_rangelock_extent_bitsbtrfs_page_set_dirtyunlock_extent_cached
(exit)lock_extent_bits read extent unlock_extent_cached (exit)we read the old data from before the page was dirtied. But there are other interleavings of a concurrent
btrfs_page_mkwriteandbtrfs_encoded_readthat would read the old data, like:
btrfs_page_mkwritebtrfs_encoded_read
---------------------------------------------------
(enter) (enter)
btrfs_wait_ordered_rangelock_extent_bitslock_extent_bitsblockedread extent unlock_extent_cached (exit)
lock_extent_bitsreturnsbtrfs_page_set_dirtyunlock_extent_cached
(exit)Or even if we were to use
BTRFS_ILOCK_MMAP:
btrfs_page_mkwritebtrfs_encoded_read
-------------------------------------------------------------------
(enter) (enter)
btrfs_inode_lock(BTRFS_ILOCK_MMAP)down_read(i_mmap_lock)(blocked)
btrfs_wait_ordered_rangelock_extent_bits
read extentunlock_extent_cachedbtrfs_inode_unlock(BTRFS_ILOCK_MMAP)down_read(i_mmap_lock)returnslock_extent_bitsbtrfs_page_set_dirtyunlock_extent_cached
Quoted 2 lines
In other words, this is inherently racy, so it's fine that we return the old data in this tiny window.
Thanks for the analysis, please put it to the changelog, I think it will be handy one day.
Re: [PATCH v12 09/17] btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar SandovalQuoted 17 lines · Omar Sandoval
Quoted 11 lines · David Sterba
Review
Quoted 2 lines · Omar Sandoval
(quoted diff) +2
-0+ + inode_lock_shared(inode);We have helpers for inode locking now,
btrfs_inode_lock, that take additional parameter for cases where we want to exclude certain locking combinations.Which also brings the question if the encoded read/write should be excluded against some other operations like eg. deduplication has to do against mmap.
I _think_ we want to exclude mmap, but I need to think some more about it. Other than this comment, I believe I've addressed your other outstanding comments and rebased my branches:
Quoted 5 lines
https://github.com/osandov/linux/tree/btrfs-send-encoded
https://github.com/osandov/btrfs-progs/tree/send-encodedI'm guessing you're still looking at the send parts, so I'll figure out mmap and await further comments before resending.
First I want to get the encoded ioctl, so please send v13.