Add THERMAL control driver for Sunplus SP7021 SoC

PATCH Superseded Li-hao Kuo 2 participants 5 messages Dec 23, 2021 – Dec 29, 2021

Subsystems (2)

Device tree bindings Thermal

lore

Share & tools

lore

Li-hao Kuo

author

2021-12-23 05:06 UTC #0 lore raw

v2 cover Add THERMAL control driver for Sunplus SP7021 SoC

This is a patch series for SPI driver for Sunplus SP7021 SoC.

Sunplus SP7021 is an ARM Cortex A7 (4 cores) based SoC. It integrates many peripherals (ex: UART, I2C, SPI, SDIO, eMMC, USB, SD card and etc.) into a single chip. It is designed for industrial control.

Refer to:
https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
https://tibbo.com/store/plus1.html

Li-hao Kuo (2):
THERMAL: Add THERMAL driver for Sunplus SP7021
devicetree: bindings THERMAL Add bindings doc for Sunplus SP7021

 .../bindings/thermal/sunplus_thermal.yaml          |  49 +++++++
 MAINTAINERS                                        |   7 +
 drivers/thermal/Kconfig                            |  10 ++
 drivers/thermal/Makefile                           |   1 +
 drivers/thermal/sunplus_thermal.c                  | 161 +++++++++++++++++++++
 5 files changed, 228 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
 create mode 100644 drivers/thermal/sunplus_thermal.c

Signature · 1 line

2.7.4

Li-hao Kuo

author

2021-12-23 05:06 UTC #1 lore raw

PATCH v2 1/2 THERMAL: Add THERMAL driver for Sunplus SP7021

Add THERMAL driver for Sunplus SP7021.

Signed-off-by Li-hao Kuo <[email protected]>

---
Changes in v2:
- Addressed all comments from Mr. Rob Herring
- Modify Theraml driver

 MAINTAINERS                       |   6 ++
 drivers/thermal/Kconfig           |  10 +++
 drivers/thermal/Makefile          |   1 +
 drivers/thermal/sunplus_thermal.c | 161 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 178 insertions(+)
 create mode 100644 drivers/thermal/sunplus_thermal.c

MAINTAINERS +6 -0

index 8912b2c..5f1fa6d 100644
@@ -18242,6 +18242,12 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/net/ethernet/dlink/sundance.c
 
+SUNPLUS THERMAL DRIVER
+M:	Li-hao Kuo <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/thermal/sunplus_thermal.c
+
 SUPERH
 M:	Yoshinori Sato <[email protected]>
 M:	Rich Felker <[email protected]>

drivers/thermal/Kconfig +10 -0

index d7f44de..ddad391 100644
@@ -493,4 +493,14 @@ config KHADAS_MCU_FAN_THERMAL
 	  If you say yes here you get support for the FAN controlled
 	  by the Microcontroller found on the Khadas VIM boards.
 
+config SUNPLUS_THERMAL
+	tristate "Sunplus thermal drivers"
+	depends on SOC_SP7021 || COMPILE_TEST
+	help
+	  This the Sunplus SP7021 thermal driver, which supports the primitive
+	  temperature sensor embedded in Sunplus SP7021 SoC.
+
+	  If you have a Sunplus SP7021 platform say Y here and enable this option
+	  to have support for thermal management
+
 endif

drivers/thermal/Makefile +1 -0

index 82fc3e6..23f8dce 100644
@@ -60,3 +60,4 @@ obj-$(CONFIG_UNIPHIER_THERMAL)	+= uniphier_thermal.o
 obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
 obj-$(CONFIG_SPRD_THERMAL)	+= sprd_thermal.o
 obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL)	+= khadas_mcu_fan.o
+obj-$(CONFIG_SUNPLUS_THERMAL)	+= sunplus_thermal.o
\ No newline at end of file

drivers/thermal/sunplus_thermal.c new file +161 -0

161 lines not on this page · raw message

Signature · 1 line

2.7.4

kernel test robot

build bot

2021-12-29 13:04 UTC #2 lore raw

Re: [PATCH v2 1/2] THERMAL: Add THERMAL driver for Sunplus SP7021

I love your patch! Perhaps something to improve:

Hi Li-hao,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v5.16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Li-hao-Kuo/Add-THERMAL-control-driver-for-Sunplus-SP7021-SoC/20211223-130720
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: h8300-allyesconfig (https://download.01.org/0day-ci/archive/20211229/202112292049.x3u9VQgr-lkp(a)intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/99e97d44b9115aad59fc953c2945c7cbda1d57bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Li-hao-Kuo/Add-THERMAL-control-driver-for-Sunplus-SP7021-SoC/20211223-130720 git checkout 99e97d44b9115aad59fc953c2945c7cbda1d57bb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/thermal/

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

drivers/thermal/sunplus_thermal.c:44:7: warning: no previous prototype for 'sp7021_otp_coef_read' [-Wmissing-prototypes]

      44 | char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
         |       ^~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/printk.h:559,
                    from include/linux/kernel.h:20,
                    from include/linux/clk.h:13,
                    from drivers/thermal/sunplus_thermal.c:8:
   drivers/thermal/sunplus_thermal.c: In function 'sp7021_otp_coef_read':
>> drivers/thermal/sunplus_thermal.c:55:22: warning: format '%d' expects argument of type 'int', but argument 4 has type 'ssize_t' {aka 'long int'} [-Wformat=]
      55 |         dev_dbg(dev, "%d bytes read from OTP", *len);
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/thermal/sunplus_thermal.c:55:9: note: in expansion of macro 'dev_dbg'
      55 |         dev_dbg(dev, "%d bytes read from OTP", *len);
         |         ^~~~~~~
   drivers/thermal/sunplus_thermal.c:55:24: note: format string is defined here
      55 |         dev_dbg(dev, "%d bytes read from OTP", *len);
         |                       ~^
         |                        |
         |                        int
         |                       %ld

vim +55 drivers/thermal/sunplus_thermal.c

    43	
  > 44	char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
    45	{
    46		char *ret = NULL;
    47		struct nvmem_cell *c = nvmem_cell_get(dev, "therm_calib");
    48	
    49		if (IS_ERR_OR_NULL(c)) {
    50			dev_err(dev, "OTP read failure:%ld", PTR_ERR(c));
    51			return NULL;
    52		}
    53		ret = nvmem_cell_read(c, len);
    54		nvmem_cell_put(c);
  > 55		dev_dbg(dev, "%d bytes read from OTP", *len);
    56		return ret;
    57	}
    58

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

kernel test robot

build bot

2021-12-29 16:27 UTC #3 lore raw

Re: [PATCH v2 1/2] THERMAL: Add THERMAL driver for Sunplus SP7021

In reply to Li-hao Kuo

I love your patch! Perhaps something to improve:

Hi Li-hao,

I love your patch! Perhaps something to improve:

url:    https://github.com/0day-ci/linux/commits/Li-hao-Kuo/Add-THERMAL-control-driver-for-Sunplus-SP7021-SoC/20211223-130720
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211230/202112300008.jdRkNNeV-lkp(a)intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/thermal/sunplus_thermal.c:44:7: warning: no previous prototype for 'sp7021_otp_coef_read' [-Wmissing-prototypes]
      44 | char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
         |       ^~~~~~~~~~~~~~~~~~~~

vim +/sp7021_otp_coef_read +44 drivers/thermal/sunplus_thermal.c

    43	
  > 44	char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
    45	{
    46		char *ret = NULL;
    47		struct nvmem_cell *c = nvmem_cell_get(dev, "therm_calib");
    48	
    49		if (IS_ERR_OR_NULL(c)) {
    50			dev_err(dev, "OTP read failure:%ld", PTR_ERR(c));
    51			return NULL;
    52		}
    53		ret = nvmem_cell_read(c, len);
    54		nvmem_cell_put(c);
    55		dev_dbg(dev, "%d bytes read from OTP", *len);
    56		return ret;
    57	}
    58

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Li-hao Kuo

author

2021-12-23 05:06 UTC #4 lore raw

PATCH v2 2/2 devicetree: bindings THERMAL Add bindings doc for Sunplus SP7021

In reply to Li-hao Kuo

Add devicetree bindings THERMAL Add bindings doc for Sunplus SP7021

Signed-off-by Li-hao Kuo <[email protected]>

---
Changes in v2:
- Addressed all comments from Mr. Rob Herring
- Modify Theraml driver

 .../bindings/thermal/sunplus_thermal.yaml          | 49 ++++++++++++++++++++++
 MAINTAINERS                                        |  1 +
 2 files changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml

Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml new file +49 -0

new file mode 100644
index 0000000..e0290fa
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/sunplus_thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus Thermal controller
+
+maintainers:
+  - Li-hao Kuo <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - sunplus,sp7021-thermal
+
+  reg:
+    maxItems: 1
+
+  reg-names:
+    items:
+      - const: reg
+      - const: moon4
+
+  nvmem-cells:
+    maxItems: 1
+
+  nvmem-cell-names:
+    const: therm_calib
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - nvmem-cells
+  - nvmem-cell-names
+
+additionalProperties: false
+
+examples:
+  - |
+    thermal@9c000280 {
+        compatible = "sunplus,sp7021-thermal";
+        reg = <0x9c000280 0x80>;
+        nvmem-cells = <&therm_calib>;
+        nvmem-cell-names = "therm_calib";
+    };
+...

MAINTAINERS +1 -0

index 5f1fa6d..17035b5 100644
@@ -18246,6 +18246,7 @@ SUNPLUS THERMAL DRIVER
 M:	Li-hao Kuo <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
 F:	drivers/thermal/sunplus_thermal.c
 
 SUPERH

Signature · 1 line

2.7.4