drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
Subsystems (3)
v2 cover drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
v2 of [1]. Address review comments, drop crtc state compare move, add hw state readout&sanitization split, and sprinkle some struct drm_i915_private *i915 cleanups on top.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/105156/
Jani Nikula (11):
drm/i915/wm: move wm state verification to intel_pm.c drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings drm/i915/mpllb: move mpllb state check to intel_snps_phy.c drm/i915/display: split out modeset verification code drm/i915/display: split out crtc state dump to a separate file drm/i915/display: change who adds [] around crtc state dump context
string
drm/i915/display: rename dev_priv -> i915 in crtc state dump drm/i915/display: split out hw state readout and sanitize drm/i915/display: some struct drm_i915_private *i915 conversions drm/i915/display: convert modeset setup to struct drm_i915_private
*i915
drivers/gpu/drm/i915/Makefile | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 314 +++ .../drm/i915/display/intel_crtc_state_dump.h | 16 + drivers/gpu/drm/i915/display/intel_display.c | 1680 +---------------- drivers/gpu/drm/i915/display/intel_display.h | 18 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 + .../drm/i915/display/intel_modeset_setup.c | 724 +++++++ .../drm/i915/display/intel_modeset_setup.h | 15 + .../drm/i915/display/intel_modeset_verify.c | 246 +++ .../drm/i915/display/intel_modeset_verify.h | 21 + drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 + drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +- drivers/gpu/drm/i915/intel_pm.c | 138 +- drivers/gpu/drm/i915/intel_pm.h | 14 +- 15 files changed, 1724 insertions(+), 1606 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.h
Signature · 1 line
2.30.2
PATCH v2 1/11 drm/i915/wm: move wm state verification to intel_pm.c
By moving wm state verification to intel_pm.c, we can make a bunch of functions static, hiding the wm details better. Also declutter intel_display.c.
v2: intel_wm_state_verify -> intel_wm_verify_state (Ville)
--- drivers/gpu/drm/i915/display/intel_display.c | 122 +--------------- drivers/gpu/drm/i915/intel_pm.c | 138 +++++++++++++++++-- drivers/gpu/drm/i915/intel_pm.h | 14 +- 3 files changed, 132 insertions(+), 142 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -121
@@ -6424,126 +6424,6 @@ static void intel_pipe_config_sanity_check(struct drm_i915_private *dev_priv, } } -static void verify_wm_state (struct intel_crtc *crtc, -struct intel_crtc_state *new_crtc_state) -{ -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -struct skl_hw_state { -struct skl_ddb_entry ddb[I915_MAX_PLANES ]; -struct skl_ddb_entry ddb_y[I915_MAX_PLANES ]; -struct skl_pipe_wm wm; - } *hw; -const struct skl_pipe_wm *sw_wm = &new_crtc_state->wm.skl.optimal; -int level, max_level =ilk_wm_max_level (dev_priv); -struct intel_plane *plane; -u8 hw_enabled_slices; - -if (DISPLAY_VER (dev_priv) <9 || !new_crtc_state->hw.active) -return ; - - hw =kzalloc (sizeof (*hw),GFP_KERNEL ); -if (!hw) -return ; - -skl_pipe_wm_get_hw_state (crtc, &hw->wm); - -skl_pipe_ddb_get_hw_state (crtc, hw->ddb, hw->ddb_y); - - hw_enabled_slices =intel_enabled_dbuf_slices_mask (dev_priv); - -if (DISPLAY_VER (dev_priv) >=11 && - hw_enabled_slices != dev_priv->dbuf.enabled_slices) -drm_err (&dev_priv->drm, -"mismatch in DBUF Slices (expected 0x%x, got 0x%x)\n" , - dev_priv->dbuf.enabled_slices, - hw_enabled_slices); - -for_each_intel_plane_on_crtc (&dev_priv->drm, crtc, plane) { -const struct skl_ddb_entry *hw_ddb_entry, *sw_ddb_entry; -const struct skl_wm_level *hw_wm_level, *sw_wm_level; - -/* Watermarks */ -for (level =0 ; level <= max_level; level++) { - hw_wm_level = &hw->wm.planes[plane->id].wm[level]; - sw_wm_level =skl_plane_wm_level (sw_wm, plane->id, level); - -if (skl_wm_level_equals (hw_wm_level, sw_wm_level)) -continue ; - -drm_err (&dev_priv->drm, -"[PLANE:%d:%s] mismatch in WM%d (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n" , - plane->base.base.id, plane->base.name, level, - sw_wm_level->enable, - sw_wm_level->blocks, - sw_wm_level->lines, - hw_wm_level->enable, - hw_wm_level->blocks, - hw_wm_level->lines); - } - - hw_wm_level = &hw->wm.planes[plane->id].trans_wm; - sw_wm_level =skl_plane_trans_wm (sw_wm, plane->id); - -if (!skl_wm_level_equals (hw_wm_level, sw_wm_level)) { -drm_err (&dev_priv->drm, -"[PLANE:%d:%s] mismatch in trans WM (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n" , - plane->base.base.id, plane->base.name, - sw_wm_level->enable, - sw_wm_level->blocks, - sw_wm_level->lines, - hw_wm_level->enable, - hw_wm_level->blocks, - hw_wm_level->lines); - } - - hw_wm_level = &hw->wm.planes[plane->id].sagv.wm0; - sw_wm_level = &sw_wm->planes[plane->id].sagv.wm0; - -if (HAS_HW_SAGV_WM (dev_priv) && - !skl_wm_level_equals (hw_wm_level, sw_wm_level)) { -drm_err (&dev_priv->drm, -"[PLANE:%d:%s] mismatch in SAGV WM (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n" , - plane->base.base.id, plane->base.name, - sw_wm_level->enable, - sw_wm_level->blocks, - sw_wm_level->lines, - hw_wm_level->enable, - hw_wm_level->blocks, - hw_wm_level->lines); - } - - hw_wm_level = &hw->wm.planes[plane->id].sagv.trans_wm; - sw_wm_level = &sw_wm->planes[plane->id].sagv.trans_wm; - -if (HAS_HW_SAGV_WM (dev_priv) && - !skl_wm_level_equals (hw_wm_level, sw_wm_level)) { -drm_err (&dev_priv->drm, -"[PLANE:%d:%s] mismatch in SAGV trans WM (expected e=%d b=%u l=%u, got e=%d b=%u l=%u)\n" , - plane->base.base.id, plane->base.name, - sw_wm_level->enable, - sw_wm_level->blocks, - sw_wm_level->lines, - hw_wm_level->enable, - hw_wm_level->blocks, - hw_wm_level->lines); - } - -/* DDB */ - hw_ddb_entry = &hw->ddb[PLANE_CURSOR ]; - sw_ddb_entry = &new_crtc_state->wm.skl.plane_ddb[PLANE_CURSOR ]; - -if (!skl_ddb_entry_equal (hw_ddb_entry, sw_ddb_entry)) { -drm_err (&dev_priv->drm, -"[PLANE:%d:%s] mismatch in DDB (expected (%u,%u), found (%u,%u))\n" , - plane->base.base.id, plane->base.name, - sw_ddb_entry->start, sw_ddb_entry->end, - hw_ddb_entry->start, hw_ddb_entry->end); - } - } - -kfree (hw); -} -static void verify_connector_state (struct intel_atomic_state *state,struct intel_crtc *crtc)
@@ -6836,7 +6716,7 @@ intel_modeset_verify_crtc(struct intel_crtc *crtc,if (!intel_crtc_needs_modeset (new_crtc_state) && !new_crtc_state->update_pipe)return ; -verify_wm_state (crtc, new_crtc_state); +intel_wm_state_verify (crtc, new_crtc_state);verify_connector_state (state, crtc);verify_crtc_state (crtc, old_crtc_state, new_crtc_state);verify_shared_dpll_state (crtc, old_crtc_state, new_crtc_state);
drivers/gpu/drm/i915/intel_pm.c +129 -9
174 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.h +2 -12
@@ -35,15 +35,12 @@ void g4x_wm_get_hw_state(struct drm_i915_private *dev_priv);void vlv_wm_get_hw_state (struct drm_i915_private *dev_priv);void ilk_wm_get_hw_state (struct drm_i915_private *dev_priv);void skl_wm_get_hw_state (struct drm_i915_private *dev_priv); +void intel_wm_state_verify (struct intel_crtc *crtc, +struct intel_crtc_state *new_crtc_state);u8 intel_enabled_dbuf_slices_mask (struct drm_i915_private *dev_priv); -void skl_pipe_ddb_get_hw_state (struct intel_crtc *crtc, -struct skl_ddb_entry *ddb_y, -struct skl_ddb_entry *ddb_uv);void skl_ddb_get_hw_state (struct drm_i915_private *dev_priv);u32 skl_ddb_dbuf_slice_mask (struct drm_i915_private *dev_priv,const struct skl_ddb_entry *entry); -void skl_pipe_wm_get_hw_state (struct intel_crtc *crtc, -struct skl_pipe_wm *out);void g4x_wm_sanitize (struct drm_i915_private *dev_priv);void vlv_wm_sanitize (struct drm_i915_private *dev_priv);void skl_wm_sanitize (struct drm_i915_private *dev_priv);
@@ -51,13 +48,6 @@ bool intel_can_enable_sagv(struct drm_i915_private *dev_priv, const struct intel_bw_state *bw_state);void intel_sagv_pre_plane_update (struct intel_atomic_state *state);void intel_sagv_post_plane_update (struct intel_atomic_state *state); -const struct skl_wm_level *skl_plane_wm_level (const struct skl_pipe_wm *pipe_wm, -enum plane_id plane_id, -int level); -const struct skl_wm_level *skl_plane_trans_wm (const struct skl_pipe_wm *pipe_wm, -enum plane_id plane_id); -bool skl_wm_level_equals (const struct skl_wm_level *l1, -const struct skl_wm_level *l2);bool skl_ddb_allocation_overlaps (const struct skl_ddb_entry *ddb,const struct skl_ddb_entry *entries,int num_entries,int ignore_idx);
Signature · 1 line
2.30.2
PATCH v2 2/11 drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c
In reply to Jani NikulaKeep the shared dpll implementation details together by moving the dpll state verification to intel_dpll_mgr.c. Also declutter intel_display.c.
v2: intel_shared_dpll_verify_state -> intel_shared_dpll_state_verify (Ville)
--- drivers/gpu/drm/i915/display/intel_display.c | 94 +------------------ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 + 3 files changed, 95 insertions(+), 92 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -92
@@ -6582,85 +6582,6 @@ intel_verify_planes(struct intel_atomic_state *state) plane_state->uapi.visible); } -static void -verify_single_dpll_state (struct drm_i915_private *dev_priv, -struct intel_shared_dpll *pll, -struct intel_crtc *crtc, -struct intel_crtc_state *new_crtc_state) -{ -struct intel_dpll_hw_state dpll_hw_state; -u8 pipe_mask; -bool active; - -memset (&dpll_hw_state,0 ,sizeof (dpll_hw_state)); - -drm_dbg_kms (&dev_priv->drm,"%s\n" , pll->info->name); - - active =intel_dpll_get_hw_state (dev_priv, pll, &dpll_hw_state); - -if (!(pll->info->flags &INTEL_DPLL_ALWAYS_ON )) { -I915_STATE_WARN (!pll->on && pll->active_mask, -"pll in active use but not on in sw tracking\n" ); -I915_STATE_WARN (pll->on && !pll->active_mask, -"pll is on but not used by any active pipe\n" ); -I915_STATE_WARN (pll->on != active, -"pll on state mismatch (expected %i, found %i)\n" , - pll->on, active); - } - -if (!crtc) { -I915_STATE_WARN (pll->active_mask & ~pll->state.pipe_mask, -"more active pll users than references: 0x%x vs 0x%x\n" , - pll->active_mask, pll->state.pipe_mask); - -return ; - } - - pipe_mask =BIT (crtc->pipe); - -if (new_crtc_state->hw.active) -I915_STATE_WARN (!(pll->active_mask & pipe_mask), -"pll active mismatch (expected pipe %c in active mask 0x%x)\n" , -pipe_name (crtc->pipe), pll->active_mask); -else -I915_STATE_WARN (pll->active_mask & pipe_mask, -"pll active mismatch (didn't expect pipe %c in active mask 0x%x)\n" , -pipe_name (crtc->pipe), pll->active_mask); - -I915_STATE_WARN (!(pll->state.pipe_mask & pipe_mask), -"pll enabled crtcs mismatch (expected 0x%x in 0x%x)\n" , - pipe_mask, pll->state.pipe_mask); - -I915_STATE_WARN (pll->on &&memcmp (&pll->state.hw_state, - &dpll_hw_state, -sizeof (dpll_hw_state)), -"pll hw state mismatch\n" ); -} - -static void -verify_shared_dpll_state (struct intel_crtc *crtc, -struct intel_crtc_state *old_crtc_state, -struct intel_crtc_state *new_crtc_state) -{ -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); - -if (new_crtc_state->shared_dpll) -verify_single_dpll_state (dev_priv, new_crtc_state->shared_dpll, crtc, new_crtc_state); - -if (old_crtc_state->shared_dpll && - old_crtc_state->shared_dpll != new_crtc_state->shared_dpll) { -u8 pipe_mask =BIT (crtc->pipe); -struct intel_shared_dpll *pll = old_crtc_state->shared_dpll; - -I915_STATE_WARN (pll->active_mask & pipe_mask, -"pll active mismatch (didn't expect pipe %c in active mask (0x%x))\n" , -pipe_name (crtc->pipe), pll->active_mask); -I915_STATE_WARN (pll->state.pipe_mask & pipe_mask, -"pll enabled crtcs mismatch (found %x in enabled mask (0x%x))\n" , -pipe_name (crtc->pipe), pll->state.pipe_mask); - } -} -static void verify_mpllb_state (struct intel_atomic_state *state,struct intel_crtc_state *new_crtc_state)
@@ -6719,28 +6640,17 @@ intel_modeset_verify_crtc(struct intel_crtc *crtc,intel_wm_state_verify (crtc, new_crtc_state);verify_connector_state (state, crtc);verify_crtc_state (crtc, old_crtc_state, new_crtc_state); -verify_shared_dpll_state (crtc, old_crtc_state, new_crtc_state); +intel_shared_dpll_state_verify (crtc, old_crtc_state, new_crtc_state);verify_mpllb_state (state, new_crtc_state); } -static void -verify_disabled_dpll_state (struct drm_i915_private *dev_priv) -{ -int i; - -for (i =0 ; i < dev_priv->dpll.num_shared_dpll; i++) -verify_single_dpll_state (dev_priv, - &dev_priv->dpll.shared_dplls[i], -NULL ,NULL ); -} -static void intel_modeset_verify_disabled (struct drm_i915_private *dev_priv,struct intel_atomic_state *state) {verify_encoder_state (dev_priv, state);verify_connector_state (state,NULL ); -verify_disabled_dpll_state (dev_priv); +intel_shared_dpll_verify_disabled (dev_priv); }int intel_modeset_all_pipes (struct intel_atomic_state *state)
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +88 -0
91 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpll_mgr.h +5 -0
@@ -368,4 +368,9 @@ void intel_dpll_dump_hw_state(struct drm_i915_private *dev_priv,enum intel_dpll_id icl_tc_port_to_pll_id (enum tc_port tc_port);bool intel_dpll_is_combophy (enum intel_dpll_id id); +void intel_shared_dpll_state_verify (struct intel_crtc *crtc, +struct intel_crtc_state *old_crtc_state, +struct intel_crtc_state *new_crtc_state); +void intel_shared_dpll_verify_disabled (struct drm_i915_private *i915); +#endif /* _INTEL_DPLL_MGR_H_ */
Signature · 1 line
2.30.2
PATCH v2 3/11 drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings
In reply to Jani NikulaThe pipe_config_mismatch() function is primarily for logging comparison results.
--- drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +6 -8
@@ -6601,14 +6601,12 @@ verify_mpllb_state(struct intel_atomic_state *state, encoder =intel_get_crtc_new_encoder (state, new_crtc_state);intel_mpllb_readout_hw_state (encoder, &mpllb_hw_state); -#define MPLLB_CHECK (name) do { \ - if (mpllb_sw_state->name != mpllb_hw_state.name) { \ - pipe_config_mismatch(false, crtc, "MPLLB:" __stringify(name), \ - "(expected 0x%08x, found 0x%08x)", \ - mpllb_sw_state->name, \ - mpllb_hw_state.name); \ - } \ -} while (0) +#define MPLLB_CHECK (__name) \ + I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \ + "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \ + crtc->base.base.id, crtc->base.name, \ + __stringify(__name), \ + mpllb_sw_state->__name, mpllb_hw_state.__name)MPLLB_CHECK (mpllb_cp);MPLLB_CHECK (mpllb_div);
Signature · 1 line
2.30.2
PATCH v2 4/11 drm/i915/mpllb: move mpllb state check to intel_snps_phy.c
In reply to Jani NikulaKeep the mpllb implementation details together in intel_snps_phy.c. Also declutter intel_display.c.
v2: intel_mpllb_verify_state -> void intel_mpllb_state_verify (Ville)
--- drivers/gpu/drm/i915/display/intel_display.c | 46 +------------------ drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +- 3 files changed, 48 insertions(+), 46 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +1 -45
@@ -6582,50 +6582,6 @@ intel_verify_planes(struct intel_atomic_state *state) plane_state->uapi.visible); } -static void -verify_mpllb_state (struct intel_atomic_state *state, -struct intel_crtc_state *new_crtc_state) -{ -struct drm_i915_private *i915 =to_i915 (state->base.dev); -struct intel_mpllb_state mpllb_hw_state = {0 }; -struct intel_mpllb_state *mpllb_sw_state = &new_crtc_state->mpllb_state; -struct intel_crtc *crtc =to_intel_crtc (new_crtc_state->uapi.crtc); -struct intel_encoder *encoder; - -if (!IS_DG2 (i915)) -return ; - -if (!new_crtc_state->hw.active) -return ; - - encoder =intel_get_crtc_new_encoder (state, new_crtc_state); -intel_mpllb_readout_hw_state (encoder, &mpllb_hw_state); - -#define MPLLB_CHECK (__name) \ - I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \ - "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \ - crtc->base.base.id, crtc->base.name, \ - __stringify(__name), \ - mpllb_sw_state->__name, mpllb_hw_state.__name) - -MPLLB_CHECK (mpllb_cp); -MPLLB_CHECK (mpllb_div); -MPLLB_CHECK (mpllb_div2); -MPLLB_CHECK (mpllb_fracn1); -MPLLB_CHECK (mpllb_fracn2); -MPLLB_CHECK (mpllb_sscen); -MPLLB_CHECK (mpllb_sscstep); - -/* -* ref_control is handled by the hardware/firemware and never -* programmed by the software, but the proper values are supplied -* in the bspec for verification purposes. -*/ -MPLLB_CHECK (ref_control); - -#undef MPLLB_CHECK -} - static void intel_modeset_verify_crtc(struct intel_crtc *crtc, struct intel_atomic_state *state,
@@ -6639,7 +6595,7 @@ intel_modeset_verify_crtc(struct intel_crtc *crtc,verify_connector_state (state, crtc);verify_crtc_state (crtc, old_crtc_state, new_crtc_state);intel_shared_dpll_state_verify (crtc, old_crtc_state, new_crtc_state); -verify_mpllb_state (state, new_crtc_state); +intel_mpllb_state_verify (state, new_crtc_state); } static void
drivers/gpu/drm/i915/display/intel_snps_phy.c +43 -0
46 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_snps_phy.h +4 -1
@@ -9,8 +9,9 @@#include <linux/types.h> struct drm_i915_private ; -struct intel_encoder ; +struct intel_atomic_state ;struct intel_crtc_state ; +struct intel_encoder ;struct intel_mpllb_state ;enum phy ;
@@ -31,5 +32,7 @@ int intel_mpllb_calc_port_clock(struct intel_encoder *encoder,int intel_snps_phy_check_hdmi_link_rate (int clock);void intel_snps_phy_set_signal_levels (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state); +void intel_mpllb_state_verify (struct intel_atomic_state *state, +struct intel_crtc_state *new_crtc_state);#endif /* __INTEL_SNPS_PHY_H__ */
Signature · 1 line
2.30.2
PATCH v2 5/11 drm/i915/display: split out modeset verification code
In reply to Jani NikulaAdd new file intel_modeset_verify.c for high level modeset verification code to declutter intel_display.h. The new file is supposed to be about crtc/encoder/connector verification; the state verification for very specific functionality such as plls or wm should be placed next to the code it verifies.
Fix some minor checkpatch issues while at it.
v2: Rebase
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 243 +---------------- drivers/gpu/drm/i915/display/intel_display.h | 9 + .../drm/i915/display/intel_modeset_verify.c | 245 ++++++++++++++++++ .../drm/i915/display/intel_modeset_verify.h | 21 ++ 5 files changed, 284 insertions(+), 235 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -242,6 +242,7 @@ i915-y += \ display/intel_hdcp.o \ display/intel_hotplug.o \ display/intel_lpe_audio.o \ + display/intel_modeset_verify.o \ display/intel_overlay.o \ display/intel_pch_display.o \ display/intel_pch_refclk.o \
drivers/gpu/drm/i915/display/intel_display.c +8 -235
291 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +9 -0
@@ -559,6 +559,13 @@ bool intel_crtc_is_bigjoiner_slave(const struct intel_crtc_state *crtc_state);bool intel_crtc_is_bigjoiner_master (const struct intel_crtc_state *crtc_state);u8 intel_crtc_bigjoiner_slave_pipes (const struct intel_crtc_state *crtc_state);struct intel_crtc *intel_master_crtc (const struct intel_crtc_state *crtc_state); +bool intel_crtc_get_pipe_config (struct intel_crtc_state *crtc_state); +bool intel_pipe_config_compare (const struct intel_crtc_state *current_config, +const struct intel_crtc_state *pipe_config, +bool fastset); +void intel_dump_pipe_config (const struct intel_crtc_state *pipe_config, +struct intel_atomic_state *state, +const char *context);void intel_plane_destroy (struct drm_plane *plane);void intel_enable_transcoder (const struct intel_crtc_state *new_crtc_state);
@@ -583,6 +590,8 @@ int intel_display_suspend(struct drm_device *dev);void intel_encoder_destroy (struct drm_encoder *encoder);struct drm_display_mode *intel_encoder_current_mode (struct intel_encoder *encoder); +void intel_encoder_get_config (struct intel_encoder *encoder, +struct intel_crtc_state *crtc_state);bool intel_phy_is_combo (struct drm_i915_private *dev_priv,enum phy phy);bool intel_phy_is_tc (struct drm_i915_private *dev_priv,enum phy phy);bool intel_phy_is_snps (struct drm_i915_private *dev_priv,enum phy phy);
drivers/gpu/drm/i915/display/intel_modeset_verify.c new file +245 -0
245 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_modeset_verify.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_MODESET_VERIFY_H__ +#define __INTEL_MODESET_VERIFY_H__ + +struct drm_i915_private ; +struct intel_atomic_state ; +struct intel_crtc ; +struct intel_crtc_state ; + +void intel_modeset_verify_crtc (struct intel_crtc *crtc, +struct intel_atomic_state *state, +struct intel_crtc_state *old_crtc_state, +struct intel_crtc_state *new_crtc_state); +void intel_modeset_verify_disabled (struct drm_i915_private *dev_priv, +struct intel_atomic_state *state); + +#endif /* __INTEL_MODESET_VERIFY_H__ */
Signature · 1 line
2.30.2
PATCH v2 6/11 drm/i915/display: split out crtc state dump to a separate file
In reply to Jani NikulaDeclutter intel_display.c by splitting out crtc state dumping to a separate file.
v2: intel_pipe_config_dump -> intel_crtc_state_dump
--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_crtc_state_dump.c | 314 +++++++++++++++++ .../drm/i915/display/intel_crtc_state_dump.h | 16 + drivers/gpu/drm/i915/display/intel_display.c | 315 +----------------- drivers/gpu/drm/i915/display/intel_display.h | 3 - .../drm/i915/display/intel_modeset_verify.c | 5 +- 6 files changed, 340 insertions(+), 314 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -220,6 +220,7 @@ i915-y += \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_crtc.o \ + display/intel_crtc_state_dump.o \ display/intel_cursor.o \ display/intel_display.o \ display/intel_display_power.o \
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c new file +314 -0
314 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_crtc_state_dump.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_CRTC_STATE_DUMP_H__ +#define __INTEL_CRTC_STATE_DUMP_H__ + +struct intel_crtc_state ; +struct intel_atomic_state ; + +void intel_crtc_state_dump (const struct intel_crtc_state *crtc_state, +struct intel_atomic_state *state, +const char *context); + +#endif /* __INTEL_CRTC_STATE_H__ */
drivers/gpu/drm/i915/display/intel_display.c +6 -309
345 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +0 -3
@@ -563,9 +563,6 @@ bool intel_crtc_get_pipe_config(struct intel_crtc_state *crtc_state);bool intel_pipe_config_compare (const struct intel_crtc_state *current_config,const struct intel_crtc_state *pipe_config,bool fastset); -void intel_dump_pipe_config (const struct intel_crtc_state *pipe_config, -struct intel_atomic_state *state, -const char *context);void intel_plane_destroy (struct drm_plane *plane);void intel_enable_transcoder (const struct intel_crtc_state *new_crtc_state);
drivers/gpu/drm/i915/display/intel_modeset_verify.c +3 -2
@@ -10,6 +10,7 @@#include "i915_drv.h" #include "intel_atomic.h" #include "intel_crtc.h" +#include "intel_crtc_state_dump.h" #include "intel_display.h" #include "intel_display_types.h" #include "intel_fdi.h"
@@ -216,8 +217,8 @@ verify_crtc_state(struct intel_crtc *crtc,if (!intel_pipe_config_compare (new_crtc_state, pipe_config, false)) {I915_STATE_WARN (1 ,"pipe state doesn't match!\n" ); -intel_dump_pipe_config (pipe_config,NULL ,"[hw state]" ); -intel_dump_pipe_config (new_crtc_state,NULL ,"[sw state]" ); +intel_crtc_state_dump (pipe_config,NULL ,"[hw state]" ); +intel_crtc_state_dump (new_crtc_state,NULL ,"[sw state]" ); } }
Signature · 1 line
2.30.2
PATCH v2 7/11 drm/i915/display: change who adds [] around crtc state dump context string
In reply to Jani NikulaAdd the brackets [] around crtc state dump context string in intel_crtc_state_dump() so the callers don't have to.
--- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/display/intel_modeset_verify.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +1 -1
@@ -154,7 +154,7 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,char buf[64 ];int i; -drm_dbg_kms (&dev_priv->drm,"[CRTC:%d:%s] enable: %s %s\n" , +drm_dbg_kms (&dev_priv->drm,"[CRTC:%d:%s] enable: %s [%s]\n" , crtc->base.base.id, crtc->base.name,str_yes_no (pipe_config->hw.enable), context);
drivers/gpu/drm/i915/display/intel_display.c +3 -3
@@ -7091,7 +7091,7 @@ static int intel_atomic_check(struct drm_device *dev,intel_crtc_state_dump (new_crtc_state, state,intel_crtc_needs_modeset (new_crtc_state) ? -"[modeset]" :"[fastset]" ); +"modeset" :"fastset" ); }return 0 ;
@@ -7106,7 +7106,7 @@ static int intel_atomic_check(struct drm_device *dev,*/ for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) -intel_crtc_state_dump (new_crtc_state, state,"[failed]" ); +intel_crtc_state_dump (new_crtc_state, state,"failed" );return ret; }
@@ -9586,7 +9586,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev,to_intel_crtc_state (crtc->base.state);intel_sanitize_crtc (crtc, ctx); -intel_crtc_state_dump (crtc_state,NULL ,"[setup_hw_state]" ); +intel_crtc_state_dump (crtc_state,NULL ,"setup_hw_state" ); }intel_modeset_update_connector_atomic_state (dev);
drivers/gpu/drm/i915/display/intel_modeset_verify.c +2 -2
@@ -217,8 +217,8 @@ verify_crtc_state(struct intel_crtc *crtc,if (!intel_pipe_config_compare (new_crtc_state, pipe_config, false)) {I915_STATE_WARN (1 ,"pipe state doesn't match!\n" ); -intel_crtc_state_dump (pipe_config,NULL ,"[hw state]" ); -intel_crtc_state_dump (new_crtc_state,NULL ,"[sw state]" ); +intel_crtc_state_dump (pipe_config,NULL ,"hw state" ); +intel_crtc_state_dump (new_crtc_state,NULL ,"sw state" ); } }
Signature · 1 line
2.30.2
PATCH v2 8/11 drm/i915/display: rename dev_priv -> i915 in crtc state dump
In reply to Jani NikulaRename dev_priv to i915 in crtc state dumping code.
--- .../drm/i915/display/intel_crtc_state_dump.c | 80 +++++++++---------- 1 file changed, 40 insertions(+), 40 deletions(-)
drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +40 -40
@@ -37,23 +37,23 @@ intel_dump_m_n_config(const struct intel_crtc_state *pipe_config, }static void -intel_dump_infoframe (struct drm_i915_private *dev_priv, +intel_dump_infoframe (struct drm_i915_private *i915,const union hdmi_infoframe *frame) {if (!drm_debug_enabled (DRM_UT_KMS ))return ; -hdmi_infoframe_log (KERN_DEBUG , dev_priv->drm.dev, frame); +hdmi_infoframe_log (KERN_DEBUG , i915->drm.dev, frame); }static void -intel_dump_dp_vsc_sdp (struct drm_i915_private *dev_priv, +intel_dump_dp_vsc_sdp (struct drm_i915_private *i915,const struct drm_dp_vsc_sdp *vsc) {if (!drm_debug_enabled (DRM_UT_KMS ))return ; -drm_dp_vsc_sdp_log (KERN_DEBUG , dev_priv->drm.dev, vsc); +drm_dp_vsc_sdp_log (KERN_DEBUG , i915->drm.dev, vsc); }#define OUTPUT_TYPE (x) [INTEL_OUTPUT_ ## x] = #x
@@ -148,13 +148,13 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, const char *context) {struct intel_crtc *crtc =to_intel_crtc (pipe_config->uapi.crtc); -struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); +struct drm_i915_private *i915 =to_i915 (crtc->base.dev);const struct intel_plane_state *plane_state;struct intel_plane *plane;char buf[64 ];int i; -drm_dbg_kms (&dev_priv->drm,"[CRTC:%d:%s] enable: %s [%s]\n" , +drm_dbg_kms (&i915->drm,"[CRTC:%d:%s] enable: %s [%s]\n" , crtc->base.base.id, crtc->base.name,str_yes_no (pipe_config->hw.enable), context);
@@ -162,31 +162,31 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, goto dump_planes;snprintf_output_types (buf,sizeof (buf), pipe_config->output_types); -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"active: %s, output_types: %s (0x%x), output format: %s\n" ,str_yes_no (pipe_config->hw.active), buf, pipe_config->output_types,output_formats (pipe_config->output_format)); -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n" ,transcoder_name (pipe_config->cpu_transcoder), pipe_config->pipe_bpp, pipe_config->dither); -drm_dbg_kms (&dev_priv->drm,"MST master transcoder: %s\n" , +drm_dbg_kms (&i915->drm,"MST master transcoder: %s\n" ,transcoder_name (pipe_config->mst_master_transcoder)); -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"port sync: master transcoder: %s, slave transcoder bitmask = 0x%x\n" ,transcoder_name (pipe_config->master_transcoder), pipe_config->sync_mode_slaves_mask); -drm_dbg_kms (&dev_priv->drm,"bigjoiner: %s, pipes: 0x%x\n" , +drm_dbg_kms (&i915->drm,"bigjoiner: %s, pipes: 0x%x\n" ,intel_crtc_is_bigjoiner_slave (pipe_config) ?"slave" :intel_crtc_is_bigjoiner_master (pipe_config) ?"master" :"no" , pipe_config->bigjoiner_pipes); -drm_dbg_kms (&dev_priv->drm,"splitter: %s, link count %d, overlap %d\n" , +drm_dbg_kms (&i915->drm,"splitter: %s, link count %d, overlap %d\n" ,str_enabled_disabled (pipe_config->splitter.enable), pipe_config->splitter.link_count, pipe_config->splitter.pixel_overlap);
@@ -205,38 +205,38 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, &pipe_config->dp_m2_n2); } -drm_dbg_kms (&dev_priv->drm,"framestart delay: %d, MSA timing delay: %d\n" , +drm_dbg_kms (&i915->drm,"framestart delay: %d, MSA timing delay: %d\n" , pipe_config->framestart_delay, pipe_config->msa_timing_delay); -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"audio: %i, infoframes: %i, infoframes enabled: 0x%x\n" , pipe_config->has_audio, pipe_config->has_infoframe, pipe_config->infoframes.enable);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GENERAL_CONTROL )) -drm_dbg_kms (&dev_priv->drm,"GCP: 0x%x\n" , +drm_dbg_kms (&i915->drm,"GCP: 0x%x\n" , pipe_config->infoframes.gcp);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI )) -intel_dump_infoframe (dev_priv, &pipe_config->infoframes.avi); +intel_dump_infoframe (i915, &pipe_config->infoframes.avi);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_SPD )) -intel_dump_infoframe (dev_priv, &pipe_config->infoframes.spd); +intel_dump_infoframe (i915, &pipe_config->infoframes.spd);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_VENDOR )) -intel_dump_infoframe (dev_priv, &pipe_config->infoframes.hdmi); +intel_dump_infoframe (i915, &pipe_config->infoframes.hdmi);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_DRM )) -intel_dump_infoframe (dev_priv, &pipe_config->infoframes.drm); +intel_dump_infoframe (i915, &pipe_config->infoframes.drm);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GAMUT_METADATA )) -intel_dump_infoframe (dev_priv, &pipe_config->infoframes.drm); +intel_dump_infoframe (i915, &pipe_config->infoframes.drm);if (pipe_config->infoframes.enable &intel_hdmi_infoframe_enable (DP_SDP_VSC )) -intel_dump_dp_vsc_sdp (dev_priv, &pipe_config->infoframes.vsc); +intel_dump_dp_vsc_sdp (i915, &pipe_config->infoframes.vsc); - drm_dbg_kms(&dev_priv->drm, "vrr: %s, vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n", + drm_dbg_kms(&i915->drm, "vrr: %s, vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n", str_yes_no(pipe_config->vrr.enable), pipe_config->vrr.vmin, pipe_config->vrr.vmax, pipe_config->vrr.pipeline_full, pipe_config->vrr.guardband,
@@ -244,60 +244,60 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,intel_vrr_vmin_vblank_start (pipe_config), intel_vrr_vmax_vblank_start(pipe_config)); -drm_dbg_kms (&dev_priv->drm,"requested mode: " DRM_MODE_FMT "\n" , +drm_dbg_kms (&i915->drm,"requested mode: " DRM_MODE_FMT "\n" ,DRM_MODE_ARG (&pipe_config->hw.mode)); -drm_dbg_kms (&dev_priv->drm,"adjusted mode: " DRM_MODE_FMT "\n" , +drm_dbg_kms (&i915->drm,"adjusted mode: " DRM_MODE_FMT "\n" ,DRM_MODE_ARG (&pipe_config->hw.adjusted_mode)); -intel_dump_crtc_timings (dev_priv, &pipe_config->hw.adjusted_mode); -drm_dbg_kms (&dev_priv->drm,"pipe mode: " DRM_MODE_FMT "\n" , +intel_dump_crtc_timings (i915, &pipe_config->hw.adjusted_mode); +drm_dbg_kms (&i915->drm,"pipe mode: " DRM_MODE_FMT "\n" ,DRM_MODE_ARG (&pipe_config->hw.pipe_mode)); -intel_dump_crtc_timings (dev_priv, &pipe_config->hw.pipe_mode); -drm_dbg_kms (&dev_priv->drm, +intel_dump_crtc_timings (i915, &pipe_config->hw.pipe_mode); +drm_dbg_kms (&i915->drm,"port clock: %d, pipe src: " DRM_RECT_FMT ", pixel rate %d\n" , pipe_config->port_clock,DRM_RECT_ARG (&pipe_config->pipe_src), pipe_config->pixel_rate); -drm_dbg_kms (&dev_priv->drm,"linetime: %d, ips linetime: %d\n" , +drm_dbg_kms (&i915->drm,"linetime: %d, ips linetime: %d\n" , pipe_config->linetime, pipe_config->ips_linetime); -if (DISPLAY_VER (dev_priv) >=9 ) -drm_dbg_kms (&dev_priv->drm, +if (DISPLAY_VER (i915) >=9 ) +drm_dbg_kms (&i915->drm,"num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n" , crtc->num_scalers, pipe_config->scaler_state.scaler_users, pipe_config->scaler_state.scaler_id); -if (HAS_GMCH (dev_priv)) -drm_dbg_kms (&dev_priv->drm, +if (HAS_GMCH (i915)) +drm_dbg_kms (&i915->drm,"gmch pfit: control: 0x%08x, ratios: 0x%08x, lvds border: 0x%08x\n" , pipe_config->gmch_pfit.control, pipe_config->gmch_pfit.pgm_ratios, pipe_config->gmch_pfit.lvds_border_bits);else -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"pch pfit: " DRM_RECT_FMT ", %s, force thru: %s\n" ,DRM_RECT_ARG (&pipe_config->pch_pfit.dst),str_enabled_disabled (pipe_config->pch_pfit.enabled),str_yes_no (pipe_config->pch_pfit.force_thru)); -drm_dbg_kms (&dev_priv->drm,"ips: %i, double wide: %i, drrs: %i\n" , +drm_dbg_kms (&i915->drm,"ips: %i, double wide: %i, drrs: %i\n" , pipe_config->ips_enabled, pipe_config->double_wide, pipe_config->has_drrs); -intel_dpll_dump_hw_state (dev_priv, &pipe_config->dpll_hw_state); +intel_dpll_dump_hw_state (i915, &pipe_config->dpll_hw_state); -if (IS_CHERRYVIEW (dev_priv)) -drm_dbg_kms (&dev_priv->drm, +if (IS_CHERRYVIEW (i915)) +drm_dbg_kms (&i915->drm,"cgm_mode: 0x%x gamma_mode: 0x%x gamma_enable: %d csc_enable: %d\n" , pipe_config->cgm_mode, pipe_config->gamma_mode, pipe_config->gamma_enable, pipe_config->csc_enable);else -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"csc_mode: 0x%x gamma_mode: 0x%x gamma_enable: %d csc_enable: %d\n" , pipe_config->csc_mode, pipe_config->gamma_mode, pipe_config->gamma_enable, pipe_config->csc_enable); - drm_dbg_kms(&dev_priv->drm, "degamma lut: %d entries, gamma lut: %d entries\n", + drm_dbg_kms(&i915->drm, "degamma lut: %d entries, gamma lut: %d entries\n", pipe_config->hw.degamma_lut ? drm_color_lut_size(pipe_config->hw.degamma_lut) : 0, pipe_config->hw.gamma_lut ?
Signature · 1 line
2.30.2
PATCH v2 9/11 drm/i915/display: split out hw state readout and sanitize
In reply to Jani NikulaSplit out the modeset hardware state readout and sanitize, or state setup, to a separate file.
Do some drive-by checkpatch fixes while at it.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 730 +----------------- drivers/gpu/drm/i915/display/intel_display.h | 12 + .../drm/i915/display/intel_modeset_setup.c | 727 +++++++++++++++++ .../drm/i915/display/intel_modeset_setup.h | 15 + 5 files changed, 769 insertions(+), 716 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -244,6 +244,7 @@ i915-y += \ display/intel_hotplug.o \ display/intel_lpe_audio.o \ display/intel_modeset_verify.o \ + display/intel_modeset_setup.o \ display/intel_overlay.o \ display/intel_pch_display.o \ display/intel_pch_refclk.o \
drivers/gpu/drm/i915/display/intel_display.c +14 -716
820 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +12 -0
@@ -56,6 +56,7 @@ struct intel_initial_plane_config;struct intel_load_detect_pipe ;struct intel_plane ;struct intel_plane_state ; +struct intel_power_domain_mask ;struct intel_remapped_info ;struct intel_rotation_info ;struct pci_dev ;
@@ -563,6 +564,7 @@ bool intel_crtc_get_pipe_config(struct intel_crtc_state *crtc_state);bool intel_pipe_config_compare (const struct intel_crtc_state *current_config,const struct intel_crtc_state *pipe_config,bool fastset); +void intel_crtc_update_active_timings (const struct intel_crtc_state *crtc_state);void intel_plane_destroy (struct drm_plane *plane);void intel_enable_transcoder (const struct intel_crtc_state *new_crtc_state);
@@ -659,10 +661,16 @@ intel_get_crtc_new_encoder(const struct intel_atomic_state *state, const struct intel_crtc_state *crtc_state);void intel_plane_disable_noatomic (struct intel_crtc *crtc,struct intel_plane *plane); +void intel_set_plane_visible (struct intel_crtc_state *crtc_state, +struct intel_plane_state *plane_state, +bool visible); +void intel_plane_fixup_bitmasks (struct intel_crtc_state *crtc_state);void intel_display_driver_register (struct drm_i915_private *i915);void intel_display_driver_unregister (struct drm_i915_private *i915); +void intel_update_watermarks (struct drm_i915_private *i915); +/* modesetting */ bool intel_modeset_probe_defer (struct pci_dev *pdev);void intel_modeset_init_hw (struct drm_i915_private *i915);
@@ -674,6 +682,10 @@ void intel_modeset_driver_remove_noirq(struct drm_i915_private *i915);void intel_modeset_driver_remove_nogem (struct drm_i915_private *i915);void intel_display_resume (struct drm_device *dev);int intel_modeset_all_pipes (struct intel_atomic_state *state); +void intel_modeset_get_crtc_power_domains (struct intel_crtc_state *crtc_state, +struct intel_power_domain_mask *old_domains); +void intel_modeset_put_crtc_power_domains (struct intel_crtc *crtc, +struct intel_power_domain_mask *domains);/* modesetting asserts */ void assert_transcoder(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/display/intel_modeset_setup.c new file +727 -0
727 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_modeset_setup.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_MODESET_SETUP_H__ +#define __INTEL_MODESET_SETUP_H__ + +struct drm_device ; +struct drm_modeset_acquire_ctx ; + +void intel_modeset_setup_hw_state (struct drm_device *dev, +struct drm_modeset_acquire_ctx *ctx); + +#endif /* __INTEL_MODESET_SETUP_H__ */
Signature · 1 line
2.30.2
PATCH v2 10/11 drm/i915/display: some struct drm_i915_private *i915 conversions
In reply to Jani NikulaPrefer struct drm_i915_private *i915 over struct drm_device or dev_priv.
--- drivers/gpu/drm/i915/display/intel_display.c | 60 ++++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +30 -30
@@ -830,7 +830,7 @@ intel_plane_fence_y_offset(const struct intel_plane_state *plane_state) }static int -__intel_display_resume (struct drm_device *dev, +__intel_display_resume (struct drm_i915_private *i915,struct drm_atomic_state *state,struct drm_modeset_acquire_ctx *ctx) {
@@ -838,8 +838,8 @@ __intel_display_resume(struct drm_device *dev,struct drm_crtc *crtc;int i, ret; -intel_modeset_setup_hw_state (dev, ctx); -intel_vga_redisable (to_i915 (dev)); +intel_modeset_setup_hw_state (&i915->drm, ctx); +intel_vga_redisable (i915);if (!state)return 0 ;
@@ -859,12 +859,13 @@ __intel_display_resume(struct drm_device *dev, }/* ignore any reset values/BIOS leftovers in the WM registers */ -if (!HAS_GMCH (to_i915 (dev))) +if (!HAS_GMCH (i915))to_intel_atomic_state (state)->skip_intermediate_wm = true; ret =drm_atomic_helper_commit_duplicated_state (state, ctx); -drm_WARN_ON (dev, ret == -EDEADLK ); +drm_WARN_ON (&i915->drm, ret == -EDEADLK ); +return ret; }
@@ -937,56 +938,55 @@ void intel_display_prepare_reset(struct drm_i915_private *dev_priv) state->acquire_ctx = ctx; } -void intel_display_finish_reset (struct drm_i915_private *dev_priv) +void intel_display_finish_reset (struct drm_i915_private *i915) { -struct drm_device *dev = &dev_priv->drm; -struct drm_modeset_acquire_ctx *ctx = &dev_priv->reset_ctx; +struct drm_modeset_acquire_ctx *ctx = &i915->reset_ctx;struct drm_atomic_state *state;int ret; -if (!HAS_DISPLAY (dev_priv)) +if (!HAS_DISPLAY (i915))return ;/* reset doesn't touch the display */ -if (!test_bit (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags)) +if (!test_bit (I915_RESET_MODESET , &to_gt (i915)->reset.flags))return ; - state =fetch_and_zero (&dev_priv->modeset_restore_state); + state =fetch_and_zero (&i915->modeset_restore_state);if (!state) goto unlock;/* reset doesn't touch the display */ -if (!gpu_reset_clobbers_display (dev_priv)) { +if (!gpu_reset_clobbers_display (i915)) {/* for testing only restore the display */ - ret =__intel_display_resume (dev, state, ctx); + ret =__intel_display_resume (i915, state, ctx);if (ret) -drm_err (&dev_priv->drm, +drm_err (&i915->drm,"Restoring old state failed with %i\n" , ret); }else {/* * The display has been reset as well, * so need a full re-initialization. */ -intel_pps_unlock_regs_wa (dev_priv); -intel_modeset_init_hw (dev_priv); -intel_init_clock_gating (dev_priv); -intel_hpd_init (dev_priv); +intel_pps_unlock_regs_wa (i915); +intel_modeset_init_hw (i915); +intel_init_clock_gating (i915); +intel_hpd_init (i915); - ret =__intel_display_resume (dev, state, ctx); + ret =__intel_display_resume (i915, state, ctx);if (ret) -drm_err (&dev_priv->drm, +drm_err (&i915->drm,"Restoring old state failed with %i\n" , ret); -intel_hpd_poll_disable (dev_priv); +intel_hpd_poll_disable (i915); }drm_atomic_state_put (state); unlock:drm_modeset_drop_locks (ctx);drm_modeset_acquire_fini (ctx); -mutex_unlock (&dev->mode_config.mutex); +mutex_unlock (&i915->drm.mode_config.mutex); -clear_bit_unlock (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags); +clear_bit_unlock (I915_RESET_MODESET , &to_gt (i915)->reset.flags); }static void icl_set_pipe_chicken (const struct intel_crtc_state *crtc_state)
@@ -8921,15 +8921,15 @@ void i830_disable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe)void intel_display_resume (struct drm_device *dev) { -struct drm_i915_private *dev_priv =to_i915 (dev); -struct drm_atomic_state *state = dev_priv->modeset_restore_state; +struct drm_i915_private *i915 =to_i915 (dev); +struct drm_atomic_state *state = i915->modeset_restore_state;struct drm_modeset_acquire_ctx ctx;int ret; -if (!HAS_DISPLAY (dev_priv)) +if (!HAS_DISPLAY (i915))return ; - dev_priv->modeset_restore_state =NULL ; + i915->modeset_restore_state =NULL ;if (state) state->acquire_ctx = &ctx;
@@ -8944,14 +8944,14 @@ void intel_display_resume(struct drm_device *dev) }if (!ret) - ret =__intel_display_resume (dev, state, &ctx); + ret =__intel_display_resume (i915, state, &ctx); -intel_enable_ipc (dev_priv); +intel_enable_ipc (i915);drm_modeset_drop_locks (&ctx);drm_modeset_acquire_fini (&ctx);if (ret) -drm_err (&dev_priv->drm, +drm_err (&i915->drm,"Restoring old state failed with %i\n" , ret);if (state)drm_atomic_state_put (state);
Signature · 1 line
2.30.2
PATCH v2 11/11 drm/i915/display: convert modeset setup to struct drm_i915_private *i915
In reply to Jani NikulaPass struct drm_i915_private * instead of struct drm_device *, and rename dev_priv to i915.
--- drivers/gpu/drm/i915/display/intel_display.c | 4 +- .../drm/i915/display/intel_modeset_setup.c | 199 +++++++++--------- .../drm/i915/display/intel_modeset_setup.h | 4 +- 3 files changed, 102 insertions(+), 105 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -2
@@ -838,7 +838,7 @@ __intel_display_resume(struct drm_i915_private *i915,struct drm_crtc *crtc;int i, ret; -intel_modeset_setup_hw_state (&i915->drm, ctx); +intel_modeset_setup_hw_state (i915, ctx);intel_vga_redisable (i915);if (!state)
@@ -8766,7 +8766,7 @@ int intel_modeset_init_nogem(struct drm_i915_private *i915)intel_setup_outputs (i915);drm_modeset_lock_all (dev); -intel_modeset_setup_hw_state (dev, dev->mode_config.acquire_ctx); +intel_modeset_setup_hw_state (i915, dev->mode_config.acquire_ctx);intel_acpi_assign_connector_fwnodes (i915);drm_modeset_unlock_all (dev);
drivers/gpu/drm/i915/display/intel_modeset_setup.c +98 -101
530 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_modeset_setup.h +2 -2
@@ -6,10 +6,10 @@#ifndef __INTEL_MODESET_SETUP_H__#define __INTEL_MODESET_SETUP_H__ -struct drm_device ; +struct drm_i915_private ;struct drm_modeset_acquire_ctx ; -void intel_modeset_setup_hw_state (struct drm_device *dev, +void intel_modeset_setup_hw_state (struct drm_i915_private *i915,struct drm_modeset_acquire_ctx *ctx);#endif /* __INTEL_MODESET_SETUP_H__ */
Signature · 1 line
2.30.2
Quoted 23 lines · Jani Nikula
v2 of [1]. Address review comments, drop crtc state compare move, add hw state readout&sanitization split, and sprinkle some struct
drm_i915_private*i915 cleanups on top.BR,
Jani.[1] https://patchwork.freedesktop.org/series/105156/
Jani Nikula (11):
drm/i915/wm: move wm state verification tointel_pm.cdrm/i915/dpll: move shared dpll state verification tointel_dpll_mgr.cdrm/i915/mpllb: useI915_STATE_WARN()for state mismatch warnings drm/i915/mpllb: move mpllb state check tointel_snps_phy.cdrm/i915/display: split out modeset verification code drm/i915/display: split out crtc state dump to a separate file drm/i915/display: change who adds [] around crtc state dump context
string
drm/i915/display: renamedev_priv-> i915 in crtc state dump drm/i915/display: split out hw state readout and sanitize drm/i915/display: some structdrm_i915_private*i915 conversions drm/i915/display: convert modeset setup to structdrm_i915_private
Quoted 1 line
*i915
Series is
Quoted 26 lines
drivers/gpu/drm/i915/Makefile | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 314 +++ .../drm/i915/display/intel_crtc_state_dump.h | 16 + drivers/gpu/drm/i915/display/intel_display.c | 1680 +---------------- drivers/gpu/drm/i915/display/intel_display.h | 18 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 + .../drm/i915/display/intel_modeset_setup.c | 724 +++++++ .../drm/i915/display/intel_modeset_setup.h | 15 + .../drm/i915/display/intel_modeset_verify.c | 246 +++ .../drm/i915/display/intel_modeset_verify.h | 21 + drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 + drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +- drivers/gpu/drm/i915/intel_pm.c | 138 +- drivers/gpu/drm/i915/intel_pm.h | 14 +- 15 files changed, 1724 insertions(+), 1606 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.hSignature · 1 line
2.30.2
Signature · 2 lines
Ville Syrjälä Intel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
URL : https://patchwork.freedesktop.org/series/105220/
State : warning
== Summary ==
Error: dim checkpatch failedab29d65b77e1 drm/i915/wm: move wm state verification to intel_pm.cd7c89dd74933 drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13:
v2: intel_shared_dpll_verify_state -> intel_shared_dpll_state_verify (Ville)
total: 0 errors, 1 warnings, 0 checks, 215 lines checked3fb0167385c7 drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings -:32: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__name' - possible side-effects? #32: FILE: drivers/gpu/drm/i915/display/intel_display.c:6604:
+#define MPLLB_CHECK(__name) \
+ I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \
+ "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \
+ crtc->base.base.id, crtc->base.name, \
+ __stringify(__name), \
+ mpllb_sw_state->__name, mpllb_hw_state.__name)
-:32: CHECK:MACRO_ARG_PRECEDENCE: Macro argument '__name' may be better as '(__name)' to avoid precedence issues #32: FILE: drivers/gpu/drm/i915/display/intel_display.c:6604:
+#define MPLLB_CHECK(__name) \
+ I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \
+ "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \
+ crtc->base.base.id, crtc->base.name, \
+ __stringify(__name), \
+ mpllb_sw_state->__name, mpllb_hw_state.__name)
total: 0 errors, 0 warnings, 2 checks, 20 lines checked2c6e11c59640 drm/i915/mpllb: move mpllb state check to intel_snps_phy.c -:108: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__name' - possible side-effects? #108: FILE: drivers/gpu/drm/i915/display/intel_snps_phy.c:835:
+#define MPLLB_CHECK(__name) \
+ I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \
+ "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \
+ crtc->base.base.id, crtc->base.name, \
+ __stringify(__name), \
+ mpllb_sw_state->__name, mpllb_hw_state.__name)
-:108: CHECK:MACRO_ARG_PRECEDENCE: Macro argument '__name' may be better as '(__name)' to avoid precedence issues #108: FILE: drivers/gpu/drm/i915/display/intel_snps_phy.c:835:
+#define MPLLB_CHECK(__name) \
+ I915_STATE_WARN(mpllb_sw_state->__name != mpllb_hw_state.__name, \
+ "[CRTC:%d:%s] mismatch in MPLLB: %s (expected 0x%08x, found 0x%08x)", \
+ crtc->base.base.id, crtc->base.name, \
+ __stringify(__name), \
+ mpllb_sw_state->__name, mpllb_hw_state.__name)
total: 0 errors, 0 warnings, 2 checks, 121 lines checked2dc25c9664a8 drm/i915/display: split out modeset verification code
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:365: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #365:
new file mode 100644
-:459: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #459: FILE: drivers/gpu/drm/i915/display/intel_modeset_verify.c:90:
+ int fdi_dotclock = intel_dotclock_calculate(intel_fdi_link_freq(dev_priv, pipe_config),
total: 0 errors, 2 warnings, 0 checks, 585 lines checked7ed4eeeef068 drm/i915/display: split out crtc state dump to a separate file Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:27: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #27:
new file mode 100644
-:90: ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #90: FILE: drivers/gpu/drm/i915/display/intel_crtc_state_dump.c:59:
+#define OUTPUT_TYPE(x) [INTEL_OUTPUT_ ## x] = #x
total: 1 errors, 1 warnings, 0 checks, 708 lines checked6001a929f514 drm/i915/display: change who adds [] around crtc state dump context string 24883fc54e92 drm/i915/display: rename dev_priv -> i915 in crtc state dump b8c70fc5cfcd drm/i915/display: split out hw state readout and sanitize Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:283: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#283: FILE: drivers/gpu/drm/i915/display/intel_display.c:7532:
+ intel_modeset_get_crtc_power_domains(new_crtc_state, &put_domains[crtc->pipe]);
-:913: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #913:
new file mode 100644
-:1388: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #1388: FILE: drivers/gpu/drm/i915/display/intel_modeset_setup.c:471:
+ intel_crtc_bigjoiner_slave_pipes(crtc_state)) {
-:1391: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1391: FILE: drivers/gpu/drm/i915/display/intel_modeset_setup.c:474:
+ slave_crtc_state = to_intel_crtc_state(slave_crtc->base.state);
total: 0 errors, 4 warnings, 0 checks, 1609 lines checked5a3aa1448abb drm/i915/display: some struct drm_i915_private *i915 conversions bb615290f6ce drm/i915/display: convert modeset setup to struct drm_i915_private *i915
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
URL : https://patchwork.freedesktop.org/series/105220/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
URL : https://patchwork.freedesktop.org/series/105220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11767 -> Patchwork_105220v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/index.html
Participating hosts (42 -> 42)
------------------------------
Additional (2): bat-adlm-1 bat-atsm-1
Missing (2): fi-kbl-soraka fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_105220v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [PASS][1] -> [DMESG-WARN][2] ([i915#1888] / [i915#62])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/fi-cfl-8109u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/fi-cfl-8109u/igt@[email protected]
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][3] -> [DMESG-FAIL][4] ([i915#4528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/fi-pnv-d510/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/fi-pnv-d510/igt@i915_selftest@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-4: [PASS][5] -> [DMESG-WARN][6] ([i915#3576])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/bat-adlp-4/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/bat-adlp-4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- fi-tgl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/fi-tgl-u2/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/fi-tgl-u2/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-cfl-8109u: [PASS][9] -> [DMESG-WARN][10] ([i915#62]) +15 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/fi-cfl-8109u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/fi-cfl-8109u/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][11] ([i915#4494] / [i915#4957]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/bat-dg1-5/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/bat-dg1-5/igt@i915_selftest@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][13] ([i915#3576]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/bat-adlp-6/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/bat-adlp-6/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- bat-adlp-4: [DMESG-WARN][15] ([i915#3576]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/bat-adlp-4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/bat-adlp-4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#6103]: https://gitlab.freedesktop.org/drm/intel/issues/6103
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6244]: https://gitlab.freedesktop.org/drm/intel/issues/6244
Build changes
-------------
* Linux: CI_DRM_11767 -> Patchwork_105220v1
CI-20190529: 20190529
CI_DRM_11767: 822a8442835012ce405080cb40f6317ef1e854ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6533: 6b5107d91827962808441db6b98e478aa9e67bdb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105220v1: 822a8442835012ce405080cb40f6317ef1e854ac @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
0beb94edef12 drm/i915/display: convert modeset setup to struct drm_i915_private *i915 afb90dc7cc3c drm/i915/display: some struct drm_i915_private *i915 conversions 14862dd9c28d drm/i915/display: split out hw state readout and sanitize 07649d13b56d drm/i915/display: rename dev_priv -> i915 in crtc state dump 51cbfeafca41 drm/i915/display: change who adds [] around crtc state dump context string 4df5ac8be996 drm/i915/display: split out crtc state dump to a separate file 4b5cf8b359c4 drm/i915/display: split out modeset verification code b1fa5b079924 drm/i915/mpllb: move mpllb state check to intel_snps_phy.c 6b760249d4d5 drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings 7973e5603a12 drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c b8f53ec1f446 drm/i915/wm: move wm state verification to intel_pm.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: drm/i915/display: split out verification, hw readout and dump from intel_display.c
URL : https://patchwork.freedesktop.org/series/105220/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11767_full -> Patchwork_105220v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105220v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_105220v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105220v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-tglb: [PASS][1] -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb5/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_105220v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ccs@block-copy-compressed:
- shard-iclb: NOTRUN -> [SKIP][3] ([i915#5327])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-apl: [PASS][4] -> [DMESG-WARN][5] ([i915#180]) +5 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl3/igt@gem_ctx_isolation@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl8/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb8/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-kbl1/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-glk5/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-glk1/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb2/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_params@secure-non-root:
- shard-iclb: NOTRUN -> [SKIP][15] ([fdo#112283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][16] -> [SKIP][17] ([i915#2190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb8/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#2190])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271]) +20 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-snb5/igt@[email protected]
* igt@gem_mmap_gtt@coherency:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109292])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_pxp@create-regular-buffer:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#4270])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][24] ([i915#768]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3323])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([i915#5566] / [i915#716])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl2/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl3/igt@[email protected]
* igt@gen9_exec_parse@bb-start-cmd:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][29] -> [TIMEOUT][30] ([i915#3953])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb5/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-skl: NOTRUN -> [FAIL][31] ([i915#454])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl1/igt@[email protected]
* igt@i915_selftest@live@gt_engines:
- shard-tglb: [PASS][32] -> [DMESG-WARN][33] ([i915#2867]) +14 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb6/igt@i915_selftest@live@gt_engines.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb5/igt@i915_selftest@live@gt_engines.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [PASS][34] -> [INCOMPLETE][35] ([i915#4817] / [i915#4939])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-skl10/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#5286])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#110723])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [i915#3886])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271]) +12 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs.html
* igt@kms_cdclk@mode-transition:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#3742])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_chamelium@dp-crc-single:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +9 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109284] / [fdo#111827]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278]) +6 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-iclb: NOTRUN -> [FAIL][47] ([i915#2346])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [PASS][48] -> [FAIL][49] ([i915#2346])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#533]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109274]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_flip@plain-flip-ts-check@b-edp1:
- shard-skl: [PASS][52] -> [FAIL][53] ([i915#2122]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-skl6/igt@kms_flip@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3701])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109280]) +7 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
- shard-iclb: [PASS][56] -> [FAIL][57] ([i915#1888])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb8/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-skl: [PASS][58] -> [DMESG-WARN][59] ([i915#1982])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [PASS][60] -> [FAIL][61] ([i915#1188])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-kbl6/igt@kms_hdr@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-kbl6/igt@kms_hdr@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][62] -> [SKIP][63] ([i915#5176]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-edp-1:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271]) +177 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl6/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][67] -> [SKIP][68] ([fdo#109642] / [fdo#111068] / [i915#658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb6/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][69] -> [SKIP][70] ([fdo#109441]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109441])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-kbl: [PASS][72] -> [SKIP][73] ([fdo#109271])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-kbl4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-kbl4/igt@[email protected]
* igt@kms_vrr@flipline:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#3555])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278] / [i915#2530])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
* igt@perf@polling-small-buf:
- shard-skl: [PASS][76] -> [FAIL][77] ([i915#1722])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-skl1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl7/igt@[email protected]
* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109291]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@prime_udl.html
* igt@sysfs_clients@fair-7:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl1/igt@[email protected]
* igt@sysfs_clients@sema-50:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#2994])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@info:
- {shard-rkl}: [SKIP][81] ([i915#2582]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][83] ([i915#6252]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-5/igt@gem_ctx_persistence@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-1/igt@gem_ctx_persistence@[email protected]
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][85] ([i915#3063]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglu-3/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglu-3/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][87] ([i915#4525]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb7/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb4/igt@[email protected]
* igt@gem_exec_capture@pi@vcs0:
- shard-iclb: [INCOMPLETE][89] ([i915#3371]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb6/igt@gem_exec_capture@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb7/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl6/igt@gem_exec_fair@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][93] ([i915#2842]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-kbl1/igt@gem_exec_fair@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][95] ([i915#2842]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb5/igt@gem_exec_fair@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-gtt-wc:
- {shard-rkl}: [SKIP][97] ([i915#3281]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@reads:
- {shard-rkl}: [SKIP][99] ([i915#3282]) -> [PASS][100] +4 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-secure:
- {shard-rkl}: [SKIP][101] ([i915#2527]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-5/igt@[email protected]
* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][103] -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-5/igt@i915_hangman@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-1/igt@i915_hangman@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [DMESG-WARN][105] ([i915#6201]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-snb6/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-snb5/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][107] ([i915#454]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb3/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb6/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- {shard-tglu}: [WARN][109] ([i915#2681]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglu-1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglu-1/igt@[email protected]
* igt@kms_atomic@plane-primary-legacy:
- shard-snb: [SKIP][111] ([fdo#109271]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-snb6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-snb5/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-25:
- {shard-rkl}: [SKIP][113] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen:
- {shard-rkl}: [SKIP][115] ([fdo#112022] / [i915#4070]) -> [PASS][116] +6 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- {shard-rkl}: [SKIP][117] ([fdo#111825] / [i915#4070]) -> [PASS][118] +6 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@pipe-c-torture-bo:
- {shard-rkl}: [SKIP][119] ([i915#4070]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-5/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- {shard-rkl}: [SKIP][121] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][122] +5 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_fbcon_fbt@psr:
- {shard-rkl}: [SKIP][123] ([fdo#110189] / [i915#3955]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][125] ([i915#180]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl7/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [FAIL][127] ([i915#2122]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-skl6/igt@kms_flip@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt:
- {shard-rkl}: [SKIP][129] ([i915#1849] / [i915#4098]) -> [PASS][130] +22 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [FAIL][131] ([i915#1188]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-kbl6/igt@kms_hdr@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-kbl6/igt@kms_hdr@[email protected]
* igt@kms_invalid_mode@zero-hdisplay:
- {shard-rkl}: [SKIP][133] ([i915#4278]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@pixel-format@pipe-a-planes:
- {shard-rkl}: [SKIP][135] ([i915#1849] / [i915#3558]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@kms_plane@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
- {shard-rkl}: [SKIP][137] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][138] +3 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][139] ([i915#5235]) -> [PASS][140] +2 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb2/igt@kms_plane_scaling@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb6/igt@kms_plane_scaling@[email protected]
* igt@kms_prime@basic-crc@second-to-first:
- {shard-rkl}: [SKIP][141] ([i915#1849]) -> [PASS][142] +2 similar issues
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@kms_prime@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@kms_prime@[email protected]
* igt@kms_psr@cursor_mmap_cpu:
- {shard-rkl}: [SKIP][143] ([i915#1072]) -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@kms_psr@cursor_mmap_cpu.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][145] ([fdo#109441]) -> [PASS][146] +1 similar issue
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb5/igt@kms_psr@psr2_primary_render.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb2/igt@kms_psr@psr2_primary_render.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][147] ([i915#5519]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb2/igt@[email protected]
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-iclb: [SKIP][149] ([i915#5519]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb7/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb1/igt@[email protected]
* igt@kms_universal_plane@universal-plane-pipe-b-sanity:
- {shard-rkl}: [SKIP][151] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][152] +1 similar issue
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-b-query-forked:
- {shard-rkl}: [SKIP][153] ([i915#1845] / [i915#4098]) -> [PASS][154] +26 similar issues
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
* igt@perf@gen8-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][155] ([i915#2436]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-2/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-5/igt@[email protected]
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][157] ([i915#1722]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-rkl-1/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-rkl-6/igt@[email protected]
#### Warnings ####
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: [DMESG-FAIL][159] ([i915#2373]) -> [DMESG-FAIL][160] ([i915#2373] / [i915#2867])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb6/igt@i915_selftest@live@gt_lrc.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb5/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: [DMESG-FAIL][161] ([i915#1759]) -> [DMESG-FAIL][162] ([i915#1759] / [i915#2867])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-tglb6/igt@i915_selftest@live@gt_pm.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-tglb5/igt@i915_selftest@live@gt_pm.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][163] ([fdo#111068] / [i915#658]) -> [SKIP][164] ([i915#2920])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-iclb5/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][165], [FAIL][166], [FAIL][167]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][168], [FAIL][169], [FAIL][170], [FAIL][171], [FAIL][172], [FAIL][173], [FAIL][174]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl7/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl7/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11767/shard-apl1/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl3/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl8/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl4/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl1/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl8/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/shard-apl3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109292]: https://bugs.freedesktop.org/show_bug.cgi?id=109292
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3953]: https://gitlab.freedesktop.org/drm/intel/issues/3953
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6201]: https://gitlab.freedesktop.org/drm/intel/issues/6201
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
Build changes
-------------
* Linux: CI_DRM_11767 -> Patchwork_105220v1
CI-20190529: 20190529
CI_DRM_11767: 822a8442835012ce405080cb40f6317ef1e854ac @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6533: 6b5107d91827962808441db6b98e478aa9e67bdb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105220v1: 822a8442835012ce405080cb40f6317ef1e854ac @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105220v1/index.html
Quoted 26 lines · Ville Syrjälä
Quoted 23 lines · Jani Nikula
v2 of [1]. Address review comments, drop crtc state compare move, add hw state readout&sanitization split, and sprinkle some struct
drm_i915_private*i915 cleanups on top.BR,
Jani.[1] https://patchwork.freedesktop.org/series/105156/
Jani Nikula (11):
drm/i915/wm: move wm state verification tointel_pm.cdrm/i915/dpll: move shared dpll state verification tointel_dpll_mgr.cdrm/i915/mpllb: useI915_STATE_WARN()for state mismatch warnings drm/i915/mpllb: move mpllb state check tointel_snps_phy.cdrm/i915/display: split out modeset verification code drm/i915/display: split out crtc state dump to a separate file drm/i915/display: change who adds [] around crtc state dump context
string
drm/i915/display: renamedev_priv-> i915 in crtc state dump drm/i915/display: split out hw state readout and sanitize drm/i915/display: some structdrm_i915_private*i915 conversions drm/i915/display: convert modeset setup to structdrm_i915_privateQuoted 1 line
*i915
Quoted 2 lines
Series is
Reviewed-by Ville Syrjälä <[email protected]>
Thanks for the review, pushed everything except patches 9 and 11 which conflicted, will respin those shortly.
BR,
Jani.
Quoted 27 lines
Quoted 27 lines
drivers/gpu/drm/i915/Makefile | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 314 +++ .../drm/i915/display/intel_crtc_state_dump.h | 16 + drivers/gpu/drm/i915/display/intel_display.c | 1680 +---------------- drivers/gpu/drm/i915/display/intel_display.h | 18 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 + .../drm/i915/display/intel_modeset_setup.c | 724 +++++++ .../drm/i915/display/intel_modeset_setup.h | 15 + .../drm/i915/display/intel_modeset_verify.c | 246 +++ .../drm/i915/display/intel_modeset_verify.h | 21 + drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 + drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +- drivers/gpu/drm/i915/intel_pm.c | 138 +- drivers/gpu/drm/i915/intel_pm.h | 14 +- 15 files changed, 1724 insertions(+), 1606 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.hSignature · 1 line
2.30.2
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center