Skip to contentSkip to conversation

drm/i915: Apply waitboosting before fence wait

PATCH Superseded Karolina Drobnik 4 participants 14 messages Jul 5, 2022 – Jul 8, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#7 lore raw

PATCH 2/3 drm/i915: Bump GT idling delay to 2 jiffies

In reply to Karolina Drobnik

From: Chris Wilson <[email protected]>

In monitoring a transcode pipeline that is latency sensitive (it waits between submitting frames, and each frame requires work on rcs/vcs/vecs engines), it is found that it took longer than a single jiffy for it to sustain its workload. Allowing an extra jiffy headroom for the userspace prevents us from prematurely parking and having to exit powersaving immediately.

---
 drivers/gpu/drm/i915/i915_active.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_active.c +1 -1
index ee2b3a375362..7412abf166a8 100644
@@ -974,7 +974,7 @@ void i915_active_acquire_barrier(struct i915_active *ref)
 
 		GEM_BUG_ON(!intel_engine_pm_is_awake(engine));
 		llist_add(barrier_to_ll(node), &engine->barrier_tasks);
-		intel_engine_pm_put_delay(engine, 1);
+		intel_engine_pm_put_delay(engine, 2);
 	}
 }
 
Signature · 1 line
2.25.1
#10 lore raw

PATCH 3/3 drm/i915/gt: Only kick the signal worker if there's been an update

In reply to Karolina Drobnik

From: Chris Wilson <[email protected]>

One impact of commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") is that it stores many, many more fences. Whereas adding an exclusive fence used to remove the shared fence list, that list is now preserved and the write fences included into the list. Not just a single write fence, but now a write/read fence per context. That causes us to have to track more fences than before (albeit half of those are redundant), and we trigger more interrupts for multi-engine workloads.

As part of reducing the impact from handling more signaling, we observe we only need to kick the signal worker after adding a fence iff we have good cause to believe that there is work to be done in processing the fence i.e. we either need to enable the interrupt or the request is already complete but we don't know if we saw the interrupt and so need to check signaling.

References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")

---
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_breadcrumbs.c +2 -1
index 9dc9dccf7b09..ecc990ec1b95 100644
@@ -399,7 +399,8 @@ static void insert_breadcrumb(struct i915_request *rq)
 	 * the request as it may have completed and raised the interrupt as
 	 * we were attaching it into the lists.
 	 */
-	irq_work_queue(&b->irq_work);
+	if (!b->irq_armed || __i915_request_is_complete(rq))
+		irq_work_queue(&b->irq_work);
 }
 
 bool i915_request_enable_breadcrumb(struct i915_request *rq)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

In reply to Karolina Drobnik

From: Chris Wilson <[email protected]>

We employ a "waitboost" heuristic to detect when userspace is stalled waiting for results from earlier execution. Under latency sensitive work mixed between the gpu/cpu, the GPU is typically under-utilised and so RPS sees that low utilisation as a reason to downclock the frequency, causing longer stalls and lower throughput. The user left waiting for the results is not impressed.

On applying commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") it was observed that deinterlacing h264 on Haswell performance dropped by 2-5x. The reason being that the natural workload was not intense enough to trigger RPS (using HW evaluation intervals) to upclock, and so it was depending on waitboosting for the throughput.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the composition of dma-resv from keeping a single write fence + multiple read fences, to a single array of multiple write and read fences (a maximum of one pair of write/read fences per context). The iteration order was also changed implicitly from all-read fences then the single write fence, to a mix of write fences followed by read fences. It is that ordering change that belied the fragility of waitboosting.

Currently, a waitboost is inspected at the point of waiting on an outstanding fence. If the GPU is backlogged such that we haven't yet stated the request we need to wait on, we force the GPU to upclock until the completion of that request. By changing the order in which we waited upon requests, we ended up waiting on those requests in sequence and as such we saw that each request was already started and so not a suitable candidate for waitboosting.

Instead of asking whether to boost each fence in turn, we can look at whether boosting is required for the dma-resv ensemble prior to waiting on any fence, making the heuristic more robust to the order in which fences are stored in the dma-resv.

Fixes 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
Cc Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_wait.c | 35 ++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_wait.c +35 -0
index 319936f91ac5..3fbb464746e1 100644
@@ -9,6 +9,7 @@
 #include <linux/jiffies.h>
 
 #include "gt/intel_engine.h"
+#include "gt/intel_rps.h"
 
 #include "i915_gem_ioctls.h"
 #include "i915_gem_object.h"
@@ -31,6 +32,38 @@ i915_gem_object_wait_fence(struct dma_fence *fence,
 				      timeout);
 }
 
+static void
+i915_gem_object_boost(struct dma_resv *resv, unsigned int flags)
+{
+	struct dma_resv_iter cursor;
+	struct dma_fence *fence;
+
+	/*
+	 * Prescan all fences for potential boosting before we begin waiting.
+	 *
+	 * When we wait, we wait on outstanding fences serially. If the
+	 * dma-resv contains a sequence such as 1:1, 1:2 instead of a reduced
+	 * form 1:2, then as we look at each wait in turn we see that each
+	 * request is currently executing and not worthy of boosting. But if
+	 * we only happen to look at the final fence in the sequence (because
+	 * of request coalescing or splitting between read/write arrays by
+	 * the iterator), then we would boost. As such our decision to boost
+	 * or not is delicately balanced on the order we wait on fences.
+	 *
+	 * So instead of looking for boosts sequentially, look for all boosts
+	 * upfront and then wait on the outstanding fences.
+	 */
+
+	dma_resv_iter_begin(&cursor, resv,
+			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}
+	dma_resv_iter_end(&cursor);
+}
+
 static long
 i915_gem_object_wait_reservation(struct dma_resv *resv,
 				 unsigned int flags,
@@ -40,6 +73,8 @@ i915_gem_object_wait_reservation(struct dma_resv *resv,
 	struct dma_fence *fence;
 	long ret = timeout ?: 1;
 
+	i915_gem_object_boost(resv, flags);
+
 	dma_resv_iter_begin(&cursor, resv,
 			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
 	dma_resv_for_each_fence_unlocked(&cursor, fence) {
Signature · 1 line
2.25.1
#0 lore raw

cover drm/i915: Apply waitboosting before fence wait

Waitboost is a heuristic that detects latency sensitive workloads waiting for the results from previous execution. The wait can be seen as GPU under-utilisation by RPS, Render Power State management, which might lower the GPU frequency to save power. Limiting the frequency means more waiting for results, which is undesirable for submissions with tight time constraints. To circumvent this, with waitboost we iteratively check the list of fences during gem_wait to see if any of them is stalled waiting for GPU. If such is found, and the request hasn't yet started its execution, we temporarily bump up the GPU frequency, so we get the required results as soon as possible.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the fences order and how they are iterated. Under this new scheme, we would wait on each fence that starts executing, rendering them not suitable for waitboost.

To avoid situation like this, inspect the entire list of fences dma-resv earlier, before gem_wait, instead of sequentially waiting for each of them, applying the boost when needed.

Test-with: [email protected]

Chris Wilson (3):
drm/i915/gem: Look for waitboosting across the whole object prior to
individual waits
drm/i915: Bump GT idling delay to 2 jiffies
drm/i915/gt: Only kick the signal worker if there's been an update

 drivers/gpu/drm/i915/gem/i915_gem_wait.c    | 35 +++++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c |  3 +-
 drivers/gpu/drm/i915/i915_active.c          |  2 +-
 3 files changed, 38 insertions(+), 2 deletions(-)

--
2.25.1

#11 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Apply waitboosting before fence wait

== Series Details ==

== Series Details ==

Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : warning

== Summary ==

Error: dim checkpatch failed
3102ce715842 drm/i915/gem: Look for waitboosting across the whole object prior to individual waits bc7ab100fb8f drm/i915: Bump GT idling delay to 2 jiffies
0c81ea0e8458 drm/i915/gt: Only kick the signal worker if there's been an update
-:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #23:
References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")

-:23: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")' #23:
References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")

total: 1 errors, 1 warnings, 0 checks, 9 lines checked

#12 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Apply waitboosting before fence wait

In reply to Karolina Drobnik
== Series Details ==

== Series Details ==

Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11849 -> Patchwork_105925v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/index.html

Participating hosts (43 -> 39)
------------------------------

Additional (1): fi-bxt-dsi
Missing (5): fi-bdw-5557u fi-tgl-u2 fi-cfl-guc fi-apl-guc bat-jsl-1

Known issues
------------

Here are the changes found in Patchwork_105925v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: [PASS][1] -> [FAIL][2] ([fdo#103375])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-rkl-11600/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-bxt-dsi: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bxt-dsi/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bxt-dsi: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bxt-dsi/igt@[email protected]

* igt@gem_tiled_blits@basic:
- fi-bxt-dsi: NOTRUN -> [SKIP][5] ([fdo#109271]) +12 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bxt-dsi/igt@[email protected]

* igt@i915_selftest@live@gem:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][6] ([i915#4528])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][7] -> [DMESG-FAIL][8] ([i915#4494] / [i915#4957])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-dg1-5/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-dg1-5/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [PASS][9] -> [DMESG-FAIL][10] ([i915#3428])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html

* igt@kms_busy@basic@flip:
- bat-adlp-4: [PASS][11] -> [DMESG-WARN][12] ([i915#3576])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-adlp-4/igt@kms_busy@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-adlp-4/igt@kms_busy@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-bxt-dsi: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bxt-dsi/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][14] -> [FAIL][15] ([i915#6298])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][16] ([fdo#109271] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-bsw-nick/igt@[email protected]

#### Possible fixes ####

* igt@gem_ringfill@basic-all:
- {bat-dg2-9}: [FAIL][17] ([i915#5886]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-dg2-9/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-dg2-9/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-8109u: [DMESG-FAIL][19] ([i915#5334]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_timelines:
- {bat-dg2-9}: [DMESG-WARN][21] ([i915#5763]) -> [PASS][22] +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-dg2-9/igt@i915_selftest@live@gt_timelines.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-dg2-9/igt@i915_selftest@live@gt_timelines.html

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][23] ([i915#4528]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/fi-pnv-d510/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][25] ([i915#3576]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-adlp-6/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-adlp-6/igt@kms_flip@[email protected]

* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- bat-adlp-4: [DMESG-WARN][27] ([i915#3576]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/bat-adlp-4/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/bat-adlp-4/igt@kms_flip@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5886]: https://gitlab.freedesktop.org/drm/intel/issues/5886
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298

Build changes
-------------

* IGT: IGT_6555 -> IGTPW_7461
* Linux: CI_DRM_11849 -> Patchwork_105925v1

CI-20190529: 20190529
CI_DRM_11849: 66197f3ca0b462799e265b002dc5cf8dcec1c62d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7461: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7461/index.html
IGT_6555: 1a3ffecd400b8f82c35745fa2e07992f6bdeede2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105925v1: 66197f3ca0b462799e265b002dc5cf8dcec1c62d @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

6ef30cc35957 drm/i915/gt: Only kick the signal worker if there's been an update 53622b3017f7 drm/i915: Bump GT idling delay to 2 jiffies
93c23c739ceb drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/index.html

#13 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Apply waitboosting before fence wait

In reply to Karolina Drobnik
== Series Details ==

== Series Details ==

Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_105925v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (12 -> 12)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_105925v1_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- {shard-rkl}: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html

* {igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode}:
- shard-iclb: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1:
- {shard-tglu}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglu-5/igt@kms_pipe_crc_basic@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglu-1/igt@kms_pipe_crc_basic@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_11849_full and Patchwork_105925v1_full:

### New IGT tests (2) ###

* igt@i915_pm_rps@fence-order:
- Statuses : 9 pass(s)
- Exec time: [0.01, 0.07] s

* igt@kms_color@ctm-green-to-red@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.44] s

Known issues
------------

Here are the changes found in Patchwork_105925v1_full that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- shard-skl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [FAIL][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52]) ([i915#5032])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl10/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl10/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl10/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl10/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl6/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl7/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl7/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/boot.html

### IGT changes ###

#### Issues hit ####

* igt@device_reset@unbind-reset-rebind:
- shard-snb: [PASS][53] -> [DMESG-WARN][54] ([i915#4528])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-snb5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-snb2/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-kbl: [PASS][55] -> [DMESG-WARN][56] ([i915#180]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@gem_ctx_isolation@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#1099])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-snb6/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][58] ([i915#2410])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb5/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][59] -> [SKIP][60] ([i915#4525]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb7/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][61] -> [FAIL][62] ([i915#2842]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglb2/igt@gem_exec_fair@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][63] -> [FAIL][64] ([i915#2842]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk2/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][65] -> [FAIL][66] ([i915#2842]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-queues:
- shard-snb: NOTRUN -> [SKIP][67] ([fdo#109271]) +57 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-snb6/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2190])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#4613]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl1/igt@[email protected]

* igt@gem_lmem_swapping@heavy-random:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@gem_lmem_swapping@verify-random-ccs:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@[email protected]

* igt@gem_pxp@display-protected-crc:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#4270])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#4270])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@[email protected]

* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][74] ([i915#4171])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl8/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][75] ([i915#4171])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-kbl: NOTRUN -> [DMESG-WARN][76] ([i915#180]) +5 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][77] ([i915#4991])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
- shard-skl: NOTRUN -> [DMESG-WARN][78] ([i915#4991])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#3297])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#3297])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@[email protected]

* igt@gen3_render_tiledy_blits:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271]) +121 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/igt@gen3_render_tiledy_blits.html

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][82] -> [DMESG-WARN][83] ([i915#5566] / [i915#716])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-apl1/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl3/igt@[email protected]

* igt@gen9_exec_parse@secure-batches:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#2527] / [i915#2856])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb3/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#1937])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl6/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271]) +242 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][87] ([i915#1886])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][88] -> [DMESG-WARN][89] ([i915#5591])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglb1/igt@i915_selftest@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@i915_selftest@[email protected]

* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#5286])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#5286])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- shard-glk: [PASS][92] -> [FAIL][93] ([i915#1888] / [i915#5138])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk3/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk2/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111615]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][95] ([i915#3743]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#110723])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb8/igt@[email protected]

* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3886]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886]) +8 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
- shard-skl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3886]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl7/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#6095])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb3/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109278] / [i915#3886])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb8/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#3689] / [i915#3886])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#3886])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk9/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#3689])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@hdmi-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [fdo#111827]) +8 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [fdo#111827]) +4 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl8/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109284] / [fdo#111827])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk9/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109284] / [fdo#111827])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb7/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][110] ([fdo#109271] / [fdo#111827]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-snb2/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [fdo#111827]) +14 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][112] ([i915#1319])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- shard-tglb: NOTRUN -> [SKIP][113] ([i915#4103])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#4103])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb2/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-8bpc@pipe-a-hdmi-a-1:
- shard-glk: [PASS][115] -> [DMESG-WARN][116] ([i915#118] / [i915#1888])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk1/igt@kms_dither@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk2/igt@kms_dither@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#5287])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#5287])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb5/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: NOTRUN -> [INCOMPLETE][119] ([i915#180] / [i915#4939])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl6/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109274])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb7/igt@kms_flip@2x-wf_vblank-ts-check.html
- shard-tglb: NOTRUN -> [SKIP][121] ([fdo#109274] / [fdo#111825] / [i915#3637])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb5/igt@kms_flip@2x-wf_vblank-ts-check.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][122] -> [FAIL][123] ([i915#79])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/igt@kms_flip@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [PASS][124] -> [FAIL][125] ([i915#2122])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk2/igt@kms_flip@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][126] -> [DMESG-WARN][127] ([i915#180])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-apl4/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [PASS][128] -> [FAIL][129] ([i915#2122]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl9/igt@kms_flip@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][130] ([i915#2672]) +4 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb7/igt@kms_flip_scaled_crc@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][131] ([fdo#109280] / [fdo#111825]) +4 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu.html
- shard-iclb: NOTRUN -> [SKIP][132] ([fdo#109280]) +4 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][133] ([fdo#109271]) +27 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-apl: NOTRUN -> [SKIP][134] ([fdo#109271]) +120 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-tglb: NOTRUN -> [SKIP][135] ([i915#3555]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@[email protected]

* igt@kms_hdr@static-toggle-suspend:
- shard-iclb: NOTRUN -> [SKIP][136] ([i915#3555]) +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@[email protected]

* igt@kms_mmap_write_crc@main:
- shard-skl: [PASS][137] -> [SKIP][138] ([fdo#109271]) +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][139] ([fdo#108145] / [i915#265]) +3 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][141] ([i915#265])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][142] ([fdo#108145] / [i915#265]) +2 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl4/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-primary-size-256:
- shard-iclb: NOTRUN -> [SKIP][143] ([fdo#109278]) +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-tglb: NOTRUN -> [SKIP][144] ([i915#1836])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@kms_prime@[email protected]
- shard-iclb: NOTRUN -> [SKIP][145] ([i915#1836])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb5/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][146] ([fdo#109271] / [i915#658])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl2/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][147] ([fdo#109271] / [i915#658])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-kbl: NOTRUN -> [SKIP][148] ([fdo#109271] / [i915#658]) +2 similar issues
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][149] ([i915#132] / [i915#3467])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb8/igt@kms_psr@psr2_cursor_mmap_gtt.html
- shard-iclb: NOTRUN -> [SKIP][150] ([fdo#109441])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_gtt.html

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][151] -> [SKIP][152] ([fdo#109441])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb5/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][153] -> [SKIP][154] ([i915#5519])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglb7/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- shard-iclb: NOTRUN -> [SKIP][155] ([i915#5030]) +2 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@kms_scaling_modes@[email protected]

* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][156] ([i915#5030]) +3 similar issues
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@kms_scaling_modes@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][157] ([fdo#109271] / [i915#533])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][158] ([fdo#109271] / [i915#2437])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl3/igt@[email protected]

* igt@perf@polling-small-buf:
- shard-skl: [PASS][159] -> [FAIL][160] ([i915#1722])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl1/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl10/igt@[email protected]

* igt@prime_nv_api@i915_self_import_to_different_fd:
- shard-tglb: NOTRUN -> [SKIP][161] ([fdo#109291])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb1/igt@prime_nv_api@i915_self_import_to_different_fd.html
- shard-iclb: NOTRUN -> [SKIP][162] ([fdo#109291])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@prime_nv_api@i915_self_import_to_different_fd.html

* igt@sw_sync@sync_merge_same:
- shard-kbl: NOTRUN -> [FAIL][163] ([i915#6140])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@sw_sync@sync_merge_same.html

* igt@sw_sync@sync_multi_timeline_wait:
- shard-apl: NOTRUN -> [FAIL][164] ([i915#6140])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl6/igt@sw_sync@sync_multi_timeline_wait.html

* igt@sysfs_clients@create:
- shard-kbl: NOTRUN -> [SKIP][165] ([fdo#109271] / [i915#2994]) +3 similar issues
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]

* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][166] ([fdo#109271] / [i915#2994])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@[email protected]

* igt@sysfs_clients@recycle:
- shard-apl: NOTRUN -> [SKIP][167] ([fdo#109271] / [i915#2994]) +2 similar issues
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][168] ([i915#2994])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][169] ([fdo#109271] / [i915#2994])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][170] ([i915#2994])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb4/igt@[email protected]

#### Possible fixes ####

* igt@drm_buddy@all@buddy_alloc_smoke:
- shard-skl: [INCOMPLETE][171] ([i915#5800]) -> [PASS][172]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl7/igt@drm_buddy@all@buddy_alloc_smoke.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@drm_buddy@all@buddy_alloc_smoke.html

* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][173] ([i915#6268]) -> [PASS][174]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-5/igt@[email protected]
- {shard-tglu}: [FAIL][175] ([i915#6268]) -> [PASS][176]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglu-8/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglu-2/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [SKIP][177] ([i915#4525]) -> [PASS][178]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb7/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-rkl}: [FAIL][179] ([i915#2842]) -> [PASS][180] +1 similar issue
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@gem_exec_fair@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][181] ([i915#2842]) -> [PASS][182]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-apl6/igt@gem_exec_fair@[email protected]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][183] ([i915#2842]) -> [PASS][184]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk9/igt@gem_exec_fair@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk2/igt@gem_exec_fair@[email protected]
- {shard-tglu}: [FAIL][185] ([i915#2842]) -> [PASS][186]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglu-5/igt@gem_exec_fair@[email protected]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglu-8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][187] ([i915#2842]) -> [PASS][188]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@gem_exec_fair@[email protected]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-write-read-noreloc:
- {shard-rkl}: [SKIP][189] ([i915#3281]) -> [PASS][190] +9 similar issues
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-6/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-5/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [DMESG-WARN][191] ([i915#118]) -> [PASS][192] +2 similar issues
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk9/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk6/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads:
- {shard-rkl}: [SKIP][193] ([i915#3282]) -> [PASS][194] +4 similar issues
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@[email protected]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-5/igt@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][195] ([i915#180]) -> [PASS][196] +2 similar issues
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-apl6/igt@[email protected]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl6/igt@[email protected]

* igt@gen9_exec_parse@bb-start-param:
- {shard-rkl}: [SKIP][197] ([i915#2527]) -> [PASS][198] +2 similar issues
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-5/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [DMESG-WARN][199] ([i915#6201]) -> [PASS][200]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-snb6/igt@[email protected]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-snb5/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][201] ([i915#3989] / [i915#454]) -> [PASS][202]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglu-1/igt@[email protected]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglu-2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][203] ([i915#454]) -> [PASS][204]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb1/igt@[email protected]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb7/igt@[email protected]
- {shard-rkl}: [FAIL][205] ([i915#3989]) -> [PASS][206]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-6/igt@[email protected]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: [SKIP][207] ([fdo#109308]) -> [PASS][208] +1 similar issue
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-skl: [FAIL][209] ([i915#3048]) -> [PASS][210]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@[email protected]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl10/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][211] ([i915#180]) -> [PASS][212] +3 similar issues
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [FAIL][213] ([i915#2346]) -> [PASS][214] +2 similar issues
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb5/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-iclb: [FAIL][215] -> [PASS][216]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb5/igt@kms_cursor_legacy@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- {shard-rkl}: [SKIP][217] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][218] +3 similar issues
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@[email protected]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][219] ([i915#79]) -> [PASS][220]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk8/igt@kms_flip@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][221] ([i915#2122]) -> [PASS][222]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@kms_flip@[email protected]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][223] ([i915#79]) -> [PASS][224]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@kms_flip@[email protected]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][225] ([i915#1849] / [i915#4098]) -> [PASS][226] +9 similar issues
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html

* igt@kms_invalid_mode@zero-hdisplay:
- {shard-rkl}: [SKIP][227] ([i915#4278]) -> [PASS][228]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- {shard-rkl}: [SKIP][229] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][230]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- {shard-rkl}: [SKIP][231] ([i915#1849] / [i915#3558] / [i915#4070]) -> [PASS][232]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_properties@crtc-properties-atomic:
- {shard-rkl}: [SKIP][233] ([i915#1849]) -> [PASS][234]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-5/igt@[email protected]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_psr@primary_blt:
- {shard-rkl}: [SKIP][235] ([i915#1072]) -> [PASS][236] +1 similar issue
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-5/igt@kms_psr@primary_blt.html
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@kms_psr@primary_blt.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][237] ([fdo#109441]) -> [PASS][238] +1 similar issue
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- {shard-rkl}: [SKIP][239] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][240] +2 similar issues
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@kms_vblank@pipe-a-wait-forked-hang:
- shard-skl: [SKIP][241] ([fdo#109271]) -> [PASS][242] +28 similar issues
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@[email protected]
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl1/igt@[email protected]

* igt@kms_vblank@pipe-b-wait-forked-hang:
- {shard-rkl}: [SKIP][243] ([i915#1845] / [i915#4098]) -> [PASS][244] +16 similar issues
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-5/igt@[email protected]
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-6/igt@[email protected]

* igt@perf@gen8-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][245] ([i915#2436]) -> [PASS][246]
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-rkl-2/igt@[email protected]
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-rkl-5/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-skl: [FAIL][247] ([i915#5639]) -> [PASS][248]
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@[email protected]
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl7/igt@[email protected]
- shard-apl: [FAIL][249] ([i915#5639]) -> [PASS][250]
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-apl8/igt@[email protected]
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-apl4/igt@[email protected]
- shard-glk: [FAIL][251] ([i915#5639]) -> [PASS][252]
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-glk2/igt@[email protected]
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-glk5/igt@[email protected]

#### Warnings ####

* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][253] ([i915#5784]) -> [TIMEOUT][254] ([i915#3063])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglb5/igt@[email protected]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb7/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][255] ([i915#4525]) -> [FAIL][256] ([i915#6117])
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb3/igt@[email protected]
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][257] ([i915#2842]) -> [FAIL][258] ([i915#2849])
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb7/igt@gem_exec_fair@[email protected]
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: [SKIP][259] ([fdo#109271]) -> [SKIP][260] ([fdo#109271] / [i915#3886])
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl10/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-random-ccs-data-4_tiled_dg2_rc_ccs:
- shard-skl: [SKIP][261] ([fdo#109271] / [i915#1888]) -> [SKIP][262] ([fdo#109271])
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl6/igt@kms_ccs@pipe-c-random-ccs-data-4_tiled_dg2_rc_ccs.html
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl9/igt@kms_ccs@pipe-c-random-ccs-data-4_tiled_dg2_rc_ccs.html

* igt@kms_chamelium@hdmi-audio:
- shard-skl: [SKIP][263] ([fdo#109271] / [fdo#111827] / [i915#1888]) -> [SKIP][264] ([fdo#109271] / [fdo#111827])
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl6/igt@[email protected]
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl6/igt@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-tglb: [SKIP][265] ([fdo#109300]) -> [SKIP][266] ([i915#1063])
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-tglb5/igt@kms_content_protection@mei_interface.html
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-tglb2/igt@kms_content_protection@mei_interface.html
- shard-iclb: [SKIP][267] ([fdo#109300]) -> [SKIP][268] ([fdo#109300] / [fdo#111066])
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb6/igt@kms_content_protection@mei_interface.html
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@kms_content_protection@mei_interface.html

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][269] ([i915#79]) -> [FAIL][270] ([i915#2122])
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@kms_flip@[email protected]
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-skl: [INCOMPLETE][271] -> [SKIP][272] ([fdo#109271])
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-skl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-skl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][273] ([i915#180] / [i915#1982]) -> [DMESG-WARN][274] ([i915#180])
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][275] ([fdo#111068] / [i915#658]) -> [SKIP][276] ([i915#2920])
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb7/igt@[email protected]
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [FAIL][277] ([i915#5939]) -> [SKIP][278] ([fdo#109642] / [fdo#111068] / [i915#658])
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-iclb6/igt@kms_psr2_su@page_flip-p010.html

* igt@runner@aborted:
- shard-kbl: ([FAIL][279], [FAIL][280], [FAIL][281], [FAIL][282], [FAIL][283], [FAIL][284], [FAIL][285], [FAIL][286], [FAIL][287], [FAIL][288], [FAIL][289], [FAIL][290], [FAIL][291], [FAIL][292]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][293], [FAIL][294], [FAIL][295], [FAIL][296], [FAIL][297], [FAIL][298], [FAIL][299], [FAIL][300], [FAIL][301], [FAIL][302], [FAIL][303], [FAIL][304], [FAIL][305], [FAIL][306]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl1/igt@[email protected]
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl4/igt@[email protected]
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl7/igt@[email protected]
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl7/igt@[email protected]
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl7/igt@[email protected]
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11849/shard-kbl7/igt@[email protected]
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl7/igt@[email protected]
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl6/igt@[email protected]
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl1/igt@[email protected]
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl4/igt@[email protected]
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/shard-kbl6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3048]: https://gitlab.freedesktop.org/drm/intel/issues/3048
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5800]: https://gitlab.freedesktop.org/drm/intel/issues/5800
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6201]: https://gitlab.freedesktop.org/drm/intel/issues/6201
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92

Build changes
-------------

* IGT: IGT_6555 -> IGTPW_7461
* Linux: CI_DRM_11849 -> Patchwork_105925v1

CI-20190529: 20190529
CI_DRM_11849: 66197f3ca0b462799e265b002dc5cf8dcec1c62d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7461: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7461/index.html
IGT_6555: 1a3ffecd400b8f82c35745fa2e07992f6bdeede2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105925v1: 66197f3ca0b462799e265b002dc5cf8dcec1c62d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105925v1/index.html

maintainer
#2 lore raw

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

In reply to Karolina Drobnik
Quoted 32 lines · Karolina Drobnik

From: Chris Wilson <[email protected]>

We employ a "waitboost" heuristic to detect when userspace is stalled waiting for results from earlier execution. Under latency sensitive work mixed between the gpu/cpu, the GPU is typically under-utilised and so RPS sees that low utilisation as a reason to downclock the frequency, causing longer stalls and lower throughput. The user left waiting for the results is not impressed.

On applying commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") it was observed that deinterlacing h264 on Haswell performance dropped by 2-5x. The reason being that the natural workload was not intense enough to trigger RPS (using HW evaluation intervals) to upclock, and so it was depending on waitboosting for the throughput.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the composition of dma-resv from keeping a single write fence + multiple read fences, to a single array of multiple write and read fences (a maximum of one pair of write/read fences per context). The iteration order was also changed implicitly from all-read fences then the single write fence, to a mix of write fences followed by read fences. It is that ordering change that belied the fragility of waitboosting.

Currently, a waitboost is inspected at the point of waiting on an outstanding fence. If the GPU is backlogged such that we haven't yet stated the request we need to wait on, we force the GPU to upclock until the completion of that request. By changing the order in which we waited upon requests, we ended up waiting on those requests in sequence and as such we saw that each request was already started and so not a suitable candidate for waitboosting.

Quoted 1 line

Instead of

Okay, all the explanation makes sense. But this commit message and the cover letter tells that we are doing X *Instead* *of* Y. That would mean code for Y would be removed. But this patch just add X.

So it looks to me that we are adding extra boosts with the code below.

What am I missing?

asking whether to boost each fence in turn, we can look at

Quoted 78 lines

whether boosting is required for the dma-resv ensemble prior to waiting on any fence, making the heuristic more robust to the order in which fences are stored in the dma-resv.

Fixes 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
Cc Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_wait.c | 35 ++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_wait.c +35 -0
index 319936f91ac5..3fbb464746e1 100644
@@ -9,6 +9,7 @@
 #include <linux/jiffies.h>
 
 #include "gt/intel_engine.h"
+#include "gt/intel_rps.h"
 
 #include "i915_gem_ioctls.h"
 #include "i915_gem_object.h"
@@ -31,6 +32,38 @@ i915_gem_object_wait_fence(struct dma_fence *fence,
 				      timeout);
 }
 
+static void
+i915_gem_object_boost(struct dma_resv *resv, unsigned int flags)
+{
+	struct dma_resv_iter cursor;
+	struct dma_fence *fence;
+
+	/*
+	 * Prescan all fences for potential boosting before we begin waiting.
+	 *
+	 * When we wait, we wait on outstanding fences serially. If the
+	 * dma-resv contains a sequence such as 1:1, 1:2 instead of a reduced
+	 * form 1:2, then as we look at each wait in turn we see that each
+	 * request is currently executing and not worthy of boosting. But if
+	 * we only happen to look at the final fence in the sequence (because
+	 * of request coalescing or splitting between read/write arrays by
+	 * the iterator), then we would boost. As such our decision to boost
+	 * or not is delicately balanced on the order we wait on fences.
+	 *
+	 * So instead of looking for boosts sequentially, look for all boosts
+	 * upfront and then wait on the outstanding fences.
+	 */
+
+	dma_resv_iter_begin(&cursor, resv,
+			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}
+	dma_resv_iter_end(&cursor);
+}
+
 static long
 i915_gem_object_wait_reservation(struct dma_resv *resv,
 				 unsigned int flags,
@@ -40,6 +73,8 @@ i915_gem_object_wait_reservation(struct dma_resv *resv,
 	struct dma_fence *fence;
 	long ret = timeout ?: 1;
 
+	i915_gem_object_boost(resv, flags);
+
 	dma_resv_iter_begin(&cursor, resv,
 			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
 	dma_resv_for_each_fence_unlocked(&cursor, fence) {
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 2/3
#8 lore raw

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bump GT idling delay to 2 jiffies

In reply to Karolina Drobnik
Quoted 21 lines · Karolina Drobnik

From: Chris Wilson <[email protected]>

In monitoring a transcode pipeline that is latency sensitive (it waits between submitting frames, and each frame requires work on rcs/vcs/vecs engines), it is found that it took longer than a single jiffy for it to sustain its workload. Allowing an extra jiffy headroom for the userspace prevents us from prematurely parking and having to exit powersaving immediately.

---
 drivers/gpu/drm/i915/i915_active.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_active.c +0 -0
index ee2b3a375362..7412abf166a8 100644

drivers/gpu/drm/i915/i915_active.c void i915_active_acquire_barrier(struct i915_active *ref) · line 977

Quoted 5 lines
drivers/gpu/drm/i915/i915_active.c +1 -1
@@ -974,7 +974,7 @@ void i915_active_acquire_barrier(struct i915_active *ref)
 
 		GEM_BUG_ON(!intel_engine_pm_is_awake(engine));
 		llist_add(barrier_to_ll(node), &engine->barrier_tasks);
-		intel_engine_pm_put_delay(engine, 1);
+		intel_engine_pm_put_delay(engine, 2);

I believe we should make more use of the runtime_idle to check for some pending activity like this... but in the current structure this patch seems the best and easiest option.

Quoted 6 lines
drivers/gpu/drm/i915/i915_active.c +0 -0
 	}
 }
 
Signature · 1 line
2.25.1
#3 lore raw

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

In reply to Rodrigo Vivi

Hi Rodrigo, Chris and Karolina,

Quoted 9 lines · Rodrigo Vivi
Quoted 8 lines · Karolina Drobnik

From: Chris Wilson <[email protected]>

We employ a "waitboost" heuristic to detect when userspace is stalled waiting for results from earlier execution. Under latency sensitive work mixed between the gpu/cpu, the GPU is typically under-utilised and so RPS sees that low utilisation as a reason to downclock the frequency, causing longer stalls and lower throughput. The user left waiting for the results is not impressed.

you can also write here "... is not impressed, was sad and cried"

Quoted 25 lines
Quoted 23 lines

On applying commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") it was observed that deinterlacing h264 on Haswell performance dropped by 2-5x. The reason being that the natural workload was not intense enough to trigger RPS (using HW evaluation intervals) to upclock, and so it was depending on waitboosting for the throughput.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the composition of dma-resv from keeping a single write fence + multiple read fences, to a single array of multiple write and read fences (a maximum of one pair of write/read fences per context). The iteration order was also changed implicitly from all-read fences then the single write fence, to a mix of write fences followed by read fences. It is that ordering change that belied the fragility of waitboosting.

Currently, a waitboost is inspected at the point of waiting on an outstanding fence. If the GPU is backlogged such that we haven't yet stated the request we need to wait on, we force the GPU to upclock until the completion of that request. By changing the order in which we waited upon requests, we ended up waiting on those requests in sequence and as such we saw that each request was already started and so not a suitable candidate for waitboosting.

Quoted 1 line

Instead of

Quoted 7 lines

Okay, all the explanation makes sense. But this commit message and the cover letter tells that we are doing X *Instead* *of* Y. That would mean code for Y would be removed. But this patch just add X.

So it looks to me that we are adding extra boosts with the code below.

What am I missing?

I think the two things are unrelated and they are not mutually exclusive.

What this patch does is to scan the fences upfront and boost those requests that are not naturally boosted (that is what we currently do and as of now regressed) in order to not leave the sad user above crying for long.

Am I right? If so I would r-b this patch as it looks good to me.

Quoted 53 lines

asking whether to boost each fence in turn, we can look at

Quoted 52 lines

whether boosting is required for the dma-resv ensemble prior to waiting on any fence, making the heuristic more robust to the order in which fences are stored in the dma-resv.

Fixes 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
Cc Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_wait.c | 35 ++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_wait.c +22 -0
index 319936f91ac5..3fbb464746e1 100644
@@ -9,6 +9,7 @@
 #include <linux/jiffies.h>
 
 #include "gt/intel_engine.h"
+#include "gt/intel_rps.h"
 
 #include "i915_gem_ioctls.h"
 #include "i915_gem_object.h"
@@ -31,6 +32,38 @@ i915_gem_object_wait_fence(struct dma_fence *fence,
 				      timeout);
 }
 
+static void
+i915_gem_object_boost(struct dma_resv *resv, unsigned int flags)
+{
+	struct dma_resv_iter cursor;
+	struct dma_fence *fence;
+
+	/*
+	 * Prescan all fences for potential boosting before we begin waiting.
+	 *
+	 * When we wait, we wait on outstanding fences serially. If the
+	 * dma-resv contains a sequence such as 1:1, 1:2 instead of a reduced
+	 * form 1:2, then as we look at each wait in turn we see that each
+	 * request is currently executing and not worthy of boosting. But if
+	 * we only happen to look at the final fence in the sequence (because
+	 * of request coalescing or splitting between read/write arrays by
+	 * the iterator), then we would boost. As such our decision to boost
+	 * or not is delicately balanced on the order we wait on fences.
+	 *
+	 * So instead of looking for boosts sequentially, look for all boosts
+	 * upfront and then wait on the outstanding fences.
+	 */
Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_wait.c i915_gem_object_wait_fence(struct dma_fence *fence, · line 63

Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +8 -0
+
+	dma_resv_iter_begin(&cursor, resv,
+			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}

you can remove the brackets here.

Andi

Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +5 -0
+	dma_resv_iter_end(&cursor);
+}
+
 static long
 i915_gem_object_wait_reservation(struct dma_resv *resv,
 				 unsigned int flags,
@@ -40,6 +73,8 @@ i915_gem_object_wait_reservation(struct dma_resv *resv,
 	struct dma_fence *fence;
 	long ret = timeout ?: 1;
 
+	i915_gem_object_boost(resv, flags);
+
 	dma_resv_iter_begin(&cursor, resv,
 			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
 	dma_resv_for_each_fence_unlocked(&cursor, fence) {
Signature · 1 line
2.25.1
Reviewed-by on v1 2/3
#9 lore raw

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bump GT idling delay to 2 jiffies

In reply to Karolina Drobnik

Hi,

Quoted 9 lines · Karolina Drobnik

From: Chris Wilson <[email protected]>

In monitoring a transcode pipeline that is latency sensitive (it waits between submitting frames, and each frame requires work on rcs/vcs/vecs engines), it is found that it took longer than a single jiffy for it to sustain its workload. Allowing an extra jiffy headroom for the userspace prevents us from prematurely parking and having to exit powersaving immediately.

Quoted 3 lines

Andi

Quoted 19 lines
---
 drivers/gpu/drm/i915/i915_active.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_active.c +1 -1
index ee2b3a375362..7412abf166a8 100644
@@ -974,7 +974,7 @@ void i915_active_acquire_barrier(struct i915_active *ref)
 
 		GEM_BUG_ON(!intel_engine_pm_is_awake(engine));
 		llist_add(barrier_to_ll(node), &engine->barrier_tasks);
-		intel_engine_pm_put_delay(engine, 1);
+		intel_engine_pm_put_delay(engine, 2);
 	}
 }
 
Signature · 1 line
2.25.1
#4 lore raw

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

In reply to Andi Shyti

Hi Rodrigo and Andi,

Thank you very much for your reviews.

Quoted 6 lines · Andi Shyti

Hi Rodrigo, Chris and Karolina,

Quoted 3 lines · Rodrigo Vivi
Quoted 2 lines · Karolina Drobnik

From: Chris Wilson <[email protected]>

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

We employ a "waitboost" heuristic to detect when userspace is stalled waiting for results from earlier execution. Under latency sensitive work mixed between the gpu/cpu, the GPU is typically under-utilised and so RPS sees that low utilisation as a reason to downclock the frequency, causing longer stalls and lower throughput. The user left waiting for the results is not impressed.

you can also write here "... is not impressed, was sad and cried"

:)

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

On applying commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") it was observed that deinterlacing h264 on Haswell performance dropped by 2-5x. The reason being that the natural workload was not intense enough to trigger RPS (using HW evaluation intervals) to upclock, and so it was depending on waitboosting for the throughput.

Commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") changes the composition of dma-resv from keeping a single write fence + multiple read fences, to a single array of multiple write and read fences (a maximum of one pair of write/read fences per context). The iteration order was also changed implicitly from all-read fences then the single write fence, to a mix of write fences followed by read fences. It is that ordering change that belied the fragility of waitboosting.

Currently, a waitboost is inspected at the point of waiting on an outstanding fence. If the GPU is backlogged such that we haven't yet stated the request we need to wait on, we force the GPU to upclock until the completion of that request. By changing the order in which we waited upon requests, we ended up waiting on those requests in sequence and as such we saw that each request was already started and so not a suitable candidate for waitboosting.

Quoted 5 lines
Quoted 5 lines
Quoted 1 line

Instead of

Okay, all the explanation makes sense. But this commit message and the cover letter tells that we are doing X *Instead* *of* Y. That would mean code for Y would be removed. But this patch just add X.

The boost we have right now is applied in i915_request_wait_timeout, which is at the lower level than i915_gem_object_wait, and works for all users, not just gem_object(s).

Quoted 1 line
Quoted 1 line

So it looks to me that we are adding extra boosts with the code below.

That's true - we'll have a redundant boost check for gem_object, but this is fine. In this case it wouldn't apply the boost again because either (1) the request already started execution, or (2) intel_rps_boost returns early because i915_request_has_waitboost(rq) is true.

Quoted 5 lines
Quoted 2 lines

What am I missing?

I think the two things are unrelated and they are not mutually exclusive.

Exactly

Quoted 4 lines

What this patch does is to scan the fences upfront and boost those requests that are not naturally boosted (that is what we currently do and as of now regressed) in order to not leave the sad user above crying for long.

That is correct (especially the crying part)

Quoted 66 lines

Am I right? If so I would r-b this patch as it looks good to me.

Quoted 53 lines

asking whether to boost each fence in turn, we can look at

Quoted 52 lines

whether boosting is required for the dma-resv ensemble prior to waiting on any fence, making the heuristic more robust to the order in which fences are stored in the dma-resv.

Fixes 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
Cc Tvrtko Ursulin <[email protected]>
---
  drivers/gpu/drm/i915/gem/i915_gem_wait.c | 35 ++++++++++++++++++++++++
  1 file changed, 35 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_wait.c +22 -0
index 319936f91ac5..3fbb464746e1 100644
@@ -9,6 +9,7 @@
  #include <linux/jiffies.h>
 
  #include "gt/intel_engine.h"
+#include "gt/intel_rps.h"
 
  #include "i915_gem_ioctls.h"
  #include "i915_gem_object.h"
@@ -31,6 +32,38 @@ i915_gem_object_wait_fence(struct dma_fence *fence,
  				      timeout);
  }
 
+static void
+i915_gem_object_boost(struct dma_resv *resv, unsigned int flags)
+{
+	struct dma_resv_iter cursor;
+	struct dma_fence *fence;
+
+	/*
+	 * Prescan all fences for potential boosting before we begin waiting.
+	 *
+	 * When we wait, we wait on outstanding fences serially. If the
+	 * dma-resv contains a sequence such as 1:1, 1:2 instead of a reduced
+	 * form 1:2, then as we look at each wait in turn we see that each
+	 * request is currently executing and not worthy of boosting. But if
+	 * we only happen to look at the final fence in the sequence (because
+	 * of request coalescing or splitting between read/write arrays by
+	 * the iterator), then we would boost. As such our decision to boost
+	 * or not is delicately balanced on the order we wait on fences.
+	 *
+	 * So instead of looking for boosts sequentially, look for all boosts
+	 * upfront and then wait on the outstanding fences.
+	 */
Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_wait.c i915_gem_object_wait_fence(struct dma_fence *fence, · line 63

Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +8 -0
+
+	dma_resv_iter_begin(&cursor, resv,
+			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}

you can remove the brackets here.

Quoted 1 line

Andi

Would you like me to send v2 for it?

All the best,
Karolina

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +5 -0
+	dma_resv_iter_end(&cursor);
+}
+
  static long
  i915_gem_object_wait_reservation(struct dma_resv *resv,
  				 unsigned int flags,
@@ -40,6 +73,8 @@ i915_gem_object_wait_reservation(struct dma_resv *resv,
  	struct dma_fence *fence;
  	long ret = timeout ?: 1;
 
+	i915_gem_object_boost(resv, flags);
+
  	dma_resv_iter_begin(&cursor, resv,
  			    dma_resv_usage_rw(flags & I915_WAIT_ALL));
  	dma_resv_for_each_fence_unlocked(&cursor, fence) {
Signature · 1 line
2.25.1
Reviewed-by
#5 lore raw

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

Hi Karolina,

[...]

Quoted 11 lines
Quoted 9 lines
Quoted 5 lines

drivers/gpu/drm/i915/gem/i915_gem_wait.c i915_gem_object_wait_fence(struct dma_fence *fence, · line 63

Quoted 5 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +5 -0
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}

you can remove the brackets here.

Andi

Would you like me to send v2 for it?

if the committer takes care of removing it, then no need, otherwise, please yes, resend it. Even if it's a stupid nitpick, if it gets applied it would be very difficult to get it fixed[*].

Didn't checkpatch.pl complain about it?

If you are going to resend it, you can add my:

also here.

Thanks,
Andi

[*] Because just minor coding style patches are generally rejected, the only way for fixing style issues would be if:

1. someone is working in that part of the code
2. someone will sneak in the code fix in some unrelated patch screwing up git blame
3. someone will send a big series on this file and have some trivial coding style patches in it.

Amongst the three above, number '2' is the one I dislike the most, but unfortunately that's also the most used.

#6 lore raw

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

Hi Andi,

Quoted 14 lines · Andi Shyti

Hi Karolina,

[...]

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

drivers/gpu/drm/i915/gem/i915_gem_wait.c i915_gem_object_wait_fence(struct dma_fence *fence, · line 63

Quoted 5 lines
drivers/gpu/drm/i915/gem/i915_gem_wait.c +5 -0
+	dma_resv_for_each_fence_unlocked(&cursor, fence) {
+		if (dma_fence_is_i915(fence) &&
+		    !i915_request_started(to_request(fence)))
+			intel_rps_boost(to_request(fence));
+	}

you can remove the brackets here.

Andi

Quoted 7 lines
Quoted 1 line

Would you like me to send v2 for it?

if the committer takes care of removing it, then no need, otherwise, please yes, resend it. Even if it's a stupid nitpick, if it gets applied it would be very difficult to get it fixed[*].

Didn't checkpatch.pl complain about it?

Right, thanks for explaining this. checkpatch.pl only complained about unwrapped References tag (a false positive), but I can delete the braces and resend the patchset.

Quoted 5 lines

If you are going to resend it, you can add my:

also here.

OK, will so do, thanks

All the best,
Karolina

Quoted 14 lines

Thanks,
Andi

[*] Because just minor coding style patches are generally rejected, the only way for fixing style issues would be if:

1. someone is working in that part of the code
2. someone will sneak in the code fix in some unrelated patch screwing up git blame
3. someone will send a big series on this file and have some trivial coding style patches in it.

Amongst the three above, number '2' is the one I dislike the most, but unfortunately that's also the most used.