staging: qlge: code refinement around a for loop
Subsystems (3)
v4 cover staging: qlge: code refinement around a for loop
* Patch 1:
Fix indentation according to checkpatch. Format the long for loop thanks to Joe's review.
* Patch 2:
Optimize by avoiding the multiplication thanks to Joe's review.
I agree with Joe and think it's the same logic, and it compiles without error.
But I don't have the real hardware, so can't prove that code is still doing the same thing. So I understand if you don't apply this patch without the "proof".
v4:
- Separate the code style change and "optimization" into 2 patches
v3:
Thanks to Joe's review.
- Align page_entries in the for loop to open parenthesis.
- Optimize by avoiding the multiplication.
v2:
- Change the long for loop into 3 lines
Binyi Han (2):
staging: qlge: Fix indentation issue under long for loop
staging: qlge: Avoid multiplication while keep the same logic
drivers/staging/qlge/qlge_main.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1
PATCH v4 1/2 staging: qlge: Fix indentation issue under long for loop
Fix indentation issue to adhere to Linux kernel coding style, issue found by checkpatch. And change the long for loop into 3 lines.
--- drivers/staging/qlge/qlge_main.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/staging/qlge/qlge_main.c +10 -8
@@ -3007,10 +3007,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring tmp = (u64 )rx_ring->lbq.base_dma; base_indirect_ptr = rx_ring->lbq.base_indirect; -for (page_entries =0 ; page_entries < -MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); page_entries++) - base_indirect_ptr[page_entries] = -cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); +for (page_entries =0 ; + page_entries <MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); + page_entries++) + base_indirect_ptr[page_entries] = +cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); cqicb->lbq_addr =cpu_to_le64 (rx_ring->lbq.base_indirect_dma); cqicb->lbq_buf_size =cpu_to_le16 (QLGE_FIT16 (qdev->lbq_buf_size));
@@ -3022,10 +3023,11 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring tmp = (u64 )rx_ring->sbq.base_dma; base_indirect_ptr = rx_ring->sbq.base_indirect; -for (page_entries =0 ; page_entries < -MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); page_entries++) - base_indirect_ptr[page_entries] = -cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); +for (page_entries =0 ; + page_entries <MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); + page_entries++) + base_indirect_ptr[page_entries] = +cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); cqicb->sbq_addr =cpu_to_le64 (rx_ring->sbq.base_indirect_dma); cqicb->sbq_buf_size =cpu_to_le16 (SMALL_BUFFER_SIZE );
Signature · 1 line
2.25.1
PATCH v4 2/2 staging: qlge: Avoid multiplication while keep the same logic
In reply to Binyi HanAvoid the more expensive multiplication while keep the same logic.
--- drivers/staging/qlge/qlge_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/staging/qlge/qlge_main.c +8 -6
@@ -3009,9 +3009,10 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ringfor (page_entries =0 ; page_entries <MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); - page_entries++) - base_indirect_ptr[page_entries] = -cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); + page_entries++) { + base_indirect_ptr[page_entries] =cpu_to_le64 (tmp); + tmp +=DB_PAGE_SIZE ; + } cqicb->lbq_addr =cpu_to_le64 (rx_ring->lbq.base_indirect_dma); cqicb->lbq_buf_size =cpu_to_le16 (QLGE_FIT16 (qdev->lbq_buf_size));
@@ -3025,9 +3026,10 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ringfor (page_entries =0 ; page_entries <MAX_DB_PAGES_PER_BQ (QLGE_BQ_LEN ); - page_entries++) - base_indirect_ptr[page_entries] = -cpu_to_le64 (tmp + (page_entries *DB_PAGE_SIZE )); + page_entries++) { + base_indirect_ptr[page_entries] =cpu_to_le64 (tmp); + tmp +=DB_PAGE_SIZE ; + } cqicb->sbq_addr =cpu_to_le64 (rx_ring->sbq.base_indirect_dma); cqicb->sbq_buf_size =cpu_to_le16 (SMALL_BUFFER_SIZE );
Signature · 1 line
2.25.1