Deprecate interrupt-map for realtek-rtl IRQ driver
Subsystems (2)
v6 cover Deprecate interrupt-map for realtek-rtl IRQ driver
The original implementation for this interrupt controller/router used an interrupt-map parser to determine which parent interrupts were present. However, this controller is not transparent, so a list of parent interrupts seems more appropriate, while also getting rid of the assumed routing to parent interrupts.
Changes since v5:
- Allow interrupt-map for new compatibles, but mark as deprecated
- Change back to single-cell interrupt specifiers
- Drop patch adding a domain for every output line
Changes since v4:
- Add Rob's Reviewed-by
- Use irq_domain_add_linear instead of irq_domain_add_simple
- Drop 'inline' specifiers from static functions
- Drop WARN in intc_select() to only warn once for old bindings
Changes since v3:
- Patches with fixes were merged, so these are no longer included.
- Update the devicetree changes to more clearly indicate the controller is not transparent.
Changes since v2 (RFC):
- Define new, two-part compatibles for devicetree bindings. The existing format is kept for the old one-part compatible, but deprecated. New compatibles will require a different way of specifying parent interrupts and interrupt routing.
- Add change to handle all pending SoC interrupts in one go.
Changes since v1 (RFC):
- Split some of the changes to limit the patch scope to one issue.
- Dropped some small (spurious or unneeded) changes
- Instead of dropping/replacing interrupt-map, the last patches now provide an implementation that amends the current situtation.
Sander Vanheule (3):
irqchip/realtek-rtl: use irq_domain_add_linear
dt-bindings: interrupt-controller: realtek,rtl-intc: require parents irqchip/realtek-rtl: use parent interrupts
.../realtek,rtl-intc.yaml | 60 ++++++-- drivers/irqchip/irq-realtek-rtl.c | 134 ++++++++---------- 2 files changed, 106 insertions(+), 88 deletions(-)
Signature · 1 line
2.37.3
PATCH v6 1/3 irqchip/realtek-rtl: use irq_domain_add_linear()
When using an offset of 0, irq_domain_add_simple() is identical to irq_domain_add_linear() on DT-based systems, so use the latter instead.
--- drivers/irqchip/irq-realtek-rtl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/irqchip/irq-realtek-rtl.c +1 -2
@@ -171,8 +171,7 @@ static int __init realtek_rtl_of_init(struct device_node *node, struct device_no/* Disable all cascaded interrupts */ writel (0 ,REG (RTL_ICTL_GIMR )); - domain =irq_domain_add_simple (node,32 ,0 , - &irq_domain_ops,NULL ); + domain =irq_domain_add_linear (node,32 , &irq_domain_ops,NULL ); ret =map_interrupts (node, domain);if (ret) {
Signature · 1 line
2.37.3
PATCH v6 2/3 dt-bindings: interrupt-controller: realtek,rtl-intc: require parents
In reply to Sander VanheuleThe interrupt router has 32 inputs, and up to 15 outputs connected to the MIPS CPU's interrupts. The way these are mapped to each other is runtime configurable. This controller can also mask individual interrupt sources, and has a status register to indicate pending interrupts. This means the controller is not transparent, and the use of "interrupt-map" inappropriate. Instead, a list of parent interrupts should be specified.
Two-part compatibles are introduced to be able to require "interrupts" for new devicetrees. For backward compatibility "interrupt-map" is still allowed on these new compatibles, but deprecated. The old compatible, with required "interrupt-map" and "#address-cells", is also deprecated. The relevant descriptions are added or extended to more clearly describe the functionality of this controller.
To prevent spurious changes to the binding when more SoCs are added, "allOf" is used with one "if", and the compatible enum only has one item.
The example is updated to provide a correct example for RTL8380 SoCs.
---
Changes in v6:
- Allow interrupt-map for backwards compatibility, but mark as deprecated.
- Update commit message to explain forward/backward compatibility
- Drop Rob's Reviewed-by because of above changes
Changes in v5:
- Add Rob's Reviewed-by
Changes in v4:
- Indicate more clearly that the controller is not transparent.
--- .../realtek,rtl-intc.yaml | 60 ++++++++++++++----- 1 file changed, 45 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml +45 -15
@@ -6,6 +6,14 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Realtek RTL SoC interrupt controller devicetree bindings +description: + Interrupt controller and router for Realtek MIPS SoCs, allowing each SoC + interrupt to be routed to one parent CPU (hardware) interrupt, or left + disconnected. + All connected input lines from SoC peripherals can be masked individually, + and an interrupt status register is present to indicate which interrupts are + pending. + maintainers: - Birger Koblitz <[email protected]> - Bert Vermeulen <[email protected]>
@@ -13,23 +21,33 @@ maintainers: properties: compatible: - const: realtek,rtl-intc + oneOf: + - items: + - enum: + - realtek,rtl8380-intc + - const: realtek,rtl-intc + - const: realtek,rtl-intc + deprecated: true "#interrupt-cells": + description: + SoC interrupt line index. const: 1 reg: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 15 + description: + List of parent interrupts, in the order that they are connected to this + interrupt router's outputs, starting at the first output. interrupt-controller: true - "#address-cells": - const: 0 - interrupt-map: + deprecated: true description: Describes mapping from SoC interrupts to CPU interrupts required:
@@ -37,21 +55,33 @@ required: - reg - "#interrupt-cells" - interrupt-controller - - "#address-cells" - - interrupt-map + +allOf: + - if: + properties: + compatible: + const: realtek,rtl-intc + then: + properties: + "#address-cells": + const: 0 + required: + - "#address-cells" + - interrupt-map + else: + required: + - interrupts additionalProperties: false examples: - | - intc: interrupt-controller@3000 { - compatible = "realtek,rtl-intc"; + interrupt-controller@3000 { + compatible = "realtek,rtl8380-intc", "realtek,rtl-intc"; #interrupt-cells = <1>; interrupt-controller; - reg = <0x3000 0x20>; - #address-cells = <0>; - interrupt-map = - <31 &cpuintc 2>, - <30 &cpuintc 1>, - <29 &cpuintc 5>; + reg = <0x3000 0x18>; + + interrupt-parent = <&cpuintc>; + interrupts = <2>, <3>, <4>, <5>, <6>; };
Signature · 1 line
2.37.3
PATCH v6 3/3 irqchip/realtek-rtl: use parent interrupts
In reply to Sander VanheuleThe interrupt-map property for "realtek,rtl-intc" has been deprecated in favor of a list of parent interrupts. Drop the open-coded parser for interrupt-map, and use the first parent interrupt instead. If no parent was provided, the driver will assume that this is the first hardware interrupt of the SoC's MIPS CPU for compatibility with the legacy binding.
All SoC interrupts were treated equally, independent of which output they were actually routed to. This means the driver might as well route all interrupts to the first output, and achieve the same behaviour.
Without the interrupt-map property, interrupt usage information is no longer available at initialisation. Routing setup will now happen later, when a hardware interrupt is mapped by the subsystem.
--- drivers/irqchip/irq-realtek-rtl.c | 133 ++++++++++++++---------------- 1 file changed, 61 insertions(+), 72 deletions(-)
drivers/irqchip/irq-realtek-rtl.c +61 -72
@@ -21,11 +21,33 @@#define RTL_ICTL_IRR2 0x10#define RTL_ICTL_IRR3 0x14 +#define RTL_ICTL_NUM_INPUTS 32 +#define REG (x) (realtek_ictl_base + x)static DEFINE_RAW_SPINLOCK (irq_lock);static void __iomem *realtek_ictl_base; +/* +* IRR0-IRR3 store 4 bits per interrupt, but Realtek uses inverted numbering, +* placing IRQ 31 in the first four bits. A routing value of '0' means the +* interrupt is left disconnected. Routing values {1..15} connect to output +* lines {0..14}. +*/ +#define IRR_OFFSET (idx) (4 * (3 - (idx * 4) / 32)) +#define IRR_SHIFT (idx) ((idx * 4) % 32) + +static void write_irr (void __iomem *irr0,int idx,u32 value) +{ +unsigned int offset =IRR_OFFSET (idx); +unsigned int shift =IRR_SHIFT (idx); +u32 irr; + + irr =readl (irr0 + offset) & ~(0xf << shift); + irr |= (value &0xf ) << shift; +writel (irr, irr0 + offset); +} +static void realtek_ictl_unmask_irq (struct irq_data *i) {unsigned long flags;
@@ -62,8 +84,14 @@ static struct irq_chip realtek_ictl_irq = {static int intc_map (struct irq_domain *d,unsigned int irq,irq_hw_number_t hw) { +unsigned long flags; +irq_set_chip_and_handler (irq, &realtek_ictl_irq, handle_level_irq); +raw_spin_lock_irqsave (&irq_lock, flags); +write_irr (REG (RTL_ICTL_IRR0 ), hw,1 ); +raw_spin_unlock_irqrestore (&irq_lock, flags); +return 0 ; }
@@ -95,89 +123,50 @@ static void realtek_irq_dispatch(struct irq_desc *desc)chained_irq_exit (chip, desc); } -/* -* SoC interrupts are cascaded to MIPS CPU interrupts according to the -* interrupt-map in the device tree. Each SoC interrupt gets 4 bits for -* the CPU interrupt in an Interrupt Routing Register. Max 32 SoC interrupts -* thus go into 4 IRRs. A routing value of '0' means the interrupt is left -* disconnected. Routing values {1..15} connect to output lines {0..14}. -*/ -static int __init map_interrupts (struct device_node *node,struct irq_domain *domain) -{ -struct device_node *cpu_ictl; -const __be32 *imap; -u32 imaplen, soc_int, cpu_int, tmp, regs[4 ]; -int ret, i, irr_regs[] = { -RTL_ICTL_IRR3 , -RTL_ICTL_IRR2 , -RTL_ICTL_IRR1 , -RTL_ICTL_IRR0 , - }; -u8 mips_irqs_set; - - ret =of_property_read_u32 (node,"#address-cells" , &tmp); -if (ret || tmp) -return -EINVAL ; - - imap =of_get_property (node,"interrupt-map" , &imaplen); -if (!imap || imaplen %3 ) -return -EINVAL ; - - mips_irqs_set =0 ; -memset (regs,0 ,sizeof (regs)); -for (i =0 ; i < imaplen; i +=3 *sizeof (u32)) { - soc_int =be32_to_cpup (imap); -if (soc_int >31 ) -return -EINVAL ; - - cpu_ictl =of_find_node_by_phandle (be32_to_cpup (imap +1 )); -if (!cpu_ictl) -return -EINVAL ; - ret =of_property_read_u32 (cpu_ictl,"#interrupt-cells" , &tmp); -of_node_put (cpu_ictl); -if (ret || tmp !=1 ) -return -EINVAL ; - - cpu_int =be32_to_cpup (imap +2 ); -if (cpu_int >7 || cpu_int <2 ) -return -EINVAL ; - -if (!(mips_irqs_set &BIT (cpu_int))) { -irq_set_chained_handler_and_data (cpu_int, realtek_irq_dispatch, - domain); - mips_irqs_set |=BIT (cpu_int); - } - -/* Use routing values (1..6) for CPU interrupts (2..7) */ - regs[(soc_int *4 ) /32 ] |= (cpu_int -1 ) << (soc_int *4 ) %32 ; - imap +=3 ; - } - -for (i =0 ; i <4 ; i++) -writel (regs[i],REG (irr_regs[i])); - -return 0 ; -} -static int __init realtek_rtl_of_init (struct device_node *node,struct device_node *parent) { +struct of_phandle_args oirq;struct irq_domain *domain; -int ret; +unsigned int soc_irq; +int parent_irq; realtek_ictl_base =of_iomap (node,0 );if (!realtek_ictl_base)return -ENXIO ; -/* Disable all cascaded interrupts */ +/* Disable all cascaded interrupts and clear routing */ writel (0 ,REG (RTL_ICTL_GIMR )); +for (soc_irq =0 ; soc_irq <RTL_ICTL_NUM_INPUTS ; soc_irq++) +write_irr (REG (RTL_ICTL_IRR0 ), soc_irq,0 ); + +if (WARN_ON (!of_irq_count (node))) { +/* +* If DT contains no parent interrupts, assume MIPS CPU IRQ 2 +* (HW0) is connected to the first output. This is the case for +* all known hardware anyway. "interrupt-map" is deprecated, so +* don't bother trying to parse that. +*/ + oirq.np =of_find_compatible_node (NULL ,NULL ,"mti,cpu-interrupt-controller" ); + oirq.args_count =1 ; + oirq.args[0 ] =2 ; + + parent_irq =irq_create_of_mapping (&oirq); + +of_node_put (oirq.np); + }else { + parent_irq =of_irq_get (node,0 ); + } - domain =irq_domain_add_linear (node,32 , &irq_domain_ops,NULL ); +if (parent_irq <0 ) +return parent_irq; +else if (!parent_irq) +return -ENODEV ; - ret =map_interrupts (node, domain); -if (ret) { -pr_err ("invalid interrupt map\n" ); -return ret; - } + domain =irq_domain_add_linear (node,RTL_ICTL_NUM_INPUTS , &irq_domain_ops,NULL ); +if (!domain) +return -ENOMEM ; + +irq_set_chained_handler_and_data (parent_irq, realtek_irq_dispatch, domain);return 0 ; }
Signature · 1 line
2.37.3
Re: [PATCH v6 2/3] dt-bindings: interrupt-controller: realtek,rtl-intc: require parents
In reply to Sander VanheuleQuoted 20 lines · Sander Vanheule
The interrupt router has 32 inputs, and up to 15 outputs connected to the MIPS CPU's interrupts. The way these are mapped to each other is runtime configurable. This controller can also mask individual interrupt sources, and has a status register to indicate pending interrupts. This means the controller is not transparent, and the use of "interrupt-map" inappropriate. Instead, a list of parent interrupts should be specified.
Two-part compatibles are introduced to be able to require "interrupts" for new devicetrees. For backward compatibility "interrupt-map" is still allowed on these new compatibles, but deprecated. The old compatible, with required "interrupt-map" and "#address-cells", is also deprecated. The relevant descriptions are added or extended to more clearly describe the functionality of this controller.
To prevent spurious changes to the binding when more SoCs are added, "allOf" is used with one "if", and the compatible enum only has one item.
The example is updated to provide a correct example for RTL8380 SoCs.
Quoted 7 lines
Signed-off-by Sander Vanheule <[email protected]>---
Changes in v6:
- Allow interrupt-map for backwards compatibility, but mark as deprecated.
- Update commit message to explain forward/backward compatibility
- Drop Rob's Reviewed-by because of above changes
Please, still wait a bit. I'll leave it to Rob (who should come online next week) for a review.
Best regards,
Krzysztof
Re: [PATCH v6 2/3] dt-bindings: interrupt-controller: realtek,rtl-intc: require parents
In reply to Sander VanheuleQuoted 28 lines · Sander Vanheule
The interrupt router has 32 inputs, and up to 15 outputs connected to the MIPS CPU's interrupts. The way these are mapped to each other is runtime configurable. This controller can also mask individual interrupt sources, and has a status register to indicate pending interrupts. This means the controller is not transparent, and the use of "interrupt-map" inappropriate. Instead, a list of parent interrupts should be specified.
Two-part compatibles are introduced to be able to require "interrupts" for new devicetrees. For backward compatibility "interrupt-map" is still allowed on these new compatibles, but deprecated. The old compatible, with required "interrupt-map" and "#address-cells", is also deprecated. The relevant descriptions are added or extended to more clearly describe the functionality of this controller.
To prevent spurious changes to the binding when more SoCs are added, "allOf" is used with one "if", and the compatible enum only has one item.
The example is updated to provide a correct example for RTL8380 SoCs.
Signed-off-by Sander Vanheule <[email protected]>---
Changes in v6:
- Allow interrupt-map for backwards compatibility, but mark as deprecated.
- Update commit message to explain forward/backward compatibility
- Drop Rob's Reviewed-by because of above changes
Quoted 9 lines
Changes in v5:
- Add Rob's Reviewed-byChanges in v4:
- Indicate more clearly that the controller is not transparent.--- .../realtek,rtl-intc.yaml | 60 ++++++++++++++----- 1 file changed, 45 insertions(+), 15 deletions(-)