drm/connector: connector iterator with filtering
cover drm/connector: connector iterator with filtering
Currently i915 assumes all drm_connectors it encounters are embedded in intel_connectors that i915 allocated. The drm_writeback_connector forces a design where this is not the case; we can't provide our own connector, and writeback embeds the drm_connector it initializes itself.
To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in intel_connector. Checking this is tedious, and would require an intermediate step with drm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
BR,
Jani.
Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterate intel_connectors only
drivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 1 line
2.34.1
RFC 1/2 drm/connector: add connector list iteration with filtering
Add new function drm_connector_list_iter_filter_begin() to initialize connector list iterator with a filter function. Subsequent iteration on the list will only return connectors on which the filter function returns true.
--- drivers/gpu/drm/drm_connector.c | 57 ++++++++++++++++++++++++++------- include/drm/drm_connector.h | 9 ++++++ 2 files changed, 54 insertions(+), 12 deletions(-)
drivers/gpu/drm/drm_connector.c +45 -12
@@ -762,6 +762,29 @@ static struct lockdep_map connector_list_iter_dep_map = { };#endif +/** +* drm_connector_list_iter_filter_begin - initialize a connector_list iterator with filter +* @dev: DRM device +* @iter: connector_list iterator +* @filter: connector filter function +* @filter_context: context to be passed to the filter function +* +* Same as drm_connector_list_iter_begin(), but sets up the iterator to only +* return connectors where filter(connector) returns true. +*/ +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context) +{ + iter->dev = dev; + iter->conn =NULL ; + iter->filter = filter; + iter->filter_context = filter_context; +lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +} +EXPORT_SYMBOL (drm_connector_list_iter_filter_begin); +/** * drm_connector_list_iter_begin - initialize a connector_list iterator * @dev: DRM device
@@ -775,9 +798,7 @@ static struct lockdep_map connector_list_iter_dep_map = {void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter) { - iter->dev = dev; - iter->conn =NULL ; -lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +drm_connector_list_iter_filter_begin (dev, iter,NULL ,NULL ); }EXPORT_SYMBOL (drm_connector_list_iter_begin);
@@ -800,15 +821,8 @@ __drm_connector_put_safe(struct drm_connector *conn)schedule_work (&config->connector_free_work); } -/** -* drm_connector_list_iter_next - return next connector -* @iter: connector_list iterator -* -* Returns: the next connector for @iter, or NULL when the list walk has -* completed. -*/ -struct drm_connector * -drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +static struct drm_connector * +__drm_connector_list_iter_next (struct drm_connector_list_iter *iter) {struct drm_connector *old_conn = iter->conn;struct drm_mode_config *config = &iter->dev->mode_config;
@@ -836,6 +850,25 @@ drm_connector_list_iter_next(struct drm_connector_list_iter *iter)return iter->conn; } + +/** +* drm_connector_list_iter_next - return next connector +* @iter: connector_list iterator +* +* Returns: the next connector for @iter, or NULL when the list walk has +* completed. +*/ +struct drm_connector * +drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +{ +struct drm_connector *connector; + +while ((connector =__drm_connector_list_iter_next (iter)) && + iter->filter && !iter->filter (connector, iter->filter_context)) + ; + +return connector; +}EXPORT_SYMBOL (drm_connector_list_iter_next);/**
include/drm/drm_connector.h +9 -0
@@ -1868,6 +1868,9 @@ struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,void drm_mode_put_tile_group (struct drm_device *dev,struct drm_tile_group *tg); +typedef bool (*drm_connector_list_iter_filter_fn )(const struct drm_connector *connector, +void *filter_context); +/** * struct drm_connector_list_iter - connector_list iterator *
@@ -1886,10 +1889,16 @@ struct drm_connector_list_iter {/* private: */ struct drm_device *dev;struct drm_connector *conn; +drm_connector_list_iter_filter_fn filter; +void *filter_context; };void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter); +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context);struct drm_connector *drm_connector_list_iter_next (struct drm_connector_list_iter *iter);void drm_connector_list_iter_end (struct drm_connector_list_iter *iter);
Signature · 1 line
2.34.1
RFC 2/2 drm/i915: iterate intel_connectors only
In reply to Jani NikulaThe drm_connectors that are embedded in writeback connectors won't be embedded in intel_connectors, so we can't assume being able to convert a drm_connector to intel_connector when iterating all the connectors we have. Use the drm connector list filtering to skip writeback connectors.
Note: We could also wrap the begin/end calls to intel specific macros to hide the boilerplate.
--- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- drivers/gpu/drm/i915/display/intel_display_types.h | 7 +++++++ drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 ++- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++++++++---- drivers/gpu/drm/i915/display/intel_modeset_setup.c | 6 ++++-- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++++++--- 8 files changed, 35 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -1
@@ -8960,7 +8960,8 @@ static void intel_hpd_poll_fini(struct drm_i915_private *i915)struct drm_connector_list_iter conn_iter;/* Kill all the work that may have been queued by hpd. */ -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {if (connector->modeset_retry_work.func)cancel_work_sync (&connector->modeset_retry_work);
drivers/gpu/drm/i915/display/intel_display_types.h +7 -0
@@ -612,6 +612,13 @@ struct intel_connector {struct intel_hdcp hdcp; }; +static inline bool is_intel_connector (const struct drm_connector *connector, +void *unused_filter_context) +{ +/* writeback connectors aren't embedded in intel_connector */ +return connector->connector_type !=DRM_MODE_CONNECTOR_WRITEBACK ; +} +struct intel_digital_connector_state {struct drm_connector_state base;
drivers/gpu/drm/i915/display/intel_dp.c +4 -2
@@ -4044,7 +4044,8 @@ static int intel_dp_prep_link_retrain(struct intel_dp *intel_dp,if (!intel_dp_needs_link_retrain (intel_dp))return 0 ; -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {struct drm_connector_state *conn_state = connector->base.state;
@@ -4173,7 +4174,8 @@ static int intel_dp_prep_phy_test(struct intel_dp *intel_dp, *pipe_mask =0 ; -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {struct drm_connector_state *conn_state = connector->base.state;
drivers/gpu/drm/i915/display/intel_dp_mst.c +2 -1
@@ -272,7 +272,8 @@ intel_dp_mst_atomic_master_trans_check(struct intel_connector *connector,if (!intel_connector_needs_modeset (state, &connector->base))return 0 ; -drm_connector_list_iter_begin (&dev_priv->drm, &connector_list_iter); +drm_connector_list_iter_filter_begin (&dev_priv->drm, &connector_list_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector_iter, &connector_list_iter) {struct intel_digital_connector_state *conn_iter_state;struct intel_crtc_state *crtc_state;
drivers/gpu/drm/i915/display/intel_hdcp.c +2 -1
@@ -83,7 +83,8 @@ intel_hdcp_required_content_stream(struct intel_digital_port *dig_port)if (dig_port->hdcp_auth_status)return 0 ; -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {if (connector->base.status == connector_status_disconnected)continue ;
drivers/gpu/drm/i915/display/intel_hotplug.c +8 -4
@@ -185,7 +185,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)lockdep_assert_held (&dev_priv->irq_lock); -drm_connector_list_iter_begin (dev, &conn_iter); +drm_connector_list_iter_filter_begin (dev, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {enum hpd_pin pin;
@@ -232,7 +233,8 @@ static void intel_hpd_irq_storm_reenable_work(struct work_struct *work)spin_lock_irq (&dev_priv->irq_lock); -drm_connector_list_iter_begin (dev, &conn_iter); +drm_connector_list_iter_filter_begin (dev, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) { pin =intel_connector_hpd_pin (connector); if (pin == HPD_NONE ||
@@ -392,7 +394,8 @@ static void i915_hotplug_work_func(struct work_struct *work)spin_unlock_irq (&dev_priv->irq_lock); -drm_connector_list_iter_begin (dev, &conn_iter); +drm_connector_list_iter_filter_begin (dev, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {enum hpd_pin pin;u32 hpd_bit;
@@ -624,7 +627,8 @@ static void i915_hpd_poll_init_work(struct work_struct *work) enabled =READ_ONCE (dev_priv->display.hotplug.poll_enabled); -drm_connector_list_iter_begin (dev, &conn_iter); +drm_connector_list_iter_filter_begin (dev, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {enum hpd_pin pin;
drivers/gpu/drm/i915/display/intel_modeset_setup.c +4 -2
@@ -114,7 +114,8 @@ static void intel_modeset_update_connector_atomic_state(struct drm_i915_privatestruct intel_connector *connector;struct drm_connector_list_iter conn_iter; -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {struct drm_connector_state *conn_state = connector->base.state; struct intel_encoder *encoder =
@@ -498,7 +499,8 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)intel_dpll_readout_hw_state (i915); -drm_connector_list_iter_begin (&i915->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&i915->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {if (connector->get_hw_state (connector)) {struct intel_crtc_state *crtc_state;
drivers/gpu/drm/i915/display/intel_opregion.c +6 -3
@@ -488,7 +488,8 @@ static u32 asle_set_backlight(struct drm_i915_private *dev_priv, u32 bclp)*/ drm_dbg_kms (&dev_priv->drm,"updating opregion backlight %d/255\n" , bclp); -drm_connector_list_iter_begin (dev, &conn_iter); +drm_connector_list_iter_filter_begin (dev, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter)intel_backlight_set_acpi (connector->base.state, bclp,255 );drm_connector_list_iter_end (&conn_iter);
@@ -709,7 +710,8 @@ static void intel_didl_outputs(struct drm_i915_private *dev_priv)intel_acpi_device_id_update (dev_priv); -drm_connector_list_iter_begin (&dev_priv->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&dev_priv->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {if (i < max_outputs)set_did (opregion, i, connector->acpi_device_id);
@@ -746,7 +748,8 @@ static void intel_setup_cadls(struct drm_i915_private *dev_priv)* Note that internal panels should be at the front of the connector * list already, ensuring they're not left out. */ -drm_connector_list_iter_begin (&dev_priv->drm, &conn_iter); +drm_connector_list_iter_filter_begin (&dev_priv->drm, &conn_iter, + is_intel_connector,NULL );for_each_intel_connector_iter (connector, &conn_iter) {if (i >=ARRAY_SIZE (opregion->acpi->cadl))break ;
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/connector: connector iterator with filtering
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/connector: connector iterator with filtering
URL : https://patchwork.freedesktop.org/series/109411/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/connector: connector iterator with filtering
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/connector: connector iterator with filtering
URL : https://patchwork.freedesktop.org/series/109411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12217 -> Patchwork_109411v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/index.html
Participating hosts (43 -> 43)
------------------------------
Additional (3): fi-hsw-4770 fi-rkl-11600 bat-atsm-1
Missing (3): fi-ctg-p8600 fi-tgl-dsi fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109411v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_fence@nb-await@bcs0:
- {bat-rpls-1}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/bat-rpls-1/igt@gem_exec_fence@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/bat-rpls-1/igt@gem_exec_fence@[email protected]
Known issues
------------
Here are the changes found in Patchwork_109411v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@gem_softpin@allocator-basic-reserve:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-hsw-4770/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#3012])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-hsw-4770/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#3012])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][9] ([i915#5982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-hsw-4770/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([fdo#111827]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([i915#4103])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#109285] / [i915#4098])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#1072]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1072]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([i915#3555] / [i915#4098])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([fdo#109295] / [i915#3301] / [i915#3708])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/fi-rkl-11600/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][19] ([i915#4258]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
Build changes
-------------
* Linux: CI_DRM_12217 -> Patchwork_109411v1
CI-20190529: 20190529
CI_DRM_12217: 62a55ad3add25f5819f6aafe2b18ab5ff97a0faf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6682: 8b73737b2adc2ef3381ca6ae5d261cd7a7342e83 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109411v1: 62a55ad3add25f5819f6aafe2b18ab5ff97a0faf @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
54a02cf556e3 drm/i915: iterate intel_connectors only 8e2b3c5bd69b drm/connector: add connector list iteration with filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/connector: connector iterator with filtering
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/connector: connector iterator with filtering
URL : https://patchwork.freedesktop.org/series/109411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12217_full -> Patchwork_109411v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109411v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_109411v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109411v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@[email protected]
#### Warnings ####
* igt@dmabuf@all@dma_fence_chain:
- shard-skl: [INCOMPLETE][3] ([i915#6949]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl10/igt@dmabuf@all@dma_fence_chain.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl9/igt@dmabuf@all@dma_fence_chain.html
Known issues
------------
Here are the changes found in Patchwork_109411v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [FAIL][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) ([i915#4392]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk8/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk7/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk5/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk1/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk9/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk7/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk5/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk3/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#1839])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109314])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@gem_ctx_persistence@engines-hang@bcs0:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271]) +52 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#4525]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb5/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2842])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2190])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl7/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-glk: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#4613]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl6/igt@[email protected]
* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#4270])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#3323])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl3/igt@[email protected]
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#109289]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][68] -> [FAIL][69] ([i915#6537])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-apl6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl8/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][70] ([i915#1886])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl10/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][71] -> [DMESG-WARN][72] ([i915#180])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-apl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl3/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-skl: [PASS][73] -> [FAIL][74] ([i915#2521])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl1/igt@kms_async_flips@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl1/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#5286]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +150 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][77] ([i915#3763])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111615]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3689])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#3886]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +9 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3689] / [i915#6095]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#6095])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3742])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +4 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/igt@[email protected]
* igt@kms_chamelium@dp-hpd-storm:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109284] / [fdo#111827])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_chamelium@vga-frame-dump:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [fdo#111827]) +9 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl6/igt@[email protected]
* igt@kms_color_chamelium@ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3116] / [i915#3299])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#4103])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][91] -> [FAIL][92] ([i915#79]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl10/igt@kms_flip@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][93] -> [DMESG-WARN][94] ([i915#180] / [i915#1982])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-apl6/igt@kms_flip@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [PASS][95] -> [INCOMPLETE][96] ([i915#4939])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl10/igt@kms_flip@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][97] -> [FAIL][98] ([i915#2122])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl10/igt@kms_flip@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#2672]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2587] / [i915#2672]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][101] ([i915#2587] / [i915#2672]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109280] / [fdo#111825]) +6 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#6497]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#5176]) +3 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#5235]) +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271]) +55 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#658])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl7/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][108] -> [SKIP][109] ([fdo#109642] / [fdo#111068] / [i915#658])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb5/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-glk: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#658])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][111] -> [SKIP][112] ([fdo#109441])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb2/igt@kms_psr@psr2_basic.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb8/igt@kms_psr@psr2_basic.html
* igt@kms_psr@psr2_sprite_render:
- shard-tglb: NOTRUN -> [FAIL][113] ([i915#132] / [i915#3467]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-glk: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#533])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk2/igt@[email protected]
* igt@kms_vrr@flip-dpms:
- shard-tglb: NOTRUN -> [SKIP][115] ([i915#3555])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb2/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [PASS][116] -> [FAIL][117] ([i915#1542])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-glk: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#2994])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/igt@[email protected]
* igt@sysfs_clients@recycle:
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl3/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@info:
- {shard-rkl}: [SKIP][120] ([i915#2582]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-3/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-6/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][122] ([i915#4525]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb1/igt@[email protected]
* igt@gem_exec_capture@pi@bcs0:
- shard-skl: [INCOMPLETE][124] ([i915#3371]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl6/igt@gem_exec_capture@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl7/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][126] ([i915#2842]) -> [PASS][127] +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-tglb2/igt@gem_exec_fair@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [FAIL][128] ([i915#2842]) -> [PASS][129] +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk3/igt@gem_exec_fair@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][130] ([i915#2842]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-tglu-2/igt@gem_exec_fair@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglu-4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][132] ([i915#3281]) -> [PASS][133] +8 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-5/igt@[email protected]
* igt@gem_pwrite_snooped:
- {shard-rkl}: [SKIP][134] ([i915#3282]) -> [PASS][135] +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-6/igt@gem_pwrite_snooped.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-5/igt@gem_pwrite_snooped.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][136] ([i915#5566] / [i915#716]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk1/igt@[email protected]
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][138] ([i915#2527]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-1/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][140] ([i915#4281]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-tglu-5/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglu-2/igt@[email protected]
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][142] ([i915#1849]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-5/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rps@min-max-config-idle:
- {shard-rkl}: [FAIL][144] ([i915#4016]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-1/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-5/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][146] ([i915#5334]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk7/igt@i915_selftest@live@gt_heartbeat.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][148] ([i915#1845] / [i915#4098]) -> [PASS][149] +14 similar issues
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-3/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][150] ([i915#2346]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk7/igt@kms_cursor_legacy@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk9/igt@kms_cursor_legacy@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-dg1}: [FAIL][152] ([i915#4767]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-dg1-19/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-dg1-18/igt@[email protected]
- shard-apl: [INCOMPLETE][154] ([i915#180] / [i915#1982] / [i915#4939]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-apl3/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl3/igt@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [FAIL][156] ([i915#4767]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl1/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl1/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][158] ([i915#2122]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl10/igt@kms_flip@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
- {shard-tglu}: [FAIL][160] -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-tglu-5/igt@kms_flip@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglu-4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- {shard-rkl}: [SKIP][162] ([i915#1849] / [i915#4098]) -> [PASS][163] +7 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-3/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-skl: [DMESG-WARN][164] ([i915#1982]) -> [PASS][165] +1 similar issue
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][166] ([i915#180]) -> [PASS][167] +3 similar issues
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-apl1/igt@kms_hdr@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-apl2/igt@kms_hdr@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][168] ([i915#5235]) -> [PASS][169] +5 similar issues
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][170] ([fdo#109441]) -> [PASS][171] +1 similar issue
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@suspend:
- {shard-rkl}: [SKIP][172] ([i915#1072]) -> [PASS][173]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-rkl-3/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][174] ([i915#5519]) -> [PASS][175]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-tglb5/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-tglb5/igt@[email protected]
- shard-iclb: [SKIP][176] ([i915#5519]) -> [PASS][177] +1 similar issue
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-iclb5/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-iclb2/igt@[email protected]
* igt@perf@short-reads:
- shard-skl: [FAIL][178] ([i915#51]) -> [PASS][179]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl7/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl1/igt@[email protected]
#### Warnings ####
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-glk: [SKIP][180] ([fdo#109271]) -> [SKIP][181] ([fdo#109271] / [i915#1888])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-glk1/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-glk3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][182] ([i915#79]) -> [FAIL][183] ([i915#2122])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12217/shard-skl1/igt@kms_flip@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/shard-skl1/igt@kms_flip@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6474]: https://gitlab.freedesktop.org/drm/intel/issues/6474
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12217 -> Patchwork_109411v1
CI-20190529: 20190529
CI_DRM_12217: 62a55ad3add25f5819f6aafe2b18ab5ff97a0faf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6682: 8b73737b2adc2ef3381ca6ae5d261cd7a7342e83 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109411v1: 62a55ad3add25f5819f6aafe2b18ab5ff97a0faf @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109411v1/index.html
Quoted 12 lines · Jani Nikula
Currently i915 assumes all
drm_connectorsit encounters are embedded inintel_connectorsthat i915 allocated. Thedrm_writeback_connectorforces a design where this is not the case; we can't provide our own connector, and writeback embeds thedrm_connectorit initializes itself.To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in
intel_connector. Checking this is tedious, and would require an intermediate step withdrm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.
Quoted 4 lines
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
Any feedback on this one?
BR,
Jani.
Quoted 27 lines
BR,
Jani.Cc Arun R Murthy <[email protected]>Cc Dave Airlie <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterateintel_connectorsonlydrivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 5 lines · Jani Nikula
Currently i915 assumes all
drm_connectorsit encounters are embedded inintel_connectorsthat i915 allocated. Thedrm_writeback_connectorforces a design where this is not the case; we can't provide our own connector, and writeback embeds thedrm_connectorit initializes itself.
Quoted 7 lines
To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in
intel_connector. Checking this is tedious, and would require an intermediate step withdrm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.
We've been trying to hook up drm_writeback_connector in amdgpu and this would be really helpful. I've had to do liberal sprinkling of "!= DRM_MODE_CONNECTOR_WRITEBACK" all over the place.
Quoted 5 lines
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
I think this would be even better but also be much more work and impact every driver that implements writeback. FWIW, there was no way for me to add writeback connector handling without KASAN. Interpreting the connector wrong in one place leads to memory corruption and undefined behavior and is almost impossible to spot without KASAN.
This series is
Harry
Quoted 27 lines
BR,
Jani.Cc Arun R Murthy <[email protected]>Cc Dave Airlie <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterateintel_connectorsonlydrivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Re: [RFC 1/2] drm/connector: add connector list iteration with filtering
In reply to Jani NikulaHi Jani,
Thank you for the patch.
Quoted 49 lines · Jani Nikula
Add new function
drm_connector_list_iter_filter_begin()to initialize connector list iterator with a filter function. Subsequent iteration on the list will only return connectors on which the filter function returns true.Cc Arun R Murthy <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_connector.c | 57 ++++++++++++++++++++++++++------- include/drm/drm_connector.h | 9 ++++++ 2 files changed, 54 insertions(+), 12 deletions(-)drivers/gpu/drm/drm_connector.c +23
-0@@ -762,6 +762,29 @@ static struct lockdep_map connector_list_iter_dep_map = { };#endif +/** +* drm_connector_list_iter_filter_begin - initialize a connector_list iterator with filter +* @dev: DRM device +* @iter: connector_list iterator +* @filter: connector filter function +* @filter_context: context to be passed to the filter function +* +* Same as drm_connector_list_iter_begin(), but sets up the iterator to only +* return connectors where filter(connector) returns true. +*/ +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context) +{ + iter->dev = dev; + iter->conn =NULL ; + iter->filter = filter; + iter->filter_context = filter_context; +lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +} +EXPORT_SYMBOL (drm_connector_list_iter_filter_begin); +/** * drm_connector_list_iter_begin - initialize a connector_list iterator * @dev: DRM device
drivers/gpu/drm/drm_connector.c static struct lockdep_map connector_list_iter_dep_map = { · line 803
Quoted 9 lines
drivers/gpu/drm/drm_connector.c +1
-3@@ -775,9 +798,7 @@ static struct lockdep_map connector_list_iter_dep_map = {void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter) { - iter->dev = dev; - iter->conn =NULL ; -lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +drm_connector_list_iter_filter_begin (dev, iter,NULL ,NULL ); }EXPORT_SYMBOL (drm_connector_list_iter_begin);
I would have made this a static inline function in include/drm/drm_connector.h. Apart from that,
Quoted 76 lines
drivers/gpu/drm/drm_connector.c +21
-9@@ -800,15 +821,8 @@ __drm_connector_put_safe(struct drm_connector *conn)schedule_work (&config->connector_free_work); } -/** -* drm_connector_list_iter_next - return next connector -* @iter: connector_list iterator -* -* Returns: the next connector for @iter, or NULL when the list walk has -* completed. -*/ -struct drm_connector * -drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +static struct drm_connector * +__drm_connector_list_iter_next (struct drm_connector_list_iter *iter) {struct drm_connector *old_conn = iter->conn;struct drm_mode_config *config = &iter->dev->mode_config;@@ -836,6 +850,25 @@ drm_connector_list_iter_next(struct drm_connector_list_iter *iter)return iter->conn; } + +/** +* drm_connector_list_iter_next - return next connector +* @iter: connector_list iterator +* +* Returns: the next connector for @iter, or NULL when the list walk has +* completed. +*/ +struct drm_connector * +drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +{ +struct drm_connector *connector; + +while ((connector =__drm_connector_list_iter_next (iter)) && + iter->filter && !iter->filter (connector, iter->filter_context)) + ; + +return connector; +}EXPORT_SYMBOL (drm_connector_list_iter_next);/** include/drm/drm_connector.h +9
-0@@ -1868,6 +1868,9 @@ struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,void drm_mode_put_tile_group (struct drm_device *dev,struct drm_tile_group *tg); +typedef bool (*drm_connector_list_iter_filter_fn )(const struct drm_connector *connector, +void *filter_context); +/** * struct drm_connector_list_iter - connector_list iterator * @@ -1886,10 +1889,16 @@ struct drm_connector_list_iter {/* private: */ struct drm_device *dev;struct drm_connector *conn; +drm_connector_list_iter_filter_fn filter; +void *filter_context; };void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter); +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context);struct drm_connector *drm_connector_list_iter_next (struct drm_connector_list_iter *iter);void drm_connector_list_iter_end (struct drm_connector_list_iter *iter);
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 24 lines · Harry Wentland
Quoted 5 lines · Jani Nikula
Currently i915 assumes all
drm_connectorsit encounters are embedded inintel_connectorsthat i915 allocated. Thedrm_writeback_connectorforces a design where this is not the case; we can't provide our own connector, and writeback embeds thedrm_connectorit initializes itself.Quoted 7 lines
To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in
intel_connector. Checking this is tedious, and would require an intermediate step withdrm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.We've been trying to hook up
drm_writeback_connectorin amdgpu and this would be really helpful. I've had to do liberal sprinkling of "!=DRM_MODE_CONNECTOR_WRITEBACK" all over the place.Quoted 5 lines
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
Quoted 5 lines
I think this would be even better but also be much more work and impact every driver that implements writeback. FWIW, there was no way for me to add writeback connector handling without KASAN. Interpreting the connector wrong in one place leads to memory corruption and undefined behavior and is almost impossible to spot without KASAN.
Laurent, I once again plead - could we please reconsider this and give drivers the option to allocate and provide the drm_connector to writeback themselves?
All things considered I think that would be the safer option.
BR,
Jani.
Quoted 34 lines
This series is
Acked-by Harry Wentland <[email protected]>Harry
Quoted 27 lines
BR,
Jani.Cc Arun R Murthy <[email protected]>Cc Dave Airlie <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterateintel_connectorsonlydrivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Hi Jani,
Quoted 30 lines · Jani Nikula
Quoted 23 lines · Harry Wentland
Quoted 5 lines · Jani Nikula
Currently i915 assumes all
drm_connectorsit encounters are embedded inintel_connectorsthat i915 allocated. Thedrm_writeback_connectorforces a design where this is not the case; we can't provide our own connector, and writeback embeds thedrm_connectorit initializes itself.Quoted 7 lines
To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in
intel_connector. Checking this is tedious, and would require an intermediate step withdrm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.We've been trying to hook up
drm_writeback_connectorin amdgpu and this would be really helpful. I've had to do liberal sprinkling of "!=DRM_MODE_CONNECTOR_WRITEBACK" all over the place.Quoted 4 lines
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
Quoted 5 lines
I think this would be even better but also be much more work and impact every driver that implements writeback. FWIW, there was no way for me to add writeback connector handling without KASAN. Interpreting the connector wrong in one place leads to memory corruption and undefined behavior and is almost impossible to spot without KASAN.
Quoted 5 lines
Laurent, I once again plead - could we please reconsider this and give drivers the option to allocate and provide the
drm_connectorto writeback themselves?All things considered I think that would be the safer option.
I do think all this stems from the decision of using connectors for writeback, and we're paying the price for it now. It's painful in drivers, and that's why I would prefer hiding it from drivers and handling it completely in the DRM core. Ideally the connector enumeration API exposed to drivers should not even enumerate the writeback connectors by default.
I'm just a contributor to the subsystem, so I don't make the call. If there's a general consensus it's better to require all drivers to handle writeback connectors explicitly everywhere (Daniel and Dave may want to chime in here), I can be overruled, like anybody else.
Quoted 24 lines
Quoted 24 lines
This series is
Acked-by Harry Wentland <[email protected]>Quoted 21 lines
Cc Arun R Murthy <[email protected]>Cc Dave Airlie <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterateintel_connectorsonlydrivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 37 lines · Laurent Pinchart
Hi Jani,
Quoted 34 lines · Jani Nikula
Quoted 23 lines · Harry Wentland
Quoted 5 lines · Jani Nikula
Currently i915 assumes all
drm_connectorsit encounters are embedded inintel_connectorsthat i915 allocated. Thedrm_writeback_connectorforces a design where this is not the case; we can't provide our own connector, and writeback embeds thedrm_connectorit initializes itself.Quoted 7 lines
To use drm writeback, none of the i915 connector iteration could assume the drm connector is embedded in
intel_connector. Checking this is tedious, and would require an intermediate step withdrm_connector. Here's an idea I came up with; filtering at the drm connector iterator level with a caller supplied function. Not too much code, and could be used for other things as well.We've been trying to hook up
drm_writeback_connectorin amdgpu and this would be really helpful. I've had to do liberal sprinkling of "!=DRM_MODE_CONNECTOR_WRITEBACK" all over the place.Quoted 4 lines
Mind you, we'd still much rather modify drm writeback to allow passing the connector i915 allocated, instead of the current midlayer design that forces drivers to a certain model. Working around this is a bunch of error prone and tedious code that we really could do without.
Quoted 5 lines
I think this would be even better but also be much more work and impact every driver that implements writeback. FWIW, there was no way for me to add writeback connector handling without KASAN. Interpreting the connector wrong in one place leads to memory corruption and undefined behavior and is almost impossible to spot without KASAN.
Laurent, I once again plead - could we please reconsider this and give drivers the option to allocate and provide the
drm_connectorto writeback themselves?
Quoted 6 lines
Quoted 1 line
All things considered I think that would be the safer option.
I do think all this stems from the decision of using connectors for writeback, and we're paying the price for it now. It's painful in drivers, and that's why I would prefer hiding it from drivers and handling it completely in the DRM core.
Unfortunately, the current abstraction leaks to drivers in a way that's worse than just openly embracing the connector usage. :(
And we still have to provide the struct drm_connector_funcs pointer to writeback just as well.
Quoted 7 lines
Ideally the connector enumeration API exposed to drivers should not even enumerate the writeback connectors by default.
I'm just a contributor to the subsystem, so I don't make the call. If there's a general consensus it's better to require all drivers to handle writeback connectors explicitly everywhere (Daniel and Dave may want to chime in here), I can be overruled, like anybody else.
Well, outside of i915 I'm just a contributor too, and I prefer trying to find consensus between us rather than seeking maintainers to overrule other contributors!
Frankly, we pretty much already agreed to do what you originally suggested, even if we thought it was going to be a bunch of work, but we, and seems like AMD too, are finding it to also be quite error prone. It's just inherently clumsy to check the "sub class" type in C in runtime, or to even be sure when such checks aren't required.
BR,
Jani.
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
This series is
Acked-by Harry Wentland <[email protected]>Quoted 21 lines
Cc Arun R Murthy <[email protected]>Cc Dave Airlie <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Jani Nikula (2):
drm/connector: add connector list iteration with filtering drm/i915: iterateintel_connectorsonlydrivers/gpu/drm/drm_connector.c | 57 +++++++++++++++---- drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../drm/i915/display/intel_display_types.h | 7 +++ drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 12 ++-- .../drm/i915/display/intel_modeset_setup.c | 6 +- drivers/gpu/drm/i915/display/intel_opregion.c | 9 ++- include/drm/drm_connector.h | 9 +++ 10 files changed, 89 insertions(+), 26 deletions(-)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [RFC 1/2] drm/connector: add connector list iteration with filtering
In reply to Jani NikulaQuoted 34 lines · Jani Nikula
Add new function
drm_connector_list_iter_filter_begin()to initialize connector list iterator with a filter function. Subsequent iteration on the list will only return connectors on which the filter function returns true.Cc Arun R Murthy <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_connector.c | 57 ++++++++++++++++++++++++++------- include/drm/drm_connector.h | 9 ++++++ 2 files changed, 54 insertions(+), 12 deletions(-)drivers/gpu/drm/drm_connector.c +12
-0@@ -762,6 +762,29 @@ static struct lockdep_map connector_list_iter_dep_map = { };#endif +/** +* drm_connector_list_iter_filter_begin - initialize a connector_list iterator with filter +* @dev: DRM device +* @iter: connector_list iterator +* @filter: connector filter function +* @filter_context: context to be passed to the filter function +* +* Same as drm_connector_list_iter_begin(), but sets up the iterator to only +* return connectors where filter(connector) returns true. +*/ +void drm_connector_list_iter_filter_begin(struct drm_device *dev, + struct drm_connector_list_iter *iter,
drivers/gpu/drm/drm_connector.c static struct lockdep_map connector_list_iter_dep_map = { · line 786
Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10
-0+drm_connector_list_iter_filter_fn filter, + void *filter_context) +{ + iter->dev = dev; + iter->conn =NULL ; + iter->filter = filter; + iter->filter_context = filter_context; +lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +} +EXPORT_SYMBOL (drm_connector_list_iter_filter_begin);
So maybe I'm missing the obvious, but can't we just put a for_each_fi right after the for_each_connector_iter?
And then maybe provide a default filter to kick out connectors and maybe a macro that does the filtered iteration? The iter_begin/next/end is already fairly tricky pattern compared to plain for_each macro, I think we should try hard to not complicate it further with lots of variants if that's not absolutely necessary.
-Daniel
Quoted 93 lines
drivers/gpu/drm/drm_connector.c +23
-12+/** * drm_connector_list_iter_begin - initialize a connector_list iterator * @dev: DRM device @@ -775,9 +798,7 @@ static struct lockdep_map connector_list_iter_dep_map = {void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter) { - iter->dev = dev; - iter->conn =NULL ; -lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +drm_connector_list_iter_filter_begin (dev, iter,NULL ,NULL ); }EXPORT_SYMBOL (drm_connector_list_iter_begin);@@ -800,15 +821,8 @@ __drm_connector_put_safe(struct drm_connector *conn)schedule_work (&config->connector_free_work); } -/** -* drm_connector_list_iter_next - return next connector -* @iter: connector_list iterator -* -* Returns: the next connector for @iter, or NULL when the list walk has -* completed. -*/ -struct drm_connector * -drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +static struct drm_connector * +__drm_connector_list_iter_next (struct drm_connector_list_iter *iter) {struct drm_connector *old_conn = iter->conn;struct drm_mode_config *config = &iter->dev->mode_config;@@ -836,6 +850,25 @@ drm_connector_list_iter_next(struct drm_connector_list_iter *iter)return iter->conn; } + +/** +* drm_connector_list_iter_next - return next connector +* @iter: connector_list iterator +* +* Returns: the next connector for @iter, or NULL when the list walk has +* completed. +*/ +struct drm_connector * +drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +{ +struct drm_connector *connector; + +while ((connector =__drm_connector_list_iter_next (iter)) && + iter->filter && !iter->filter (connector, iter->filter_context)) + ; + +return connector; +}EXPORT_SYMBOL (drm_connector_list_iter_next);/** include/drm/drm_connector.h +9
-0@@ -1868,6 +1868,9 @@ struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,void drm_mode_put_tile_group (struct drm_device *dev,struct drm_tile_group *tg); +typedef bool (*drm_connector_list_iter_filter_fn )(const struct drm_connector *connector, +void *filter_context); +/** * struct drm_connector_list_iter - connector_list iterator * @@ -1886,10 +1889,16 @@ struct drm_connector_list_iter {/* private: */ struct drm_device *dev;struct drm_connector *conn; +drm_connector_list_iter_filter_fn filter; +void *filter_context; };void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter); +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context);struct drm_connector *drm_connector_list_iter_next (struct drm_connector_list_iter *iter);void drm_connector_list_iter_end (struct drm_connector_list_iter *iter);Signature · 1 line
2.34.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [RFC 1/2] drm/connector: add connector list iteration with filtering
Quoted 49 lines · Daniel Vetter
Quoted 34 lines · Jani Nikula
Add new function
drm_connector_list_iter_filter_begin()to initialize connector list iterator with a filter function. Subsequent iteration on the list will only return connectors on which the filter function returns true.Cc Arun R Murthy <[email protected]>Cc Suraj Kandpal <[email protected]>Cc Ville Syrjälä <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_connector.c | 57 ++++++++++++++++++++++++++------- include/drm/drm_connector.h | 9 ++++++ 2 files changed, 54 insertions(+), 12 deletions(-)drivers/gpu/drm/drm_connector.c +12
-0@@ -762,6 +762,29 @@ static struct lockdep_map connector_list_iter_dep_map = { };#endif +/** +* drm_connector_list_iter_filter_begin - initialize a connector_list iterator with filter +* @dev: DRM device +* @iter: connector_list iterator +* @filter: connector filter function +* @filter_context: context to be passed to the filter function +* +* Same as drm_connector_list_iter_begin(), but sets up the iterator to only +* return connectors where filter(connector) returns true. +*/ +void drm_connector_list_iter_filter_begin(struct drm_device *dev, + struct drm_connector_list_iter *iter,drivers/gpu/drm/drm_connector.c static struct lockdep_map connector_list_iter_dep_map = { · line 786
Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10
-0+drm_connector_list_iter_filter_fn filter, + void *filter_context) +{ + iter->dev = dev; + iter->conn =NULL ; + iter->filter = filter; + iter->filter_context = filter_context; +lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +} +EXPORT_SYMBOL (drm_connector_list_iter_filter_begin);So maybe I'm missing the obvious, but can't we just put a
for_each_firight after thefor_each_connector_iter?
Quoted 5 lines
And then maybe provide a default filter to kick out connectors and maybe a macro that does the filtered iteration? The iter_begin/next/end is already fairly tricky pattern compared to plain
for_eachmacro, I think we should try hard to not complicate it further with lots of variants if that's not absolutely necessary.
Sorry, dropped the ball here, and lost sight of it.
You mean not have any of this in drm core, and just add the for_each_if() in local wrappers everywhere?
BR,
Jani.
Quoted 96 lines
-Daniel
Quoted 93 lines
drivers/gpu/drm/drm_connector.c +23
-12+/** * drm_connector_list_iter_begin - initialize a connector_list iterator * @dev: DRM device @@ -775,9 +798,7 @@ static struct lockdep_map connector_list_iter_dep_map = {void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter) { - iter->dev = dev; - iter->conn =NULL ; -lock_acquire_shared_recursive (&connector_list_iter_dep_map,0 ,1 ,NULL , _RET_IP_); +drm_connector_list_iter_filter_begin (dev, iter,NULL ,NULL ); }EXPORT_SYMBOL (drm_connector_list_iter_begin);@@ -800,15 +821,8 @@ __drm_connector_put_safe(struct drm_connector *conn)schedule_work (&config->connector_free_work); } -/** -* drm_connector_list_iter_next - return next connector -* @iter: connector_list iterator -* -* Returns: the next connector for @iter, or NULL when the list walk has -* completed. -*/ -struct drm_connector * -drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +static struct drm_connector * +__drm_connector_list_iter_next (struct drm_connector_list_iter *iter) {struct drm_connector *old_conn = iter->conn;struct drm_mode_config *config = &iter->dev->mode_config;@@ -836,6 +850,25 @@ drm_connector_list_iter_next(struct drm_connector_list_iter *iter)return iter->conn; } + +/** +* drm_connector_list_iter_next - return next connector +* @iter: connector_list iterator +* +* Returns: the next connector for @iter, or NULL when the list walk has +* completed. +*/ +struct drm_connector * +drm_connector_list_iter_next (struct drm_connector_list_iter *iter) +{ +struct drm_connector *connector; + +while ((connector =__drm_connector_list_iter_next (iter)) && + iter->filter && !iter->filter (connector, iter->filter_context)) + ; + +return connector; +}EXPORT_SYMBOL (drm_connector_list_iter_next);/** include/drm/drm_connector.h +9
-0@@ -1868,6 +1868,9 @@ struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,void drm_mode_put_tile_group (struct drm_device *dev,struct drm_tile_group *tg); +typedef bool (*drm_connector_list_iter_filter_fn )(const struct drm_connector *connector, +void *filter_context); +/** * struct drm_connector_list_iter - connector_list iterator * @@ -1886,10 +1889,16 @@ struct drm_connector_list_iter {/* private: */ struct drm_device *dev;struct drm_connector *conn; +drm_connector_list_iter_filter_fn filter; +void *filter_context; };void drm_connector_list_iter_begin (struct drm_device *dev,struct drm_connector_list_iter *iter); +void drm_connector_list_iter_filter_begin (struct drm_device *dev, +struct drm_connector_list_iter *iter, +drm_connector_list_iter_filter_fn filter, +void *filter_context);struct drm_connector *drm_connector_list_iter_next (struct drm_connector_list_iter *iter);void drm_connector_list_iter_end (struct drm_connector_list_iter *iter);Signature · 1 line
2.34.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center