tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests
cover tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests
Divide the functional_test_pipe test into seven subtests based on CRC comparisons because this will make it easier to debug the test and help in detecting the failure.
First 7 patches decouple each subtest and run it individually keeping functional_test_pipe' test as it is. After making sure that each subtest can run individually with the expected result on both vkms and i915 drivers, improve the test by creating run_functional_test_pipe and call all subtests from it and call run_functional_test_pipe in igt_main`.
Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy and atomic
api
tests/kms_universal_plane: decouple verification of disabling primary
plane
tests/kms_universal_plane: decouple verification of re-enabling
primary plane
tests/kms_universal_plane: decouple verification of setup plane FB's
while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity to modeset
with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to move the
primary plane completely offscreen
tests/kms_universal_plane: decouple verification of ablity to
explicitly disable an already implicitly-disabled primary plane
tests/kms_universal_plane: create the run_functional_test_pipe and
call all tests from it
tests/kms_universal_plane.c | 416 ++++++++++++++++++++++-------------- 1 file changed, 261 insertions(+), 155 deletions(-)
Signature · 1 line
2.34.1
RFC PATCH 7/8 tests/kms_universal_plane: decouple verification of ablity to explicitly disable an already implicitly-disabled primary plane
decouple verification of ablity to explicitly disable an already implicitly-disabled primary plane in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 90 +++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+)
tests/kms_universal_plane.c +90 -0
@@ -537,6 +537,91 @@ test_set_primary_completely_offscreen(data_t *data, enum pipe pipe, igt_output_tfunctional_test_fini (&test, output); } + + +static void +test_explicitly_disable_primary (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = {.data = data}; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) + { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 3: Legacy API's, yellow primary (CRC 3) */ +igt_plane_set_fb (primary, &test.yellow_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3); + +/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4); + +/* Step 5: Universal API's, disable primary plane (CRC 5) */ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); + +/* +* Step 15: Explicitly disable primary after it's already been +* implicitly disabled (CRC 10). +*/ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_10); + +/* Step 16: Legacy API's, blue primary, red sprite */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); + +/* +* We should be able to explicitly disable an already +* implicitly-disabled primary plane +*/ +igt_assert_crc_equal (&test.crc_5, &test.crc_10); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +} + +/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -1238,6 +1323,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe) kmstest_pipe_name(pipe)) for_each_valid_output_on_pipe(&data->display, pipe, output) test_set_primary_completely_offscreen(data, pipe, output); + + igt_subtest_f("explicitly-disable-primary-%s", + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_explicitly_disable_primary (data, pipe, output);igt_describe ("Check the switching between different primary plane fbs with CRTC off" ); igt_subtest_f("universal-plane-pipe-%s-functional",
Signature · 1 line
2.34.1
RFC PATCH 6/8 tests/kms_universal_plane: decouple verification of ablity to move the primary plane completely offscreen
In reply to Alaa Emaddecouple verification of ablity to move the primary plane completely offscreen in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 90 +++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+)
tests/kms_universal_plane.c +90 -0
@@ -451,7 +451,92 @@ test_legacy_modeset_to_yellow_fb(data_t *data, enum pipe pipe, igt_output_t *outfunctional_test_fini (&test, output); } +static void +test_set_primary_completely_offscreen (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 3: Legacy API's, yellow primary (CRC 3) */ +igt_plane_set_fb (primary, &test.yellow_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3); +/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4); + +/* Step 5: Universal API's, disable primary plane (CRC 5) */ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); + +/* +* Step 14: Universal API, set primary completely offscreen (CRC 9). +* Skip on amdgpu which rejects offscreen planes. +*/ +if (!is_amdgpu_device (data->drm_fd)) { +igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, + output->config.crtc->crtc_id, + test.blue_fb.fb_id,0 , +9000 ,9000 , + test.mode->hdisplay, + test.mode->vdisplay, +IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), +IGT_FIXED (test.mode->hdisplay,0 ), +IGT_FIXED (test.mode->vdisplay,0 )) ==0 ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_9); + } + +/* +* We should be able to move the primary plane completely offscreen +* and have it disable successfully. Skip on amdgpu since crc_9 was +* skipped with offscreen planes previously. +*/ +if (!is_amdgpu_device (data->drm_fd)) +igt_assert_crc_equal (&test.crc_5, &test.crc_9); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +}/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -1149,6 +1234,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)for_each_valid_output_on_pipe (&data->display, pipe, output)test_legacy_modeset_to_yellow_fb (data, pipe, output); +igt_subtest_f ("set-primary-completely-offscreen-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_set_primary_completely_offscreen (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
RFC PATCH 3/8 tests/kms_universal_plane: decouple verification of re-enabling primary plane
In reply to Alaa Emaddecouple verification of re-enable primary plane in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 67 +++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+)
tests/kms_universal_plane.c +67 -0
@@ -234,6 +234,68 @@ test_disable_primary_red_sprite(data_t *data, enum pipe pipe, igt_output_t *outpfunctional_test_fini (&test, output); } +static void +test_re_enable_primary_with_blue (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); + +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); + +/* Step 6: Universal API's, re-enable primary with blue (CRC 6) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_6); + +/* Re-enabling primary should return to blue properly */ +igt_assert_crc_equal (&test.crc_2, &test.crc_6); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +}/* * Universal plane functional testing.
@@ -917,6 +979,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)for_each_valid_output_on_pipe (&data->display, pipe, output)test_disable_primary_red_sprite (data, pipe, output); +igt_subtest_f ("re-enable-primary-with-blue-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_re_enable_primary_with_blue (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
RFC PATCH 5/8 tests/kms_universal_plane: decouple verification of ablity to modeset with the primary plane off
In reply to Alaa Emaddecouple verification of ablity to modeset with the primary plane off in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 72 +++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+)
tests/kms_universal_plane.c +72 -0
@@ -385,6 +385,73 @@ test_universal_api_with_crtc_off(data_t *data, enum pipe pipe, igt_output_t *outfunctional_test_fini (&test, output); } +static void +test_legacy_modeset_to_yellow_fb (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 3: Legacy API's, yellow primary (CRC 3) */ +igt_plane_set_fb (primary, &test.yellow_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3); + +/* Step 11: Disable primary plane */ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); + +/* Step 12: Legacy modeset to yellow FB (CRC 8) */ +igt_plane_set_fb (primary, &test.yellow_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_8); + +/* +* We should be able to modeset with the primary plane off +* successfully +*/ +igt_assert_crc_equal (&test.crc_3, &test.crc_8); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +} + +/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -1077,6 +1144,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)for_each_valid_output_on_pipe (&data->display, pipe, output)test_universal_api_with_crtc_off (data, pipe, output); +igt_subtest_f ("legacy-modeset-to-yellow-fb-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_legacy_modeset_to_yellow_fb (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
RFC PATCH 1/8 tests/kms_universal_plane: decouple verification of legacy and atomic api
In reply to Alaa Emaddecouple the verification of leagacy and atomic api in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 68 +++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+)
tests/kms_universal_plane.c +68 -0
@@ -112,6 +112,68 @@ functional_test_fini(functional_test_t *test, igt_output_t *output)igt_display_commit2 (&test->data->display,COMMIT_LEGACY ); } +static void +test_legacy_atomic_interfaces (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); + +/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4); + + +/* Blue bg + red sprite should be same under both types of API's */ +igt_assert_crc_equal (&test.crc_2, &test.crc_4); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +} +/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -782,6 +844,12 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)igt_require_f (valid_tests,"no valid crtc/connector combinations found\n" ); } +igt_describe ("Blue bg + red sprite should be same under both types of API's" ); +igt_subtest_f ("blue-primary-red-sprite-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_legacy_atomic_interfaces (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
RFC PATCH 8/8 tests/kms_universal_plane: create the run_functional_test_pipe and call all tests from it
In reply to Alaa Emadafter decoupling functional_test_pipe to seven subtests, create the run_functional_test_pipe and call all tests from it and improve subtests's code.
--- tests/kms_universal_plane.c | 749 ++++++++---------------------------- 1 file changed, 154 insertions(+), 595 deletions(-)
tests/kms_universal_plane.c +154 -595
@@ -68,8 +68,7 @@ functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pidata_t *data = test->data;drmModeModeInfo *mode; - test->pipe_crc =igt_pipe_crc_new (data->drm_fd, pipe, -IGT_PIPE_CRC_SOURCE_AUTO ); + test->pipe_crc =igt_pipe_crc_new (data->drm_fd, pipe,IGT_PIPE_CRC_SOURCE_AUTO );igt_output_set_pipe (output, pipe);
@@ -113,399 +112,167 @@ functional_test_fini(functional_test_t *test, igt_output_t *output) }static void -test_legacy_atomic_interfaces (data_t *data,enum pipe pipe,igt_output_t *output) +test_legacy_atomic_interfaces (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; - -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); - -/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +/* Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_2); -/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +/* Universal API's, blue primary, red sprite (CRC 4) */ +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4); - +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_4);/* Blue bg + red sprite should be same under both types of API's */ -igt_assert_crc_equal (&test.crc_2, &test.crc_4); +igt_assert_crc_equal (&test->crc_2, &test->crc_4); -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); }static void -test_disable_primary_red_sprite (data_t *data,enum pipe pipe,igt_output_t *output) +test_disable_primary_red_sprite (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; - -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); -/* Step 1: Legacy API's, black primary, red sprite (CRC 1) */ -igt_plane_set_fb (primary, &test.black_fb); -igt_plane_set_fb (sprite, &test.red_fb); +/* Legacy API's, black primary, red sprite (CRC 1) */ +igt_plane_set_fb (primary, &test->black_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_1); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_1); -/* Step 5: Universal API's, disable primary plane (CRC 5) */ +/* Universal API's, disable primary plane (CRC 5) */ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_5);/* Disabling primary plane should be same as black primary */ -igt_assert_crc_equal (&test.crc_1, &test.crc_5); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); +igt_assert_crc_equal (&test->crc_1, &test->crc_5); -functional_test_fini (&test, output); }static void -test_re_enable_primary_with_blue (data_t *data,enum pipe pipe,igt_output_t *output) +test_re_enable_primary_with_blue (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); - -/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +/* Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_2);igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -/* Step 6: Universal API's, re-enable primary with blue (CRC 6) */ -igt_plane_set_fb (primary, &test.blue_fb); +/* Universal API's, re-enable primary with blue (CRC 6) */ +igt_plane_set_fb (primary, &test->blue_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_6); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_6);/* Re-enabling primary should return to blue properly */ -igt_assert_crc_equal (&test.crc_2, &test.crc_6); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); +igt_assert_crc_equal (&test->crc_2, &test->crc_6); }static void -test_universal_api_with_crtc_off (data_t *data,enum pipe pipe,igt_output_t *output) +test_universal_api_with_crtc_off (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); - -/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +/* Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_2); -/* Step 7: Legacy API's, yellow primary, no sprite */ -igt_plane_set_fb (primary, &test.yellow_fb); +/* Legacy API's, yellow primary, no sprite */ +igt_plane_set_fb (primary, &test->yellow_fb);igt_plane_set_fb (sprite,NULL );igt_display_commit2 (display,COMMIT_LEGACY ); -/* Step 8: Disable CRTC */ +/* Disable CRTC */ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_LEGACY ); -/* Step 9: Universal API's with crtc off: +/* Universal API's with crtc off: * - red sprite * - multiple primary fb's, ending in blue */ -igt_plane_set_fb (sprite, &test.red_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.yellow_fb); +igt_plane_set_fb (primary, &test->yellow_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.black_fb); +igt_plane_set_fb (primary, &test->black_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (primary, &test->blue_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -/* Step 10: Enable crtc (fb = -1), take CRC (CRC 7) */ +/* Enable crtc (fb = -1), take CRC (CRC 7) */ igt_assert (drmModeSetCrtc (data->drm_fd, output->config.crtc->crtc_id,-1 ,0 ,0 , &output->config.connector->connector_id, -1 , test.mode) ==0 ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_7); - +1 , test->mode) ==0 ); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_7);/* * We should be able to setup plane FB's while CRTC is disabled and * then have them pop up correctly when the CRTC is re-enabled. */ -igt_assert_crc_equal (&test.crc_2, &test.crc_7); - - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); +igt_assert_crc_equal (&test->crc_2, &test->crc_7); }static void -test_legacy_modeset_to_yellow_fb (data_t *data,enum pipe pipe,igt_output_t *output) +test_legacy_modeset_to_yellow_fb (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); - -/* Step 3: Legacy API's, yellow primary (CRC 3) */ -igt_plane_set_fb (primary, &test.yellow_fb); +/* Legacy API's, yellow primary (CRC 3) */ +igt_plane_set_fb (primary, &test->yellow_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_3); -/* Step 11: Disable primary plane */ +/* Disable primary plane */ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -/* Step 12: Legacy modeset to yellow FB (CRC 8) */ -igt_plane_set_fb (primary, &test.yellow_fb); +/* Legacy modeset to yellow FB (CRC 8) */ +igt_plane_set_fb (primary, &test->yellow_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_8); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_8);/* * We should be able to modeset with the primary plane off * successfully */ -igt_assert_crc_equal (&test.crc_3, &test.crc_8); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); +igt_assert_crc_equal (&test->crc_3, &test->crc_8); }static void -test_set_primary_completely_offscreen (data_t *data,enum pipe pipe,igt_output_t *output) +test_set_primary_completely_offscreen (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = { .data = data }; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; - -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 );/* Step 3: Legacy API's, yellow primary (CRC 3) */ -igt_plane_set_fb (primary, &test.yellow_fb); +igt_plane_set_fb (primary, &test->yellow_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3);/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4);/* Step 5: Universal API's, disable primary plane (CRC 5) */ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_5);/* * Step 14: Universal API, set primary completely offscreen (CRC 9).
@@ -514,14 +281,14 @@ test_set_primary_completely_offscreen(data_t *data, enum pipe pipe, igt_output_tif (!is_amdgpu_device (data->drm_fd)) {igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, output->config.crtc->crtc_id, - test.blue_fb.fb_id,0 , + test->blue_fb.fb_id,0 ,9000 ,9000 , - test.mode->hdisplay, - test.mode->vdisplay, + test->mode->hdisplay, + test->mode->vdisplay,IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (test.mode->hdisplay,0 ), -IGT_FIXED (test.mode->vdisplay,0 )) ==0 ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_9); +IGT_FIXED (test->mode->hdisplay,0 ), +IGT_FIXED (test->mode->vdisplay,0 )) ==0 ); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_9); }/*
@@ -530,71 +297,28 @@ test_set_primary_completely_offscreen(data_t *data, enum pipe pipe, igt_output_t* skipped with offscreen planes previously. */ if (!is_amdgpu_device (data->drm_fd)) -igt_assert_crc_equal (&test.crc_5, &test.crc_9); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); +igt_assert_crc_equal (&test->crc_5, &test->crc_9); } -static void -test_explicitly_disable_primary (data_t *data,enum pipe pipe,igt_output_t *output) +test_explicitly_disable_primary (functional_test_t *test,igt_plane_t *primary,igt_plane_t *sprite,igt_output_t *output) { -functional_test_t test = {.data = data}; +data_t *data = test->data;igt_display_t *display = &data->display; -igt_plane_t *primary, *sprite; -int num_primary =0 , num_cursor =0 ; -int i; - -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) - { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 );/* Step 3: Legacy API's, yellow primary (CRC 3) */ -igt_plane_set_fb (primary, &test.yellow_fb); +igt_plane_set_fb (primary, &test->yellow_fb);igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3);/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); +igt_plane_set_fb (primary, &test->blue_fb); +igt_plane_set_fb (sprite, &test->red_fb);igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4);/* Step 5: Universal API's, disable primary plane (CRC 5) */ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_5);/* * Step 15: Explicitly disable primary after it's already been
@@ -602,23 +326,13 @@ test_explicitly_disable_primary(data_t *data, enum pipe pipe, igt_output_t *outp*/ igt_plane_set_fb (primary,NULL );igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_10); - -/* Step 16: Legacy API's, blue primary, red sprite */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test->pipe_crc, &test->crc_10);/* * We should be able to explicitly disable an already * implicitly-disabled primary plane */ -igt_assert_crc_equal (&test.crc_5, &test.crc_10); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); +igt_assert_crc_equal (&test->crc_5, &test->crc_10); }
@@ -638,196 +352,90 @@ test_explicitly_disable_primary(data_t *data, enum pipe pipe, igt_output_t *outp* - Enable CRTC, grab CRC:6 (should be same as CRC:2) */ static void -functional_test_pipe (data_t *data,enum pipe pipe,igt_output_t *output) +run_functional_test_pipe (data_t *data,enum pipe pipe) { -functional_test_t test = { .data = data }; + +igt_output_t *output; + +functional_test_t test = {.data = data};igt_display_t *display = &data->display;igt_plane_t *primary, *sprite;int num_primary =0 , num_cursor =0 ;int i; + +struct { +const char *name; +void (*testfunc) (functional_test_t *,igt_plane_t *,igt_plane_t * ,igt_output_t *); +const char *desc; + } functional_tests[] = { + {"test-legacy-atomic-interfaces" , test_legacy_atomic_interfaces, +" Blue bg + red sprite should be same under both types of API's " }, -igt_require_pipe (display, pipe); - -igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), -kmstest_pipe_name (pipe)); - -functional_test_init (&test, output, pipe); - -/* -* Make sure we have no more than one primary or cursor plane per crtc. -* If the kernel accidentally calls drm_plane_init() rather than -* drm_universal_plane_init(), the type enum can get interpreted as a -* boolean and show up in userspace as the wrong type. -*/ -for (i =0 ; i < display->pipes[pipe].n_planes; i++) -if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) - num_primary++; -else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) - num_cursor++; - -igt_warn_on (num_primary !=1 ); -igt_warn_on (num_cursor >1 ); - - primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); - sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); -if (!sprite) { -functional_test_fini (&test, output); -igt_skip ("No sprite plane available\n" ); - } - -igt_plane_set_position (sprite,100 ,100 ); - -/* Step 1: Legacy API's, black primary, red sprite (CRC 1) */ -igt_plane_set_fb (primary, &test.black_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_1); - -/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); - -/* Step 3: Legacy API's, yellow primary (CRC 3) */ -igt_plane_set_fb (primary, &test.yellow_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_3); - -/* Step 4: Universal API's, blue primary, red sprite (CRC 4) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_4); - -/* Step 5: Universal API's, disable primary plane (CRC 5) */ -if (!is_amdgpu_device (data->drm_fd)) { -igt_plane_set_fb (primary,NULL ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); - } + {"test-disable-primary-red-sprite" , test_disable_primary_red_sprite, +"Disabling primary plane should be same as black primary " }, -/* Step 6: Universal API's, re-enable primary with blue (CRC 6) */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_6); + {"test-re-enable-primary-with-blue" , test_re_enable_primary_with_blue, +"Re-enabling primary should return to blue properly " }, -/* Step 7: Legacy API's, yellow primary, no sprite */ -igt_plane_set_fb (primary, &test.yellow_fb); -igt_plane_set_fb (sprite,NULL ); -igt_display_commit2 (display,COMMIT_LEGACY ); + {"test-universal-api-with-crtc-off" , test_universal_api_with_crtc_off, +" setup plane FB's while CRTC is disabled and then have them pop up correctly when the CRTC is re-enabled" }, -/* Step 8: Disable CRTC */ -igt_plane_set_fb (primary,NULL ); -igt_display_commit2 (display,COMMIT_LEGACY ); + {"test-legacy-modeset-to-yellow-fb" , test_legacy_modeset_to_yellow_fb, +" modeset with the primary plane off successfully" }, -/* Step 9: Universal API's with crtc off: -* - red sprite -* - multiple primary fb's, ending in blue -*/ -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.yellow_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.black_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_plane_set_fb (primary, &test.blue_fb); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); + {"test-set-primary-completely-offscreen" , test_set_primary_completely_offscreen, +" move the primary plane completely offscreen" }, -/* Step 10: Enable crtc (fb = -1), take CRC (CRC 7) */ -igt_assert (drmModeSetCrtc (data->drm_fd, output->config.crtc->crtc_id,-1 , -0 ,0 , &output->config.connector->connector_id, -1 , test.mode) ==0 ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_7); - -/* Step 11: Disable primary plane */ -igt_output_set_pipe (output,PIPE_NONE ); -igt_display_commit2 (display,COMMIT_ATOMIC ); -igt_plane_set_fb (primary,NULL ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); - -/* Step 12: Legacy modeset to yellow FB (CRC 8) */ -igt_plane_set_fb (primary, &test.yellow_fb); -igt_output_set_pipe (output, pipe); -igt_display_commit2 (display,COMMIT_LEGACY ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_8); - -/* Step 13: Legacy API', blue primary, red sprite */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); + {"test-explicitly-disable-primary" , test_explicitly_disable_primary, +"explicitly disable an already implicitly-disabled primary plane " } + }; -/* -* Step 14: Universal API, set primary completely offscreen (CRC 9). -* Skip on amdgpu which rejects offscreen planes. -*/ -if (!is_amdgpu_device (data->drm_fd)) { -igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, - output->config.crtc->crtc_id, - test.blue_fb.fb_id,0 , -9000 ,9000 , - test.mode->hdisplay, - test.mode->vdisplay, -IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (test.mode->hdisplay,0 ), -IGT_FIXED (test.mode->vdisplay,0 )) ==0 ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_9); + igt_fixture { +igt_require_pipe (&data->display, pipe); } -/* -* Step 15: Explicitly disable primary after it's already been -* implicitly disabled (CRC 10). -*/ -if (!is_amdgpu_device (data->drm_fd)) { -igt_plane_set_fb (primary,NULL ); -igt_display_commit2 (display,COMMIT_UNIVERSAL ); -igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_10); +for (int index =0 ; index <ARRAY_SIZE (functional_tests); index++) { +igt_describe (functional_tests[index].desc); + igt_subtest_group { + igt_subtest_f("%s-%s",functional_tests[index].name, kmstest_pipe_name(pipe)) { +for_each_valid_output_on_pipe (&data->display, pipe, output) { +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); + +if (!sprite) + { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + + functional_tests[index].testfunc (&test, primary, sprite, output); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); + } + } + } } - -/* Step 16: Legacy API's, blue primary, red sprite */ -igt_plane_set_fb (primary, &test.blue_fb); -igt_plane_set_fb (sprite, &test.red_fb); -igt_display_commit2 (display,COMMIT_LEGACY ); - -/* Blue bg + red sprite should be same under both types of API's */ -igt_assert_crc_equal (&test.crc_2, &test.crc_4); - -/* Disabling primary plane should be same as black primary */ -if (!is_amdgpu_device (data->drm_fd)) -igt_assert_crc_equal (&test.crc_1, &test.crc_5); - -/* Re-enabling primary should return to blue properly */ -igt_assert_crc_equal (&test.crc_2, &test.crc_6); - -/* -* We should be able to setup plane FB's while CRTC is disabled and -* then have them pop up correctly when the CRTC is re-enabled. -*/ -igt_assert_crc_equal (&test.crc_2, &test.crc_7); - -/* -* We should be able to modeset with the primary plane off -* successfully -*/ -igt_assert_crc_equal (&test.crc_3, &test.crc_8); - -/* -* We should be able to move the primary plane completely offscreen -* and have it disable successfully. Skip on amdgpu since crc_9 was -* skipped with offscreen planes previously. -*/ -igt_assert_crc_equal (&test.crc_5, &test.crc_9); - -/* -* We should be able to explicitly disable an already -* implicitly-disabled primary plane -*/ -igt_assert_crc_equal (&test.crc_5, &test.crc_10); - -igt_plane_set_fb (primary,NULL ); -igt_plane_set_fb (sprite,NULL ); - -functional_test_fini (&test, output); } static void
@@ -907,7 +515,6 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)* doesn't cover CRTC (should fail on pre-gen9 and succeed on * gen9+). */ -igt_require_intel (data->drm_fd);igt_plane_set_fb (primary, &test.undersized_fb); expect = (data->display_ver <9 ) ? -EINVAL :0 ;igt_assert (igt_display_try_commit2 (&data->display,COMMIT_UNIVERSAL ) == expect);
@@ -1015,8 +622,6 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_display_commit2 (&data->display,COMMIT_LEGACY );/* Disable the primary plane */ -igt_output_set_pipe (output,PIPE_NONE ); -igt_display_commit2 (&data->display,COMMIT_ATOMIC );igt_plane_set_fb (primary,NULL );igt_display_commit2 (&data->display,COMMIT_UNIVERSAL );
@@ -1026,7 +631,6 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)* Note that crtc->primary->fb = NULL causes flip to return EBUSY for * historical reasons... */ -igt_output_set_pipe (output, pipe);igt_assert (drmModePageFlip (data->drm_fd, output->config.crtc->crtc_id, test.red_fb.fb_id,0 ,NULL ) == -EBUSY );
@@ -1041,13 +645,9 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)* completes, which we don't have a good way to specifically test for, * but at least we can make sure that nothing blows up. */ -igt_output_set_pipe (output, pipe); -igt_display_commit2 (&data->display,COMMIT_ATOMIC );igt_assert (drmModePageFlip (data->drm_fd, output->config.crtc->crtc_id, test.red_fb.fb_id,DRM_MODE_PAGE_FLIP_EVENT , &test) ==0 ); -igt_output_set_pipe (output,PIPE_NONE ); -igt_display_commit2 (&data->display,COMMIT_ATOMIC );igt_plane_set_fb (primary,NULL );igt_display_commit2 (&data->display,COMMIT_UNIVERSAL );
@@ -1112,7 +712,6 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_require_pipe (display, pipe);igt_require (display->has_cursor_plane); -igt_require_intel (data->drm_fd);igt_output_set_pipe (output, pipe); mode =igt_output_get_mode (output);
@@ -1292,49 +891,6 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)igt_require_f (valid_tests,"no valid crtc/connector combinations found\n" ); } -igt_describe ("Blue bg + red sprite should be same under both types of API's" ); -igt_subtest_f ("blue-primary-red-sprite-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_legacy_atomic_interfaces (data, pipe, output); - -igt_describe ("Check the switching between different primary plane fbs with CRTC off" ); -igt_subtest_f ("disable-primary-red-sprite-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_disable_primary_red_sprite (data, pipe, output); - -igt_subtest_f ("re-enable-primary-with-blue-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_re_enable_primary_with_blue (data, pipe, output); - -igt_subtest_f ("universal-api-with-crtc-off-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_universal_api_with_crtc_off (data, pipe, output); - -igt_subtest_f ("legacy-modeset-to-yellow-fb-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_legacy_modeset_to_yellow_fb (data, pipe, output); - -igt_subtest_f ("set-primary-completely-offscreen-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_set_primary_completely_offscreen (data, pipe, output); - -igt_subtest_f ("explicitly-disable-primary-%s" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -test_explicitly_disable_primary (data, pipe, output); - -igt_describe ("Check the switching between different primary plane fbs with CRTC off" ); -igt_subtest_f ("universal-plane-pipe-%s-functional" , - kmstest_pipe_name(pipe)) -for_each_valid_output_on_pipe (&data->display, pipe, output) -functional_test_pipe (data, pipe, output); -igt_describe ("Test for scale-up or scale-down using universal plane API without covering CRTC" );igt_subtest_f ("universal-plane-pipe-%s-sanity" ,kmstest_pipe_name (pipe))
@@ -1379,12 +935,15 @@ igt_main }for_each_pipe_static (pipe) { + +igt_subtest_group + run_functional_test_pipe(&data, pipe); +igt_subtest_group - run_tests_for_pipe(&data, pipe); + run_tests_for_pipe(&data, pipe); } igt_fixture {igt_display_fini (&data.display); -close (data.drm_fd); } }
Signature · 1 line
2.34.1
Please, let me know your thoughts.
Quoted 32 lines · Alaa Emad
Divide the
functional_test_pipetest into seven subtests based on CRC comparisons because this will make it easier to debug the test and help in detecting the failure.First 7 patches decouple each subtest and run it individually keeping
functional_test_pipe' test as it is. After making sure that each subtest can run individually with the expected result on both vkms and i915 drivers, improve the test by creatingrun_functional_test_pipeand call all subtests from it and callrun_functional_test_pipeinigt_main`.Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy and atomic
api
tests/kms_universal_plane: decouple verification of disabling primary
plane
tests/kms_universal_plane: decouple verification of re-enabling
primary plane
tests/kms_universal_plane: decouple verification of setup plane FB's
while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity to modeset
with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to move the
primary plane completely offscreen
tests/kms_universal_plane: decouple verification of ablity to
explicitly disable an already implicitly-disabled primary plane
tests/kms_universal_plane: create therun_functional_test_pipeand
call all tests from ittests/kms_universal_plane.c | 416 ++++++++++++++++++++++-------------- 1 file changed, 261 insertions(+), 155 deletions(-)
RFC PATCH 4/8 tests/kms_universal_plane: decouple verification of setup plane FB's while CRTC is disabled
In reply to Alaa Emaddecouple verification of setup plane FB's while CRTC is disabled in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 93 +++++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+)
tests/kms_universal_plane.c +93 -0
@@ -297,6 +297,94 @@ test_re_enable_primary_with_blue(data_t *data, enum pipe pipe, igt_output_t *outfunctional_test_fini (&test, output); } +static void +test_universal_api_with_crtc_off (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 2: Legacy API', blue primary, red sprite (CRC 2) */ +igt_plane_set_fb (primary, &test.blue_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_2); + +/* Step 7: Legacy API's, yellow primary, no sprite */ +igt_plane_set_fb (primary, &test.yellow_fb); +igt_plane_set_fb (sprite,NULL ); +igt_display_commit2 (display,COMMIT_LEGACY ); + +/* Step 8: Disable CRTC */ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_LEGACY ); + +/* Step 9: Universal API's with crtc off: +* - red sprite +* - multiple primary fb's, ending in blue +*/ +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_plane_set_fb (primary, &test.yellow_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_plane_set_fb (primary, &test.black_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_plane_set_fb (primary, &test.blue_fb); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); + +/* Step 10: Enable crtc (fb = -1), take CRC (CRC 7) */ +igt_assert (drmModeSetCrtc (data->drm_fd, output->config.crtc->crtc_id,-1 , +0 ,0 , &output->config.connector->connector_id, +1 , test.mode) ==0 ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_7); + + +/* +* We should be able to setup plane FB's while CRTC is disabled and +* then have them pop up correctly when the CRTC is re-enabled. +*/ +igt_assert_crc_equal (&test.crc_2, &test.crc_7); + + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +} +/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -984,6 +1072,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)for_each_valid_output_on_pipe (&data->display, pipe, output)test_re_enable_primary_with_blue (data, pipe, output); +igt_subtest_f ("universal-api-with-crtc-off-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_universal_api_with_crtc_off (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
RFC PATCH 2/8 tests/kms_universal_plane: decouple verification of disabling primary plane
In reply to Alaa Emaddecouple verification of disabling primary plane in a separated subtests to be able to run it individually, creating the function.
--- tests/kms_universal_plane.c | 67 +++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+)
tests/kms_universal_plane.c +67 -0
@@ -174,6 +174,67 @@ test_legacy_atomic_interfaces(data_t *data, enum pipe pipe, igt_output_t *outputfunctional_test_fini (&test, output); } +static void +test_disable_primary_red_sprite (data_t *data,enum pipe pipe,igt_output_t *output) +{ +functional_test_t test = { .data = data }; +igt_display_t *display = &data->display; +igt_plane_t *primary, *sprite; +int num_primary =0 , num_cursor =0 ; +int i; + +igt_require_pipe (display, pipe); + +igt_info ("Testing connector %s using pipe %s\n" ,igt_output_name (output), +kmstest_pipe_name (pipe)); + +functional_test_init (&test, output, pipe); + +/* +* Make sure we have no more than one primary or cursor plane per crtc. +* If the kernel accidentally calls drm_plane_init() rather than +* drm_universal_plane_init(), the type enum can get interpreted as a +* boolean and show up in userspace as the wrong type. +*/ +for (i =0 ; i < display->pipes[pipe].n_planes; i++) +if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_PRIMARY ) + num_primary++; +else if (display->pipes[pipe].planes[i].type ==DRM_PLANE_TYPE_CURSOR ) + num_cursor++; + +igt_warn_on (num_primary !=1 ); +igt_warn_on (num_cursor >1 ); + + primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY ); + sprite =igt_output_get_plane_type (output,DRM_PLANE_TYPE_OVERLAY ); +if (!sprite) { +functional_test_fini (&test, output); +igt_skip ("No sprite plane available\n" ); + } + +igt_plane_set_position (sprite,100 ,100 ); + +/* Step 1: Legacy API's, black primary, red sprite (CRC 1) */ +igt_plane_set_fb (primary, &test.black_fb); +igt_plane_set_fb (sprite, &test.red_fb); +igt_display_commit2 (display,COMMIT_LEGACY ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_1); + +/* Step 5: Universal API's, disable primary plane (CRC 5) */ +igt_plane_set_fb (primary,NULL ); +igt_display_commit2 (display,COMMIT_UNIVERSAL ); +igt_pipe_crc_collect_crc (test.pipe_crc, &test.crc_5); + +/* Disabling primary plane should be same as black primary */ +igt_assert_crc_equal (&test.crc_1, &test.crc_5); + +igt_plane_set_fb (primary,NULL ); +igt_plane_set_fb (sprite,NULL ); + +functional_test_fini (&test, output); +} + +/* * Universal plane functional testing. * - Black primary plane via traditional interfaces, red sprite, grab CRC:1.
@@ -850,6 +911,12 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)for_each_valid_output_on_pipe (&data->display, pipe, output)test_legacy_atomic_interfaces (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" ); +igt_subtest_f ("disable-primary-red-sprite-%s" , + kmstest_pipe_name(pipe)) +for_each_valid_output_on_pipe (&data->display, pipe, output) +test_disable_primary_red_sprite (data, pipe, output); +igt_describe ("Check the switching between different primary plane fbs with CRTC off" );igt_subtest_f ("universal-plane-pipe-%s-functional" ,kmstest_pipe_name (pipe))
Signature · 1 line
2.34.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests
In reply to Alaa Emad== Series Details ==
== Series Details ==
Series: tests/kms_universal_plane: divide functional_test_pipe to mini-subtests
URL : https://patchwork.freedesktop.org/series/110797/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12369 -> IGTPW_8086
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
Participating hosts (40 -> 39)
------------------------------
Additional (1): fi-tgl-dsi
Missing (2): fi-ctg-p8600 fi-bdw-samus
Known issues
------------
Here are the changes found in IGTPW_8086 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [PASS][1] -> [INCOMPLETE][2] ([i915#7056])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/fi-apl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/fi-apl-guc/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/fi-hsw-4770/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][4] ([i915#2867]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/bat-rplp-1/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rpls-1}: [DMESG-WARN][6] ([i915#6687]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][8] ([i915#4785]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/fi-hsw-4770/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][10] ([i915#6367]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/bat-rpls-1/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7056]: https://gitlab.freedesktop.org/drm/intel/issues/7056
[i915#7058]: https://gitlab.freedesktop.org/drm/intel/issues/7058
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7433]: https://gitlab.freedesktop.org/drm/intel/issues/7433
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7050 -> IGTPW_8086
CI-20190529: 20190529
CI_DRM_12369: cdcedc1a52e4f4ec01a8f8c51065d651c31bea87 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8086: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
IGT_7050: 42839a7c2bab78bc6cda8c949d8545606f377735 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_universal_plane@test-disable-primary-red-sprite-a +igt@kms_universal_plane@test-disable-primary-red-sprite-b +igt@kms_universal_plane@test-disable-primary-red-sprite-c +igt@kms_universal_plane@test-disable-primary-red-sprite-d +igt@kms_universal_plane@test-disable-primary-red-sprite-e +igt@kms_universal_plane@test-disable-primary-red-sprite-f +igt@kms_universal_plane@test-explicitly-disable-primary-a +igt@kms_universal_plane@test-explicitly-disable-primary-b +igt@kms_universal_plane@test-explicitly-disable-primary-c +igt@kms_universal_plane@test-explicitly-disable-primary-d +igt@kms_universal_plane@test-explicitly-disable-primary-e +igt@kms_universal_plane@test-explicitly-disable-primary-f +igt@kms_universal_plane@test-legacy-atomic-interfaces-a +igt@kms_universal_plane@test-legacy-atomic-interfaces-b +igt@kms_universal_plane@test-legacy-atomic-interfaces-c +igt@kms_universal_plane@test-legacy-atomic-interfaces-d +igt@kms_universal_plane@test-legacy-atomic-interfaces-e +igt@kms_universal_plane@test-legacy-atomic-interfaces-f +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-a +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-b +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-c +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-d +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-e +igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-f +igt@kms_universal_plane@test-re-enable-primary-with-blue-a +igt@kms_universal_plane@test-re-enable-primary-with-blue-b +igt@kms_universal_plane@test-re-enable-primary-with-blue-c +igt@kms_universal_plane@test-re-enable-primary-with-blue-d +igt@kms_universal_plane@test-re-enable-primary-with-blue-e +igt@kms_universal_plane@test-re-enable-primary-with-blue-f +igt@kms_universal_plane@test-set-primary-completely-offscreen-a +igt@kms_universal_plane@test-set-primary-completely-offscreen-b +igt@kms_universal_plane@test-set-primary-completely-offscreen-c +igt@kms_universal_plane@test-set-primary-completely-offscreen-d +igt@kms_universal_plane@test-set-primary-completely-offscreen-e +igt@kms_universal_plane@test-set-primary-completely-offscreen-f +igt@kms_universal_plane@test-universal-api-with-crtc-off-a +igt@kms_universal_plane@test-universal-api-with-crtc-off-b +igt@kms_universal_plane@test-universal-api-with-crtc-off-c +igt@kms_universal_plane@test-universal-api-with-crtc-off-d +igt@kms_universal_plane@test-universal-api-with-crtc-off-e +igt@kms_universal_plane@test-universal-api-with-crtc-off-f -igt@kms_universal_plane@universal-plane-pipe-a-functional -igt@kms_universal_plane@universal-plane-pipe-b-functional -igt@kms_universal_plane@universal-plane-pipe-c-functional -igt@kms_universal_plane@universal-plane-pipe-d-functional -igt@kms_universal_plane@universal-plane-pipe-e-functional -igt@kms_universal_plane@universal-plane-pipe-f-functional
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests
In reply to Alaa Emad== Series Details ==
== Series Details ==
Series: tests/kms_universal_plane: divide functional_test_pipe to mini-subtests
URL : https://patchwork.freedesktop.org/series/110797/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12369_full -> IGTPW_8086_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8086_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_universal_plane@test-explicitly-disable-primary-e} (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][1] +10 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-dg1-12/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][2] +13 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb8/igt@[email protected]
* {igt@kms_universal_plane@test-legacy-atomic-interfaces-c} (NEW):
- shard-glk: NOTRUN -> [WARN][3] +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk1/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_balancer@nop:
- {shard-rkl}: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-2/igt@[email protected]
* igt@gem_exec_suspend@basic-s3-devices@smem:
- {shard-rkl}: [PASS][6] -> [FAIL][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-6/igt@gem_exec_suspend@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-4/igt@gem_exec_suspend@[email protected]
* igt@kms_invalid_mode@int-max-clock:
- {shard-rkl}: NOTRUN -> [SKIP][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-5/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_12369_full and IGTPW_8086_full:
### New IGT tests (42) ###
* igt@kms_universal_plane@test-disable-primary-red-sprite-a:
- Statuses : 6 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-disable-primary-red-sprite-b:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-disable-primary-red-sprite-c:
- Statuses : 4 pass(s) 1 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-disable-primary-red-sprite-d:
- Statuses : 2 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-disable-primary-red-sprite-e:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-disable-primary-red-sprite-f:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-a:
- Statuses : 6 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-b:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-c:
- Statuses : 4 pass(s) 1 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-d:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-e:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-explicitly-disable-primary-f:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-a:
- Statuses : 5 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-b:
- Statuses : 6 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-c:
- Statuses : 4 pass(s) 2 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-d:
- Statuses : 2 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-e:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-atomic-interfaces-f:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-a:
- Statuses : 5 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-b:
- Statuses : 5 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-c:
- Statuses : 3 pass(s) 1 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-d:
- Statuses : 1 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-e:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-legacy-modeset-to-yellow-fb-f:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-a:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-b:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-c:
- Statuses : 5 pass(s) 1 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-d:
- Statuses :
- Exec time: [None] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-e:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-re-enable-primary-with-blue-f:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-a:
- Statuses : 5 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-b:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-c:
- Statuses : 3 pass(s) 1 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-d:
- Statuses : 2 pass(s) 4 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-e:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-set-primary-completely-offscreen-f:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-a:
- Statuses : 4 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-b:
- Statuses : 6 pass(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-c:
- Statuses : 4 pass(s) 2 skip(s) 1 warn(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-d:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-e:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_universal_plane@test-universal-api-with-crtc-off-f:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8086_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@device_reset@unbind-reset-rebind:
- shard-snb: [PASS][9] -> [DMESG-WARN][10] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-snb6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-snb2/igt@[email protected]
* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][11] ([i915#4991])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-snb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][12] -> [SKIP][13] ([i915#4525]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb1/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#4525])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2846])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk3/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk9/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl6/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
* igt@gem_userptr_blits@readonly-unsync:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#3297])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#3297])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb6/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][27] -> [DMESG-WARN][28] ([i915#5566] / [i915#716])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk3/igt@[email protected]
* igt@i915_module_load@resize-bar:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#6412])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#6412])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271]) +124 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl2/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#5286])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#5286])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb3/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +6 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#6095])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk1/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3689]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_mc_ccs.html
* igt@kms_chamelium@dp-hpd-fast:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb3/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-snb6/igt@[email protected]
* igt@kms_color_chamelium@ctm-red-to-blue:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +5 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl6/igt@[email protected]
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][43] ([i915#7173])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl2/igt@kms_content_protection@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109274] / [fdo#111825])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109274])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][46] -> [FAIL][47] ([i915#2346])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk8/igt@kms_cursor_legacy@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk7/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][48] ([i915#2587] / [i915#2672]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#3555])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#2672]) +6 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][51] ([i915#2672] / [i915#3555])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109280])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109280] / [fdo#111825])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271]) +55 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk7/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [PASS][55] -> [INCOMPLETE][56] ([i915#7282])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl3/igt@kms_hdr@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl2/igt@kms_hdr@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-edp-1:
- shard-iclb: [PASS][57] -> [DMESG-WARN][58] ([i915#2867]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb3/igt@kms_pipe_crc_basic@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb3/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2:
- shard-glk: NOTRUN -> [FAIL][59] ([i915#4573]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk9/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#112054] / [i915#5288])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb8/igt@[email protected]
* igt@kms_plane_lowres@tiling-yf@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][61] ([i915#3536]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb5/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][62] -> [SKIP][63] ([i915#5235]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb1/igt@kms_plane_scaling@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl8/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#7037])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb3/igt@kms_psr2_su@page_flip-nv12.html
- shard-glk: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#658]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk6/igt@kms_psr2_su@page_flip-nv12.html
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109642] / [fdo#111068] / [i915#658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][68] -> [SKIP][69] ([fdo#109441]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][70] -> [SKIP][71] ([i915#5519]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb6/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb8/igt@[email protected]
* {igt@kms_universal_plane@test-disable-primary-red-sprite-e} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][72] ([i915#4098]) +6 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-5/igt@[email protected]
* {igt@kms_universal_plane@test-set-primary-completely-offscreen-d} (NEW):
- shard-snb: NOTRUN -> [SKIP][73] ([fdo#109271]) +46 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-snb4/igt@[email protected]
* {igt@kms_universal_plane@test-set-primary-completely-offscreen-f} (NEW):
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109278]) +22 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb7/igt@[email protected]
* {igt@kms_universal_plane@test-universal-api-with-crtc-off-c} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][75] ([i915#4070]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@[email protected]
* {igt@kms_universal_plane@test-universal-api-with-crtc-off-d} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][76] ([i915#4070] / [i915#4098]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-1/igt@[email protected]
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2994]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl7/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@read:
- {shard-rkl}: [SKIP][78] ([i915#2582]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@[email protected]
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][80] ([i915#4525]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb8/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@[email protected]
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][82] ([i915#6247]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@gem_exec_endless@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-4/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [FAIL][84] ([i915#2842]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb5/igt@gem_exec_fair@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- {shard-rkl}: [SKIP][86] ([i915#3281]) -> [PASS][87] +12 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-5/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][88] ([i915#2190]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-tglb7/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb8/igt@[email protected]
* igt@gem_set_tiling_vs_pwrite:
- {shard-rkl}: [SKIP][90] ([i915#3282]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-4/igt@gem_set_tiling_vs_pwrite.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-5/igt@gem_set_tiling_vs_pwrite.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][92] ([i915#2527]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-6/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-5/igt@[email protected]
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-iclb: [DMESG-WARN][94] ([i915#1982]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb6/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][96] ([i915#3989] / [i915#454]) -> [PASS][97] +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb3/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb6/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][98] ([fdo#109271]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl1/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl7/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][100] ([i915#3591]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][102] ([i915#1397]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-4/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [INCOMPLETE][104] ([i915#7232]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl3/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-iclb: [FAIL][106] ([i915#2521]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb7/igt@kms_async_flips@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb6/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-rkl}: [SKIP][108] ([i915#1845] / [i915#4098]) -> [PASS][109] +16 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-4/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180:
- shard-glk: [DMESG-FAIL][110] ([i915#118] / [i915#5138]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [INCOMPLETE][112] ([i915#4839]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl2/igt@kms_flip@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- {shard-rkl}: [SKIP][114] ([i915#1849] / [i915#4098]) -> [PASS][115] +9 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][116] ([i915#1849] / [i915#3558]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-2/igt@kms_plane@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@sprite_blt:
- {shard-rkl}: [SKIP][120] ([i915#1072]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@kms_psr@sprite_blt.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@kms_psr@sprite_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [INCOMPLETE][122] -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl3/igt@[email protected]
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][124] ([fdo#109289]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-4/igt@[email protected]
* igt@perf@polling:
- {shard-rkl}: [FAIL][126] ([i915#5639]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-6/igt@[email protected]
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][128] ([i915#5213]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk7/igt@[email protected]
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-glk: [FAIL][130] ([i915#1731]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk3/igt@sysfs_heartbeat_interval@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk5/igt@sysfs_heartbeat_interval@[email protected]
* igt@sysfs_timeslice_duration@timeout@vecs0:
- {shard-rkl}: [FAIL][132] ([i915#1755]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-rkl-5/igt@sysfs_timeslice_duration@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-rkl-4/igt@sysfs_timeslice_duration@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][134] ([i915#6117]) -> [SKIP][135] ([i915#4525])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-tglb: [INCOMPLETE][136] ([i915#7248]) -> [WARN][137] ([i915#2658])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-tglb6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb7/igt@[email protected]
- shard-glk: [INCOMPLETE][138] ([i915#7248]) -> [WARN][139] ([i915#2658]) +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-glk7/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-glk5/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-iclb: [WARN][140] ([i915#2684]) -> [FAIL][141] ([i915#2684])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb8/igt@i915_pm_rc6_residency@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb8/igt@i915_pm_rc6_residency@[email protected]
* igt@kms_content_protection@mei_interface:
- shard-tglb: [SKIP][142] ([i915#7118]) -> [SKIP][143] ([fdo#109300])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-tglb2/igt@kms_content_protection@mei_interface.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-tglb6/igt@kms_content_protection@mei_interface.html
- shard-iclb: [SKIP][144] ([i915#7118]) -> [SKIP][145] ([fdo#109300])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb8/igt@kms_content_protection@mei_interface.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb3/igt@kms_content_protection@mei_interface.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][146] ([i915#658]) -> [SKIP][147] ([i915#2920])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb1/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][148] ([i915#2920]) -> [SKIP][149] ([i915#658])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb2/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb5/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][150] ([i915#2920]) -> [SKIP][151] ([fdo#111068] / [i915#658]) +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb2/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb7/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][152] ([fdo#111068] / [i915#658]) -> [SKIP][153] ([i915#2920])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-iclb8/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][154], [FAIL][155]) ([i915#3002] / [i915#4312]) -> ([FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl7/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12369/shard-apl8/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl8/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl6/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/shard-apl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7232]: https://gitlab.freedesktop.org/drm/intel/issues/7232
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7282]: https://gitlab.freedesktop.org/drm/intel/issues/7282
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7050 -> IGTPW_8086
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12369: cdcedc1a52e4f4ec01a8f8c51065d651c31bea87 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8086: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
IGT_7050: 42839a7c2bab78bc6cda8c949d8545606f377735 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8086/index.html
Hi Aemad,
Thanks for breaking the test into smaller subtests.
Some GPU drivers, including amdgpu, do not allow primary plane off without turning crtc off (https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c#L385), but kms_universal_plane has many the below code which was guarded with is_amdgpu_device()
igt_plane_set_fb(primary, NULL); igt_display_commit2(&data->display, COMMIT_UNIVERSAL);
Many of the is_amdgpu_device() are not present in your patches and kms_universal fails. I needed to add is_amdgpu_device() to patch 2~3 and 5~7 (I didn't check 8).
------------------------------------------------------------------------
*From:* aemad <[email protected]>
*Sent:* 11 November 2022 01:31
*To:* [email protected] <[email protected]>
*Cc:* [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Siqueira, Rodrigo <[email protected]>; Hung, Alex <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> *Subject:* Re: [PATCH RFC i-g-t 0/8] tests/kms_universal_plane: divide functional_test_pipe to mini-subtests
Please, let me know your thoughts.
Quoted 32 lines · Alaa Emad
Divide the
functional_test_pipetest into seven subtests based on CRC comparisons because this will make it easier to debug the test and help in detecting the failure.First 7 patches decouple each subtest and run it individually keeping
functional_test_pipe' test as it is. After making sure that each subtest can run individually with the expected result on both vkms and i915 drivers, improve the test by creatingrun_functional_test_pipeand call all subtests from it and callrun_functional_test_pipeinigt_main`.Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy and atomic api
tests/kms_universal_plane: decouple verification of disabling primary plane
tests/kms_universal_plane: decouple verification of re-enabling primary plane
tests/kms_universal_plane: decouple verification of setup plane FB's while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity to modeset with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to move the primary plane completely offscreen tests/kms_universal_plane: decouple verification of ablity to explicitly disable an already implicitly-disabled primary plane tests/kms_universal_plane: create therun_functional_test_pipeand call all tests from it
tests/kms_universal_plane.c| 416 ++++++++++++++++++++++--------------1 file changed, 261 insertions(+), 155 deletions(-)
Hi Alex,
Quoted 10 lines · Alex Hung
Hi Aemad,
Thanks for breaking the test into smaller subtests.
Some GPU drivers, including amdgpu, do not allow primary plane off without turning crtc off
(https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c#L385),
butkms_universal_planehas many the below code which was guarded withis_amdgpu_device()
Quoted 8 lines
igt_plane_set_fb(primary, NULL); igt_display_commit2(&data->display, COMMIT_UNIVERSAL);Many of the
is_amdgpu_device()are not present in your patches andkms_universalfails. I needed to addis_amdgpu_device()to patch 2~3 and 5~7 (I didn't check 8).-------------------------
Thanks for your feedback, I will add AMD guard and resend them again.
BR,
Alaa
Quoted 59 lines
From: aemad <[email protected]>
Sent: 11 November 2022 01:31
To: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Siqueira, Rodrigo <[email protected]>; Hung, Alex <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH RFC i-g-t 0/8] tests/kms_universal_plane: dividefunctional_test_pipeto mini-subtestsPlease, let me know your thoughts.
Quoted 1 line · Alaa Emad
Divide the
functional_test_pipetest into seven subtests based onCRC
Quoted 1 line
comparisons because this will make it easier to debug the test and
help
Quoted 3 lines
in detecting the failure.
First 7 patches decouple each subtest and run it individually
keeping
Quoted 2 lines
`functional_test_pipe' test as it is. After making sure that each subtest can run individually with the expected result on both vkms
and i915
Quoted 7 lines
drivers, improve the test by creating
run_functional_test_pipeand call all subtests from it and callrun_functional_test_pipeinigt_main.Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy andatomic
Quoted 2 lines
api
tests/kms_universal_plane: decouple verification of disablingprimary
Quoted 4 lines
plane
tests/kms_universal_plane: decouple verification of re-enabling
primary plane
tests/kms_universal_plane: decouple verification of setup planeFB's
Quoted 2 lines
while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity tomodeset
Quoted 2 lines
with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to movethe
Quoted 7 lines
primary plane completely offscreen
tests/kms_universal_plane: decouple verification of ablity to
explicitly disable an already implicitly-disabled primary plane
tests/kms_universal_plane: create therun_functional_test_pipeand
call all tests from ittests/kms_universal_plane.c | 416++++++++++++++++++++++--------------
Quoted 1 line
1 file changed, 261 insertions(+), 155 deletions(-)