staging: sm750fb: change function naming style
cover staging: sm750fb: change function naming style
Address checkpatch's "Avoid camelCase" for sm750fb module by changing function name to conform to kernel code style.
The patches are required to be applied in sequence.
Richard Akintola (8):
staging: sm750fb: change sii164GetDeviceID to snake_case
staging: sm750fb: change sii164ResetChip to snake_case
staging: sm750fb: change sii164SetPower to snake_case
staging: sm750fb: change sii164GetChipString to snake_case
staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
staging: sm750fb: change sii164IsConnected to snake_case
staging: sm750fb: change sii164CheckInterrupt to snake_case
staging: sm750fb: change sii164ClearInterrupt to snake_case
drivers/staging/sm750fb/ddk750_dvi.c | 16 +++++----- drivers/staging/sm750fb/ddk750_sii164.c | 42 ++++++++++++------------- drivers/staging/sm750fb/ddk750_sii164.h | 16 +++++----- 3 files changed, 37 insertions(+), 37 deletions(-)
Signature · 1 line
2.39.5
PATCH 1/8 staging: sm750fb: change sii164GetDeviceID to snake_case
Change camelCase function name sii164GetDeviceID to sii164_get_device_id to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetDeviceID>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { { .init = sii164_init_chip, .get_vendor_id = sii164_get_vendor_id, - .get_device_id = sii164GetDeviceID, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164ResetChip, .get_chip_string = sii164GetChipString,
drivers/staging/sm750fb/ddk750_sii164.c +3 -3
@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void) }/* -* sii164GetDeviceID +* sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID (void ) +unsigned short sii164_get_device_id (void ) {unsigned short deviceID;
@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,/* Check if SII164 Chip exists */ if ((sii164_get_vendor_id () ==SII164_VENDOR_ID ) && - (sii164GetDeviceID () ==SII164_DEVICE_ID )) { + (sii164_get_device_id () ==SII164_DEVICE_ID )) {/* * Initialize SII164 controller chip. */
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect, unsigned char pllFilterValue);unsigned short sii164_get_vendor_id (void ); -unsigned short sii164GetDeviceID (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS void sii164ResetChip (void );
Signature · 1 line
2.39.5
PATCH 2/8 staging: sm750fb: change sii164ResetChip to snake_case
In reply to Richard AkintolaChange camelCase function name sii164ResetChip to sii164_reset_chip to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_vendor_id = sii164_get_vendor_id, .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .reset_chip = sii164ResetChip, + .reset_chip = sii164_reset_chip, .get_chip_string = sii164GetChipString, .set_power = sii164SetPower, .enable_hot_plug_detection = sii164EnableHotPlugDetection,
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,#ifdef SII164_FULL_FUNCTIONS /* -* sii164ResetChip +* sii164_reset_chip * This function resets the DVI Controller Chip. */ -void sii164ResetChip (void ) +void sii164_reset_chip (void ) {/* Power down */ sii164SetPower (0 );
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS -void sii164ResetChip (void ); +void sii164_reset_chip (void );char *sii164GetChipString (void );void sii164SetPower (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);
Signature · 1 line
2.39.5
PATCH 3/8 staging: sm750fb: change sii164SetPower to snake_case
In reply to Richard AkintolaChange camelCase function name sii164SetPower to sii164_set_power to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164SetPower>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -20,7 +20,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {#ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164_reset_chip, .get_chip_string = sii164GetChipString, - .set_power = sii164SetPower, + .set_power = sii164_set_power, .enable_hot_plug_detection = sii164EnableHotPlugDetection, .is_connected = sii164IsConnected, .check_interrupt = sii164CheckInterrupt,
drivers/staging/sm750fb/ddk750_sii164.c +4 -4
@@ -256,8 +256,8 @@ long sii164_init_chip(unsigned char edge_select,void sii164_reset_chip (void ) {/* Power down */ -sii164SetPower (0 ); -sii164SetPower (1 ); +sii164_set_power (0 ); +sii164_set_power (1 ); }/*
@@ -273,13 +273,13 @@ char *sii164GetChipString(void) }/* -* sii164SetPower +* sii164_set_power * This function sets the power configuration of the DVI Controller Chip. * * Input: * powerUp - Flag to set the power down or up */ -void sii164SetPower (unsigned char powerUp) +void sii164_set_power (unsigned char powerUp) {unsigned char config;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -33,7 +33,7 @@ unsigned short sii164_get_device_id(void);#ifdef SII164_FULL_FUNCTIONS void sii164_reset_chip (void );char *sii164GetChipString (void ); -void sii164SetPower (unsigned char powerUp); +void sii164_set_power (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);unsigned char sii164IsConnected (void );unsigned char sii164CheckInterrupt (void );
Signature · 1 line
2.39.5
PATCH 4/8 staging: sm750fb: change sii164GetChipString to snake_case
In reply to Richard AkintolaChange camelCase function name sii164GetChipString to sii164_get_chip_string to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetChipString>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -19,7 +19,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164_reset_chip, - .get_chip_string = sii164GetChipString, + .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, .enable_hot_plug_detection = sii164EnableHotPlugDetection, .is_connected = sii164IsConnected,
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -261,13 +261,13 @@ void sii164_reset_chip(void) }/* -* sii164GetChipString +* sii164_get_chip_string * This function returns a char string name of the current DVI Controller * chip. * * It's convenient for application need to display the chip name. */ -char *sii164GetChipString (void ) +char *sii164_get_chip_string (void ) {return gDviCtrlChipName; }
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -32,7 +32,7 @@ unsigned short sii164_get_device_id(void);#ifdef SII164_FULL_FUNCTIONS void sii164_reset_chip (void ); -char *sii164GetChipString (void ); +char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);unsigned char sii164IsConnected (void );
Signature · 1 line
2.39.5
PATCH 5/8 staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
In reply to Richard AkintolaChange camelCase function name sii164EnableHotPlugDetection to sii164_enable_hot_plug_detection and it's parameter enableHotPlug to enable_hot_plug
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164EnableHotPlugDetection>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .reset_chip = sii164_reset_chip, .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, - .enable_hot_plug_detection = sii164EnableHotPlugDetection, + .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164IsConnected, .check_interrupt = sii164CheckInterrupt, .clear_interrupt = sii164ClearInterrupt,
drivers/staging/sm750fb/ddk750_sii164.c +4 -4
@@ -329,12 +329,12 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) }/* -* sii164EnableHotPlugDetection +* sii164_enable_hot_plug_detection * This function enables the Hot Plug detection. * -* enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection +* enable_hot_plug - Enable (=1) / disable (=0) Hot Plug detection */ -void sii164EnableHotPlugDetection (unsigned char enableHotPlug) +void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug) {unsigned char detectReg;
@@ -343,7 +343,7 @@ void sii164EnableHotPlugDetection(unsigned char enableHotPlug)/* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. */ -if (enableHotPlug !=0 ) +if (enable_hot_plug !=0 )sii164SelectHotPlugDetectionMode (SII164_HOTPLUG_USE_MDI );else sii164SelectHotPlugDetectionMode (SII164_HOTPLUG_DISABLE );
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -34,7 +34,7 @@ unsigned short sii164_get_device_id(void);void sii164_reset_chip (void );char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp); -void sii164EnableHotPlugDetection (unsigned char enableHotPlug); +void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164IsConnected (void );unsigned char sii164CheckInterrupt (void );void sii164ClearInterrupt (void );
Signature · 1 line
2.39.5
PATCH 6/8 staging: sm750fb: change sii164IsConnected to snake_case
In reply to Richard AkintolaChange camelCase function name sii164IsConnected to sii164_is_connected to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164IsConnected>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -22,7 +22,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, .enable_hot_plug_detection = sii164_enable_hot_plug_detection, - .is_connected = sii164IsConnected, + .is_connected = sii164_is_connected, .check_interrupt = sii164CheckInterrupt, .clear_interrupt = sii164ClearInterrupt,#endif
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -350,14 +350,14 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) }/* -* sii164IsConnected +* sii164_is_connected * Check if the DVI Monitor is connected. * * Output: * 0 - Not Connected * 1 - Connected */ -unsigned char sii164IsConnected (void ) +unsigned char sii164_is_connected (void ) {unsigned char hotPlugValue;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -35,7 +35,7 @@ void sii164_reset_chip(void);char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug); -unsigned char sii164IsConnected (void ); +unsigned char sii164_is_connected (void );unsigned char sii164CheckInterrupt (void );void sii164ClearInterrupt (void );#endif
Signature · 1 line
2.39.5
PATCH 7/8 staging: sm750fb: change sii164CheckInterrupt to snake_case
In reply to Richard AkintolaChange camelCase function name sii164CheckInterrupt to sii164_check_interrupt in order to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164CheckInterrupt>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -23,7 +23,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .set_power = sii164_set_power, .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164_is_connected, - .check_interrupt = sii164CheckInterrupt, + .check_interrupt = sii164_check_interrupt, .clear_interrupt = sii164ClearInterrupt,#endif },
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -370,14 +370,14 @@ unsigned char sii164_is_connected(void) }/* -* sii164CheckInterrupt +* sii164_check_interrupt * Checks if interrupt has occurred. * * Output: * 0 - No interrupt * 1 - Interrupt occurs */ -unsigned char sii164CheckInterrupt (void ) +unsigned char sii164_check_interrupt (void ) {unsigned char detectReg;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -36,7 +36,7 @@ char *sii164_get_chip_string(void);void sii164_set_power (unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164_is_connected (void ); -unsigned char sii164CheckInterrupt (void ); +unsigned char sii164_check_interrupt (void );void sii164ClearInterrupt (void );#endif /*
Signature · 1 line
2.39.5
PATCH 8/8 staging: sm750fb: change sii164ClearInterrupt to snake_case
In reply to Richard AkintolaChange camelCase function name sii164ClearInterrupt to sii164_clear_interrupt in order to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ClearInterrupt>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -24,7 +24,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164_is_connected, .check_interrupt = sii164_check_interrupt, - .clear_interrupt = sii164ClearInterrupt, + .clear_interrupt = sii164_clear_interrupt, #endif },#endif
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -390,10 +390,10 @@ unsigned char sii164_check_interrupt(void) }/* -* sii164ClearInterrupt +* sii164_clear_interrupt * Clear the hot plug interrupt. */ -void sii164ClearInterrupt (void ) +void sii164_clear_interrupt (void ) {unsigned char detectReg;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -37,7 +37,7 @@ void sii164_set_power(unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164_is_connected (void );unsigned char sii164_check_interrupt (void ); -void sii164ClearInterrupt (void ); +void sii164_clear_interrupt (void );#endif /* * below register definition is used for
Signature · 1 line
2.39.5
Greg KH
maintainerQuoted 15 lines · Richard Akintola
Address checkpatch's "Avoid camelCase" for sm750fb module by changing function name to conform to kernel code style.
The patches are required to be applied in sequence.
Richard Akintola (8):
staging: sm750fb: change sii164GetDeviceID tosnake_case
staging: sm750fb: change sii164ResetChip tosnake_case
staging: sm750fb: change sii164SetPower tosnake_case
staging: sm750fb: change sii164GetChipString tosnake_case
staging: sm750fb: change sii164EnableHotPlugDetection tosnake_case
staging: sm750fb: change sii164IsConnected tosnake_case
staging: sm750fb: change sii164CheckInterrupt tosnake_case
staging: sm750fb: change sii164ClearInterrupt tosnake_case
Quoted 9 lines
drivers/staging/sm750fb/ddk750_dvi.c | 16 +++++----- drivers/staging/sm750fb/ddk750_sii164.c | 42 ++++++++++++------------- drivers/staging/sm750fb/ddk750_sii164.h | 16 +++++----- 3 files changed, 37 insertions(+), 37 deletions(-)Signature · 1 line
2.39.5
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 2 lines · Greg KH
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version.
Please, how do I resolve this issue?
Richard Akintola
Quoted 9 lines · Richard Akintola
Quoted 2 lines · Greg KH
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version.
Please, how do I resolve this issue?
Richard Akintola
Hello Richard
THis is the main message from the bot
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
It basically means that if you made a change to a patch, you will have a new version.
You will have to indicate the patch version and also what changed
So lets say you have a first Patch then after review, or you edited the commit message
or made a change in the code or something,
you will now have a new patch which you will call v2.
you will use git format-patch -o /tmp/ --subject-prefix="PATCH v2" <commit-ID>
then when you want to send with mutt, immediately after the signed-off by line there are three dashes (---),
You will then write what changes under these three dashes in the format
signedoff-by: Richard
---
Changes in v1:
- This is what changed in v1.
I hope this helps
Adekunle.
Quoted 38 lines · Samuel Abraham
Quoted 9 lines · Richard Akintola
Quoted 2 lines · Greg KH
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version.
Please, how do I resolve this issue?
Richard Akintola
Hello Richard
THis is the main message from the bot
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.It basically means that if you made a change to a patch, you will have a new version.
You will have to indicate the patch version and also what changedSo lets say you have a first Patch then after review, or you edited the commit message
or made a change in the code or something,
you will now have a new patch which you will call v2.you will use git format-patch -o
/tmp/--subject-prefix="PATCH v2" <commit-ID>then when you want to send with mutt, immediately after the signed-off by line there are three dashes (---),
You will then write what changes under these three dashes in the format
Quoted 7 lines
signedoff-by: Richard
---
Changes in v1:
- This is what changed in v1.I hope this helps
Also, you can go to the "Submitting a Patchset" section down the page of the firstPatch
documentation for more information on versioning patchsets.
Adekunle
Quoted 5 lines · Samuel Abraham
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.
Hi Samuel,
I sent the patches individually before, but I was instructed to send a patch series.
Given that I didn't change any code, should I still add version number and sending
patch series as the difference?
Richard Akintola
Greg KH
maintainerQuoted 10 lines · Richard Akintola
Quoted 5 lines · Samuel Abraham
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.
Quoted 8 lines
Hi Samuel,
I sent the patches individually before, but I was instructed to send a patch series.
Given that I didn't change any code, should I still add version number and sending
patch series as the difference?
Yes.
Think about it from our side, what would you want to see if you had to review hundreds of different patches a day?
thanks,
greg k-h
Quoted 4 lines · Greg KH
Yes.
Think about it from our side, what would you want to see if you had to review hundreds of different patches a day?
Thank you for the clarification Greg K-H, the change in perspective made it clear, would send them in as soon as I get hold of my PC.
Richard Akintola
Quoted 21 lines · Greg KH
Quoted 10 lines · Richard Akintola
Quoted 5 lines · Samuel Abraham
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.Quoted 8 lines
Hi Samuel,
I sent the patches individually before, but I was instructed to send a patch series.
Given that I didn't change any code, should I still add version number and sending
patch series as the difference?
Quoted 8 lines
Yes.
Think about it from our side, what would you want to see if you had to review hundreds of different patches a day?
thanks,
greg k-h
Hi Greg,
I have sent the new version, please do have a look at it. Thank you.
Richard Akintola
Greg KH
maintainerQuoted 27 lines · Richard Akintola
Quoted 26 lines · Greg KH
Quoted 10 lines · Richard Akintola
Quoted 5 lines · Samuel Abraham
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.Quoted 8 lines
Hi Samuel,
I sent the patches individually before, but I was instructed to send a patch series.
Given that I didn't change any code, should I still add version number and sending
patch series as the difference?Yes.
Think about it from our side, what would you want to see if you had to review hundreds of different patches a day?
Quoted 7 lines
Quoted 3 lines
thanks,
greg k-h
Hi Greg,
I have sent the new version, please do have a look at it.
Again, please realize that some of us get hundreds, if not thousands, of changes a day to review. A normal delay is about 1-2 weeks to get to a review of a change. Ideally it would be faster, but there are only so many hours in a day.
To help make this faster, please help out in reviewing other changes submitted by other developers, that will cause your changes to bubble up.
thanks,
greg k-h
Quoted 42 lines · Greg KH
Quoted 27 lines · Richard Akintola
Quoted 26 lines · Greg KH
Quoted 10 lines · Richard Akintola
Quoted 5 lines · Samuel Abraham
This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file,Documentation/process/submitting-patches.rstfor what needs to be done here to properly describe this.Quoted 8 lines
Hi Samuel,
I sent the patches individually before, but I was instructed to send a patch series.
Given that I didn't change any code, should I still add version number and sending
patch series as the difference?Yes.
Think about it from our side, what would you want to see if you had to review hundreds of different patches a day?
Quoted 7 lines
Quoted 3 lines
thanks,
greg k-h
Hi Greg,
I have sent the new version, please do have a look at it.
Again, please realize that some of us get hundreds, if not thousands, of changes a day to review. A normal delay is about 1-2 weeks to get to a review of a change. Ideally it would be faster, but there are only so many hours in a day.
Quoted 7 lines
To help make this faster, please help out in reviewing other changes submitted by other developers, that will cause your changes to bubble up.
thanks,
greg k-h
I really do understand the situation and to be candid, I am in no hurry but won't mind helping out in the review, perhaps a help with Review 101?
thanks,
Richard Akintola