staging: sm750fb: change function naming style
v2 cover staging: sm750fb: change function naming style
Address checkpatch's "Avoid camelCase" for sm750fb module by changing function name to conform to kernel code style.
The patches are required to be applied in sequence.
---
changes in v2:
- Fixed typo in the commit message for patch 1
- Sent patches as patchset
Richard Akintola (8):
staging: sm750fb: change sii164GetDeviceID to snake_case
staging: sm750fb: change sii164ResetChip to snake_case
staging: sm750fb: change sii164SetPower to snake_case
staging: sm750fb: change sii164GetChipString to snake_case
staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
staging: sm750fb: change sii164IsConnected to snake_case
staging: sm750fb: change sii164CheckInterrupt to snake_case
staging: sm750fb: change sii164ClearInterrupt to snake_case
drivers/staging/sm750fb/ddk750_dvi.c | 16 +++++----- drivers/staging/sm750fb/ddk750_sii164.c | 42 ++++++++++++------------- drivers/staging/sm750fb/ddk750_sii164.h | 16 +++++----- 3 files changed, 37 insertions(+), 37 deletions(-)
Signature · 1 line
2.39.5
PATCH v2 1/8 staging: sm750fb: change sii164GetDeviceID to snake_case
Change camelCase function name sii164GetDeviceID to sii164_get_device_id to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetDeviceID>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { { .init = sii164_init_chip, .get_vendor_id = sii164_get_vendor_id, - .get_device_id = sii164GetDeviceID, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164ResetChip, .get_chip_string = sii164GetChipString,
drivers/staging/sm750fb/ddk750_sii164.c +3 -3
@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void) }/* -* sii164GetDeviceID +* sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID (void ) +unsigned short sii164_get_device_id (void ) {unsigned short deviceID;
@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,/* Check if SII164 Chip exists */ if ((sii164_get_vendor_id () ==SII164_VENDOR_ID ) && - (sii164GetDeviceID () ==SII164_DEVICE_ID )) { + (sii164_get_device_id () ==SII164_DEVICE_ID )) {/* * Initialize SII164 controller chip. */
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect, unsigned char pllFilterValue);unsigned short sii164_get_vendor_id (void ); -unsigned short sii164GetDeviceID (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS void sii164ResetChip (void );
Signature · 1 line
2.39.5
PATCH v2 2/8 staging: sm750fb: change sii164ResetChip to snake_case
In reply to Richard AkintolaChange camelCase function name sii164ResetChip to sii164_reset_chip to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_vendor_id = sii164_get_vendor_id, .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .reset_chip = sii164ResetChip, + .reset_chip = sii164_reset_chip, .get_chip_string = sii164GetChipString, .set_power = sii164SetPower, .enable_hot_plug_detection = sii164EnableHotPlugDetection,
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,#ifdef SII164_FULL_FUNCTIONS /* -* sii164ResetChip +* sii164_reset_chip * This function resets the DVI Controller Chip. */ -void sii164ResetChip (void ) +void sii164_reset_chip (void ) {/* Power down */ sii164SetPower (0 );
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS -void sii164ResetChip (void ); +void sii164_reset_chip (void );char *sii164GetChipString (void );void sii164SetPower (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);
Signature · 1 line
2.39.5
PATCH v2 3/8 staging: sm750fb: change sii164SetPower to snake_case
In reply to Richard AkintolaChange camelCase function name sii164SetPower to sii164_set_power to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164SetPower>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -20,7 +20,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {#ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164_reset_chip, .get_chip_string = sii164GetChipString, - .set_power = sii164SetPower, + .set_power = sii164_set_power, .enable_hot_plug_detection = sii164EnableHotPlugDetection, .is_connected = sii164IsConnected, .check_interrupt = sii164CheckInterrupt,
drivers/staging/sm750fb/ddk750_sii164.c +4 -4
@@ -256,8 +256,8 @@ long sii164_init_chip(unsigned char edge_select,void sii164_reset_chip (void ) {/* Power down */ -sii164SetPower (0 ); -sii164SetPower (1 ); +sii164_set_power (0 ); +sii164_set_power (1 ); }/*
@@ -273,13 +273,13 @@ char *sii164GetChipString(void) }/* -* sii164SetPower +* sii164_set_power * This function sets the power configuration of the DVI Controller Chip. * * Input: * powerUp - Flag to set the power down or up */ -void sii164SetPower (unsigned char powerUp) +void sii164_set_power (unsigned char powerUp) {unsigned char config;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -33,7 +33,7 @@ unsigned short sii164_get_device_id(void);#ifdef SII164_FULL_FUNCTIONS void sii164_reset_chip (void );char *sii164GetChipString (void ); -void sii164SetPower (unsigned char powerUp); +void sii164_set_power (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);unsigned char sii164IsConnected (void );unsigned char sii164CheckInterrupt (void );
Signature · 1 line
2.39.5
PATCH v2 4/8 staging: sm750fb: change sii164GetChipString to snake_case
In reply to Richard AkintolaChange camelCase function name sii164GetChipString to sii164_get_chip_string to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetChipString>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -19,7 +19,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS .reset_chip = sii164_reset_chip, - .get_chip_string = sii164GetChipString, + .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, .enable_hot_plug_detection = sii164EnableHotPlugDetection, .is_connected = sii164IsConnected,
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -261,13 +261,13 @@ void sii164_reset_chip(void) }/* -* sii164GetChipString +* sii164_get_chip_string * This function returns a char string name of the current DVI Controller * chip. * * It's convenient for application need to display the chip name. */ -char *sii164GetChipString (void ) +char *sii164_get_chip_string (void ) {return gDviCtrlChipName; }
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -32,7 +32,7 @@ unsigned short sii164_get_device_id(void);#ifdef SII164_FULL_FUNCTIONS void sii164_reset_chip (void ); -char *sii164GetChipString (void ); +char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp);void sii164EnableHotPlugDetection (unsigned char enableHotPlug);unsigned char sii164IsConnected (void );
Signature · 1 line
2.39.5
PATCH v2 5/8 staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
In reply to Richard AkintolaChange camelCase function name sii164EnableHotPlugDetection to sii164_enable_hot_plug_detection and it's parameter enableHotPlug to enable_hot_plug
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164EnableHotPlugDetection>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .reset_chip = sii164_reset_chip, .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, - .enable_hot_plug_detection = sii164EnableHotPlugDetection, + .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164IsConnected, .check_interrupt = sii164CheckInterrupt, .clear_interrupt = sii164ClearInterrupt,
drivers/staging/sm750fb/ddk750_sii164.c +4 -4
@@ -329,12 +329,12 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) }/* -* sii164EnableHotPlugDetection +* sii164_enable_hot_plug_detection * This function enables the Hot Plug detection. * -* enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection +* enable_hot_plug - Enable (=1) / disable (=0) Hot Plug detection */ -void sii164EnableHotPlugDetection (unsigned char enableHotPlug) +void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug) {unsigned char detectReg;
@@ -343,7 +343,7 @@ void sii164EnableHotPlugDetection(unsigned char enableHotPlug)/* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. */ -if (enableHotPlug !=0 ) +if (enable_hot_plug !=0 )sii164SelectHotPlugDetectionMode (SII164_HOTPLUG_USE_MDI );else sii164SelectHotPlugDetectionMode (SII164_HOTPLUG_DISABLE );
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -34,7 +34,7 @@ unsigned short sii164_get_device_id(void);void sii164_reset_chip (void );char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp); -void sii164EnableHotPlugDetection (unsigned char enableHotPlug); +void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164IsConnected (void );unsigned char sii164CheckInterrupt (void );void sii164ClearInterrupt (void );
Signature · 1 line
2.39.5
PATCH v2 6/8 staging: sm750fb: change sii164IsConnected to snake_case
In reply to Richard AkintolaChange camelCase function name sii164IsConnected to sii164_is_connected to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164IsConnected>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -22,7 +22,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .get_chip_string = sii164_get_chip_string, .set_power = sii164_set_power, .enable_hot_plug_detection = sii164_enable_hot_plug_detection, - .is_connected = sii164IsConnected, + .is_connected = sii164_is_connected, .check_interrupt = sii164CheckInterrupt, .clear_interrupt = sii164ClearInterrupt,#endif
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -350,14 +350,14 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) }/* -* sii164IsConnected +* sii164_is_connected * Check if the DVI Monitor is connected. * * Output: * 0 - Not Connected * 1 - Connected */ -unsigned char sii164IsConnected (void ) +unsigned char sii164_is_connected (void ) {unsigned char hotPlugValue;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -35,7 +35,7 @@ void sii164_reset_chip(void);char *sii164_get_chip_string (void );void sii164_set_power (unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug); -unsigned char sii164IsConnected (void ); +unsigned char sii164_is_connected (void );unsigned char sii164CheckInterrupt (void );void sii164ClearInterrupt (void );#endif
Signature · 1 line
2.39.5
PATCH v2 7/8 staging: sm750fb: change sii164CheckInterrupt to snake_case
In reply to Richard AkintolaChange camelCase function name sii164CheckInterrupt to sii164_check_interrupt in order to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164CheckInterrupt>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -23,7 +23,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .set_power = sii164_set_power, .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164_is_connected, - .check_interrupt = sii164CheckInterrupt, + .check_interrupt = sii164_check_interrupt, .clear_interrupt = sii164ClearInterrupt,#endif },
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -370,14 +370,14 @@ unsigned char sii164_is_connected(void) }/* -* sii164CheckInterrupt +* sii164_check_interrupt * Checks if interrupt has occurred. * * Output: * 0 - No interrupt * 1 - Interrupt occurs */ -unsigned char sii164CheckInterrupt (void ) +unsigned char sii164_check_interrupt (void ) {unsigned char detectReg;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -36,7 +36,7 @@ char *sii164_get_chip_string(void);void sii164_set_power (unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164_is_connected (void ); -unsigned char sii164CheckInterrupt (void ); +unsigned char sii164_check_interrupt (void );void sii164ClearInterrupt (void );#endif /*
Signature · 1 line
2.39.5
PATCH v2 8/8 staging: sm750fb: change sii164ClearInterrupt to snake_case
In reply to Richard AkintolaChange camelCase function name sii164ClearInterrupt to sii164_clear_interrupt in order to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ClearInterrupt>
--- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -24,7 +24,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { .enable_hot_plug_detection = sii164_enable_hot_plug_detection, .is_connected = sii164_is_connected, .check_interrupt = sii164_check_interrupt, - .clear_interrupt = sii164ClearInterrupt, + .clear_interrupt = sii164_clear_interrupt, #endif },#endif
drivers/staging/sm750fb/ddk750_sii164.c +2 -2
@@ -390,10 +390,10 @@ unsigned char sii164_check_interrupt(void) }/* -* sii164ClearInterrupt +* sii164_clear_interrupt * Clear the hot plug interrupt. */ -void sii164ClearInterrupt (void ) +void sii164_clear_interrupt (void ) {unsigned char detectReg;
drivers/staging/sm750fb/ddk750_sii164.h +1 -1
@@ -37,7 +37,7 @@ void sii164_set_power(unsigned char powerUp);void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug);unsigned char sii164_is_connected (void );unsigned char sii164_check_interrupt (void ); -void sii164ClearInterrupt (void ); +void sii164_clear_interrupt (void );#endif /* * below register definition is used for
Signature · 1 line
2.39.5