selftests/bpf: fix flaky build_id test
Subsystems (3)
v2 cover selftests/bpf: fix flaky build_id test
The build_id selftest intermittently fails with the following error:
./test_progs -t build_id/nofault-paged-out serial_test_build_id:PASS:parse_build_id 0 nsec subtest_nofault:PASS:skel_open 0 nsec
subtest_nofault:PASS:link 0 nsec
subtest_nofault:PASS:trigger_uprobe 0 nsec
subtest_nofault:PASS:res 0 nsec
subtest_nofault:FAIL:build_id_status unexpected build_id_status: actual 1 != expected 2
46/1 build_id/nofault-paged-out:FAIL
46 build_id:FAIL
397 stacktrace_build_id:OK
398 stacktrace_build_id_nmi:OK
On RHEL we consistently hit the reported failure on the first run of the test following installation, after which subsequent runs pass.
This patch implements the approach discussed in the following thread:
https://lore.kernel.org/all/CAEf4BzYWVtfZh07iQm5Fo=kMm+8hgAu+rXRx1uLRHz07wc59+Q@mail.gmail.com/
Following the discussion, the fix makes the test verify eviction rather than assuming it. In the discussion it was recommended to add a sleep before and after the madvise operations, this did not resolve the issue in our case, rather the test timed out every time. I was successful by retrying the page-out sequence until the page is actually evicted.
Additionally, the mapping alignment is increased to
64K so the test operates on a properly page-aligned buffer across supported architectures.
changelog:
- fixed indentations
- removed trailing whitespace
- add space between opening and closing brackets
Gregory Bell (2):
selftests/bpf: fix flaky build_id test selftests/bpf: align build_id test mapping to 64K page size
tools/testing/selftests/bpf/uprobe_multi.c | 19 ++++++++++++++++--- tools/testing/selftests/bpf/uprobe_multi.ld | 4 ++-- 2 files changed, 18 insertions(+), 5 deletions(-)
Signature · 1 line
2.52.0
PATCH v2 1/2 selftests/bpf: fix flaky build_id test
The build_id selftest occasionally fails because MADV_PAGEOUT does not guarantee the immediate eviction of the page. The test assumes eviction happens and proceeds without verifying that the page was actually reclaimed, leading to false test failures.
Fix the test by retrying the page-out sequence until eviction is successful, instead of relying on a single MADV_PAGEOUT attempt.
--- tools/testing/selftests/bpf/uprobe_multi.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)
tools/testing/selftests/bpf/uprobe_multi.c +16 -3
@@ -100,6 +100,9 @@ int __attribute__((weak)) trigger_uprobe(bool build_id_resident)int page_sz =sysconf (_SC_PAGESIZE);void *addr; +unsigned char vec[1 ]; +int poll =0 ; +/* page-align build ID start */ addr = (void *)((uintptr_t )&build_id_start & ~(page_sz -1 ));
@@ -108,9 +111,19 @@ int __attribute__((weak)) trigger_uprobe(bool build_id_resident)* do MADV_POPULATE_READ, and then MADV_PAGEOUT, if necessary */ madvise (addr, page_sz,MADV_POPULATE_READ ); -if (!build_id_resident) -madvise (addr, page_sz,MADV_PAGEOUT ); - +if (!build_id_resident) { +do { +madvise (addr, page_sz,MADV_PAGEOUT ); +/* check if page has been evicted */ +mincore (addr, page_sz, vec); +if (!(vec[0 ] &1 )) +break ; +/* if page is still resident re-attempt MADV_POPULATE_READ/MADV_PAGEOUT */ +madvise (addr, page_sz,MADV_POPULATE_READ ); + poll++; +usleep (100 ); + }while (poll <500 ); + } (void )uprobe ();return 0 ;
Signature · 1 line
2.52.0
PATCH v2 2/2 selftests/bpf: align build_id test mapping to 64K page size
In reply to Gregory BellSome architectures require mappings to be aligned to the system page size. The build_id selftest currently uses a smaller alignment, which can result in madvise operations executing on a different page than intended.
Increase the mapping alignment to 64K so the buffer is page-aligned on all supported architectures.
--- tools/testing/selftests/bpf/uprobe_multi.ld | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/uprobe_multi.ld +2 -2
@@ -1,8 +1,8 @@ SECTIONS { - . = ALIGN(4096); + . = ALIGN(65536); .note.gnu.build-id : { *(.note.gnu.build-id) } - . = ALIGN(4096); + . = ALIGN(65536); } INSERT AFTER .text;
Signature · 1 line
2.52.0
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 14 lines · On Tue, 17 Feb 2026 09:32:35 -0500 you wrote:
The
build_idselftest intermittently fails with the following error:./test_progs -t build_id/nofault-paged-out serial_test_build_id:PASS:parse_build_id 0 nsec subtest_nofault:PASS:skel_open 0 nsec
subtest_nofault:PASS:link 0 nsec
subtest_nofault:PASS:trigger_uprobe 0 nsec
subtest_nofault:PASS:res 0 nsec
subtest_nofault:FAIL:build_id_status unexpectedbuild_id_status: actual 1 != expected 2
46/1 build_id/nofault-paged-out:FAIL
46 build_id:FAIL
397 stacktrace_build_id:OK
398 stacktrace_build_id_nmi:OK
Quoted 1 line
[...]
Here is the summary with links:
- [bpf-next,v2,1/2] selftests/bpf: fix flaky build_id test
https://git.kernel.org/bpf/bpf-next/c/d820fa311482 - [bpf-next,v2,2/2] selftests/bpf: align build_id test mapping to 64K page size https://git.kernel.org/bpf/bpf-next/c/18a1d365e825
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html