Skip to contentSkip to conversation

arm64: dts: imx8mm-var-dart: update SoM support

PATCH Applied Stefano Radaelli 2 participants 5 messages Sep 17 – Sep 28

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: imx8mm-var-dart: update SoM support

This series updates the Variscite DART-MX8M-MINI SoM device tree to better reflect the currently supported hardware configuration.

The changes configure SAI3 in synchronous RX mode, add TPM support, and increase the Ethernet PHY reset deassert delay to improve PHY detection reliability.

v2->v3:
- Fixed reset-gpio polarity

v1->v2:
- Add tpm pinctrl
- Add comment on tpm reset line

Stefano Radaelli (3):
arm64: dts: imx8mm-var-dart: configure SAI3 synchronous RX mode
arm64: dts: imx8mm-var-dart: add TPM support
arm64: dts: imx8mm-var-dart: increase PHY reset deassert delay

 .../boot/dts/freescale/imx8mm-var-dart.dtsi   | 21 ++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

base-commit: 46d8fa682d263271f3ef7bf95166b124c19d6c62

Signature · 1 line
2.47.3
#1 lore raw

PATCH v3 1/3 arm64: dts: imx8mm-var-dart: configure SAI3 synchronous RX mode

From: Stefano Radaelli <[email protected]>

Configure SAI3 to operate in synchronous RX mode, so that the trasmit path uses the receive bit clock and frame sync signals.

Remove the TX_SYNC and TX_BCLK pinmux entries, as these signals are not used in this configuration.

---
v2->v3:
-

v1->v2:
-

 arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi +1 -2
index 2324063f8fd9..c7a9eb23e5e8 100644
@@ -305,6 +305,7 @@ &sai3 {
 	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
 	assigned-clock-rates = <1536000>;
 	fsl,sai-mclk-direction-output;
+	fsl,sai-synchronous-rx;
 	status = "okay";
 };
 
@@ -446,8 +447,6 @@ pinctrl_sai3: sai3grp {
 			MX8MM_IOMUXC_SAI3_RXFS_SAI3_RX_SYNC		0xd6
 			MX8MM_IOMUXC_SAI3_RXC_SAI3_RX_BCLK		0xd6
 			MX8MM_IOMUXC_SAI3_RXD_SAI3_RX_DATA0		0xd6
-			MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC		0xd6
-			MX8MM_IOMUXC_SAI3_TXC_SAI3_TX_BCLK		0xd6
 			MX8MM_IOMUXC_SAI3_TXD_SAI3_TX_DATA0		0xd6
 			MX8MM_IOMUXC_SAI3_MCLK_SAI3_MCLK		0xd6
 		>;
Signature · 1 line
2.47.3
#2 lore raw

PATCH v3 2/3 arm64: dts: imx8mm-var-dart: add TPM support

In reply to Stefano Radaelli

From: Stefano Radaelli <[email protected]>

Add support for the TPM available on the Variscite DART-MX8M-MINI SOM.

---
v2->v3:
- Fixed reset-gpio polarity

v1->v2:
- Add tpm pinctrl
- Add comment on tpm reset line

 .../boot/dts/freescale/imx8mm-var-dart.dtsi      | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi +16 -0
index c7a9eb23e5e8..cb7998616a87 100644
@@ -138,6 +138,16 @@ &i2c1 {
 	sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 	status = "okay";
 
+	st33ktpm2xi2c_som: tpm@2e {
+		compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
+		reg = <0x2e>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_tpm_reset>;
+		label = "tpm";
+		/* active-low TPM reset line. */
+		reset-gpios = <&gpio4 31 GPIO_ACTIVE_LOW>;
+	};
+
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
@@ -452,6 +462,12 @@ MX8MM_IOMUXC_SAI3_MCLK_SAI3_MCLK		0xd6
 		>;
 	};
 
+	pinctrl_tpm_reset: tpm-resetgrp {
+		fsl,pins = <
+			MX8MM_IOMUXC_SAI3_TXFS_GPIO4_IO31		0x19
+		>;
+	};
+
 	pinctrl_uart4: uart4grp {
 		fsl,pins = <
 			MX8MM_IOMUXC_ECSPI2_SCLK_UART4_DCE_RX		0x140
Signature · 1 line
2.47.3
#3 lore raw

PATCH v3 3/3 arm64: dts: imx8mm-var-dart: increase PHY reset deassert delay

In reply to Stefano Radaelli

From: Stefano Radaelli <[email protected]>

The Ethernet PHY reset signal also controls the regulators supplying VDDA2P5 and VDD1P0, so releasing reset restores the PHY's 2.5 V and 1.0 V analog supplies.

The existing 100 ms reset deassertion delay is not sufficient for reliable PHY detection. The TI DP83867 requires 200 ms of stabilization after power-up before MDIO register access.

Increase the reset deassertion delay to 200 ms to ensure reliable PHY detection across repeated boots.

---
v2->v3:
-

v1->v2:
-

 arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi +1 -1
index cb7998616a87..c5f0e22f549b 100644
@@ -123,7 +123,7 @@ ethphy0: ethernet-phy@0 {
 			reg = <0>;
 			reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <10000>;
-			reset-deassert-us = <100000>;
+			reset-deassert-us = <200000>;
 			vddio-supply = <&reg_phy_vddio>;
 		};
 	};
Signature · 1 line
2.47.3
#4 lore raw
In reply to Stefano Radaelli

From: Frank Li <[email protected]>

Quoted 8 lines · Stefano Radaelli

This series updates the Variscite DART-MX8M-MINI SoM device tree to better reflect the currently supported hardware configuration.

The changes configure SAI3 in synchronous RX mode, add TPM support, and increase the Ethernet PHY reset deassert delay to improve PHY detection reliability.

[...]

Applied, thanks!

[1/3] arm64: dts: imx8mm-var-dart: configure SAI3 synchronous RX mode

      commit: 6bccdc6afffa4345331d46adc880bef56537421e
[2/3] arm64: dts: imx8mm-var-dart: add TPM support
      commit: 395280622de0c67814d8b5f06366217b3a9f70c0
[3/3] arm64: dts: imx8mm-var-dart: increase PHY reset deassert delay
      commit: 8c40f32361d566c0882e9d92abab36256b268291

Best regards,

Signature · 1 line
Frank Li <[email protected]>