Skip to contentSkip to conversation

st.ko: remove unnecessary normalize_buffer

PATCH In review Bodo Stroesser 1 participant 1 message Dec 2, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 st.ko: remove unnecessary normalize_buffer

From: Bodo Stroesser <[email protected]>
Date: Mon, 2 Dec 2013 18:52:10 +0100
Subject: [PATCH 2/3] st.ko: remove unnecessary normalize_buffer

This patch removes an unnecessary call to normalize_buffer() in enlarge_buffer()

In st_open() always a buffer of one page is allocated. When the buffer needs to be enlarged later, it does not make sense to free this page unconditionally.

---

drivers/scsi/st.c +0 -3
@@ -3725,9 +3725,6 @@ static int enlarge_buffer(struct st_buff
 	if (new_size <= STbuffer->buffer_size)
 		return 1;
 
-	if (STbuffer->buffer_size <= PAGE_SIZE)
-		normalize_buffer(STbuffer);  /* Avoid extra segment */
-
 	max_segs = STbuffer->use_sg;
 
 	priority = GFP_KERNEL | __GFP_NOWARN;