Skip to contentSkip to conversation

: forgotten __init and __exit in memory.c

ALSA - driver 0001239 [email protected] 1 participant 1 message Jul 8, 2005

lore
Share & tools
lore
#0 lore raw

A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1239>
======================================================================
Reported By: Henne
Assigned To:
======================================================================

Project:                    ALSA - driver
Issue ID:                   1239
Category:                   1_OTHERS
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Distribution:               
Kernel Version:             
======================================================================
Date Submitted:             07-07-2005 10:37 CEST
Last Modified:              07-08-2005 11:52 CEST

======================================================================
Summary: forgotten __init and __exit in memory.c
Description:
I think that snd_memory_init() should get an __init,
and snd_memory_exit() an __exit, cause that __init
function isn't called again and can be removed from the memory. That doesn't save too much space, but it's cleaner and mekes more sense .
The patch I added will fix it and is made for the current cvs version(memory.c 1.38).

======================================================================

----------------------------------------------------------------------
tiwai - 07-08-05 11:52
----------------------------------------------------------------------
__exit can't be applied since it's called from init function, too. Could you regenerate the patch?

Issue History
Date Modified Username Field Change
======================================================================

07-07-05 10:37 Henne          New Issue                                    
07-07-05 10:37 Henne          File Added: memory_c.diff                    
07-08-05 11:52 tiwai          Note Added: 0005410                          

======================================================================

-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar