Skip to contentSkip to conversation

drm/panfrost: fix ref count leak in panfrost_job_hw_submit

PATCH Markus Elfring 1 participant 1 message Jun 14, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

in panfrost_job_hw_submit, …

* Can the term “reference count” become relevant also for this commit message besides other possible adjustments?

* Would you like to add the tag “Fixes”?

…

Quoted 1 line

+++ b/drivers/gpu/drm/panfrost/panfrost_job.c

…

Review static void panfrost_job_hw_submit(struct panfrost_job *job, int js) · line 189

Quoted 8 lines
(quoted diff) +3 -0
@@ -184,6 +183,9 @@  static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
 				job, js, jc_head);
 
 	job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
+out:
+	pm_runtime_put_sync_autosuspend(pfdev->dev);
+	return;
 }

…

Perhaps use the label “put_sync” instead?

Regards,
Markus