Skip to contentSkip to conversation

BUG: scheduling while atomic (2.6.26-rc3...)

DISCUSSION Andrew Price 3 participants 5 messages May 23, 2008 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

Hi,

I'm seeing this bug when I boot but unfortunately the messages don't seem to get logged and the system locks so I took a photo of as much as could fit on my laptop's screen:
http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).

Anyway, I've bisected it down to commit 2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of ieee80211_iterate_active_interfaces"

lspci says I'm using a:

02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)
Subsystem: Belkin Device 701a
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort-
<MAbort- >SERR- <PERR- INTx-
Latency: 64, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 17
Region 0: Memory at 54000000 (32-bit, non-prefetchable) [size=8K]
Capabilities: [40] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Kernel driver in use: rt2500pci

Let me know if you require any more information (or a clearer photo/transcription).

--
Andy Price

maintainer
#1 lore raw
Quoted 7 lines · Andrew Price

Hi,

I'm seeing this bug when I boot but unfortunately the messages don't seem to get logged and the system locks so I took a photo of as much as could fit on my laptop's screen:
http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).

Quoted 7 lines

Anyway, I've bisected it down to commit 2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of ieee80211_iterate_active_interfaces"

lspci says I'm using a:

02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)

Looks like rt2x00 actually needs both versions of the function.

johannes

#2 lore raw
Quoted 12 lines · Johannes Berg
Quoted 11 lines · Andrew Price

Hi,

I'm seeing this bug when I boot but unfortunately the messages don't seem to get logged and the system locks so I took a photo of as much as could fit on my laptop's screen:
http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).

Anyway, I've bisected it down to commit 2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of ieee80211_iterate_active_interfaces"

Quoted 5 lines
Quoted 3 lines

lspci says I'm using a:

02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)

Looks like rt2x00 actually needs both versions of the function.

Johannes: Thanks for the tip, I seriously overlooked that the rtnl version grabs a mutex in interrupt context. :)

Andew: Could you try below patch to see if that works?

---

drivers/net/wireless/rt2x00/rt2x00dev.c +3 -3
index 5645140..669d942 100644
@@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
 	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
 		return;
 
-	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
-					    rt2x00lib_beacondone_iter,
-					    rt2x00dev);
+	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
+						   rt2x00lib_beacondone_iter,
+						   rt2x00dev);
 
 	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
 }
#3 lore raw

Hi Ivo,

Quoted 1 line · Ivo van Doorn

Andew: Could you try below patch to see if that works?

It looks good. wlan0 came up fine and dmesg looks clean, I can ping and read email...

Seems that some traffic (ssh, http, ...) is having problems though so I'm back on -rc1 to email you but I expect that's a different problem altogether and I'll see if I can track it down.

Quoted 9 lines

---

drivers/net/wireless/rt2x00/rt2x00dev.c +0 -0
index 5645140..669d942 100644
@@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
 	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
 		return;

drivers/net/wireless/rt2x00/rt2x00dev.c void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev) · line 489

Quoted 10 lines
drivers/net/wireless/rt2x00/rt2x00dev.c +3 -3
 
-	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
-					    rt2x00lib_beacondone_iter,
-					    rt2x00dev);
+	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
+						   rt2x00lib_beacondone_iter,
+						   rt2x00dev);
 
 	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
 }

Thanks,

--
Andy Price

#4 lore raw
Quoted 7 lines · Andrew Price

Hi Ivo,

Quoted 1 line · Ivo van Doorn

Andew: Could you try below patch to see if that works?

It looks good. wlan0 came up fine and dmesg looks clean, I can ping and read email...

Excellent, I'll push the patch upstream then. :)

Ivo

Quoted 34 lines

Seems that some traffic (ssh, http, ...) is having problems though so I'm back on -rc1 to email you but I expect that's a different problem altogether and I'll see if I can track it down.

Quoted 9 lines

---

drivers/net/wireless/rt2x00/rt2x00dev.c +0 -0
index 5645140..669d942 100644
@@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
 	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
 		return;

drivers/net/wireless/rt2x00/rt2x00dev.c void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev) · line 489

Quoted 10 lines
drivers/net/wireless/rt2x00/rt2x00dev.c +3 -3
 
-	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
-					    rt2x00lib_beacondone_iter,
-					    rt2x00dev);
+	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
+						   rt2x00lib_beacondone_iter,
+						   rt2x00dev);
 
 	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
 }

Thanks,

--
Andy Price

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html