Change in openvpn[master]: dco_linux: fix case statement by using proper error value
A message that is not in the archive (sent off-list or not yet received): gerrit.1753215725000.I18df6ef659cab9525dd7847b7dd3950fc1895dd5@...2715...
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
to review the following change.
Change subject: dco_linux: fix case statement by using proper error value
......................................................................
dco_linux: fix case statement by using proper error value
A M_ERR constant accidentally slipped in as possible netlink error value.
Substitute it with the actual code matching the following error message.
---
M src/openvpn/dco_linux.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/1095/1
src/openvpn/dco_linux.c +1 -1
@@ -143,7 +143,7 @@msg (M_ERR ,"%s: netlink out of memory error" , prefix);break ; -case -M_ERR : +case -NLE_AGAIN :msg (M_WARN ,"%s: netlink reports blocking read - aborting wait" , prefix);break ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email )
Change subject: dco_linux: fix case statement by using proper error value
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: ordex <[email protected]...>
Gerrit-Comment-Date: Wed, 23 Jul 2025 06:19:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH v2 1/1 dco_linux: fix case statement by using proper error value
In reply to a message not in the archiveFrom: Antonio Quartulli <[email protected]...>
A M_ERR constant accidentally slipped in as possible netlink error value.
Substitute it with the actual code matching the following error message.
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1095
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/dco_linux.c +1 -1
@@ -143,7 +143,7 @@msg (M_ERR ,"%s: netlink out of memory error" , prefix);break ; -case -M_ERR : +case -NLE_AGAIN :msg (M_WARN ,"%s: netlink reports blocking read - aborting wait" , prefix);break ;
[Openvpn-devel] [PATCH applied] Re: dco_linux: fix case statement by using proper error value
Stared at the code, makes sense. Test compiled (after the explosion tonight, you can never test enough :-) ).
Your patch has been applied to the master branch.
commit f1a2a37897a6517c4c321abb7bc343bf495c94e2
Author: Antonio Quartulli Date: Wed Jul 23 08:20:06 2025 +0200
dco_linux: fix case statement by using proper error value
Signed-off-by: Antonio Quartulli <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32269.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#3) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco_linux: fix case statement by using proper error value
......................................................................
dco_linux: fix case statement by using proper error value
A M_ERR constant accidentally slipped in as possible netlink error value.
Substitute it with the actual code matching the following error message.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32269.html
---
M src/openvpn/dco_linux.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/1095/3
src/openvpn/dco_linux.c +1 -1
@@ -143,7 +143,7 @@msg (M_ERR ,"%s: netlink out of memory error" , prefix);break ; -case -M_ERR : +case -NLE_AGAIN :msg (M_WARN ,"%s: netlink reports blocking read - aborting wait" , prefix);break ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 3
Gerrit-Owner: ordex <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email )
Change subject: dco_linux: fix case statement by using proper error value
......................................................................
dco_linux: fix case statement by using proper error value
A M_ERR constant accidentally slipped in as possible netlink error value.
Substitute it with the actual code matching the following error message.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32269.html
---
M src/openvpn/dco_linux.c
1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/dco_linux.c +1 -1
@@ -143,7 +143,7 @@msg (M_ERR ,"%s: netlink out of memory error" , prefix);break ; -case -M_ERR : +case -NLE_AGAIN :msg (M_WARN ,"%s: netlink reports blocking read - aborting wait" , prefix);break ;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 3
Gerrit-Owner: ordex <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged