Skip to contentSkip to conversation

rtc/ds1374.c turns clock OFF when it means to turn it ON

U-Boot-Users Andrew Klossner 3 participants 3 messages Feb 23, 2007 – Feb 26, 2007

lore
Share & tools
lore
#0 lore raw

rtc/ds1374.c mistakes the "don't enable the oscillator" bit for a "do enable the oscillator bit" and sets it to 1, stopping the clock. My guess is that nobody has actually used rtc_set or rtc_reset with this driver.

We've been using this chip for a few years with a proprietary OS and are now switching to u-boot and Linux. I revised the u-boot driver based on our stable driver. Besides fixing the oscillator bit, I set it up to read all the registers with a single IIC transaction for efficiency and to see any error code from the IIC subsystem.

I would attach the new driver here but I can't figure out how. I'm typing through a broken "hello new user, we don't yet trust you" web page. If somebody could send instructions to
andrew at cesa.opbu.xerox.com, I'd like to submit this revision.

Andrew Klossner

#1 lore raw

Andrew,

Quoted 4 lines · Andrew Klossner

rtc/ds1374.c mistakes the "don't enable the oscillator" bit for a "do enable the oscillator bit" and sets it to 1, stopping the clock. My guess is that nobody has actually used rtc_set or rtc_reset with this driver.

A quick look shows that this driver is used by the Freescale MPC8349EMDS & MPC8360EMDS board ports. Some of the Freescale guys (Kim?) should jump in here.

Quoted 10 lines

We've been using this chip for a few years with a proprietary OS and are now switching to u-boot and Linux. I revised the u-boot driver based on our stable driver. Besides fixing the oscillator bit, I set it up to read all the registers with a single IIC transaction for efficiency and to see any error code from the IIC subsystem.

I would attach the new driver here but I can't figure out how. I'm typing through a broken "hello new user, we don't yet trust you" web page. If somebody could send instructions to
andrew at cesa.opbu.xerox.com, I'd like to submit this revision.

For submitting patches please take a look at the section "Submitting Patches:" at the end of the README file. Nowadays patches created using git are even better (like in the Linux kernel development).

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
=====================================================================

#2 lore raw
In reply to Andrew Klossner
Quoted 4 lines · Andrew Klossner

rtc/ds1374.c mistakes the "don't enable the oscillator" bit for a "do enable the oscillator bit" and sets it to 1, stopping the clock. My guess is that nobody has actually used rtc_set or rtc_reset with this driver.

It doesn't set it, it clears it -- rtc_write is called with "set" set to FALSE.

It's certainly not the clearest way to do it; there should probably be separate functions rtc_set_bits and rtc_clear_bits (the "set" parameter is always passed as a constant, so the runtime check isn't actually being used).

-Scott